[PATCH] D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions

owenpan created this revision. owenpan added reviewers: djasper, klimek, MyDeveloperDay, curdeius, HazardyKnusperkeks. owenpan added a project: clang-format. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. See PR50999

[PATCH] D105703: [hwasan] Use stack safety analysis.

vitalybuka added inline comments. Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; this patch mostly change code under llvm/ so tests should be also there, as IR tests

[PATCH] D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions

MyDeveloperDay added a comment. Thanks for this, I'm not sure I have the heart to dig out my old K&R code to test it ;-), Assuming the tests are good then it LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105964/new/ https://reviews.llvm.or

[PATCH] D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Myabe give the others some time to take a look too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105964/new/ https://reviews.llv

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG462d4de35b0c: [clangd] Add CMake option to (not) link in clang-tidy checks (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D105679?

[clang-tools-extra] 462d4de - [clangd] Add CMake option to (not) link in clang-tidy checks

Author: Sam McCall Date: 2021-07-14T10:04:21+02:00 New Revision: 462d4de35b0c9ef7157e49e147fc448a40c829b1 URL: https://github.com/llvm/llvm-project/commit/462d4de35b0c9ef7157e49e147fc448a40c829b1 DIFF: https://github.com/llvm/llvm-project/commit/462d4de35b0c9ef7157e49e147fc448a40c829b1.diff LO

[PATCH] D105950: [WebAssembly] Codegen for v128.loadX_lane instructions

aheejin added inline comments. Comment at: clang/lib/Headers/wasm_simd128.h:174 +static __inline__ v128_t __DEFAULT_FN_ATTRS wasm_v128_load8_lane( +const void *__ptr, v128_t __vec, int __i) __REQUIRE_CONSTANT(__i) { + struct __wasm_v128_load8_lane_struct { N

[PATCH] D105457: [clang] Refactor AST printing tests to share more infrastructure

dyung added a comment. If it helps, I have so far been able to reduce the file to this which still shows the failure when compiled with gcc 7.5: #include "ASTPrint.h" #include "clang/AST/ASTContext.h" #include "clang/ASTMatchers/ASTMatchFinder.h" #include "clang/Tooling/Tooling.h" #inc

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

balazske updated this revision to Diff 358545. balazske added a comment. Rename of DiagnosticVerifyConsumer. Changes related to handling of metadata symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637

[PATCH] D105937: [OpenMP] Encode `omp [...] assume[...]` assumptions with `omp[x]` prefix

JonChesterfield added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105937/new/ https://reviews.llvm.org/D105937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. Interesting reference point here https://blog.jetbrains.com/rscpp/2021/03/30/resharper-cpp-2021-1-syntax-style Kind of suggests that Resharper brings many of these "mutating" capabilities into the same tool that fixes your style. I'd be really interest to know if

[PATCH] D105679: [clangd] Add CMake option to (not) link in clang-tidy checks

thakis added a comment. Nit: I find the name a bit confusing. When I first saw this commit, I thought this would be a list of clang-tidy checks to support, not a binary on/off toggle. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105679/new/ http

[PATCH] D105765: Prepare Compiler-RT for GnuInstallDirs, matching libcxx, document all

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e03c37b97b6: Prepare Compiler-RT for GnuInstallDirs, matching lib

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1aca5ac96eb: [PowerPC] Fix L[D|W]ARX Implementation (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D105754?vs=358032&id=358289#toc Repository: rG LLVM Github Monorepo CHAN

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

It's very difficult to use a compile_commands database if you can't actually check out all the code and a remote service builds it for you. On Tue, Jul 13, 2021 at 6:03 PM Aaron Ballman via Phabricator < revi...@reviews.llvm.org> wrote: > aaron.ballman added a comment. > > In D69764#2874404

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added a comment. > // 1. `VisitSymbolCast`. > // Get a range for main `reg_$0` - [-2147483648, 2147483647] > // Cast main range to `short` - [-2147483648, 2147483647] -> [-32768, > 32767]. > // Now we get a valid range for further bifurcation - [-32768, 32767]. That's a great

[PATCH] D105728: [clang][Codegen] Directly lower `(*((volatile int *)(0))) = 0;` into a `call void @llvm.trap()`

lebedev.ri added a comment. @rsmith ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105728/new/ https://reviews.llvm.org/D105728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

martong added a comment. In D103967#2864229 , @steakhal wrote: > AFAICT this patch does not introduce significant overhead to the exploded > graph DOT dumps. > Before the patch, an exploded graph took 12G and about 55 secs for a single > top-level funct

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358564. fmayer marked 2 inline comments as done. fmayer added a comment. Address some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/Code

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358565. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-safe

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358567. fmayer added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-saf

[clang] bdf3147 - [Analyzer][solver] Add dump methods for (dis)equality classes.

Author: Gabor Marton Date: 2021-07-14T13:45:02+02:00 New Revision: bdf31471c76b5ded9e8d5a039250c2a7ba7aead6 URL: https://github.com/llvm/llvm-project/commit/bdf31471c76b5ded9e8d5a039250c2a7ba7aead6 DIFF: https://github.com/llvm/llvm-project/commit/bdf31471c76b5ded9e8d5a039250c2a7ba7aead6.diff

[PATCH] D103967: [Analyzer][solver] Add dump methods for (dis)equality classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbdf31471c76b: [Analyzer][solver] Add dump methods for (dis)equality classes. (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103967/new/

[PATCH] D105964: [clang-format] Make AlwaysBreakAfterReturnType work with K&R C function definitions

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105964/new/ https://reviews.llvm.org/D105964 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D105629: [TSan] Add SystemZ support

uweigand added a comment. The SystemZ specific changes all look good to me now, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105629/new/ https://reviews.llvm.org/D105629 ___ cfe-commits mailing

[PATCH] D105972: Fix __attribute__((annotate("")) with non-zero globals AS

arichardson created this revision. arichardson added reviewers: rjmccall, nhaehnle, Tyker. Herald added subscribers: jrtc27, luismarques, s.egerton, PkmX, simoncook, tpr. arichardson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The exist

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

Sockke created this revision. Sockke added reviewers: ymandel, aaron.ballman, MTC. Sockke requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The annotation about ignoringImpCasts is wrong, which will cause misunderstanding. Fix it. Reposito

[PATCH] D105974: [analyzer] Fix assertion in state split code path

vabridgers created this revision. vabridgers added reviewers: martong, steakhal. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. vabridgers requested review of this revision. He

[PATCH] D105974: [analyzer] Fix assertion in state split code path

vabridgers updated this revision to Diff 358573. vabridgers added a comment. update commit header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105974/new/ https://reviews.llvm.org/D105974 Files: clang/lib/StaticAnalyzer/Core/SValBuilder.cpp I

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

curdeius added a comment. I've been trying to make my opinion on this patch for the last few weeks... I was pretty much opposed to introducing non-whitespace chances previously, but I'm reviewing my standpoint. As mentioned already, there are precedents (include sorting, namespace comments, long

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

pdhaliwal added a comment. Looks ok to me. Regression tests and runtime tests went fine. Tested a simple cuda and openmp kernel with `sin` function on sm_61, didn't see any issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105221/new/ https://r

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358577. fmayer added a comment. fixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.cpp clang/test/CodeGen/hwasan-stack-safe

[PATCH] D105221: [openmp][nfc] Simplify macros guarding math complex headers

JonChesterfield added inline comments. Comment at: clang/lib/Headers/openmp_wrappers/complex:21 #define __OPENMP_NVPTX__ #include <__clang_cuda_complex_builtins.h> #undef __OPENMP_NVPTX__ ^ this header does not look for a macro called __CUDA__ or include any o

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer marked an inline comment as done and an inline comment as not done. fmayer added a comment. Addressed inline comments. Comment at: clang/test/CodeGen/hwasan-stack-safety-analysis-asm.c:4 + +int main(int argc, char **argv) { + char buf[10]; vitalybuka wr

[PATCH] D105703: [hwasan] Use stack safety analysis.

fmayer updated this revision to Diff 358579. fmayer marked an inline comment as done. fmayer added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105703/new/ https://reviews.llvm.org/D105703 Files: clang/lib/CodeGen/BackendUtil.

[PATCH] D104386: [PowerPC][Builtins] Added a number of builtins for compatibility with XL.

lei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsPPC.def:48 BUILTIN(__builtin_ppc_icbt, "vv*", "") +BUILTIN(__builtin_ppc_alignx, "viCvC*", "nc") +BUILTIN(__builtin_ppc_rdlam, "UWiUWiUWiCUWi", "nc") I think you need sema checking for parm

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. > So yes, I'm in favour of landing this patch (though not exactly in the > current form, I'd prefer more future-proof options for instance, not only > handling const) I am in agreement, but I don't want to not putting more effort into improving the current desig

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

+1 for not only handling "const". I've often tried getting the various bits that appertain to a declaration (static const volatile constexpr inline consteval) sorted in a consistent order - that makes them much more greppable. Different patch, I expect, though. On Wed, Jul 14, 2021 at 1:47 PM Mar

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358587. sriharikrishna added a comment. Address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp

[PATCH] D105876: OMPIRBuilder for Interop directive

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6348-6352 + } else if(HaveNowaitClause == true) { +assert("Nowait clause is used separately in OMPInteropDirective."); } else { -llvm_unreachable("Missing Interop clauses."); +assert("Un

[PATCH] D105491: [clang] Use i64 for the !srcloc metadata on asm IR nodes.

tmatheson added a comment. Looks sensible to me, I don't think slightly expanding the size of the metadata and the diagnostic will be an issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105491/new/ https://reviews.llvm.org/D105491 ___

[PATCH] D105328: [Frontend] Only compile modules if not already finalized

vsapsai added inline comments. Comment at: clang/lib/Frontend/CompilerInstance.cpp:1063 +<< ModuleName; +return ImportingInstance.getFrontendOpts().AllowPCMWithCompilerErrors; + } bnbarham wrote: > bnbarham wrote: > > vsapsai wrote: > > > Can we get

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

pdhaliwal created this revision. pdhaliwal added reviewers: JonChesterfield, ronlieb, jdoerfert. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, wd

[clang] 93dc73b - [Lexer] Fix bug in `makeFileCharRange` called on split tokens.

Author: Yitzhak Mandelbaum Date: 2021-07-14T14:36:31Z New Revision: 93dc73b1e0f31c712e5b8bbac14491ce55c414ad URL: https://github.com/llvm/llvm-project/commit/93dc73b1e0f31c712e5b8bbac14491ce55c414ad DIFF: https://github.com/llvm/llvm-project/commit/93dc73b1e0f31c712e5b8bbac14491ce55c414ad.diff

[PATCH] D105365: [Lexer] Fix bug in `makeFileCharRange` called on split tokens.

This revision was automatically updated to reflect the committed changes. Closed by commit rG93dc73b1e0f3: [Lexer] Fix bug in `makeFileCharRange` called on split tokens. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105365/new/

[PATCH] D105984: [PowerPC] Vec Div Builtins Restore FMF of Builder

quinnp created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. quinnp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch fixes `__builtin_ppc_recipdivf`, `__builtin_ppc_recipdivd`, `__builtin_ppc_rsqrtf`, and `_

[PATCH] D105492: [clang] Introduce SourceLocation::[U]IntType typedefs.

tmatheson added a comment. LGTM Comment at: clang/include/clang/Basic/SourceLocation.h:97 + using UIntType = uint32_t; + using IntType = int32_t; Nit: the `Ty` suffix seems to be slightly more common than `Type` Repository: rG LLVM Github Monorepo CHAN

[PATCH] D105493: [clang] Change set type used for SourceLocation.

tmatheson added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105493/new/ https://reviews.llvm.org/D105493 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D104904: [OpenMP][AMDGCN] Initial math headers support

JonChesterfield added a comment. Only revision I'm looking for here is to land D105221 or equivalent first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104904/new/ https://reviews.llvm.org/D104904 _

[PATCH] D104742: [UpdateCCTestChecks] Implement --global-value-regex

jdenny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104742/new/ https://reviews.llvm.org/D104742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:252 +bool Wave64 = isWave64(DriverArgs, Kind); + +// TODO: There are way too many flags that change this. Do we need to check I recognise this comment. Is this

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 358606. dgoldman added a comment. Fix clang tidy warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CMakeLists.txt clang-to

[PATCH] D105194: [PowerPC] Add PowerPC cmpb builtin and emit target indepedent code for XL compatibility

NeHuang added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:15081 } + case PPC::BI__builtin_ppc_cmpb: { +llvm::Type *Ty = Ops[0]->getType(); nemanjai wrote: > I find it rather surprising that we are emitting this complex sequence for > thi

[PATCH] D88319: [AST] Delete broken, unused template.

ymandel abandoned this revision. ymandel added a comment. Fixed in another commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88319/new/ https://reviews.llvm.org/D88319 ___ cfe-commits mailing list cf

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

pdhaliwal added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:252 +bool Wave64 = isWave64(DriverArgs, Kind); + +// TODO: There are way too many flags that change this. Do we need to check JonChesterfield wrote: > I recognise th

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 358609. quinnp marked 9 inline comments as done. quinnp added a comment. Addressing review comment about indentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 F

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

martong added a comment. In D104917#2860923 , @NoQ wrote: > WDYT about the following format: > > Equality constraints: > reg_$0 == reg_$1 > == reg_$2 > > Disequality constraints: > reg_$0 != reg_$3, > != reg_$4 > > Comma

[PATCH] D105987: [C++4OpenCL] NULL redefined as nullptr

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Redefines NULL as nullptr instead of ((void*)0) in C++ for OpenCL. Such internal representation o

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna created this revision. Herald added subscribers: ldrumm, Anastasia, yaxunl. Topotuna requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. NULL macro maps to ((void*)0) for OpenCL versions earlier than 2.0 NULL was undefined in OpenCL p

[PATCH] D105984: [PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins

quinnp updated this revision to Diff 358613. quinnp retitled this revision from "[PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins " to "[PowerPC] Restore FastMathFlags of Builder for Vector FDiv Builtins". quinnp added a comment. Fixing indentation. Repository: rG LLVM Git

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

pdhaliwal updated this revision to Diff 358614. pdhaliwal added a comment. Move linking logic to a common method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105981/new/ https://reviews.llvm.org/D105981 Files: clang/lib/Driver/ToolChains/AMDGP

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Anastasia added a comment. This seems reasonable. Comment at: clang/test/SemaOpenCL/null_literal.cl:7 #define NULL ((void*)0) I think we should remove this `NULL` definition but instead add `-finclude-default-header -fdeclare-opencl-builtins` to test the

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

kadircet added a comment. So first of all, it is not clear to me if this is a useful enough improvement to justify all the new code, but looking at your investment I'll assume this is really common in ObjC land and gonna be useful for developers working with ObjC. That's enough of a justificati

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added a reviewer: t-tye. JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:267 +llvm::SmallVector BCLibs; +BCLibs.append(RocmInstallation.getCommonBitcodeLibs( +DriverArgs, LibDeviceFile, Wave64, DAZ, F

[PATCH] D104420: thread_local support for AIX

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2971 +isEmittedWithConstantInitializer(VD, true) && +!VD->needsDestruction(getContext())) { + // Emit a weak global function referring to the initialization function

[clang] aefd6c6 - Combine two diagnostics into one and correct grammar

Author: Aaron Ballman Date: 2021-07-14T11:43:28-04:00 New Revision: aefd6c615c91a2af89fa3697cf1813aac0f622de URL: https://github.com/llvm/llvm-project/commit/aefd6c615c91a2af89fa3697cf1813aac0f622de DIFF: https://github.com/llvm/llvm-project/commit/aefd6c615c91a2af89fa3697cf1813aac0f622de.diff

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. In D105904#2877184 , @kadircet wrote: > So first of all, it is not clear to me if this is a useful enough improvement > to justify all the new code, but looking at your investment I'll assume this > is really common in ObjC lan

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna updated this revision to Diff 358625. Topotuna added a comment. Added compile time flags -finclude-default-header -fdeclare-opencl-builtins instead of #define NULL ((void*)0) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 File

[PATCH] D105973: [ASTMatchers] NFC: Fix the annotation.

aaron.ballman added a comment. The change looks good to me, but you need to regenerate the documentation manually. You can do so by running clang/docs/tools/dump_ast_matchers.py. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105973/new/ https://re

[PATCH] D105988: [OpenCL] NULL introduced prior to v2.0

Topotuna updated this revision to Diff 358628. Topotuna added a comment. Wrong diff file added previously CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105988/new/ https://reviews.llvm.org/D105988 Files: clang/lib/Headers/opencl-c-base.h clang/test/SemaOpenCL/null_literal.cl Inde

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:879-889 + // TODO: There are way too many flags that change this. Do we need to check + // them all? + bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) || + getDefaultDen

[PATCH] D105876: OMPIRBuilder for Interop directive

sriharikrishna updated this revision to Diff 358631. sriharikrishna added a comment. OMPIRBuilder for Interop directive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmtOpe

[PATCH] D91186: [clangd] Add documentation for building and testing clangd

nridge added a comment. Herald added a project: clang-tools-extra. I wonder, should these instructions be in an easier-to-find place, such as the clangd repo's own README (https://github.com/clangd/clangd/blob/master/README.md), or even a section of the clangd website (clangd.llvm.org)? I want

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 358637. quinnp added a comment. Removing a misleading comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/Co

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

quinnp updated this revision to Diff 358639. quinnp added a comment. Removing another comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105360/new/ https://reviews.llvm.org/D105360 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

JonChesterfield added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:879-889 + // TODO: There are way too many flags that change this. Do we need to check + // them all? + bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) || + getD

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

bjope added a comment. I think you can create an upstream test case by looking at `clang/test/Analysis/ptr.cl`. It uses amdgcn and address space 256, which seems to have a different pointer size compared to address space zero for that specific target. So the test case (named with a .cl extensio

[PATCH] D105493: [clang] Change set type used for SourceLocation.

miyuki added inline comments. Comment at: clang/include/clang/Basic/SourceLocation.h:19 #include "llvm/ADT/StringRef.h" #include "llvm/Support/PointerLikeTypeTraits.h" #include Can this `#include` be removed? Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, mibintc, jyknight, rjmccall. aaron.ballman requested review of this revision. Herald added a project: clang. Clang implemented the _ExtInt datatype as a bit-precise integer type, which was then proposed to WG1

[PATCH] D105997: Implement _ExtInt conversion rules

erichkeane added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-erro

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

erichkeane added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-erro

[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPU.cpp:879-889 + // TODO: There are way too many flags that change this. Do we need to check + // them all? + bool DAZ = DriverArgs.hasArg(options::OPT_cl_denorms_are_zero) || + getDefaultDen

[PATCH] D101441: Update libstdc++ hack comment

mizvekov added a comment. Here are my findings around this issue: https://godbolt.org/z/TE9rdxae8 So GCC started parsing this correctly from 9.4 to 10.1. It does not look like they have a workaround for their own older libstdc++. It seems to me this HACK is ready for removal. Is there something

[PATCH] D105974: [analyzer] Do not assume that all pointers have the same bitwidth as void*

NoQ added a comment. I think this is a plausible use case, previously I thought it's too much work but it seems reasonable last time I looked into it, so I'm glad to see it going on! Can you add a comment explaining that the new code is necessary for architectures with varying pointer bit widt

[PATCH] D104917: [Analyzer] Extend exploded-graph-rewriter to support eq and diseq classes

NoQ added a comment. We could color the special ==/!= 50% gray and/or replace it with a non-programming symbol such as ≃ and ≄. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104917/new/ https://reviews.llvm.org/D104917 ___

[PATCH] D105637: [clang][Analyzer] Add symbol uninterestingness to bug report.

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Amazing, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105637/new/ https://reviews.llvm.org/D105637 _

[PATCH] D99797: [analyzer] Implemented RangeSet::Factory::unite function to handle intersections and adjacency

ASDenysPetrov updated this revision to Diff 358656. ASDenysPetrov added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99797/new/ https://reviews.llvm.org/D99797 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedConstraintManager.h clang/lib/Stat

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

nemanjai added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), efriedma wrote: > I'

[PATCH] D101441: Update libstdc++ hack comment

urnathan added a comment. In D101441#2877463 , @mizvekov wrote: > > It seems to me this HACK is ready for removal. Is there something else I > might be missing? we want to support all the way back to gcc 4.8.3, IIRC that's the version in CentOS $SO

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

ASDenysPetrov added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; vsavchenko wrote: > ASDenysPetrov

[PATCH] D105997: Implement _ExtInt conversion rules

rsmith added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-error{{i

[PATCH] D103094: [analyzer] Implemented RangeSet::Factory::castTo function to perform promotions, truncations and conversions.

ASDenysPetrov updated this revision to Diff 358661. ASDenysPetrov added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103094/new/ https://reviews.llvm.org/D103094 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/APSIntType.h clang/include/clang/Stati

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman added inline comments. Comment at: clang/test/Sema/ext-int.c:7 _ExtInt(32) s32, int b) { - b ? s30 : s31a; // expected-error{{incompatible operand types}} - b ? s31a : s30; // expected-error{{incompatible operand types}} - b ? s32 : 0; // expected-e

[PATCH] D105997: Implement _ExtInt conversion rules

aaron.ballman updated this revision to Diff 358663. aaron.ballman added a comment. Added more test coverage in C for conversion type results. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105997/new/ https://reviews.llvm.org/D105997 Files: clang/lib/Sema/SemaExpr.cpp clang/test/Sem

[PATCH] D103096: [analyzer] Implement cast for ranges of symbolic integers.

vsavchenko added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SymbolManager.h:293-296 +SymbolRef Sym = Operand; +while (isa(Sym)) + Sym = cast(Sym)->Operand; +return Sym; ASDenysPetrov wrote: > vsavchenko wr

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay added a comment. I wanted to address your other points so we at least can be aligned as I respect your opinion. > I'm however even more wary of adding yet another tool that will be almost the > same as clang-format. Also agreed, but I see no other way forward. > It could work i

Re: [PATCH] D69764: [clang-format] Add East/West Const fixer capability

It would probably be better to make the config option names for passes that may mutate whitespace be prefixed with MaybeIncorrect than fork the tool. Scary options are better than forks. On Wed, Jul 14, 2021 at 6:42 PM MyDeveloperDay via Phabricator < revi...@reviews.llvm.org> wrote: > MyDevelope

[PATCH] D105360: [PowerPC] Fix popcntb XL Compat Builtin for 32bit

efriedma added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:831 +// 64bit version of popcntb for 64bit sized unsigned long. +let isCodeGenOnly = 1 in +def POPCNTB8 : XForm_11<31, 122, (outs g8rc:$rA), (ins g8rc:$rS), nemanjai wrote: > ef

[PATCH] D104058: ThinLTO: Fix inline assembly references to static functions with CFI

nickdesaulniers added a comment. Change LGTM, but I don't understand why the following tests are modified: - llvm/test/ThinLTO/X86/devirt2.ll - llvm/test/Transforms/ThinLTOBitcodeWriter/split-internal2.ll - llvm/test/Transforms/ThinLTOBitcodeWriter/split-vfunc-internal.ll Repository: rG LLVM

  1   2   3   >