[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111331/new/ https://reviews.llvm.org/D111331 __

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.h:392 + /// order immediately after all static allocas. + llvm::BasicBlock::iterator AllocaAddrSpaceInsertPt; + Please call this something like `PostAllocaInsertPt`. Instead of e

[PATCH] D111588: [Clang][Attr] rename btf_tag to btf_decl_tag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa162b67c9806: [Clang][Attr] rename btf_tag to btf_decl_tag (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[clang] a162b67 - [Clang][Attr] rename btf_tag to btf_decl_tag

Author: Yonghong Song Date: 2021-10-11T22:17:17-07:00 New Revision: a162b67c98066218d0d00aa13b99afb95d9bb5e6 URL: https://github.com/llvm/llvm-project/commit/a162b67c98066218d0d00aa13b99afb95d9bb5e6 DIFF: https://github.com/llvm/llvm-project/commit/a162b67c98066218d0d00aa13b99afb95d9bb5e6.diff

[PATCH] D110257: [CFE][Codegen] Make sure to maintain the contiguity of all the static allocas

hsmhsm updated this revision to Diff 378875. hsmhsm added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110257/new/ https://reviews.llvm.org/D110257 Files: clang/lib/CodeGen/CGExpr.cpp clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D111324: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb9c2d775130: [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111324/new/ https:

[clang] db9c2d7 - [CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()

Author: hsmahesha Date: 2021-10-12T10:04:15+05:30 New Revision: db9c2d775130a110ada89decff7002c64cdd3364 URL: https://github.com/llvm/llvm-project/commit/db9c2d775130a110ada89decff7002c64cdd3364 DIFF: https://github.com/llvm/llvm-project/commit/db9c2d775130a110ada89decff7002c64cdd3364.diff LOG

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

This revision was automatically updated to reflect the committed changes. Closed by commit rGf7de6962c85b: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca() (authored by hsmhsm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316

[PATCH] D111331: [ObjC][ARC] Use operand bundle "clang.arc.attachedcall" on x86-64

ahatanak updated this revision to Diff 378868. ahatanak marked an inline comment as done. ahatanak added a comment. Improve comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111331/new/ https://reviews.llvm.org/D111331 Files: clang/lib/Code

[PATCH] D111542: [analyzer] Retrieve incomplete array extent from its redeclaration.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:1663 // We can trust a const value or a value of a global initializer in main(). -const VarDecl *VD = VR->getDecl(); +const VarDecl *VD = VR->getDecl()->getMostRecentDecl(); if

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

This revision was automatically updated to reflect the committed changes. Closed by commit rG97f0c63783f5: [RISCV] Define _m intrinsics as builtins, instead of macros. (authored by HsiangKai). Changed prior to commit: https://reviews.llvm.org/D110684?vs=376890&id=378859#toc Repository: rG LL

[PATCH] D111517: [X86] Remove little support we had for MPX

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111517/new/ https://reviews.llvm.org/D111517

[PATCH] D111597: [RISCV][Clang] Fix RISCV vector header comment.

jacquesguan created this revision. jacquesguan added reviewers: HsiangKai, khchen, craig.topper. Herald added subscribers: achieveartificialintelligence, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck

[clang] c30a528 - [Driver] Re-enable aarch64-cpus.c test for arm64-apple.

Author: Ahmed Bougacha Date: 2021-10-11T18:46:26-07:00 New Revision: c30a52852ba5e85bdd3b1b70b4add7335fabca9a URL: https://github.com/llvm/llvm-project/commit/c30a52852ba5e85bdd3b1b70b4add7335fabca9a DIFF: https://github.com/llvm/llvm-project/commit/c30a52852ba5e85bdd3b1b70b4add7335fabca9a.diff

[clang] 998e067 - Reland "[clang][Fuchsia] Support availability attr on Fuchsia"

Author: Haowei Wu Date: 2021-10-11T18:41:29-07:00 New Revision: 998e067a0a579bd483c2a2d411385e58494ffbca URL: https://github.com/llvm/llvm-project/commit/998e067a0a579bd483c2a2d411385e58494ffbca DIFF: https://github.com/llvm/llvm-project/commit/998e067a0a579bd483c2a2d411385e58494ffbca.diff LOG

[PATCH] D111588: [Clang][Attr] rename btf_tag to btf_decl_tag

anakryiko accepted this revision. anakryiko added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111588/new/ https://reviews.llvm.org/D111588 _

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

rsmith added inline comments. Comment at: clang/test/SemaCXX/sugared-auto.cpp:146 +return a; + return N(); // expected-error {{but deduced as 'SARS (*)() throw(Man, Vibrio)' (aka 'void (*)() throw(Man, Vibrio)')}} +} rsmith wrote: > Why don't we get `Virus`

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

rsmith added a comment. Do you have examples showing what this does in practice for errors in real-world code? I'm concerned that stripping back to the common type sugar may produce an unintuitive result in some cases, although it certainly does seem at least theoretically nice to use a commuta

[clang] b5e8348 - Revert "[clang][Fuchsia] Support availability attr on Fuchsia"

Author: Haowei Wu Date: 2021-10-11T17:32:38-07:00 New Revision: b5e8348bf2ded134e45dab879a13d26f5b9c5815 URL: https://github.com/llvm/llvm-project/commit/b5e8348bf2ded134e45dab879a13d26f5b9c5815 DIFF: https://github.com/llvm/llvm-project/commit/b5e8348bf2ded134e45dab879a13d26f5b9c5815.diff LOG

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov updated this revision to Diff 378840. mizvekov added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111283/new/ https://reviews.llvm.org/D111283 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/Typ

[PATCH] D111588: [Clang][Attr] rename btf_tag to btf_decl_tag

yonghong-song created this revision. yonghong-song added reviewers: aaron.ballman, ast, anakryiko. Herald added a subscriber: jdoerfert. yonghong-song requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Current btf_tag is applied to declaration

[PATCH] D110210: [clang] NFC: include non friendly types and missing sugar in test expectations

mizvekov updated this revision to Diff 378832. mizvekov added a comment. rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110210/new/ https://reviews.llvm.org/D110210 Files: clang/test/CXX/expr/expr.prim/expr.prim.lambda/p4-cxx14.cpp clan

[PATCH] D111352: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. https://reviews.llvm.org/D111587 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111352/new/ https://reviews.llvm.org/D111352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith added a comment. This broke tests on windows (see the new parent revisions in the stack) otherwise the actual change's behavior, outside of the tests, is unchanged Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111587/new/ https://reviews.llv

[PATCH] D111587: re-land: [clang] Fix absolute file paths with -fdebug-prefix-map

keith created this revision. keith added a reviewer: probinson. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously if you passed an absolute path to clang, where only part of the path to the file was remapped, it would result

[clang] 25b3370 - PR52139: Properly handle more kinds of declaration when checking for

Author: Richard Smith Date: 2021-10-11T16:37:39-07:00 New Revision: 25b3370ff25f7a21f71e0dc6c4d7624d52cab604 URL: https://github.com/llvm/llvm-project/commit/25b3370ff25f7a21f71e0dc6c4d7624d52cab604 DIFF: https://github.com/llvm/llvm-project/commit/25b3370ff25f7a21f71e0dc6c4d7624d52cab604.diff

[clang] c5fb1a0 - Revert "[Clang] Ignore BTFTag attr if used as a type attribute"

Author: Yonghong Song Date: 2021-10-11T15:34:26-07:00 New Revision: c5fb1a09533ec2ed43a80f39c1592e5ee887ef9e URL: https://github.com/llvm/llvm-project/commit/c5fb1a09533ec2ed43a80f39c1592e5ee887ef9e DIFF: https://github.com/llvm/llvm-project/commit/c5fb1a09533ec2ed43a80f39c1592e5ee887ef9e.diff

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rG1131b1eb3509: [clang][Fuchsia] Support availability attr on Fuchsia (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://

[clang] 1131b1e - [clang][Fuchsia] Support availability attr on Fuchsia

Author: Haowei Wu Date: 2021-10-11T15:33:04-07:00 New Revision: 1131b1eb3509b47d30a36ea9b42367ab1d7373a2 URL: https://github.com/llvm/llvm-project/commit/1131b1eb3509b47d30a36ea9b42367ab1d7373a2 DIFF: https://github.com/llvm/llvm-project/commit/1131b1eb3509b47d30a36ea9b42367ab1d7373a2.diff LOG

[PATCH] D111582: [clang] Clear IR analyses before codegen pipeline

aeubanks created this revision. Herald added a subscriber: ormris. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This saves a tiny bit of memory in non-LTO builds [1]. [1] https://llvm-compile-time-tracker.com/compare.php?from=

Re: [clang] 2bd8493 - Improve type printing of const arrays to normalize array-of-const and const-array

On Wed, 15 Sept 2021 at 13:52, David Blaikie wrote: > On Tue, Sep 14, 2021 at 10:04 AM Richard Smith > wrote: > >> On Mon, 13 Sept 2021 at 19:24, David Blaikie via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> >>> Author: David Blaikie >>> Date: 2021-09-13T19:17:05-07:00 >>> New Rev

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith added a reviewer: compnerd. keith added a comment. Adding since you might be interested in this, I think the Swift logic is also derived from this so it might have the same difference. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111579/new/

[PATCH] D110215: [C++2a] [Module] Support extern C/C++ semantics

rsmith added a comment. Instead of moving functions and classes/enums into the global module after creating them, it would be better to push a module scope for the global module when entering a C or C++ language linkage specification and pop the module scope when leaving the linkage specificati

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

keith created this revision. keith requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On unix systems this logic would not separate the file and directory of the DIFile unless they shared more components at the start than just the root path ch

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. I can't see that any of the lib paths are tested at all, though I may be missing something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___ cfe-commits mailing list

[clang] 64d1d5f - [AIX] Unsupported newly added AMDGPU clang test

Author: Jinsong Ji Date: 2021-10-11T21:34:48Z New Revision: 64d1d5f336c3356ac77c588329ce3e449cc46de3 URL: https://github.com/llvm/llvm-project/commit/64d1d5f336c3356ac77c588329ce3e449cc46de3 DIFF: https://github.com/llvm/llvm-project/commit/64d1d5f336c3356ac77c588329ce3e449cc46de3.diff LOG: [A

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone updated this revision to Diff 378803. maharmstone added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/lib/Driver/ToolChains/MinGW.h clang/test/Driver

[PATCH] D111316: [CFE][Codegen][In-progress] Remove CodeGenFunction::InitTempAlloca()

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay, thanks, Alexey. LGTM, then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111316/new/ https://reviews.llvm.org/D111316 _

[PATCH] D111269: [clang][Driver] Make multiarch output file basenames reproducible

keith updated this revision to Diff 378796. keith added a comment. Fix slashes for windows Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111269/new/ https://reviews.llvm.org/D111269 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/darwin-d

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

python3kgae added a comment. Thanks for the review, the PR is committed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09 ___ cfe-commits mailing list cfe-commit

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:41 for (const PrebuiltModuleDep &PMD : PrebuiltModuleDeps) { -Args.push_back("-fmodule-file=" + PMD.ModuleName + "=" + PMD.PCMFile); +Args.push_back("-fmodule-

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378787. noajshu added a comment. rebase against main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ https://reviews.llvm.org/D111371 Files: clang/lib/CodeGen/BackendUtil.cpp lld/COFF/LTO.cpp l

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added a comment. In D111560#3056175 , @jansvoboda11 wrote: > In D111560#3056021 , @dexonsmith > wrote: > >> In D111560#3055578 , @jansvoboda11 >> wrote: >> >

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu added inline comments. Comment at: llvm/lib/Support/Caching.cpp:36 + SmallString<10> CacheName = CacheNameRef; return [=](unsigned Task, StringRef Key) -> AddStreamFn { tejohnson wrote: > noajshu wrote: > > noajshu wrote: > > > tejohnson wrote: > >

[PATCH] D111371: [Support][ThinLTO] Move ThinLTO caching to LLVM Support library.

noajshu updated this revision to Diff 378785. noajshu marked an inline comment as not done. noajshu added a comment. Make copies of string reference parameters outside the returned lambda. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111371/new/ h

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378784. haowei added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D110684: [RISCV] Define _m intrinsics as builtins, instead of macros.

craig.topper added a comment. This patch was uploaded without full context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110684/new/ https://reviews.llvm.org/D110684 ___ cfe-commits mailing list cfe-com

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2418-2420 + // also no children, and omit the others. None of the other current StmtAttrs + // have semantic meaning for the CFG. + if (isFallthroughStatement(A) && asc.alwaysAdd(*this, A)) {

[PATCH] D108592: [clang][Fuchsia] Support __attribute__((availability)) on Fuchsia

haowei updated this revision to Diff 378780. haowei added a comment. Fix test failures on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108592/new/ https://reviews.llvm.org/D108592 Files: clang/include/clang/Basic/Attr.td clang/includ

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 added a comment. In D111560#3056021 , @dexonsmith wrote: > In D111560#3055578 , @jansvoboda11 > wrote: > >> Note: Another approach to fixing this might be to cache the module load >> results while

[PATCH] D111543: [clang][modules] Stop creating `IdentifierInfo` for names of explicit modules

dexonsmith added a comment. It seems like using `CachedModuleLoads` wasn't quite right in the first place. I wonder if `-fmodule-file=` could/should use a different map (maybe one that doesn't exist yet), instead of replacing the key in CachedModuleLoads. In D111543#3054922

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song added inline comments. Comment at: clang/include/clang/AST/Type.h:4768 +private: + std::string BTFTypeTag; + aaron.ballman wrote: > I think we should be able to use a `StringRef` instead, rather than have to > worry about allocations. StringRef in

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

yonghong-song added a comment. In D99#3055928 , @aaron.ballman wrote: > In D99#3054126 , @yonghong-song > wrote: > >> @aaron.ballman Ping. This is to address your concern in D110127 >>

[PATCH] D111518: Add release note about `TypeLoc` matchers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG25fabc434ad5: Add release note about `TypeLoc` matchers. (authored by jcking1034, committed by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111518

[clang] 25fabc4 - Add release note about `TypeLoc` matchers.

Author: James King Date: 2021-10-11T19:57:32Z New Revision: 25fabc434ad5d1d7edd994b1fafb87e70ee2cda1 URL: https://github.com/llvm/llvm-project/commit/25fabc434ad5d1d7edd994b1fafb87e70ee2cda1 DIFF: https://github.com/llvm/llvm-project/commit/25fabc434ad5d1d7edd994b1fafb87e70ee2cda1.diff LOG: Ad

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

This revision was automatically updated to reflect the committed changes. Closed by commit rG121b2252de0e: AddGlobalAnnotations for function with or without function body. (authored by beanz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/

[clang] 121b225 - AddGlobalAnnotations for function with or without function body.

Author: Chris Bieneman Date: 2021-10-11T14:50:34-05:00 New Revision: 121b2252de0eed68f2ddf5f09e924a6c35423d47 URL: https://github.com/llvm/llvm-project/commit/121b2252de0eed68f2ddf5f09e924a6c35423d47 DIFF: https://github.com/llvm/llvm-project/commit/121b2252de0eed68f2ddf5f09e924a6c35423d47.diff

[PATCH] D111557: [clang][modules] NFC: Propagate import `SourceLocation` into `HeaderSearch::lookupModule`

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111557/new/ https://reviews.llvm.org/D111557 __

[PATCH] D102923: [clang][lex] Remark on search path usage

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks; I think this was worth it. I like how clean it looks with `-verify` in place. LGTM if you add a couple more header map tests, explained inline. Comment at:

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay added a comment. what @thakis said, this isn't normally my area but this is one of the files that has reverted its "clang-format clean" status with recent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://re

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

aaron.ballman added a comment. Thank you for the fix to this! Comment at: clang/lib/Analysis/CFG.cpp:2418-2420 + // also no children, and omit the others. None of the other current StmtAttrs + // have semantic meaning for the CFG. + if (isFallthroughStatement(A) && asc.alway

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added a comment. In D111560#3055578 , @jansvoboda11 wrote: > Note: Another approach to fixing this might be to cache the module load > results while loading the PCH too. Can you share why you chose this approach instead, and which do you thi

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 marked 2 inline comments as done. Ericson2314 added a comment. Removed extraneous StringRef conversion after previous D111322 was landed. Comment at: llvm/tools/llvm-config/llvm-config.cpp:361 +{ + SmallString<256> Path(S

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:118 AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "amdgcn", - SubArchName, - /* bitcode SDL?*/ true, - /* Pos

[PATCH] D111041: [clang-tidy] Remove 'IgnoreDestructors = true' from cppcoreguidelines-explicit-virtual-functions

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-use-override.cpp:56 virtual ~SimpleCases(); - // CHECK-MESSAGES: :[[@LINE-1]]:11: warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [modernize-use-o

[PATCH] D111199: [POC][BTF] support btf_type_tag attribute

aaron.ballman added a comment. In D99#3054126 , @yonghong-song wrote: > @aaron.ballman Ping. This is to address your concern in D110127 > , could you take a look whether my proposal > for a new attribute btf_type_t

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:194 - if (MArch.startswith_insensitive("rv32")) { -// FIXME: parse `March` to find `D` extension properly -if (MArch.substr(4).contains_insensitive("d") || -MArch.startsw

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2410 + +CFGBlock *CFGBuilder::VisitAttributedStmt(AttributedStmt *A, + AddStmtChoice asc) { (Compare this function to `CFGBuilder::VisitStmt` in this fil

[PATCH] D111570: [clang/CFG] Don't explicitly add AttributedStmtClass to AlwaysAddList

thakis created this revision. thakis added a reviewer: hans. thakis requested review of this revision. CFGBuilder::addStmt() implicitly passes AddStmtChoice::AlwaysAdd to Visit() already, so this should have no behavior change. https://reviews.llvm.org/D111570 Files: clang/lib/Sema/AnalysisBa

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. In D110663#3055813 , @phosek wrote: > I'm still worried that this solution as implemented is going to break > existing users, including major one like Rust. Well, it's better than calling the Project build deprecated (in favor o

[clang] 5ab2a95 - [clang] Remove an else-after-return

Author: Nico Weber Date: 2021-10-11T14:24:58-04:00 New Revision: 5ab2a95edb62e67478095e4e5619a07efc95ee21 URL: https://github.com/llvm/llvm-project/commit/5ab2a95edb62e67478095e4e5619a07efc95ee21 DIFF: https://github.com/llvm/llvm-project/commit/5ab2a95edb62e67478095e4e5619a07efc95ee21.diff LO

[clang] 00ca004 - [clang] Convert a few loops to for-each

Author: Nico Weber Date: 2021-10-11T14:24:32-04:00 New Revision: 00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6 URL: https://github.com/llvm/llvm-project/commit/00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6 DIFF: https://github.com/llvm/llvm-project/commit/00ca004dda3215dce98cf081cd6b1ee8b7a8b3d6.diff LO

[clang] 144f851 - [clang/CFG] Rewrap a line to 80 columns

Author: Nico Weber Date: 2021-10-11T14:23:51-04:00 New Revision: 144f851f6f5203969ef8b8052060ad56fcaab934 URL: https://github.com/llvm/llvm-project/commit/144f851f6f5203969ef8b8052060ad56fcaab934 DIFF: https://github.com/llvm/llvm-project/commit/144f851f6f5203969ef8b8052060ad56fcaab934.diff LO

[PATCH] D111568: [clang] Omit most AttributedStatements from the CFG

thakis created this revision. thakis added reviewers: hans, aaron.ballman. thakis requested review of this revision. `[[clang::fallthrough]]` has meaning for the CFG, but all other StmtAttrs we currently have don't. So omit them, as AttributedStatements with children cause several issues and there

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. In D110663#3055813 , @phosek wrote: > I'm still worried that this solution as implemented is going to break > existing users, including major one like Rust. > > I'm not also not a fan of special casing individual targets like Fuch

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

phosek added a comment. I'm still worried that this solution as implemented is going to break existing users, including major one like Rust. I'm not also not a fan of special casing individual targets like Fuchsia directly inside `Driver`, I believe that any per-target logic should live in the

[PATCH] D111208: [clang-tidy] Support globbing in NOLINT* expressions

aaron.ballman added reviewers: njames93, hokein, whisperity. aaron.ballman added a comment. Herald added a subscriber: rnkovacs. In D111208#3054246 , @carlosgalvezp wrote: > Awesome, thanks a lot for the review, I really improved my understanding of > t

[clang] d409048 - [Sema] Use llvm::is_contained (NFC)

Author: Kazu Hirata Date: 2021-10-11T11:06:44-07:00 New Revision: d4090482013599b1c246f3553717e2a88d6b24a5 URL: https://github.com/llvm/llvm-project/commit/d4090482013599b1c246f3553717e2a88d6b24a5 DIFF: https://github.com/llvm/llvm-project/commit/d4090482013599b1c246f3553717e2a88d6b24a5.diff L

[PATCH] D111517: [X86] Remove little support we had for MPX

MaskRay updated this revision to Diff 378737. MaskRay added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111517/new/ https://reviews.llvm.org/D111517 File

[PATCH] D111566: [SYCL] Fix function pointer address space

eandrews created this revision. eandrews added reviewers: vlastik, dylanmckay, bader. Herald added subscribers: Naghasan, Anastasia, ebevhan, yaxunl. eandrews requested review of this revision. Functions pointers should be created with program address space. This patch fixes a crash on lvalue ref

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

MaskRay added a comment. Ping:) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663/new/ https://reviews.llvm.org/D110663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:620 + Args.MakeArgString(Twine("--nvlink-command=" + NvlinkBin)); + CmdArgs.push_back(NvlinkPath); + Nit: the variables above are used only once. It would be fine to just `push_bac

[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

kito-cheng updated this revision to Diff 378729. kito-cheng added a comment. Changes: - Rebase to main - Remove b and zbproposedc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 Files: clang/include/c

[PATCH] D111457: [clang][test] Add lit helper for windows paths

keith updated this revision to Diff 378725. keith marked 2 inline comments as done. keith added a comment. Allow empty leading on windows This behavior is currently broken, the directory should never be `/` or `C:\` but the logic is broken and only handles `/` Repository: rG LLVM Github Mono

[PATCH] D111488: [Clang][clang-nvlink-wrapper] Pass nvlink path to the wrapper

Meinersbur accepted this revision. Meinersbur added a comment. This revision is now accepted and ready to land. Some nitpicks, but it fixes the build, so LGTM. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:617 + // Find nvlink and pass it as "--nvlink-command=" argument of

[PATCH] D111472: [docs] Mention in release notes that we now support 2^32 alignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb41cfbfcbbe2: [docs] Mention in release notes that we now support 2^32 alignment (authored by aeubanks). Repository: rG LLVM Github Monorepo CHAN

[clang] b41cfbf - [docs] Mention in release notes that we now support 2^32 alignment

Author: Arthur Eubanks Date: 2021-10-11T10:23:15-07:00 New Revision: b41cfbfcbbe27d519171b5847a8d44ca8a5a0f13 URL: https://github.com/llvm/llvm-project/commit/b41cfbfcbbe27d519171b5847a8d44ca8a5a0f13 DIFF: https://github.com/llvm/llvm-project/commit/b41cfbfcbbe27d519171b5847a8d44ca8a5a0f13.diff

[PATCH] D111472: [docs] Mention in release notes that we now support 2^32 alignment

aeubanks updated this revision to Diff 378719. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. mention in Clang release notes as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111472/new/ https:/

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 added a comment. Note: Another approach to fixing this might be to cache the module load results while loading the PCH too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111560/new/ https://reviews.llvm.org/D111560 __

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, rsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During modular build, PCM files are typically specified via the `-fmodule-file=`

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

dblaikie added a comment. Might not hurt to have some negative test cases too - like something that is a VarDecl but has NoStub DynamicInitKind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 __

[PATCH] D110127: [Clang] Support typedef with btf_tag attributes

yonghong-song added a comment. @aaron.ballman ping. To address your concerns, I intend to create another type attribute btf_type_tag (https://reviews.llvm.org/D99), could you comment on this new approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D111109: AddGlobalAnnotations for function with or without function body.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D09/new/ https://reviews.llvm.org/D09

[PATCH] D111443: [Driver] Fix ToolChain::getSanitizerArgs

eugenis added a comment. Don't we want to diagnose the problems in the job's command line? What kind of changes can the driver do there that would affect SanitizerArgs? I wonder if diagnostics should still be performed on the job args, but presented to the user differently, mainly because we ca

[PATCH] D111228: [clang-tidy] Add options to bugprone-unused-return-value.

aaron.ballman added a comment. In D111228#3054263 , @balazske wrote: > I think a configuration option that depends on configuration of another check > causes too many problems. It causes dependencies between checks, possible > circular dependency (that

[PATCH] D110779: [RISCV] Require tail policy argument to builtins to be an integer constant expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa5c3508ac71b: [RISCV] Require tail policy argument to builtins to be an integer constant… (authored by craig.topper). Herald added a project: clang.

[clang] a5c3508 - [RISCV] Require tail policy argument to builtins to be an integer constant expression

Author: Craig Topper Date: 2021-10-11T09:55:04-07:00 New Revision: a5c3508ac71bf30a6d2da35f438e90cc153d8d84 URL: https://github.com/llvm/llvm-project/commit/a5c3508ac71bf30a6d2da35f438e90cc153d8d84 DIFF: https://github.com/llvm/llvm-project/commit/a5c3508ac71bf30a6d2da35f438e90cc153d8d84.diff

[PATCH] D110258: [AArch64] Always add -tune-cpu argument to -cc1 driver

dmgreen added a comment. If D111551 was folded into this patch, would it be possible to add tests for -tune-cpu enabling/disabling features at the correct times? Comment at: clang/test/Driver/aarch64-mtune.c:3 + +// There shouldn't be a defa

[PATCH] D109517: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3550e242fad6: [Clang][ARM][AArch64] Add support for Armv9-A, Armv9.1-A and Armv9.2-A (authored by vhscampos). Repository: rG LLVM Github Monorepo

  1   2   >