[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

curdeius added a comment. Looks more or less correct, but I am afraid that this change may misbehave in some rare cases. Consider `*[](auto *x) { return x; }();`, so an immediately invoked lambda returning a pointer. It seems to be correctly formatted currently, but I don't see any test on it. C

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 425700. LegalizeAdulthood added a comment. Update documentation CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extra/

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae updated this revision to Diff 425697. python3kgae added a comment. Remove clang part change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124595/new/ https://reviews.llvm.org/D124595 Files: clang/test/CodeGenHLSL/Builtins/sin_f32.hl

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

craig.topper added a comment. I'm not opposed to this patch, but here's some additional info I think this is failing because we hit this code in CGExprScalar.cpp. Where SrcTy and DstTy are both i16 when using the conversion intrinsics. // Ignore conversions like int -> uint. if (SrcTy == Ds

[PATCH] D124595: [HLSL] Add llvm intrinsic for HLSL.

python3kgae created this revision. python3kgae added reviewers: simoll, k-ishizaka, kaz7. Herald added subscribers: Anastasia, dexonsmith, hiraditya, mgorny. Herald added a project: All. python3kgae requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert. H

[PATCH] D124594: [LegacyPM] Remove DataFlowSanitizerLegacyPass

MaskRay added a comment. In D124594#3479195 , @browneee wrote: > I know this is currently used in at least one other place: > https://github.com/tensorflow/tensorflow/blob/dde12a690476650573a0ef3f8f681271a2016224/tensorflow/compiler/xla/service/cpu/compil

[PATCH] D124594: [LegacyPM] Remove DataFlowSanitizerLegacyPass

browneee added a comment. I know this is currently used in at least one other place: https://github.com/tensorflow/tensorflow/blob/dde12a690476650573a0ef3f8f681271a2016224/tensorflow/compiler/xla/service/cpu/compiler_functor.cc#L111 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

yihanaa added a comment. > While we'd usually be happy to take the fix-in-hand and apply it, part of the > discussion on the other thread is whether to remove `__builtin_dump_struct` > entirely. Because of that, I don't think we should make substantial changes > in this area until it's clear we

[PATCH] D124594: [LegacyPM] Remove DataFlowSanitizerLegacyPass

MaskRay created this revision. MaskRay added reviewers: Sanitizers, browneee, vitalybuka. Herald added subscribers: StephenFan, hiraditya. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a proje

[PATCH] D124593: [HLSL][clang] Add clang builtin for HLSL.

python3kgae created this revision. python3kgae added reviewers: anakryiko, ast, yonghong-song. Herald added a subscriber: Anastasia. Herald added a project: All. python3kgae requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. A directx specific

[PATCH] D124356: [Driver][Solaris] -r: imply -nostdlib like GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7da810e4a6: [Driver][Solaris] -r: imply -nostdlib like GCC (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 3d7da81 - [Driver][Solaris] -r: imply -nostdlib like GCC

Author: Brad Smith Date: 2022-04-28T00:19:45-04:00 New Revision: 3d7da810e4a6e1ade2c0d649f17f8aa820248765 URL: https://github.com/llvm/llvm-project/commit/3d7da810e4a6e1ade2c0d649f17f8aa820248765 DIFF: https://github.com/llvm/llvm-project/commit/3d7da810e4a6e1ade2c0d649f17f8aa820248765.diff LO

[PATCH] D124556: [NFC] Prevent shadowing a variable declared in `if`

hubert.reinterpretcast added a comment. @ken-matsui, can you provide some rationale for the change (got compiler warning/error)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124556/new/ https://reviews.llvm.org/D124556 __

[PATCH] D115844: [ubsan] Using metadata instead of prologue data for function sanitizer

ychen added a comment. gentle ping. @pcc could we please move this forward if the direction looks good to you? It has been sitting for a while... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115844/new/ https://reviews.llvm.org/D115844

[PATCH] D124509: [RISCV] Fix int16 -> __fp16 conversion code gen

khchen added a comment. It's seem like all targets need to return `false` in `useFP16ConversionIntrinsics` for correctness of `int16` -> `__fp16` conversion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124509/new/ https://reviews.llvm.org/D12450

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) shchenz wrote: > nemanjai wrot

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. In D124563#3478978 , @aaronpuchert wrote: > Git will apply the LF -> CRLF transformation when it checks out itself. Git > doesn't show the file as modified because after cleaning the file (i.e. > applying CRLF -> LF) it's

[PATCH] D124434: [Clang][Test] Run tests in C++14 mode explicitly.

junaire planned changes to this revision. junaire added a comment. > In general, my concern with the this patch is that it loses test coverage by > specifying an explicit language mode. We typically prefer to fix the tests so > that they can work in any language mode (and perhaps add additional

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122258/new/ https://reviews.llvm.org/D122258 ___

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

davide added a comment. In D122258#3479045 , @int3 wrote: > Thanks for the feedback! > >> The binary compatibility issue is non-existent on arm64, but it could be >> still a thing on x86_64. > > Can we enable `OmitDwarfIfHaveCompactUnwind` by default on

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

int3 added a comment. Thanks for the feedback! > The binary compatibility issue is non-existent on arm64, but it could be > still a thing on x86_64. Can we enable `OmitDwarfIfHaveCompactUnwind` by default on arm64 then? And have it be opt-in just for x86_64? Repository: rG LLVM Github Mono

[PATCH] D124500: [clang-tidy] Support expressions of literals in modernize-macro-to-enum

LegalizeAdulthood updated this revision to Diff 425679. LegalizeAdulthood added a comment. Add file block comment CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124500/new/ https://reviews.llvm.org/D124500 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-extr

[PATCH] D124487: [HLSL] Adjust access specifier behavior

beanz updated this revision to Diff 425678. beanz added a comment. Herald added a project: clang-tools-extra. Updates based on PR feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124487/new/ https://reviews.llvm.org/D124487 Files: clang-t

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

modimo added a comment. In D124563#3478978 , @aaronpuchert wrote: > In D124563#3478968 , @modimo wrote: > >> I used `arc patch` and also saw the same thing. > > The patch does actually change the files to LF endi

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. In D124563#3478968 , @modimo wrote: > I used `arc patch` and also saw the same thing. The patch does actually change the files to LF endings. So just applying the patch with non-Git tools will make LF endings, but Git will

[PATCH] D124060: [PowerPC] Enable CR bits support for Power8 and above.

shchenz added inline comments. Comment at: clang/lib/Basic/Targets/PPC.cpp:519 .Default(false); + Features["crbits"] = llvm::StringSwitch(CPU) +.Case("ppc64le", true) nemanjai wrote: > shchenz wrot

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

modimo added a comment. In D124563#3478951 , @aaronpuchert wrote: > In D124563#3478937 , @modimo wrote: > >> Checking locally I'm seeing LF as the line ending in crlf.cpp in the working >> directory. Can you dou

[PATCH] D124589: [clang-format] Fix a bug that misformats Access Specifier after *[]

owenpan created this revision. owenpan added reviewers: curdeius, HazardyKnusperkeks, MyDeveloperDay. owenpan added a project: clang-format. Herald added a project: All. owenpan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

modimo added a comment. In D124563#3478937 , @modimo wrote: > Checking locally I'm seeing LF as the line ending in crlf.cpp in the working > directory. Can you double check that everything matches up? Ah it was some strange setup on my end. Confirmed pa

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. In D124563#3478937 , @modimo wrote: > Checking locally I'm seeing LF as the line ending in crlf.cpp in the working > directory. Can you double check that everything matches up? I had this too, but checking out again seems t

[clang-tools-extra] c9a16e8 - Drop '* text=auto' from .gitattributes and normalize

Author: Aaron Puchert Date: 2022-04-28T03:05:10+02:00 New Revision: c9a16e8c3d99173c7525e576d78eed57110d2b08 URL: https://github.com/llvm/llvm-project/commit/c9a16e8c3d99173c7525e576d78eed57110d2b08 DIFF: https://github.com/llvm/llvm-project/commit/c9a16e8c3d99173c7525e576d78eed57110d2b08.diff

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a16e8c3d99: Drop '* text=auto' from .gitattributes and normali

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

modimo requested changes to this revision. modimo added a comment. This revision now requires changes to proceed. Checking locally I'm seeing LF as the line ending in crlf.cpp in the working directory. Can you double check that everything matches up? Repository: rG LLVM Github Monorepo CHANG

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert commandeered this revision. aaronpuchert edited reviewers, added: modimo; removed: aaronpuchert. aaronpuchert added a comment. Ok, let's do it this way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124563/new/ https://reviews.llvm.org

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

modimo added a comment. In D124563#3478915 , @aaronpuchert wrote: > Drop `* text=auto`, so that we renormalize only the files that need it. Makes sense to me, thanks for putting it up. If you want to commandeer I can accept the change or you can accept

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

aaronpuchert added a comment. Would be nice if someone could accept this. I think this comes closest to the intention of D97625 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124563/new/ https://reviews.llvm.org/D

[PATCH] D124563: Drop '* text=auto' from .gitattributes and normalize

modimo added a comment. In D124563#3478781 , @aaronpuchert wrote: > In D124563#3478653 , @modimo wrote: > >> I think the way to go is to revert ac5f7be6a868 >>

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert updated this revision to Diff 425670. aaronpuchert edited the summary of this revision. aaronpuchert removed a subscriber: drodriguez. aaronpuchert added a comment. Herald added a subscriber: jdoerfert. Drop `* text=auto`, so that we renormalize only the files that need it. Reposito

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. In D124563#3478653 , @modimo wrote: > I think the way to go is to revert ac5f7be6a868 > then > land everything as a single stack to prevent this issue.

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478627 , @smeenai wrote: > If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and > `clang-tools-extra/test/clang-apply-repl

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. In D124563#3478747 , @aaronpuchert wrote: > How about we remove `* text=auto` for now? Or would that break something? The documentation says that: > If you want to ensure that t

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. In D124563#3478625 , @smeenai wrote: > I *think* this would mean that if you're on Windows and have `core.autocrlf` > set to `input`, when you commit changes to this files, Git will convert them > back to LF line endings. N

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. In D124563#3478625 , @smeenai wrote: > I *think* this would mean that if you're on Windows and have `core.autocrlf` > set to `input`, when you commit changes to this files, Git will convert them > back to LF line endings. Not

[PATCH] D122258: [MC] Omit DWARF unwind info if compact unwind is present for all archs

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. Compact unwind was developed as a goal to replace the DWARF unwind. Some apps did not work if the OS was missing DWARF unwind, so we kept both for Intel. The binary compatibility iss

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

Meinersbur added a comment. Regarding `crlf.cpp`(`.expected`), adding the modified changes to a commit indeed solved the problem I described in https://reviews.llvm.org/rGac5f7be6a8688955a282becf00eebc542238a86b#1080897 and I was working with that so far. Still don't know why Linux git doesn't

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

modimo added a comment. In D124563#3478627 , @smeenai wrote: > If I check out this commit and then check out the previous commit, > `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and > `clang-tools-extra/test/clang-apply-replacem

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

modimo added a comment. In D124563#3478561 , @smeenai wrote: > The following files have their line endings (when checked out on disk) > changed from CRLF to LF by this patch. Seems harmless, but I just wanted to > confirm that it was expected: > > >

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425650. dgoldman added a comment. - Remove extraneous computeExprType declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 Files: clang-tools-extra/clangd/r

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. If I check out this commit and then check out the previous commit, `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp` and `clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp.expected` become modified in my working directory; their l

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. In D124563#3478623 , @aaronpuchert wrote: > So maybe we should simply remove > > # These test input files rely on two-byte Windows (CRLF) line endings. > clang-apply-replacements/Inputs/crlf/crlf.cpp text eol=crlf > clang-a

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

aaronpuchert added a comment. Most of the files changed here are not affected by the `.gitattributes` file, such as clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readability-duplicate-include.h clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { sammccall wrote:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425644. dgoldman marked 5 inline comments as done. dgoldman added a comment. - Don't use a method for computing the type - Compute the type using printType - Support MemberExprs and add a test for function pointers Repository: rG LLVM Github Monorepo CHA

[PATCH] D119296: KCFI sanitizer

samitolvanen updated this revision to Diff 425642. samitolvanen marked an inline comment as done. samitolvanen added a comment. Herald added subscribers: ormris, wenlei, steven_wu, mgorny. - Added an LLVM pass to remove unneeded `llvm.kcfi.check` calls. - Switched from zeros to 0xcc for x86 type i

[PATCH] D124563: Renormalize line endings after ac5f7be6a8688955a282becf00eebc542238a86b

smeenai added a comment. The following files have their line endings (when checked out on disk) changed from CRLF to LF by this patch. Seems harmless, but I just wanted to confirm that it was expected: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-duplicate-include/readabilit

[PATCH] D124570: Revert "[analyzer][NFC] Refactor GenericTaintChecker to use CallDescriptionMap"

t-rasmud created this revision. t-rasmud added a reviewer: NoQ. Herald added subscribers: manas, steakhal, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. t-rasmud requested review of this revis

[PATCH] D119296: KCFI sanitizer

samitolvanen added a comment. In D119296#3466217 , @joaomoreira wrote: > Oh, one other tiny detail I forgot to mention. I noticed that the tag is > pushing the functions 6 bytes forward, regardless of any prepending padding > nops that were added to en

[PATCH] D123605: [WIP][Sema][SVE] Move/simplify Sema testing for SVE ACLE builtins

paulwalker-arm added inline comments. Comment at: clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_imm_n.cpp:25 +{ + // expected-error-re@+1 3 {{argument value {{[0-9]+}} is outside the valid range [0, 7]}} + EXPAND_XZM_FUNC(SVE_ACLE_FUNC(svqshlu,_n_s8,,), pg, svundef_s8(), -

[PATCH] D121177: [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd32c685e1012: [modules] Merge equivalent extensions and diagnose ivar redeclarations for… (authored by vsapsai). Repository: rG LLVM Github Monore

[clang] d32c685 - [modules] Merge equivalent extensions and diagnose ivar redeclarations for extensions loaded from different modules.

Author: Volodymyr Sapsai Date: 2022-04-27T15:52:59-07:00 New Revision: d32c685e1012785c0d2824214740f973d30e1daa URL: https://github.com/llvm/llvm-project/commit/d32c685e1012785c0d2824214740f973d30e1daa DIFF: https://github.com/llvm/llvm-project/commit/d32c685e1012785c0d2824214740f973d30e1daa.di

[clang] 7d2dddc - [PS5] Enable dead-stripping globals in ASan

Author: Paul Robinson Date: 2022-04-27T15:44:42-07:00 New Revision: 7d2dddce8f0d3ed896f1437b01a097cb7fd1bfe9 URL: https://github.com/llvm/llvm-project/commit/7d2dddce8f0d3ed896f1437b01a097cb7fd1bfe9 DIFF: https://github.com/llvm/llvm-project/commit/7d2dddce8f0d3ed896f1437b01a097cb7fd1bfe9.diff

[PATCH] D124525: [OpenMP][ClangLinkerWrapper] Extending linker wrapper to embed metadata for multi-arch fat binaries

yaxunl added a comment. need a test for the generated registration code Comment at: clang/tools/clang-linker-wrapper/OffloadWrapper.cpp:98-104 + // struct __tgt_image_info { + // int32_t version; + // int32_t image_number; + // int32_t number_images; + // char* off

[PATCH] D124489: Deprecate LLVM_BUILD_EXTERNAL_COMPILER_RT

delcypher added a comment. I spoke to a few other engineers in Apple. They are 1. Happy for us to proceed with marking `LLVM_BUILD_EXTERNAL_COMPILER_RT` as deprecated. 2. Okay with using `LLVM_BUILD_EXTERNAL_COMPILER_RT` being an error by default that can be downgraded to a warning using a CMak

[PATCH] D124563: renormalize

modimo created this revision. Herald added subscribers: hoy, wenlei. Herald added a project: All. modimo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124563 Fi

[PATCH] D123313: [OpenMP] Make clang argument handling for the new driver more generic

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123313/new/ https://reviews.llvm.org/D123313 __

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

arsenm added a comment. As far as I know this is supposed to be a broadcast from lane 0 to every lane, so not sure why the control flow really matters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124158/new/ https://reviews.llvm.org/D124158

[PATCH] D124158: [Clang][Attr] Skip adding noundef attribute to arguments when function has convergent attribute

jdoerfert added a comment. In D124158#3477649 , @efriedma wrote: > The issue you're describing sounds like it's specific to @__shfl_sync. In > general, in C++, you aren't allowed to read from an uninitialized variable; > see [basic.indet] in the standa

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with a minor nit. Comment at: clang/lib/Driver/Driver.cpp:4230 + // compile action to embed it in. If preprocessing only ignore embedding. + if ((!isa(HostAction) && PL.back

[PATCH] D124558: [Tooling/DependencyScanning] Make skipping excluded PP ranges during dependency scanning the default

akyrtzi created this revision. Herald added a project: All. akyrtzi requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to improve maintenance a bit and remove need to maintain the additional option and related code-paths. Repository

[PATCH] D117112: [AArch64] Support for Ampere1 core

philipp.tomsich updated this revision to Diff 425609. philipp.tomsich added a comment. Herald added a project: All. Update to reflect review results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117112/new/ https://reviews.llvm.org/D117112 Files:

[PATCH] D124452: [clang-format] Adjust editor cursor position past #include blocks

This revision was automatically updated to reflect the committed changes. owenpan marked an inline comment as done. Closed by commit rGdb57acff2647: [clang-format] Adjust editor cursor position past #include blocks (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[clang] db57acf - [clang-format] Adjust editor cursor position past #include blocks

Author: owenca Date: 2022-04-27T14:26:23-07:00 New Revision: db57acff264796c6c43214e731dbfcf97ff5f6af URL: https://github.com/llvm/llvm-project/commit/db57acff264796c6c43214e731dbfcf97ff5f6af DIFF: https://github.com/llvm/llvm-project/commit/db57acff264796c6c43214e731dbfcf97ff5f6af.diff LOG: [

[PATCH] D124556: Prevent shadowing a variable declared in `if`

ken-matsui created this revision. Herald added a project: All. ken-matsui requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D124556 Files: clang/lib/Basic/Diagnostic.cpp Ind

[PATCH] D124474: Honor COMPILER_RT_INCLUDE_TESTS when using LLVM_BUILD_EXTERNAL_COMPILER_RT=ON

beanz added a comment. I posted a PR to swift that migrates build-script to use `LLVM_ENABLE_RUNTIMES`: https://github.com/apple/swift/pull/58465 Obviously I can't test this against your internal infrastructure, but the change here is pretty trivial. Repository: rG LLVM Github Monorepo CHA

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

ken-matsui added a comment. Hi @aaron.ballman, Thank you for your review! I updated the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 ___ cfe-commits m

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

ken-matsui updated this revision to Diff 425601. ken-matsui added a comment. Add a diagnostic for line directive of a gnu extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124534/new/ https://reviews.llvm.org/D124534 Files: clang/include/c

[clang] fd0e60d - [PS5] Test sanitizer options/lib names

Author: Paul Robinson Date: 2022-04-27T13:45:41-07:00 New Revision: fd0e60d7874363a641e35a862b05d8dfabab77ef URL: https://github.com/llvm/llvm-project/commit/fd0e60d7874363a641e35a862b05d8dfabab77ef DIFF: https://github.com/llvm/llvm-project/commit/fd0e60d7874363a641e35a862b05d8dfabab77ef.diff

[PATCH] D95063: AMDGPU: Use optimization remarks for register usage

arsenm abandoned this revision. arsenm added a comment. Herald added subscribers: hsmhsm, foad. Herald added a project: All. Obsoleted by D123878 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95063/new/ https://reviews.llvm.org/D95063

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 425595. void added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/Randstruct.h

[PATCH] D124551: [Driver] Add f16 support to -mrecip parsing.

craig.topper created this revision. craig.topper added reviewers: spatel, efriedma, RKSimon. Herald added a subscriber: StephenFan. Herald added a project: All. craig.topper requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: clang. This is a followup to

[PATCH] D123958: [randstruct] Randomize all elements of a record

void added inline comments. Comment at: clang/lib/AST/Randstruct.cpp:201 +dyn_cast(RandomizedFields.back()->getType())) + if (CA->getSize().sle(2) || CA->isIncompleteArrayType()) +FlexibleArray = RandomizedFields.pop_back_val(); aaron.bal

[PATCH] D123958: [randstruct] Randomize all elements of a record

void updated this revision to Diff 425593. void marked 2 inline comments as done. void added a comment. Add a few more tests and remove a dead check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123958/new/ https://reviews.llvm.org/D123958 Files:

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj planned changes to this revision. upsj added a comment. I wasn't aware of that, sounds perfect, thanks! Then I'll put this on hold until I figure out if it's really necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124373/new/ https://

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

aaron.ballman added a comment. In D124373#3477996 , @upsj wrote: > This is part of my long-term goal to add support for forwarding parameters > and documentation for make_unique-like functions to clangd. To be fair, the > details are not entirely fleshe

[clang] 5e096ce - Update PGO and 3-stage cache files

Author: Chris Bieneman Date: 2022-04-27T14:41:56-05:00 New Revision: 5e096ce6c84fe80a15158dd10d3a23fb7135aa6d URL: https://github.com/llvm/llvm-project/commit/5e096ce6c84fe80a15158dd10d3a23fb7135aa6d DIFF: https://github.com/llvm/llvm-project/commit/5e096ce6c84fe80a15158dd10d3a23fb7135aa6d.diff

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4215 Action *HostAction) const { - if (!isa(HostAction)) + if (Args.hasArg(options::OPT_offload_host_only)) return HostAction; tra wrote: > jhube

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

upsj added a comment. This is part of my long-term goal to add support for forwarding parameters and documentation for make_unique-like functions to clangd. To be fair, the details are not entirely fleshed out - for inlay hints (displaying parameter names inline), the entire function template i

[PATCH] D124221: Add new builtin __builtin_reflect_struct.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:420 +auto *FD = IFD ? IFD->getAnonField() : dyn_cast(D); +if (!FD || (FD->isUnnamedBitfield() || FD->isAnonymousStructOrUnion())) + continue; rsmith wrote: > yihanaa wro

[PATCH] D124220: [OpenMP] Add options to only compile the host or device when offloading

tra added inline comments. Comment at: clang/include/clang/Driver/Options.td:2527 HelpText<"Use the static host OpenMP runtime while linking.">; +def offload_device_only : Flag<["-"], "offload-device-only">, + HelpText<"Only compile for the offloading device.">; -

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

probinson added a comment. Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` (or you might factor that bit out into its own test with the REQUIRES). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews

[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:681 + ArgStringList &CmdArgs) const { + CmdArgs.push_back( + Args.MakeArgString(StringRef("-L") + RocmInstallation.getLib

[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:681 + ArgStringList &CmdArgs) const { + CmdArgs.push_back( + Args.MakeArgString(StringRe

[PATCH] D124534: Add a warning diagnostic for line directive of a gnu extension

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this new diagnostic! Comment at: clang-tools-extra/test/clang-apply-replacements/Inputs/crlf/crlf.cpp:1 - -// This file intentionally uses a CRLF newlines! - -void foo() { -

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

dyung added a comment. I think the problem here is that if zlib is not available, you won't get the clang command line you expect: https://lab.llvm.org/buildbot/#/builders/216/builds/3519 Input was: << 1: clang version 15.0.0 (https://github.com/llvm/llvm-project.git 2d

[clang] 82aa5e2 - Revert "[Driver] Support for compressed debug info on Fuchsia"

Author: Petr Hosek Date: 2022-04-27T11:41:41-07:00 New Revision: 82aa5e2c6fe9ffbd637d421a799deffa0d90d7bf URL: https://github.com/llvm/llvm-project/commit/82aa5e2c6fe9ffbd637d421a799deffa0d90d7bf DIFF: https://github.com/llvm/llvm-project/commit/82aa5e2c6fe9ffbd637d421a799deffa0d90d7bf.diff LO

[PATCH] D124545: [HIP] Add HIP runtime library arguments for linker

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. Add -L -l options for linker. https://reviews.llvm.org/D124545 Files: clang/include/clang/Driver/Options.td clang/include/cl

[clang] 2d0c897 - [Driver] Support for compressed debug info on Fuchsia

Author: Petr Hosek Date: 2022-04-27T11:24:41-07:00 New Revision: 2d0c897212d0551966b26eae986209ea31c4f032 URL: https://github.com/llvm/llvm-project/commit/2d0c897212d0551966b26eae986209ea31c4f032 DIFF: https://github.com/llvm/llvm-project/commit/2d0c897212d0551966b26eae986209ea31c4f032.diff LO

[PATCH] D122920: [Clang][CodeGen]Fix __builtin_dump_struct missing record type field name

aaron.ballman added a comment. In D122920#3476388 , @yihanaa wrote: > In D122920#3472379 , @asoffer wrote: > >> In D122920#3471865 , @yihanaa >> wrote: >> >>> In D122920#

[PATCH] D124461: [Analyzer] Remove undefined function

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124461/new/ https://reviews.llvm.org/D124461 ___ cf

[PATCH] D124373: [clang] add parameter pack/pack expansion matchers

aaron.ballman added a comment. Due to how expensive it is to instantiate all the templates from ASTMatchers.h, we typically don't add new matchers unless there's a need for them in-tree or they're expected to be generally useful to a number of out-of-tree matchers. Are you planning to make use

  1   2   >