[PATCH] D133180: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. This LGTM, but one question about the test. Thanks! Comment at: clang/test/CodeGenCXX/dllstorage-hidden.cpp:3 + +// RUN: %clang_cc1 -triple x86_64-windows-msvc

[PATCH] D132997: [clang][Interp] Handle DeclRefExpr of reference types

tbaeder updated this revision to Diff 457498. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132997/new/ https://reviews.llvm.org/D132997 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/arrays.cpp clang/test/AST/Interp/references.cpp Index:

[PATCH] D132136: [clang] Perform implicit lvalue-to-rvalue cast with new interpreter

tbaeder added a comment. @aaron.ballman Can you comment on my last question? I'd like to land this patch since the others depend on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132136/new/ https://reviews.llvm.org/D132136 ___

[PATCH] D133029: [Sema] Allow to diagnose the references to std::vector with incomplete T

shafik added a comment. In D133029#3763688 , @ilya-biryukov wrote: > In D133029#3763120 , @shafik wrote: > >> Do you have an idea of how common this might be? > > I don't have the numbers yet, but this broke the

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1369 } + QualType getDecayedType(QualType T, QualType Decayed) const; mizvekov wrote: > ChuanqiXu wrote: > > mizvekov wrote: > > > ChuanqiXu wrote: > > > > Maybe we need a

[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + mizvekov wrote: > ChuanqiXu

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1369 } + QualType getDecayedType(QualType T, QualType Decayed) const; ChuanqiXu wrote: > mizvekov wrote: > > ChuanqiXu wrote: > > > Maybe we need a comment for this. The

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

junaire updated this revision to Diff 457485. junaire added a comment. Update the existing diagnostic and its tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133088/new/ https://reviews.llvm.org/D133088 Files: clang/docs/ReleaseNotes.rst

[PATCH] D131858: [clang] Track the templated entity in type substitution.

mizvekov added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:623-626 + VisitDeclaratorDecl(D); + Record.AddDeclarationNameLoc(D->DNLoc, D->getDeclName()); + Record.push_back(D->getIdentifierNamespace()); + ChuanqiXu wrote: > I still

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1369 } + QualType getDecayedType(QualType T, QualType Decayed) const; mizvekov wrote: > ChuanqiXu wrote: > > Maybe we need a comment for this. The signature looks not

[PATCH] D133180: [MinGW] Ignore -fvisibility/-fvisibility-inlines-hidden for dllexport

MaskRay updated this revision to Diff 457483. MaskRay added a comment. improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133180/new/ https://reviews.llvm.org/D133180 Files: clang/lib/CodeGen/CodeGenModule.cpp

[PATCH] D131858: [clang] Track the templated entity in type substitution.

ChuanqiXu added a comment. The summary looks good and I don't make a review in depth due to it is indeed large... (I'll see if I can take a deeper review) Comment at: clang/lib/Serialization/ASTReaderDecl.cpp:890-893 + struct { +bool DoIt; +FunctionDecl *Existing =

[PATCH] D133180: [MinGW] Skip -fvisibility/-fvisibility-inlines-hidden for dllexport

MaskRay created this revision. MaskRay added reviewers: mstorsjo, mati865, rnk. Herald added a subscriber: StephenFan. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Similar to

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

mizvekov added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1369 } + QualType getDecayedType(QualType T, QualType Decayed) const; ChuanqiXu wrote: > Maybe we need a comment for this. The signature looks not straight forward > and I

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

mizvekov added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2819-2823 + // For two canonically equal types, return a type which has + // the common sugar between them. If Unqualified is true, + // both types need only be the same unqualified type. + //

[PATCH] D130308: [clang] extend getCommonSugaredType to merge sugar nodes

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:1369 } + QualType getDecayedType(QualType T, QualType Decayed) const; Maybe we need a comment for this. The signature looks not straight forward and I can't relate this to

[PATCH] D111283: [clang] template / auto deduction deduces common sugar

ChuanqiXu added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:2819-2823 + // For two canonically equal types, return a type which has + // the common sugar between them. If Unqualified is true, + // both types need only be the same unqualified type. + //

[PATCH] D133177: [Clang] Fix lambda CheckForDefaultedFunction(...) so that it checks the CXXMethodDecl is not deleted before attempting to call DefineDefaultedFunction(...)

shafik created this revision. shafik added reviewers: aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. I discovered this additional bug at the end of working on D132906 In `Sema::CheckCompletedCXXClass(...) `

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik marked an inline comment as done. shafik added inline comments. Comment at: clang/test/SemaTemplate/temp_arg_nontype_diagnostic_cxx1z.cpp:7 + +template // ok, no diagnostic expected +void func() {} mizvekov wrote: > I think this should have a new

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik updated this revision to Diff 457471. shafik added a comment. - Updated to check contained deduced type before checking if it is an `AutoType` - Split out test into C++20 and C++17 parts CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132990/new/ https://reviews.llvm.org/D132990

[PATCH] D128845: [HLSL]Add -O and -Od option for dxc mode.

python3kgae updated this revision to Diff 457470. python3kgae marked 2 inline comments as done. python3kgae added a comment. Make O0 the same as Od. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128845/new/ https://reviews.llvm.org/D128845 Files:

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (TInfo->getType()->getContainedAutoType()) { Diag(D.getIdentifierLoc(), diag::warn_cxx14_compat_template_nontype_parm_auto_type) <<

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (TInfo->getType()->getContainedAutoType()) { Diag(D.getIdentifierLoc(), diag::warn_cxx14_compat_template_nontype_parm_auto_type) <<

[PATCH] D132990: [Clang] Fix compat diagnostic to detect a nontype template parameter has a placeholder type using getContainedAutoType()

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplate.cpp:1534-1538 + if (TInfo->getType()->getContainedAutoType()) { Diag(D.getIdentifierLoc(), diag::warn_cxx14_compat_template_nontype_parm_auto_type) <<

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457468. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir updated this revision to Diff 457467. Amir added a comment. Fix up paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132975/new/ https://reviews.llvm.org/D132975 Files: clang/CMakeLists.txt clang/cmake/caches/BOLT.cmake Index:

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov added a comment. In D133082#3764256 , @aaron.ballman wrote: > If we go this route, we definitely need user-facing documentation that > explains what's going on. I don't think we have anything corresponding to >

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457462. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/docs/UsersManual.rst

[PATCH] D125419: [Arm64EC 7/?] clang side of Arm64EC varargs ABI.

efriedma updated this revision to Diff 457459. efriedma added a reviewer: rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125419/new/ https://reviews.llvm.org/D125419 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/arm64ec.c

[PATCH] D125418: [Arm64EC 6/?] Implement C/C++ mangling for Arm64EC function definitions.

efriedma updated this revision to Diff 457457. efriedma added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125418/new/ https://reviews.llvm.org/D125418 Files: clang/include/clang/AST/Mangle.h

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen requested changes to this revision. ychen added a comment. This revision now requires changes to proceed. Oh, one more thing, we probably need to handle nested levels too, for example, `foo(a);` might be triggered by a template which may be in turn triggered by the concept check. So only

[PATCH] D133093: [clang-format] Fix a bug in merging blocks with a wrapped l_brace

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:716 +auto IsCtrlStmt = [](const auto ) { + return Line.First->isOneOf(tok::kw_if, tok::kw_else, tok::kw_while, + tok::kw_do, tok::kw_for,

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4012 + // Avoid an infinite template expansion loop in requirements checking by + // skipping the conversion functions check. Would be better to check this lazily (inside the if statement

[PATCH] D133052: [clang] Avoid crash when expanding conversion templates in concepts.

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. In D133052#3763983 , @luken-google wrote: > In D133052#3763201 , @ychen wrote: > >> In D133052#3763041

[PATCH] D101400: [Driver] Add -print-multiarch-triple

MaskRay added a comment. Herald added subscribers: abrachet, StephenFan. Herald added a project: All. In D101400#2990254 , @jrtc27 wrote: > Answering the last part myself: GCC only has MULTIARCH_DIRNAME definitions > for various linux-gnu*, linux-musl,

[PATCH] D133170: [Driver] Unsupport --print-multiarch

MaskRay created this revision. MaskRay added reviewers: jrtc27, phosek. Herald added subscribers: StephenFan, pengfei. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - If GCC is configured with

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This looks plausible to me — did you build clang-tools-extra & lldb to make sure nothing else needs to be updated? Comment at:

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

jhuber6 added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4396-4398 + bool SingleDeviceOutput = !llvm::any_of(OffloadActions, [](Action *A) { +return A->getType() == types::TY_Nothing; + }) && isa(HostAction); tra wrote: > `any_of(A->getType()

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

Passw updated this revision to Diff 457438. Passw added a comment. modify Foramt.h and generate ClangFormatStyleOptions.rst by running dump_format_style.py CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087 Files:

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

tra added a comment. OK. I'm going to land it then. Comment at: clang/lib/Driver/Driver.cpp:4396-4398 + bool SingleDeviceOutput = !llvm::any_of(OffloadActions, [](Action *A) { +return A->getType() == types::TY_Nothing; + }) && isa(HostAction);

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz added inline comments. Comment at: clang/include/clang/Sema/MultiplexExternalSemaSource.h:53 /// - MultiplexExternalSemaSource(ExternalSemaSource& s1, ExternalSemaSource& s2); + MultiplexExternalSemaSource(ExternalSemaSource* S1, ExternalSemaSource* S2);

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tra marked an inline comment as done. Closed by commit rG54c47ff9398f: [CUDA] Allow using -o with -fsyntax-only (authored by tra). Repository: rG LLVM Github

[clang] 54c47ff - [CUDA] Allow using -o with -fsyntax-only

Author: Artem Belevich Date: 2022-09-01T15:52:36-07:00 New Revision: 54c47ff9398fbd5fa7e4120b3286adfb4f736ec8 URL: https://github.com/llvm/llvm-project/commit/54c47ff9398fbd5fa7e4120b3286adfb4f736ec8 DIFF:

[PATCH] D132975: [clang][BOLT] Add clang-bolt target

Amir added a comment. Hi Petr, thank you for your comments! In D132975#3763264 , @phosek wrote: > This was already on my list of build system features I'd like to implement > and I'm glad someone else is already looking into it, thank you! I have two

[PATCH] D128958: Add assembler plumbing for sanitize_memtag

hctim updated this revision to Diff 457431. hctim added a comment. Herald added subscribers: cfe-commits, ormris, steven_wu. Herald added a project: clang. Move some existing stack tests to use -fsanitize=memtag-stack now that we have a non-android warning on -fsanitize=memtag-globals (which is

[PATCH] D133117: [clang] Give better message for unsupported no_sanitize on globals

abrachet marked an inline comment as done. abrachet added a comment. In D133117#3764721 , @aaron.ballman wrote: > LGTM aside from a requested change in diagnostic wording (no need for > additional review), though please also add a release note when

[PATCH] D133066: fix a typo in comment of AddConversionCandidate

zhouyizhou added a comment. In D133066#3764384 , @aaron.ballman wrote: > The existing comment is correct according to my copy of the C++11 standard, > but the standard has changed since C++11 and those words no longer appear in >

[PATCH] D133117: [clang] Give better message for unsupported no_sanitize on globals

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6d6e33abc2e: [clang] Give better message for unsupported no_sanitize on globals (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit:

[clang] f6d6e33 - [clang] Give better message for unsupported no_sanitize on globals

Author: Alex Brachet Date: 2022-09-01T22:35:42Z New Revision: f6d6e33abc2e8657b04721841d15191b7c3ff3d1 URL: https://github.com/llvm/llvm-project/commit/f6d6e33abc2e8657b04721841d15191b7c3ff3d1 DIFF: https://github.com/llvm/llvm-project/commit/f6d6e33abc2e8657b04721841d15191b7c3ff3d1.diff LOG:

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

jhuber6 added a comment. In D133161#3765469 , @tra wrote: > Does this patch obviate D133133 or is it > purely for the new driver functionality? If the intent of that patch was to prevent it from emitting an error with

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

tra added a comment. Does this patch obviate D133133 or is it purely for the new driver functionality? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133161/new/ https://reviews.llvm.org/D133161

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc911befaec49: [InstCombine] Treat passing undef to noundef params as UB (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES

[clang] c911bef - [InstCombine] Treat passing undef to noundef params as UB

Author: Arthur Eubanks Date: 2022-09-01T15:16:45-07:00 New Revision: c911befaec494c52a63e3b957e28d449262656fb URL: https://github.com/llvm/llvm-project/commit/c911befaec494c52a63e3b957e28d449262656fb DIFF:

[PATCH] D133161: [Clang] Fix the new driver crashing when using '-fsyntax-only'

jhuber6 created this revision. jhuber6 added reviewers: tra, yaxunl, jdoerfert, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1, MaskRay. Herald added a project: clang. The new driver currently crashses when

[PATCH] D133160: [cmake] Append CLANG_LIBDIR_SUFFIX to scan-build-py installation destination.

sinan created this revision. sinan added reviewers: isthismyaccount, Ericson2314, phosek. Herald added subscribers: whisperity, mgorny. Herald added a reviewer: NoQ. Herald added a project: All. sinan requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

MaskRay added a comment. The risk conflicting with a GCC option is probably quite low. If there is something, the GCC option will likely be `-mguard-*=` instead of `-mguard=` (IMHO confusing). Comment at: clang/lib/Driver/ToolChains/MinGW.cpp:627 +StringRef GuardArgs =

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

ahatanak added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1429 + GetAddrOfLocalVar(*setterMethod->param_begin()), ivar->getType()); + callCStructCopyAssignmentOperator(Dst, Src); +} else { rjmccall wrote: > When the method takes

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

aprantl added inline comments. Comment at: clang/include/clang/Sema/MultiplexExternalSemaSource.h:53 /// - MultiplexExternalSemaSource(ExternalSemaSource& s1, ExternalSemaSource& s2); + MultiplexExternalSemaSource(ExternalSemaSource* S1, ExternalSemaSource* S2);

[PATCH] D133155: Update the docs about IRC

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133155/new/ https://reviews.llvm.org/D133155

[PATCH] D133158: [NFC] Make MultiplexExternalSemaSource own sources

beanz created this revision. beanz added reviewers: rsmith, aaron.ballman, python3kgae, akyrtzi, aprantl. Herald added a project: All. beanz requested review of this revision. Herald added a project: clang. This change refactors the MuiltiplexExternalSemaSource to take ownership of the underlying

[PATCH] D133105: [Clang][Comments] Fix `Index/comment-lots-of-unknown-commands.c`

aaronpuchert accepted this revision. aaronpuchert added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133105/new/ https://reviews.llvm.org/D133105

[PATCH] D132975: [clang][BOLT] Add clang-bolt target (WIP)

Amir updated this revision to Diff 457400. Amir added a comment. Succeeded in producing optimized Clang. Switch the default profiling target from `lld` to `count`, which produces a sufficient Clang coverage of 5.3B exec insns (along with configure-stage Clang invocations). Repository: rG

[PATCH] D133155: Update the docs about IRC

aaron.ballman created this revision. aaron.ballman added reviewers: jdoerfert, tonic, asl. Herald added a project: All. aaron.ballman requested review of this revision. Herald added a project: LLVM. We haven't had a Geordi bot in years and we moved the build bot to another channel. This updates

[PATCH] D117622: [MSAN] removing redundant tests and parameters (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b509f2d1a19: [MSAN] removing redundant tests and parameters (NFC) (authored by kda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] 0b509f2 - [MSAN] removing redundant tests and parameters (NFC)

Author: Kevin Athey Date: 2022-09-01T14:03:55-07:00 New Revision: 0b509f2d1a1944da41bfc376f39bbc17690f8ed9 URL: https://github.com/llvm/llvm-project/commit/0b509f2d1a1944da41bfc376f39bbc17690f8ed9 DIFF: https://github.com/llvm/llvm-project/commit/0b509f2d1a1944da41bfc376f39bbc17690f8ed9.diff

[PATCH] D131465: C++/ObjC++: switch to gnu++17 as the default standard

MaskRay updated this revision to Diff 457390. MaskRay retitled this revision from "C++/ObjC++: switch to gnu++17 as the default dialect" to "C++/ObjC++: switch to gnu++17 as the default standard". MaskRay edited the summary of this revision. MaskRay added a comment. Skip PS4/PS5. Add `//

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks updated this revision to Diff 457383. aeubanks added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/

[PATCH] D133043: [clangd] Fix tests for implicit C function declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc4b86cfc01c: [clangd] Fix tests for implicit C function declaration (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133043/new/

[clang-tools-extra] cc4b86c - [clangd] Fix tests for implicit C function declaration

Author: Aleksandr Platonov Date: 2022-09-01T23:46:20+03:00 New Revision: cc4b86cfc01c3a923324c4bf1485ae9c8021e0a1 URL: https://github.com/llvm/llvm-project/commit/cc4b86cfc01c3a923324c4bf1485ae9c8021e0a1 DIFF:

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

jhuber6 added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:99 +// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output: (nothing) // // Test two gpu architectures up to the assemble phase. tra wrote: > tra wrote: > > yaxunl

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

tra marked an inline comment as done. tra added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:99 +// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output: (nothing) // // Test two gpu architectures up to the assemble phase.

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

tra updated this revision to Diff 457377. tra added a comment. Updated tests and addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133133/new/ https://reviews.llvm.org/D133133 Files: clang/lib/Driver/Driver.cpp

[PATCH] D132810: [clang][MinGW] Add `-mguard=cf` and `-mguard=cf-nochecks`

mstorsjo added a comment. In D132810#3756000 , @rnk wrote: > +@maskray, should we use `-mguard=` as the GCC spelling of the MSVC `/GUARD:` > flag? Short flags are nice, but it seems there may be a risk of GCC using > `-mguard=` for something else at

[PATCH] D117622: [MSAN] removing redundant tests and parameters (NFC)

vitalybuka added inline comments. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +// RUN: %clangxx_msan %s

[PATCH] D117622: [MSAN] removing redundant tests and parameters (NFC)

kda added a comment. Just returning to finish this clean up. Comment at: compiler-rt/test/msan/noundef_analysis.cpp:5 // RUN: FileCheck %s < %t.out -// RUN: %clangxx_msan %s -disable-noundef-analysis -s -fsanitize-memory-param-retval -o %t && not %run %t >%t.out 2>&1 +//

[PATCH] D117622: cleanups from 1b1c8d83d3567a60280291c0adb95d1d60335509

kda updated this revision to Diff 457370. kda added a comment. Herald added a subscriber: Enna1. Herald added a project: All. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117622/new/ https://reviews.llvm.org/D117622 Files:

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

tra added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:99 +// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output: (nothing) // // Test two gpu architectures up to the assemble phase. yaxunl wrote: > should we check there

[PATCH] D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default

MaskRay updated this revision to Diff 457367. MaskRay marked 2 inline comments as done. MaskRay edited the summary of this revision. MaskRay added a comment. Fix a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131464/new/

[PATCH] D132056: [HLSL] Restrict to supported targets

jcranmer-intel accepted this revision. jcranmer-intel added a comment. This revision is now accepted and ready to land. I don't necessarily know clang-specific code to have that valuable an opinion here, but I don't see anything wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

yaxunl added inline comments. Comment at: clang/test/Driver/cuda-bindings.cu:99 +// SYN-DAG: # "nvptx64-nvidia-cuda" - "clang", inputs: [{{.*}}], output: (nothing) // // Test two gpu architectures up to the assemble phase. should we check there is no binding

[PATCH] D132131: [clang-format] Adds a formatter for aligning trailing comments over empty lines

HazardyKnusperkeks added a comment. In my opinion we are nearly done. Comment at: clang/docs/ClangFormatStyleOptions.rst:3698 - QualifierOrder: ['inline', 'static', 'type', 'const'] + QualifierOrder: ['inline', 'static' , 'type', 'const'] Anyone

[PATCH] D123630: Remove connection between 'ffast-math' and 'ffp-contract'.

zahiraam updated this revision to Diff 457358. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123630/new/ https://reviews.llvm.org/D123630 Files: clang/docs/UsersManual.rst clang/lib/Driver/ToolChains/Clang.cpp clang/test/CodeGen/ffp-contract-option.c

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev added a reviewer: aaron.ballman. v.g.vassilev added a comment. Adding Aaron as a reviewer who hopefully could speed up the review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127284/new/ https://reviews.llvm.org/D127284 ___

[PATCH] D133088: [Clang] Fix wrong diagnostic for scope identifier with internal linkage

pmor13 added a comment. Note that this code: int x; void f(void) { extern int x = 1; } needs to produce: error" declaration of block scope identifier with external linkage shall have no initializer So, `err_block_extern_cant_init` needs to be updated too (I think).

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LG, thanks. Comment at: clang/lib/Driver/Driver.cpp:4555 else if (A->getKind() == Action::OffloadClass && - A->getType() == types::TY_Nothing) +

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457353. python3kgae added a comment. Update warning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td

[PATCH] D132991: [Clang] Give error message for invalid profile path when compiling IR

aidengrossman added a comment. @xur I've modified the patch slightly (mainly fixing tests and changing the error message printing in `CodeGenModule` to an assert as we should be capturing everything in `CompilerInvocation`. Do you mind looking over these changes, specifically making sure that

[PATCH] D133093: [clang-format] Fix a bug in merging blocks with a wrapped l_brace

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:716 +auto IsCtrlStmt = [](const auto ) { + return

[PATCH] D133087: [clang-format][NFC][Docs] fix wrong example of warping class definitions

HazardyKnusperkeks added a comment. You have to make the change in the `Format.h` and run `clang/docs/tools/dump_format_style.py` which generates the rst. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133087/new/ https://reviews.llvm.org/D133087

[PATCH] D132756: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14757d5b845b: [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of… (authored by wyt). Repository: rG LLVM Github

[clang] 14757d5 - [clang][dataflow] Refactor `TypeErasedDataflowAnalysisTest` - replace usage of the deprecated overload of `checkDataflow`.

Author: Wei Yi Tee Date: 2022-09-01T19:17:37Z New Revision: 14757d5b845bdba0ea101b4cff2efc07261c898b URL: https://github.com/llvm/llvm-project/commit/14757d5b845bdba0ea101b4cff2efc07261c898b DIFF: https://github.com/llvm/llvm-project/commit/14757d5b845bdba0ea101b4cff2efc07261c898b.diff LOG:

[PATCH] D125655: [HLSL] add -P option for dxc mode.

beanz added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:670 +def warn_drv_dxc_ignore_output_for_preprocess : Warning< + "output compiler options like -Fo ignored with Preprocess">, + InGroup; We should be specific about

[PATCH] D133133: [CUDA] Allow using -o with -fsyntax-only

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra updated this revision to Diff 457341. tra added a comment. tra updated this revision to Diff 457343. tra published this revision for review. tra added reviewers: jhuber6,

[PATCH] D132952: [Sema] disable -Wvla for function array parameters

aaron.ballman added a comment. In D132952#3761874 , @aaron.ballman wrote: > I'll ask on the WG14 reflectors to see if I'm interpreting the variably > modified type specification wrong or not. There's some agreement that the existing words could stand

[PATCH] D125655: [HLSL] add -P option for dxc mode.

python3kgae updated this revision to Diff 457329. python3kgae added a comment. Make a full patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125655/new/ https://reviews.llvm.org/D125655 Files:

[PATCH] D133082: [clang] Implement setting crash_diagnostics_dir through env variable

mizvekov updated this revision to Diff 457327. mizvekov marked 10 inline comments as done. mizvekov requested review of this revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133082/new/ https://reviews.llvm.org/D133082 Files:

[PATCH] D130096: [Clang][AMDGPU] Emit AMDGPU library control constants in clang

jhuber6 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:9436 +CGM.getModule(), Type, true, +llvm::GlobalValue::LinkageTypes::LinkOnceODRLinkage, +llvm::ConstantInt::get(Type, Value), Name, nullptr, yaxunl wrote: >

[PATCH] D131701: [CodeGen][ObjC] Call synthesized copy constructor/assignment operator functions in getter/setter functions of non-trivial C struct properties

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGObjC.cpp:1429 + GetAddrOfLocalVar(*setterMethod->param_begin()), ivar->getType()); + callCStructCopyAssignmentOperator(Dst, Src); +} else { When the method takes the structure by

[PATCH] D132851: Further update -Wbitfield-constant-conversion for 1-bit bitfield

aaron.ballman added inline comments. Comment at: clang/test/Sema/constant-conversion.c:30 + s.b = 1; // one-bit-warning {{implicit truncation from 'int' to a one-bit wide bit-field changes value from 1 to -1}} + s.b = true; // no-warning (we suppress it manually to

[PATCH] D133043: [clangd] Fix tests for implicit C function declaration

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! (And not surprising at all this regressed, the mechanism clangd is using here is extremely fragile, we just couldn't come up with a better one :-() Repository: rG LLVM

  1   2   3   >