[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

zero9178 updated this revision to Diff 470071. zero9178 added a comment. clang-format and specify target triple in test since mangling is target dependent CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136548/new/ https://reviews.llvm.org/D136548 Files: clang/lib/CodeGen/CGBuiltin.cp

[PATCH] D112049: [ObjC] avoid crashing when emitting synthesized getter/setter and ptrdiff_t is smaller than long

mhjacobson added a comment. Hello, and sorry for the delay. The blocking bug was fixed by D112113 . This is ready for review. Please let me know if you have any feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D136162: [analyzer] Fix assertion failure with conflicting prototype calls

steakhal marked 2 inline comments as done. steakhal added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:490 +// edge-cases. +ArgVal = castArgToParamTypeIfNeeded(Call, Idx, ArgVal, SVB); + steakhal wrote: > tomasz-kaminski-sonars

[clang] f8b8426 - [RISCV] Add Svnapot extension

Author: Piyou Chen Date: 2022-10-24T01:27:04-07:00 New Revision: f8b8426861a7a26ff60fe085800cc338591bee41 URL: https://github.com/llvm/llvm-project/commit/f8b8426861a7a26ff60fe085800cc338591bee41 DIFF: https://github.com/llvm/llvm-project/commit/f8b8426861a7a26ff60fe085800cc338591bee41.diff LO

[PATCH] D136080: [flang] Add -ffp-contract option processing

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:1926 + " Default is 'fast' for CUDA, 'fast-honor-pragmas' for HIP, 'off' for flang, and 'on' otherwise.">, + HelpText<"Form fused FP ops (e.g. FMAs): fast | off (clang, flang), on | fast-honor

[PATCH] D136570: [RISCV] Add Svnapot extension

This revision was automatically updated to reflect the committed changes. Closed by commit rGf8b8426861a7: [RISCV] Add Svnapot extension (authored by BeMg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. @philnik it seems that didn't work. It seems those pipelines are already running clang-16, according to the cmake logs, they are just not bootstrapping with this patch. So gating this on clang version will not work. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86InstPrinterCommon.cpp:32 int64_t Imm = MI->getOperand(Op).getImm(); + bool flavor = MI->getOpcode() == X86::CMPCCXADDmr32 || X86::CMPCCXADDmr64; switch (Imm) { Capitalize 1st char

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3024 +// +let Predicates = [HasCMPCCXADD, In64BitMode], Defs = [EFLAGS], +Constraints = "$dstsrc2 = $dst" in { ---

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86InstrInfo.td:3027 +def CMPCCXADDmr32 : I<0xe0, MRMDestMem4VOp3CC, (outs GR32:$dst), + (ins GR32:$dstsrc2, i32mem:$dstsrc1, GR32:$src3, ccode:$cond), + "cmp${cond}xadd\t{$src3, $dst, $dstsrc1|$dstsrc1

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge updated this revision to Diff 470083. nridge marked 4 inline comments as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133756/new/ https://reviews.llvm.org/D133756 Files: clang-tools-e

[PATCH] D133756: [clangd] Introduce CompileCommandsAdjuster

nridge added a comment. (apologies, I'm also very tardy in getting back to this...) Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.h:165 +// process a file (possibly different from the one in the command). +class CompileCommandsAdjuster { +public: --

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta updated this revision to Diff 470092. thieta added a comment. Added TokenAnnotatorTest and removed reduntant FormatTests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ https://reviews.llvm.org/D136336 Files: clang/lib/Format/To

[PATCH] D136336: [clang-format] Mark pragma region lines as StringLiterals

thieta added a comment. In D136336#3877238 , @owenpan wrote: > Can you add a test to `TokenAnnotatorTest.cpp`? Thanks for the review. Fixed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136336/new/ ht

[PATCH] D136337: [clang-format] Discard pre-processor statements in parseBracedList()

thieta added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136337/new/ https://reviews.llvm.org/D136337 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

frasercrmck added a comment. I agree with @reames, though I do think the patch description could use a rewrite. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116735/new/ https://reviews.llvm.org/D116735 ___

[PATCH] D135932: [X86] Add AVX-IFMA instructions.

pengfei added inline comments. Comment at: clang/include/clang/Basic/BuiltinsX86.def:1335-1338 TARGET_BUILTIN(__builtin_ia32_vpmadd52huq128, "V2OiV2OiV2OiV2Oi", "ncV:128:", "avx512ifma,avx512vl") TARGET_BUILTIN(__builtin_ia32_vpmadd52huq256, "V4OiV4OiV4OiV4Oi", "ncV:256:", "a

[PATCH] D135953: [IncludeCleaner] Introduce decl to location mapping

kadircet added a comment. In D135953#3861180 , @tschuett wrote: > We support Apple Clang 9.3, but `std:variant` ships with Apple Clang 10.0. :-( Hi @tschuett, there are other pieces of LLVM that use `` today already, some big components include TableGen

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

vhscampos created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. vhscampos requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Cortex-X3 is an Armv9-A AArch64 CPU. This patch i

[clang] 6f1e430 - [AArch64] Alter v8.5a FRINT neon intrinsics to be target-based, not preprocessor based

Author: David Green Date: 2022-10-24T11:22:06+01:00 New Revision: 6f1e430360591e22fb163ec77b78efd2de4c1d95 URL: https://github.com/llvm/llvm-project/commit/6f1e430360591e22fb163ec77b78efd2de4c1d95 DIFF: https://github.com/llvm/llvm-project/commit/6f1e430360591e22fb163ec77b78efd2de4c1d95.diff L

[PATCH] D135646: [AArch64] Alter v8.5a FRINT neon intrinsics to be target-based, not preprocessor based

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6f1e43036059: [AArch64] Alter v8.5a FRINT neon intrinsics to be target-based, not… (authored by dmgreen). Herald added a project: clang. Herald added

[PATCH] D136293: [IncludeCleaner] Add public API

kadircet marked 13 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:14 +#include "llvm/ADT/STLFunctionalExtras.h" +#include + sammccall wrote: > This is awful but: as

[PATCH] D136293: [IncludeCleaner] Add public API

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67 +llvm::errs() << "returning stdlib\n"; +return CB(Loc, Symbol(*SS), toHeader(SS->headers())); + } samm

[PATCH] D136293: [IncludeCleaner] Add public API

kadircet updated this revision to Diff 470106. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136293/new/ https://reviews.llvm.org/D136293 Files: clang-tools-

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added reviewers: lenary, dmgreen. dmgreen added inline comments. Comment at: clang/docs/ReleaseNotes.rst:397 configuration files. +- Support has been added for the following processors (-mcpu identifiers in parentheses): + This should be in the "Arm a

[PATCH] D136589: [AArch64] Add support for the Cortex-X3 CPU

dmgreen added a comment. Can you also add a test to clang/test/Driver/aarch64-mcpu.c and the right code to llvm/lib/Support/Host.cpp if you can find it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136589/new/ https://reviews.llvm.org/D136589 __

[PATCH] D136574: [clang] Copy cmake_policy() to silence CMake warnings in standalone builds

mgorny abandoned this revision. mgorny added a comment. I'll make one patch for all relevant projects instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136574/new/ https://reviews.llvm.org/D136574 ___ cfe-commits mailing list cfe-commits

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470108. mgorny retitled this revision from "[lld] Copy cmake_policy() to silence CMake warnings in standalone builds" to "Harmonize cmake_policy() across standalone builds of all projects". mgorny edited the summary of this revision. mgorny added reviewers: me

[PATCH] D118743: [clang-tidy] Add `modernize-use-inline-const-variables-in-headers` check

Izaron added a comment. A friendly ping 🙂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118743/new/ https://reviews.llvm.org/D118743 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D135933: [X86] Add CMPCCXADD instructions.

FreddyYe added inline comments. Comment at: llvm/lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp:1453-1455 +emitMemModRMByte(MI, CurOp + 1, getX86RegNum(MI.getOperand(0)), TSFlags, + HasREX, StartByte, OS, Fixups, STI, false); +CurOp = SrcRegNum + 3;

[clang] 9ec7448 - [Clang][AArch64] Add support for -mcpu=grace

Author: Sjoerd Meijer Date: 2022-10-24T17:36:24+05:30 New Revision: 9ec7448857c1bcbc9878e9912167d9453d3be673 URL: https://github.com/llvm/llvm-project/commit/9ec7448857c1bcbc9878e9912167d9453d3be673 DIFF: https://github.com/llvm/llvm-project/commit/9ec7448857c1bcbc9878e9912167d9453d3be673.diff

[PATCH] D136425: [Clang][AArch64] Add support for -mcpu=grace

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ec7448857c1: [Clang][AArch64] Add support for -mcpu=grace (authored by SjoerdMeijer). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] 1534b04 - Fix caret position to be on the non null parameter

Author: Arthur Grillo Date: 2022-10-24T08:38:21-04:00 New Revision: 1534b048d6fdd7cf5f7dd5d3b8c6876b7cdad184 URL: https://github.com/llvm/llvm-project/commit/1534b048d6fdd7cf5f7dd5d3b8c6876b7cdad184 DIFF: https://github.com/llvm/llvm-project/commit/1534b048d6fdd7cf5f7dd5d3b8c6876b7cdad184.diff

[PATCH] D136355: [clang][Sema] Fix caret position to be on the non null parameter

This revision was automatically updated to reflect the committed changes. Closed by commit rG1534b048d6fd: Fix caret position to be on the non null parameter (authored by Grillo, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D136449: [Clang] Implement P2513

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a missing full stop in a comment. Tom's on vacation most of this week, so if he has any concerns, they can be address post-commit unless you want to wait for him

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D109239: Add support for floating-option `-ffp-eval-method` and for new `pragma clang fp eval-method`

zahiraam added a comment. In D109239#3878422 , @ArcsinX wrote: > It seems for x86_32 case (e.g. with -m32 in command line) there is a > difference between clang and GCC: > clang: `__FLT_EVAL_METHOD__` == 0 > GCC: `__FLT_EVAL_METHOD__` == 2 > > Example: >

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. It looks like precommit CI caught a failing test case that should be fixed before landing, but otherwise this LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136451/

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/test/CXX/over/over.match/over.match.best/p2.cpp:10 }; - bool k1 = A() < A(); // not ordered by constraints: prefer non-rewritten form - bool k2 = A() < A(); // prefer more-constrained 'op

[PATCH] D136545: [Clang] use non-template function declaration for constraints partial ordering

mizvekov accepted this revision. mizvekov added a comment. LGTM as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136545/new/ https://reviews.llvm.org/D136545 ___ cfe-commits mailing list cfe-commit

[PATCH] D136533: Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

erichkeane accepted this revision. erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:176 + auto *FoundRD = dyn_cast(TD); + if (DCK != DiagCtorKind::None && LookupRD && FoundRD && + FoundRD->isInjectedClassName() && So I know our cod

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This is an improvement, thanks! Comment at: clang/lib/Sema/SemaConcept.cpp:1079 MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( - CSE->

[clang] b7c9226 - GH58368: Correct concept checking in a lambda defined in concept

Author: Erich Keane Date: 2022-10-24T06:32:18-07:00 New Revision: b7c922607c5ba93db8b893d4ba461052af8317b5 URL: https://github.com/llvm/llvm-project/commit/b7c922607c5ba93db8b893d4ba461052af8317b5 DIFF: https://github.com/llvm/llvm-project/commit/b7c922607c5ba93db8b893d4ba461052af8317b5.diff L

[PATCH] D136451: GH58368: Correct concept checking in a lambda defined in concept

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb7c922607c5b: GH58368: Correct concept checking in a lambda defined in concept (authored by erichkeane). Herald added a project: clang. Changed prio

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

mizvekov added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1079 MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( - CSE->getNamedConcept(), /*Final=*/false, &TAL, + CSE->getNamedConcept(), /*Final=*/true, &TAL, /*RelativeTo

[PATCH] D136566: [clang] Instantiate concepts with sugared template arguments

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:1079 MultiLevelTemplateArgumentList MLTAL = S.getTemplateInstantiationArgs( - CSE->getNamedConcept(), /*Final=*/false, &TAL, + CSE->getNamedConcept(), /*Final=*/true, &TAL, /*Relative

[PATCH] D134604: [clang] Implement sugared substitution changes to infrastructure

erichkeane accepted this revision. erichkeane added a comment. A couple of nits, otherwise I don't have to see this again. Comment at: clang/include/clang/AST/TemplateName.h:158 + // When true the substitution will be finalized (subst node won't be placed). + bool getFinal()

[PATCH] D136528: [clang][Interp] Implement add and sub compound assign operators

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:412 + + constexpr int getTwo() { +int i = 1; I'd also like some test cases where the result of the operation is discarded. e.g., ``` constexpr int func() { int i = 12; i

[PATCH] D136528: [clang][Interp] Implement add and sub compound assign operators

tbaeder updated this revision to Diff 470138. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136528/new/ https://reviews.llvm.org/D136528 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/test/AST/I

[PATCH] D136528: [clang][Interp] Implement add and sub compound assign operators

tbaeder added inline comments. Comment at: clang/test/AST/Interp/literals.cpp:426 + } + static_assert(subAll(213) == 0); + aaron.ballman wrote: > We also need tests for failure situations: > ``` > constexpr int func() { > int i = __INT_MAX__; > i += 1; // o

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1237-1240 +if (DiscardResult) + return this->emitIncPop(*T, E); + +return this->emitInc(*T, E); Style question: should we prefer doing something like: `return D

[PATCH] D136528: [clang][Interp] Implement add and sub compound assign operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136528/new/ https://reviews.llvm.org/D136528 ___ cfe-commits mailing lis

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. I'm reasonably OK with this, I'm disappointed the 'skip for specialization' is what was required, but I don't think I know of a better way. I'll hold off approving this until I've confirmed that libcxx tests + libcxx-modules-tests are properly passing as a result of

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. ALSO; this is missing the cxx_status.html and release-notes, so please re-add those! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134128/new/ https://reviews.llvm.org/D134128 __

[PATCH] D135557: Add needsImplicitDefaultConstructor and friends

aaron.ballman added a comment. In D135557#3872324 , @dblaikie wrote: > In D135557#3871803 , @aaron.ballman > wrote: > >> In D135557#3871716 , @dblaikie >> wrote: >> >>>

[PATCH] D136602: NFC: [clang] Template argument cleanups.

mizvekov created this revision. Herald added subscribers: carlosgalvezp, kadircet, arphaman, martong. Herald added a reviewer: shafik. Herald added a project: All. mizvekov requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. R

[PATCH] D136570: [RISCV] Add Svnapot extension

reames added a comment. https://llvm.org/docs/RISCVUsage.html#extensions needs to updated after this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136570/new/ https://reviews.llvm.org/D136570 __

[PATCH] D136603: [analyzer] Model cast after LValueToRValueBitCasts

steakhal created this revision. steakhal added reviewers: ASDenysPetrov, martong, xazax.hun, NoQ, Szelethus. Herald added subscribers: manas, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware. Herald added a project: All. steakhal requested review of this revisio

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of `CXXMe

[PATCH] D136571: [RISCV] add svinval extension

reames added a comment. Please update https://llvm.org/docs/RISCVUsage.html#extensions It seems like we'd previously accept these instruction without the extension being explicitly named? If so, this is probably worth a release note to document the change in user behavior. Repository: rG L

[PATCH] D136554: [WIP] Implement CWG2631

cor3ntin updated this revision to Diff 470154. cor3ntin added a comment. Complete implementation for default member initializers, tests, cleaups, docs, etc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554

[PATCH] D136511: [RISCV][clang] Support RISC-V vectors in UninitializedValues.

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136511/new/ https://reviews.llvm.org/D136511 ___

[PATCH] D136293: [IncludeCleaner] Add public API

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:14 +#include "llvm/ADT/STLFunctionalExtras.h" +#include + kadircet wrote: > sammccall wrote: > > Th

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder updated this revision to Diff 470159. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136423/new/ https://reviews.llvm.org/D136423 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opco

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1237-1240 +if (DiscardResult) + return this->emitIncPop(*T, E); + +return this->emitInc(*T, E); aaron.ballman wrote: > Style question: should we prefer doing somethin

[clang-tools-extra] ce286ec - [IncludeCleaner] Add public API

Author: Kadir Cetinkaya Date: 2022-10-24T17:06:15+02:00 New Revision: ce286eccacd660f2b71cba15d9b83fe2217e36b8 URL: https://github.com/llvm/llvm-project/commit/ce286eccacd660f2b71cba15d9b83fe2217e36b8 DIFF: https://github.com/llvm/llvm-project/commit/ce286eccacd660f2b71cba15d9b83fe2217e36b8.dif

[PATCH] D136293: [IncludeCleaner] Add public API

This revision was automatically updated to reflect the committed changes. Closed by commit rGce286eccacd6: [IncludeCleaner] Add public API (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136293/new/ https://reviews.llvm.org/D13

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

tbaeder updated this revision to Diff 470163. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136423/new/ https://reviews.llvm.org/D136423 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/Opcodes.td clang/test/AST/Interp/arrays.cpp

[PATCH] D136532: [clang][Interp] Implement left and right shifts

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1236-1237 inline bool ShiftRight(InterpState &S, CodePtr OpPC, const T &V, unsigned RHS) { if (RHS >= V.bitWidth()) { S.Stk.push(T::from(0, V.bitWidth())); } else { This d

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from nits. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1275-1277 +if (DiscardResult) + return this->emitPop(*T, E); return thi

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 marked 4 inline comments as done. usaxena95 added a comment. I have switched to a version where we matched template heads only when they are constraints. This is for the moment to unblock the existing bugs and not break existing code prior to C++20. Let us continue the discussion over

[PATCH] D136440: [clang] Do not hide base member using-decls with different template head.

usaxena95 updated this revision to Diff 470174. usaxena95 marked 2 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136440/new/ https://reviews.llvm.org/D136440 Files: clang/in

[clang] d0d2772 - [Clang] Implement P2513

Author: Corentin Jabot Date: 2022-10-24T18:10:43+02:00 New Revision: d0d2772379bd89f1dce3c456520272678cf4b966 URL: https://github.com/llvm/llvm-project/commit/d0d2772379bd89f1dce3c456520272678cf4b966 DIFF: https://github.com/llvm/llvm-project/commit/d0d2772379bd89f1dce3c456520272678cf4b966.diff

[PATCH] D136449: [Clang] Implement P2513

This revision was automatically updated to reflect the committed changes. Closed by commit rGd0d2772379bd: [Clang] Implement P2513 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D136449?vs=469715&id=470179#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D136449: [Clang] Implement P2513

cor3ntin added a comment. Thanks Aaron! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136449/new/ https://reviews.llvm.org/D136449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D136615: [Instrumentation] Remove legacy passes

aeubanks created this revision. aeubanks added a reviewer: asbirlea. Herald added a reviewer: deadalnix. Herald added subscribers: Enna1, hiraditya. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald

[PATCH] D136080: [flang] Add -ffp-contract option processing

tblah updated this revision to Diff 470184. tblah marked 2 inline comments as not done. tblah edited the summary of this revision. tblah added a comment. Updated diff with a further reduced help text after discussions with @awarzynski CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

aaron.ballman added a comment. Thank you for the patch! We don't typically add new diagnostics that are ignored by default because we have significant evidence that users don't enable them enough to warrant adding them. In this case, I don't think we should enable this by default because it's

[PATCH] D136156: [Clang][Diagnostic] Add hidden-reinterpret-cast diagnostic warning

lebedev.ri added a comment. Looks like this and more is already being caught by clang-tidy's google-readability-casting check . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136156/new/ https://reviews.llvm.org/D136156 _

[PATCH] D132941: [DO NOT SUBMIT] [Sema] Delay evaluation of std::source_location::current() in default arguments

cor3ntin added a comment. The PR for the more general approach (note that it does not solve source location, that will need more additional work) https://reviews.llvm.org/D136554 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132941/new/ https://re

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

zixuw added a comment. Is it easy to/worth checking if the target is actually outside of the current module to keep the output smaller and concise? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136455/new/ https://reviews.llvm.org/D136455 ___

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

nickdesaulniers added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) Seems error prone. Does cmake have an include syste

[PATCH] D136423: [clang][Interp] Implement inc/dec postfix and prefix operators

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1258 + } + case UO_PreDec: { // --x +if (!this->visit(SubExpr)) You could combine this with `UO_PreInc` and just use a `bool` flag to determin

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) nickdesaulniers wrote: > Seems error prone. Does cmake have

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

mcgrathr added a comment. In D85802#3876106 , @dblaikie wrote: >> The C++ ABI is not part of the Fuchsia system ABI, nor what we call the >> "Fuchsia compiler ABI". Different users of C++ are free to use whatever C++ >> ABI they like. Only the backend AB

[PATCH] D136012: [clang][Interp] Fix record members of reference type

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:867 - if (Optional T = classify(Init->getType())) { + if (Optional T = classify(Init)) { if (!t

[PATCH] D134687: [clang] Ensure correct metadata for relative vtables

leonardchan added a comment. *ping* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134687/new/ https://reviews.llvm.org/D134687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D136604: Add clang_CXXMethod_isCopyAssignmentOperator to libclang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Would you like to obtain commit access to land this one on your own (https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)? If not, that's fine, I can also l

[clang] 5293016 - Revert "GH58368: Correct concept checking in a lambda defined in concept"

Author: Erich Keane Date: 2022-10-24T10:21:22-07:00 New Revision: 52930162870fee52d0d9c07c5d66e5dce32b08e8 URL: https://github.com/llvm/llvm-project/commit/52930162870fee52d0d9c07c5d66e5dce32b08e8 DIFF: https://github.com/llvm/llvm-project/commit/52930162870fee52d0d9c07c5d66e5dce32b08e8.diff L

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. In D85802#3879888 , @mcgrathr wrote: > In D85802#3876106 , @dblaikie wrote: > >>> The C++ ABI is not part of the Fuchsia system ABI, nor what we call the >>> "Fuchsia compiler ABI". Differ

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 created this revision. jansvoboda11 added reviewers: dexonsmith, Bigcheese, vsapsai, ilyakuteev. Herald added subscribers: ributzka, mgrang. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commit

[PATCH] D136602: NFC: [clang] Template argument cleanups.

erichkeane added a comment. I like this cleanup in general, just 2 questions. Comment at: clang/include/clang/AST/TemplateBase.h:592 + llvm::ArrayRef arguments() const { return Arguments; } + llvm::MutableArrayRef arguments() { return Arguments; } Ooh, real

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

dang added a comment. In D136455#3879849 , @zixuw wrote: > Is it easy to/worth checking if the target is actually outside of the current > module to keep the output smaller and concise? I think it can be done, since we ignore symbols that don't come fro

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

mcgrathr added a comment. In D85802#3879950 , @dblaikie wrote: > In D85802#3879888 , @mcgrathr wrote: > >> In D85802#3876106 , @dblaikie wrote: >> The C++ ABI is not par

[PATCH] D136548: [clang][CodeGen] Consistently return nullptr Values for void builtins and scalar initalization

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136548/new/ https://reviews.llvm.org/D136548 ___ cfe-commits mailing list cfe-commi

[PATCH] D85802: [clang] Add -fc++-abi= flag for specifying which C++ ABI to use

dblaikie added a comment. In D85802#3880078 , @mcgrathr wrote: > In D85802#3879950 , @dblaikie wrote: > >> In D85802#3879888 , @mcgrathr wrote: >> >>> In D85802#3876106

[PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

mgorny updated this revision to Diff 470225. mgorny edited the summary of this revision. mgorny added a comment. Herald added a project: LLVM. Use a shared policy file via `include()` instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136572/new/ https://reviews.llvm.org/D136572 Fi

[PATCH] D134902: [clang] Implement -fstrict-flex-arrays=3

void added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:60 /// static_asserts in Triple.cpp and in clang/Basic/HLSLRuntime.h. enum class ShaderStage { Pixel = 0, serge-sans-paille wrote: > Looks unrelated to this patch :-) I don't se

[PATCH] D134128: Resubmit an implemention for constrained template template parameters [P0857R0 Part B]

erichkeane added a comment. In D134128#3879295 , @erichkeane wrote: > I'm reasonably OK with this, I'm disappointed the 'skip for specialization' > is what was required, but I don't think I know of a better way. I'll hold > off approving this until I'

[clang] 7e8af2f - [ARM] Support -mexecute-only with -mlong-calls.

Author: Zhiyao Ma Date: 2022-10-24T11:41:24-07:00 New Revision: 7e8af2fc0c068de8bb47d8046b8483234fab3b13 URL: https://github.com/llvm/llvm-project/commit/7e8af2fc0c068de8bb47d8046b8483234fab3b13 DIFF: https://github.com/llvm/llvm-project/commit/7e8af2fc0c068de8bb47d8046b8483234fab3b13.diff LOG

  1   2   3   >