[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

penzn added a comment. I still need to run a few external tests, like the ones mentioned in https://github.com/emscripten-core/emscripten/issues/9340 https://github.com/WebAssembly/simd/issues/196 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140773: [WebAssembly] Use `shufflevector` for shuffle

penzn created this revision. penzn added a reviewer: tlively. Herald added subscribers: pmatos, asb, ecnelises, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added a project: All. penzn requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5457 + // RISC-V will handle -mcpu option in Clang::AddRISCVTargetArgs. + if (!Triple.isRISCV()) { +// Add the target cpu craig.topper wrote: > I wonder if we should stop

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

kito-cheng added a comment. > So if I read this correctly, the effect of this is that we never pass > -target-cpu to the backend after this patch and will only pass > -target-feature and -tune-cpu? Yes, that's prevent us taking any extensions from `-target-cpu`, so always pass

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. Go ahead, thanks for clean up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662

[PATCH] D140527: [LoongArch] Add intrinsics for CACOP instruction

XiaodongLoong added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140527/new/ https://reviews.llvm.org/D140527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeda2eaabf294: [clang][dataflow] Fix crash when having boolean-to-integral casts. (authored by junaire). Changed prior to commit:

[clang] eda2eaa - [clang][dataflow] Fix crash when having boolean-to-integral casts.

Author: Jun Zhang Date: 2022-12-30T13:14:44+08:00 New Revision: eda2eaabf2949c08ba94c92b9aad6fccb3c8eaa2 URL: https://github.com/llvm/llvm-project/commit/eda2eaabf2949c08ba94c92b9aad6fccb3c8eaa2 DIFF: https://github.com/llvm/llvm-project/commit/eda2eaabf2949c08ba94c92b9aad6fccb3c8eaa2.diff

[PATCH] D136554: Implement CWG2631

rupprecht added a comment. I threw this at the "test everything" test (some millions of targets) and it found only one breakage, so this is very very close. Without further ado, here is this silly looking thing: File `blah.h`: #include #include template struct Base { virtual

[PATCH] D140772: Fix minor bug in add_new_check.py

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. While rebuilding the list of

[PATCH] D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:97-106 +// FIXME: This is sort of workaround. Since now we just ignore all (implicit) +

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 485665. ccotter added a comment. - Remove unused variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan requested review of this revision. owenpan added inline comments. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new (Allocator.Allocate()) Token; + Lex->LexFromRawLexer(*Tok);

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485658. owenpan added a comment. It turns out that the memory bug had nothing to do with whether to use the stack or heap memory for the `Token` object. The culprit was passing `getFormattingLangOpts(Style)` directly to the `Lexer` constructor. I suppose

[PATCH] D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts.

junaire updated this revision to Diff 485657. junaire added a comment. Fix typos Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140753/new/ https://reviews.llvm.org/D140753 Files: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 485656. ccotter added a comment. oops, redo diff with correct arc diff command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 485655. ccotter added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files:

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire updated this revision to Diff 485654. junaire added a comment. Update patch according to @ymandel 's suggestion. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140753/new/ https://reviews.llvm.org/D140753 Files:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added a comment. In D140696#4019810 , @gribozavr2 wrote: >> With this change, unions are modeled exactly as structs (as far as I can >> tell), which is unsound. > > Modeling just the storage of the union (but not the value) is sound. The >

[PATCH] D138870: clang/AMDGPU: Remove flat-address-space from feature map

arsenm updated this revision to Diff 485650. arsenm added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138870/new/ https://reviews.llvm.org/D138870 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/test/CodeGenOpenCL/amdgpu-features.cl

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm closed this revision. arsenm added a comment. e630d9b299822810bba8f3d0457004d1b4c39bef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138868/new/ https://reviews.llvm.org/D138868

[clang] e630d9b - AMDGPU/clang: Remove target features from address space test builtins

Author: Matt Arsenault Date: 2022-12-29T18:46:41-05:00 New Revision: e630d9b299822810bba8f3d0457004d1b4c39bef URL: https://github.com/llvm/llvm-project/commit/e630d9b299822810bba8f3d0457004d1b4c39bef DIFF:

[libclc] 4ddba3a - libclc: Add parentheses to silence warning

Author: Matt Arsenault Date: 2022-12-29T18:19:55-05:00 New Revision: 4ddba3a7061fef81faed2f0fbaba25f4b78f6014 URL: https://github.com/llvm/llvm-project/commit/4ddba3a7061fef81faed2f0fbaba25f4b78f6014 DIFF:

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:766 Res |= SanitizerKind::SafeStack; - if (IsX86_64 || IsMIPS64 || IsAArch64) + if (IsX86_64) Res |= SanitizerKind::DataFlow; This change is still useful and worth

[PATCH] D82087: AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

arsenm closed this revision. arsenm added a comment. f4bcd7f598331457cfe74e459b489d4098369511 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82087/new/ https://reviews.llvm.org/D82087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] f4bcd7f - AMDGPU/clang: Add builtins for llvm.amdgcn.ballot

Author: Matt Arsenault Date: 2022-12-29T17:58:55-05:00 New Revision: f4bcd7f598331457cfe74e459b489d4098369511 URL: https://github.com/llvm/llvm-project/commit/f4bcd7f598331457cfe74e459b489d4098369511 DIFF:

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

gribozavr2 added a comment. > With this change, unions are modeled exactly as structs (as far as I can > tell), which is unsound. Modeling just the storage of the union (but not the value) is sound. The first revision of the patch was a targeted fix that allowed us to continue maintaining the

[PATCH] D140743: [DFSan] Fix overuse of REQUIRES: in tests.

browneee abandoned this revision. browneee added a comment. Abandon due to D140744 being submitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140743/new/ https://reviews.llvm.org/D140743

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 485643. ccotter added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D140767: [clang-format] Require space before noexcept qualifier

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This brings the noexcept qualifier more visually in line

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + Joe_Nash

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added a comment. In D140760#4019708 , @ccotter wrote: > In D140760#4019680 , > @Eugene.Zelenko wrote: > >> I just look into check documentation, new feature should be described with >> example

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. In D140760#4019680 , @Eugene.Zelenko wrote: > I just look into check documentation, new feature should be described with > example there too. Would you mind clarifying where I should add documentation to? In the release

[clang] eb20499 - [clang] Use try_emplace instead of insert when getting new identifier

Author: serge-sans-paille Date: 2022-12-29T21:40:21+01:00 New Revision: eb20499dab29e2180dd0ff106edb3233ab243323 URL: https://github.com/llvm/llvm-project/commit/eb20499dab29e2180dd0ff106edb3233ab243323 DIFF:

[PATCH] D140307: [clang-tidy] Match derived types in in modernize-loop-convert

ccotter updated this revision to Diff 485637. ccotter added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140307/new/ https://reviews.llvm.org/D140307 Files:

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

Joe_Nash accepted this revision. Joe_Nash added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +//

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added a comment. I just look into check documentation, new feature should be described with example there too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

arsenm added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + Joe_Nash

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 485634. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp clang-tools-extra/docs/ReleaseNotes.rst

[PATCH] D138868: AMDGPU/clang: Remove target features from address space test builtins

Joe_Nash added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-amdgcn-flat-address-space.cl:8 +// be initialized to something useful. The proper way to diagnose invalid flat +// usage is to forbid flat pointers on unsupported targets. + What part

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

ymandel added a comment. In D140696#4019589 , @merrymeerkat wrote: >> another thought: please verify that `createStorageLoction` and `createValue` >> can correctly handle union types. Otherwise, you'll likely end up with other >> (surprising) crashes

[PATCH] D104931: [AArch64] Wire up ILP32 ABI support in Clang

Amanieu added a comment. The situation around -mabi for AArch64 is a bit awkward: Clang uses it to select the ARM64 calling convention (`-mabi=aapcs` vs `-mabi=darwinpcs`) while GCC uses it to select between LP64 and ILP32. I'm not sure how we should be handling this. Repository: rG LLVM

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat added a comment. > another thought: please verify that `createStorageLoction` and `createValue` > can correctly handle union types. Otherwise, you'll likely end up with other > (surprising) crashes in the system. E.g. >

[PATCH] D140696: [clang][dataflow] Treat unions as structs.

merrymeerkat updated this revision to Diff 485626. merrymeerkat added a comment. Resolving review comment. Add createValue functionality for unions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140696/new/ https://reviews.llvm.org/D140696 Files:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

Eugene.Zelenko added a comment. It'll be good idea to mention change in Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:81-82 + + llvm::SpecificBumpPtrAllocator Allocator; + auto Tok = new

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter created this revision. ccotter added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a subscriber: cfe-commits. The

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad updated this revision to Diff 485607. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140757/new/ https://reviews.llvm.org/D140757 Files: clang/lib/Basic/Targets/Hexagon.cpp clang/lib/Basic/Targets/VE.cpp

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485606. eopXD added a comment. Update comment section: remove mis-indented indents. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/ https://reviews.llvm.org/D140662 Files:

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 485605. cor3ntin added a comment. Another fun one. I really apreciate your help on this. The constructor of `Wrapper` causes the constructor of `Option` to be defined, but not yet used (as default parameters are not odr used) - so none of the default

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485604. eopXD marked 2 inline comments as done. eopXD edited the summary of this revision. eopXD added a comment. Update comment section for segment load. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140662/new/

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan requested review of this revision. owenpan added a comment. In D140543#4016184 , @thakis wrote: > In D140543#4016181 , @owenpan wrote: > >> In D140543#4016156 ,

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485600. owenpan added a comment. Fix a memory bug, which doesn't surface in Debug build. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D140757: [Hexagon][VE][WebAssembly] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

brad created this revision. brad added reviewers: kparzysz, kaz7, simoll, aheejin, luke. brad added a project: clang. Herald added subscribers: pmatos, asb, ecnelises, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: All. brad requested review of this revision. Define

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire added a comment. In D140753#4019322 , @gribozavr2 wrote: > Thank you for your contribution! > > While adding a conditional check fixes the crash, the problem's root cause > must be deeper. Mismatched types indicate that one code path in

[PATCH] D140756: Add clang_CXXMethod_isExplicit to libclang

diseraluca created this revision. diseraluca added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. diseraluca requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The new method is a wrapper of

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

khchen added a comment. LGTM. Thanks for clean up code! Comment at: clang/include/clang/Basic/riscv_vector.td:820 +(Address0, ..., Address{NF - 1}, mask, Ptr, VL) +(Address0, ..., Address{NF - 1}, mask, Maskedoff0, ..., Maskedoff{NF - 1}, + Ptr, VL) nit:

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

gribozavr2 requested changes to this revision. gribozavr2 added a comment. This revision now requires changes to proceed. Thank you for your contribution! While adding a conditional check fixes the crash, the problem's root cause must be deeper. Mismatched types indicate that one code path in

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2784b243e38f: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP

[clang] 2784b24 - [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

Author: Brad Smith Date: 2022-12-29T05:07:35-05:00 New Revision: 2784b243e38f7d526a40838a854554b53ebeb41e URL: https://github.com/llvm/llvm-project/commit/2784b243e38f7d526a40838a854554b53ebeb41e DIFF: https://github.com/llvm/llvm-project/commit/2784b243e38f7d526a40838a854554b53ebeb41e.diff

[PATCH] D140685: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

XiaodongLoong added a comment. @xen0n Thanks for your suggestion. Comment at: llvm/lib/Target/LoongArch/LoongArchInstrInfo.td:53 +SDTCisVT<1, GRLenVT>]>; +def SDT_LoongArchFCSR2GR : SDTypeProfile<1, 1, [SDTCisVT<0, GRLenVT>, +SDTCisVT<1, i32>]>; xen0n

[PATCH] D140685: [LoongArch] Add intrinsics for MOVFCSR2GR and MOVGR2FCSR instructions

XiaodongLoong updated this revision to Diff 485593. XiaodongLoong marked an inline comment as done. XiaodongLoong added a comment. rebase code and change code for @xen0n's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140685/new/

[PATCH] D140753: [clang][dataflow] Check both operand's type in mergeDistinctValues

junaire created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Previously we assume RHS is a BoolValue if LHS

[PATCH] D140662: [NFC][Clang][RISCV] Reduce boilerplate when determining prototype for segment loads

eopXD updated this revision to Diff 485589. eopXD added a comment. Update code based on landing of D140678 . The motivation of this NFC patch comes from the struggle while I was tracing through them. I think the scattered comments of boilerplates with only

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

0x59616e accepted this revision. 0x59616e added a comment. The CI seems OK. My first LGTM is given to you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140695/new/ https://reviews.llvm.org/D140695 ___

[PATCH] D140433: [Clang] Add `nvptx-arch` tool to query installed NVIDIA GPUs

Hahnfeld added inline comments. Comment at: clang/tools/nvptx-arch/CMakeLists.txt:28 + +clang_target_link_libraries(nvptx-arch PRIVATE ${cuda-library}) This broke my build with `CLANG_LINK_CLANG_DYLIB`; we must use the standard CMake `target_link_libraries` for

[clang] f3c9342 - Fix build of nvptx-arch with CLANG_LINK_CLANG_DYLIB

Author: Jonas Hahnfeld Date: 2022-12-29T09:48:05+01:00 New Revision: f3c9342a3d56e1782e3b6db081401af334648492 URL: https://github.com/llvm/llvm-project/commit/f3c9342a3d56e1782e3b6db081401af334648492 DIFF:

[PATCH] D140695: [M68k] Define __GCC_HAVE_SYNC_COMPARE_AND_SWAP macros

glaubitz added a comment. In D140695#4019189 , @brad wrote: > How come the Clang M68k backend defaults to 68000? GCC defaults to 68020 for > all targets. The Clang M68k is a complete rewrite from scratch, independent of GCC, so it's not surprising you

[PATCH] D136554: Implement CWG2631

MaskRay added a comment. In D136554#4019135 , @rupprecht wrote: > [...] > The undefined symbols before are all provided by libc++, so those are fine. > After, the new undefined symbol for the lambda cannot be resolved. Depending > on how the linker is