[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel added a comment. I suppose this means `auto a = (b) -> c;` is also technically broken, actually, and there's no easy fix for that. I did have an idea for adding an additional pass taking place somewhere in `TokenAnnotator::calculateFormattingInformation`, which would detect trailing

[PATCH] D141908: [C++20][Modules] Handle defaulted and deleted functions in header units.

iains updated this revision to Diff 490383. iains added a comment. rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141908/new/ https://reviews.llvm.org/D141908 Files: clang/lib/Sema/SemaDecl.cpp

[PATCH] D141811: [clang-format] Allow trailing return types in macros

rymiel planned changes to this revision. rymiel added a comment. In D141811#4055485 , @HazardyKnusperkeks wrote: > What about `decltype(auto)`? Turns out this is a problem even without this patch: `decltype(auto) a = (b) -> c;` I'm sure this could

[PATCH] D142046: [BPF][clang] Ignore stack protector options for BPF target

yonghong-song added a comment. @compnerd could you also take a look at this patch? First, some background about this patch. The reason of this patch is due to: https://lore.kernel.org/bpf/CAOFdcFPnHEc2qd-=c+hdk4ntjjfbhsf4r-g7pdjtrbat6mu...@mail.gmail.com/ Further the following link has

[PATCH] D142075: [Clang][OpenMP] Allow `f16` literal suffix when compiling OpenMP target offloading for NVPTX

tianshilei1992 updated this revision to Diff 490375. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142075/new/ https://reviews.llvm.org/D142075 Files: clang/lib/Lex/LiteralSupport.cpp

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added subscribers: JDevlieghere, aprantl. dblaikie added a comment. In D141451#4063582 , @nickdesaulniers wrote: > In D141451#4063519 , @dblaikie > wrote: > >> In D141451#4063504

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

glandium added a comment. This broke our mac builds with errors like: ld64.lld: error: undefined symbol: CFRunLoopRun >>> referenced by tools/clang/tools/clang-stat-cache/CMakeFiles/clang-stat-cache.dir/clang-stat-cache.cpp.o:(symbol main+0x11be) (and many more symbols) Repository: rG

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai marked an inline comment as done. vsapsai added a comment. In D71734#4061228 , @ChuanqiXu wrote: > LGTM generally. It'd better to mention this in the `Potentially Breaking > Changes` section of ReleaseNotes. Thanks for all your efforts during

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. kazu marked 2 inline comments as done. Closed by commit rG83d56fb17a4d: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC) (authored by kazu).

[PATCH] D142077: [Clang][SemaCXX][Coroutines] Fix misleading diagnostics with -Wunsequenced

bruno created this revision. bruno added reviewers: ChuanqiXu, nridge, sammccall. Herald added subscribers: hoy, modimo, wenlei. Herald added a project: All. bruno requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D115187

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:225 /// /// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are /// valid arguments. jrtc27 wrote: > A bunch of

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu updated this revision to Diff 490363. kazu added a comment. I've adjusted comments for findFirstSet and findLastSet to reflect the fact that ZeroBehavior now takes only two values -- ZB_Undefined and ZB_Max. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142075: [Clang][OpenMP] Allow `f16` literal suffix when compiling OpenMP target offloading for NVPTX

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. Seems reasonable, maybe update the comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142075/new/ https://reviews.llvm.org/D142075

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

craig.topper added a comment. In D141798#4064142 , @MaskRay wrote: > `ZB_Max` is the strange mode that should be dropped, perhaps also > `ZB_Undefined`. > > In D141798#4064114 , @arsenm wrote: > >>> If you care

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

[PATCH] D142075: [Clang][OpenMP] Allow `f16` literal suffix when compiling OpenMP target offloading for NVPTX

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, jhuber6, yaxunl, rjmccall, tra. Herald added subscribers: mattd, gchakrabarti, asavonic, guansong. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits,

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

MaskRay added a comment. `ZB_Max` is the strange mode that should be dropped, perhaps also `ZB_Undefined`. In D141798#4064114 , @arsenm wrote: >> If you care about compilation speed, you should build LLVM with an >> appropriate -march= to take

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

calebzulawski added a comment. Are those failures on Linux? I only developed this change on macOS, but the automated tests passed... Admittedly I'm not sure what should happen when building for macOS from Linux (is there any use case where that works and does anything useful? I'm not sure).

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

jrtc27 added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:225 /// /// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are /// valid arguments. A bunch of functions still have this documentation, but these are now

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu added a comment. It passes on the previous windows CI. It looks like the assertion for `sizeof(...)` is indeed not a good idea. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

arsenm added a comment. > If you care about compilation speed, you should build LLVM with an appropriate -march= to take advantage of lzcnt and tzcnt. I think this is bad reasoning, nobody really uses -march Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f252333 - [-Wunsafe-buffer-usage][NFC] Fix Fixables filtering

Author: Jan Korous Date: 2023-01-18T18:54:48-08:00 New Revision: f252333b978c6b5a04d1cea3d92de16490969ff5 URL: https://github.com/llvm/llvm-project/commit/f252333b978c6b5a04d1cea3d92de16490969ff5 DIFF: https://github.com/llvm/llvm-project/commit/f252333b978c6b5a04d1cea3d92de16490969ff5.diff

[PATCH] D136315: [clang][Darwin] Try to guess the SDK root with xcrun when unspecified

thakis added a comment. This breaks oodles of tests for me: http://45.33.8.238/macm1/52994/step_7.txt Is anyone else seeing this? Also, independently of that, shouldn't this check that the _host_ os is macOS as well? Doesn't the current code try to run `xcrun` if I do `clang

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/include/llvm/Support/MathExtras.h:212 /// Only unsigned integral types are allowed. -/// -/// \param ZB the behavior on an input of 0.

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added a comment. Thanks for the fast revert! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added a comment. Also fails on 64-bit windows fwiw: http://45.33.8.238/win/73344/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141992/new/ https://reviews.llvm.org/D141992 ___

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

ChuanqiXu added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) { + static_assert(sizeof(OMPDeclareMapperDecl) == 120, +"You need to update the serializer after

[clang] 38a2f08 - Revert "[NFC] [Serialization] Add static assert for the size of the decls to"

Author: Chuanqi Xu Date: 2023-01-19T10:37:48+08:00 New Revision: 38a2f089b48103922e3ff6c363032704ce52c08e URL: https://github.com/llvm/llvm-project/commit/38a2f089b48103922e3ff6c363032704ce52c08e DIFF: https://github.com/llvm/llvm-project/commit/38a2f089b48103922e3ff6c363032704ce52c08e.diff

[PATCH] D71734: [ODRHash] Hash `RecordDecl` and diagnose discovered mismatches.

vsapsai updated this revision to Diff 490354. vsapsai added a comment. `setODRHash(0)` for consistency, mention the change in Potentially Breaking Changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71734/new/ https://reviews.llvm.org/D71734

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

thakis added inline comments. Comment at: clang/lib/Serialization/ASTWriterDecl.cpp:2313 void ASTDeclWriter::VisitOMPDeclareMapperDecl(OMPDeclareMapperDecl *D) { + static_assert(sizeof(OMPDeclareMapperDecl) == 120, +"You need to update the serializer after you

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added a comment. Please take a look. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/ https://reviews.llvm.org/D141798 ___ cfe-commits

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu marked an inline comment as done. kazu added a comment. In D141798#4055050 , @barannikov88 wrote: > It would be nice to have comments reflecting the new behavior in the case of > 0 / max value. I've added comments to all four functions --

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

kazu updated this revision to Diff 490348. kazu added a comment. Updated the patch to leave findFirstSet and findLastSet untouched. Added a comment about the behavior on 0/max input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141798/new/

[PATCH] D141992: [NFC] [Serialization] Add static assert for the size of the decls to mention developers to remember to touch the serializer after them modified the field of decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc79635cce845: [NFC] [Serialization] Add static assert for the size of the decls to (authored by ChuanqiXu). Herald added a project: clang. Herald

[clang] c79635c - [NFC] [Serialization] Add static assert for the size of the decls to

Author: Chuanqi Xu Date: 2023-01-19T10:20:29+08:00 New Revision: c79635cce845d66897970cd7f8d7c77b0a3c0286 URL: https://github.com/llvm/llvm-project/commit/c79635cce845d66897970cd7f8d7c77b0a3c0286 DIFF: https://github.com/llvm/llvm-project/commit/c79635cce845d66897970cd7f8d7c77b0a3c0286.diff

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG557a5bc336ff: [codegen] Add StackFrameLayoutAnalysisPass (authored by paulkirth). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 557a5bc - [codegen] Add StackFrameLayoutAnalysisPass

Author: Paul Kirth Date: 2023-01-19T01:51:14Z New Revision: 557a5bc336ffb9b03c53d4d13fd8f0bc9418ec96 URL: https://github.com/llvm/llvm-project/commit/557a5bc336ffb9b03c53d4d13fd8f0bc9418ec96 DIFF: https://github.com/llvm/llvm-project/commit/557a5bc336ffb9b03c53d4d13fd8f0bc9418ec96.diff LOG:

[PATCH] D140179: [WIP][-Wunsafe-buffer-usage] Add unsafe buffer checking opt-out pragmas

NoQ added inline comments. Comment at: clang/include/clang/Basic/Diagnostic.h:1040-1043 + // An ordered sequence of "-Wunsafe-buffer-usage" opt-out regions in one + // translation unit. Each region is represented by a pair of start and end + // locations. + SmallVector, 8>

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

paulwalker-arm added reviewers: david-arm, CarolineConcatto, peterwaller-arm. paulwalker-arm added a comment. This is bug fix based on something spotted when reviewing D141469 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142065: [SVE] Fix incorrect lowering of predicate permute builtins.

paulwalker-arm created this revision. Herald added subscribers: psnobl, hiraditya, tschuett. Herald added a reviewer: efriedma. Herald added a project: All. paulwalker-arm requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

barannikov88 added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 scott.linder wrote: > barannikov88 wrote: > > arsenm wrote: > > > scott.linder

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:22399-22412 bool Sema::isOpenMPDeclareMapperVarDeclAllowed(const VarDecl *VD) const { assert(LangOpts.OpenMP && "Expected OpenMP mode."); const Expr *Ref = DSAStack->getDeclareMapperVarRef(); if

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jhuber6 marked 3 inline comments as done. Closed by commit rG0660397e6809: [CUDA] Allow targeting NVPTX directly without a host toolchain (authored by jhuber6).

[clang] 0660397 - [CUDA] Allow targeting NVPTX directly without a host toolchain

Author: Joseph Huber Date: 2023-01-18T18:18:25-06:00 New Revision: 0660397e68096a64279b19f913e7de2c283e524f URL: https://github.com/llvm/llvm-project/commit/0660397e68096a64279b19f913e7de2c283e524f DIFF: https://github.com/llvm/llvm-project/commit/0660397e68096a64279b19f913e7de2c283e524f.diff

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > doru1004 wrote:

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063818 , @friss wrote: > In D136651#4063632 , @lebedev.ri > wrote: > >> In D136651#4063597 , @friss wrote: >> >>> In

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a comment. In D136651#4063632 , @lebedev.ri wrote: > In D136651#4063597 , @friss wrote: > >> In D136651#4060071 , @lebedev.ri >> wrote: >> >>> Docs still

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

void added inline comments. Comment at: clang/docs/ReleaseNotes.rst:199 + guaranteed (and necessary to support outputs along indirect edges, which is + now supported as of this release). + Is it worth it to mention that this change makes Clang's behavior with

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder added inline comments. Comment at: llvm/include/llvm/Support/CodeGen.h:57 + /// Code generation optimization level. + enum Level : IDType { +None = 0, ///< -O0 barannikov88 wrote: > arsenm wrote: > > scott.linder wrote: > > > This is ABI

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

void accepted this revision. void added a comment. Still LGTM :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 ___ cfe-commits mailing list

[PATCH] D135488: [codegen] Add StackFrameLayoutAnalysisPass

paulkirth updated this revision to Diff 490323. paulkirth added a comment. Herald added a subscriber: luke. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/docs/ReleaseNotes.rst

[PATCH] D141968: [NFC] Consolidate llvm::CodeGenOpt::Level handling

scott.linder updated this revision to Diff 490321. scott.linder marked 2 inline comments as done. scott.linder added a comment. - Fix return type of `getID` - Fix mistakenly updated option help text - Add back in missing `assert`s Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 marked 3 inline comments as done. jhuber6 added a comment. In D140158#4063720 , @tra wrote: > LGTM with few minor nits and questions. > > In D140158#4063689 , @jhuber6 wrote: > >> Addressing some

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM with few minor nits and questions. In D140158#4063689 , @jhuber6 wrote: > Addressing some comments. I don't know if there's a cleaner way to mess >

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 updated this revision to Diff 490317. jhuber6 added a comment. Addressing some comments. I don't know if there's a cleaner way to mess around with the `.cubin` nonsense. I liked symbolic links but that doesn't work on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); ABataev wrote: > doru1004 wrote: >

[clang] debfa43 - [Clang][NFC] Clang-format CUDA toolchain file

Author: Joseph Huber Date: 2023-01-18T17:15:03-06:00 New Revision: debfa43117f458cd75e3d0a7b37f7622c7c67d40 URL: https://github.com/llvm/llvm-project/commit/debfa43117f458cd75e3d0a7b37f7622c7c67d40 DIFF: https://github.com/llvm/llvm-project/commit/debfa43117f458cd75e3d0a7b37f7622c7c67d40.diff

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[PATCH] D141744: [Clang] Add lifetimebound attribute to std::move/std::forward

alexander-shaposhnikov updated this revision to Diff 490313. alexander-shaposhnikov added a comment. @aaron.ballman - thanks for the review, I've updated the release notes. Regarding LanguageExtensions.rst - somehow I don't see any appropriate sections in LanguageExtensions.rst (either about

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[PATCH] D141356: [-Wunsafe-buffer-usage] Group diagnostics by variable

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG237ca436adf4: [-Wunsafe-buffer-usage] Group diagnostics by variable (authored by jkorous). Herald added a project: clang. Herald added a subscriber:

[clang] 237ca43 - [-Wunsafe-buffer-usage] Group diagnostics by variable

Author: Jan Korous Date: 2023-01-18T15:00:22-08:00 New Revision: 237ca436adf48c72821afd9fa6e031ec1d4a0420 URL: https://github.com/llvm/llvm-project/commit/237ca436adf48c72821afd9fa6e031ec1d4a0420 DIFF: https://github.com/llvm/llvm-project/commit/237ca436adf48c72821afd9fa6e031ec1d4a0420.diff

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > arphaman wrote: > > >

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

lebedev.ri added a comment. In D136651#4063597 , @friss wrote: > In D136651#4060071 , @lebedev.ri > wrote: > >> Docs still missing. > > Sorry @lebedev.ri I missed your earlier comment about this. What format of

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); ABataev wrote: > doru1004 wrote: >

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss added a subscriber: lebedev.ri. friss added a comment. In D136651#4060071 , @lebedev.ri wrote: > Docs still missing. Sorry @lebedev.ri I missed your earlier comment about this. What format of doc would you like to see? A more elaborate comment

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4063519 , @dblaikie wrote: > In D141451#4063504 , > @nickdesaulniers wrote: > >> In D141451#4063335 , @dblaikie >> wrote: >>

Re: [clang] a033dbb - [Clang] Give Clang the ability to use a shared stat cache

Looks like my comments on the review got completely ignored and not even acknowledged. On Thu, Jan 19, 2023 at 1:35 AM Fred Riss via cfe-commits wrote: > > > Author: Fred Riss > Date: 2023-01-18T14:31:27-08:00 > New Revision: a033dbbe5c43247b60869b008e67ed86ed230eaa > > URL: >

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa033dbbe5c43: [Clang] Give Clang the ability to use a shared stat cache (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] a033dbb - [Clang] Give Clang the ability to use a shared stat cache

Author: Fred Riss Date: 2023-01-18T14:31:27-08:00 New Revision: a033dbbe5c43247b60869b008e67ed86ed230eaa URL: https://github.com/llvm/llvm-project/commit/a033dbbe5c43247b60869b008e67ed86ed230eaa DIFF: https://github.com/llvm/llvm-project/commit/a033dbbe5c43247b60869b008e67ed86ed230eaa.diff

[PATCH] D141340: [-Wunsafe-buffer-usage] Use relevant source locations for warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39a63fc7fe98: [-Wunsafe-buffer-usage] Use relevant source locations for warnings (authored by jkorous). Herald added a project: clang. Herald added

[clang] 39a63fc - [-Wunsafe-buffer-usage] Use relevant source locations for warnings

Author: Jan Korous Date: 2023-01-18T14:18:54-08:00 New Revision: 39a63fc7fe9824313764a9da8565a705d3024b1a URL: https://github.com/llvm/llvm-project/commit/39a63fc7fe9824313764a9da8565a705d3024b1a DIFF: https://github.com/llvm/llvm-project/commit/39a63fc7fe9824313764a9da8565a705d3024b1a.diff

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. In D141451#4063504 , @nickdesaulniers wrote: > In D141451#4063335 , @dblaikie > wrote: > >> In D141451#4063151 , >> @nickdesaulniers wrote:

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG304d7307aee1: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple… (authored by vsapsai). Repository: rG LLVM Github

[clang] 304d730 - [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

Author: Volodymyr Sapsai Date: 2023-01-18T16:15:53-06:00 New Revision: 304d7307aee15b6eb88d198ae94b595f4e09f485 URL: https://github.com/llvm/llvm-project/commit/304d7307aee15b6eb88d198ae94b595f4e09f485 DIFF:

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141424/new/ https://reviews.llvm.org/D141424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

nickdesaulniers added a comment. In D141451#4063335 , @dblaikie wrote: > In D141451#4063151 , > @nickdesaulniers wrote: > >> In D141451#4045658 , @efriedma >> wrote: >>

[PATCH] D140875: [clangd] prototype: Implement unused include warnings with include-cleaner library.

hokein updated this revision to Diff 490287. hokein added a comment. update the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140875/new/ https://reviews.llvm.org/D140875 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D131052: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd3da9067d143: [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR (authored by mstorsjo). Repository: rG LLVM Github

[clang-tools-extra] d3da906 - [CMake] Allow setting the location of host tools with LLVM_NATIVE_TOOL_DIR

Author: Martin Storsjö Date: 2023-01-18T23:56:15+02:00 New Revision: d3da9067d143f3d4ce59b6d9ab4606a8ef1dc937 URL: https://github.com/llvm/llvm-project/commit/d3da9067d143f3d4ce59b6d9ab4606a8ef1dc937 DIFF:

[PATCH] D141868: [Clang] [Sema] Removed a fix-it for system headers

NoQ added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:10923-10927 +for (std::vector::iterator HI = Cand->Fix.Hints.begin(), + HE = Cand->Fix.Hints.end(); + HI != HE; ++HI) +FDiag << *HI; + }

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane updated this revision to Diff 490278. erichkeane added a comment. Added tests suggested by Tom, also moved the cast creation after checking of the return type, so that we end up not hitting hte assert that Tom came up with. Added 2 tests that show the two conditions (that DID repro

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); doru1004 wrote: > ABataev wrote: >

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:1166-1168 +return llvm::any_of(Top->IteratorVarDecls, [VD](const VarDecl *IteratorVD) { + return IteratorVD == VD->getCanonicalDecl(); +}); ABataev wrote: > doru1004 wrote: >

[PATCH] D141871: [Clang][OpenMP] Add parse and sema for iterator map modifier

doru1004 updated this revision to Diff 490277. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141871/new/ https://reviews.llvm.org/D141871 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/Basic/DiagnosticParseKinds.td

[PATCH] D136913: [HLSL] support RWByteAddressBuffer.

python3kgae updated this revision to Diff 490274. python3kgae added a comment. Rebase and update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136913/new/ https://reviews.llvm.org/D136913 Files:

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. This makes sense to me, and it looks like the memory impact from the extra type nodes should be relatively small. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + erichkeane wrote: > arphaman wrote: > > aaron.ballman wrote: >

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + arphaman wrote: > aaron.ballman wrote: > > erichkeane wrote: > >

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + aaron.ballman wrote: > erichkeane wrote: > > I don't think we can

[PATCH] D141954: Forbid implicit conversion of constraint expression to bool

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaConcept.cpp:377-380 + SubstitutedExpression = ImplicitCastExpr::Create( + S.Context, SubstitutedExpression.get()->getType(), + CK_LValueToRValue, SubstitutedExpression.get(), +

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

dblaikie added a comment. In D141451#4063151 , @nickdesaulniers wrote: > In D141451#4045658 , @efriedma > wrote: > >> clang has a "LocTrackingOnly" setting for debug info, which emits DILocation >> info into

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1764 + the ``external_source_symbol`` attribute with + ``__has_attribute(external_source_symbol_with_usr)``. + erichkeane wrote: > I don't think we can do this.

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1755 + String that specifies a unified symbol resolution (USR) value for this + declaration. USR string uniquely identifies this particular declaration, and + is typically used when

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.h:196-197 + + void AddCudaIncludeArgs(const llvm::opt::ArgList , llvm::opt::ArgStringList ) const override; tra

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

jhuber6 added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:448-450 + // If we are invoking `nvlink` internally we need to output a `.cubin` file. + // Checking if the output is a temporary is the cleanest way to determine + // this. Putting this logic in

[PATCH] D141785: [Clang][LoongArch] Implement patchable function entry

aaron.ballman added a comment. The Clang bits LGTM, though you should add a release note about the new functionality so users know about it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141785/new/ https://reviews.llvm.org/D141785

[PATCH] D140158: [CUDA] Allow targeting NVPTX directly without a host toolchain

tra added a comment. LGTM overall, with few nits. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:448-450 + // If we are invoking `nvlink` internally we need to output a `.cubin` file. + // Checking if the output is a temporary is the cleanest way to determine + // this.

  1   2   3   >