[PATCH] D141472: [clang][Interp] Add function pointers

tbaeder added a comment. In D141472#4091662 , @aaron.ballman wrote: > Design question -- do you anticipate this class handling *all* function > pointers, including pointer to member functions that might be virtual: > https://godbolt.org/z/hT8fMY37n I

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

ChuanqiXu added a comment. In D142704#4092724 , @iains wrote: > I think we need to find a way to proceed - because this causes a regression > on the llvm-16 branch, and that should be resolved soon, if possible. > What is your suggestion for a way forwar

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

kadircet added a subscriber: usaxena95. kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:720 + // Pick up the name via VisitNamedDecl + Base::VisitTemplateTypeParmDecl(D); +} nridge wrote: > Am I using the API corr

[PATCH] D142085: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG54b40a1785e9: [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and… (authored by eopXD). Changed prior to commit: https

[clang] 54b40a1 - [1/3][Clang][RISCV] Add `__riscv_` prefix for vread, vwrite, vlenb, vsetvl, and vsetvlmax

Author: eopXD Date: 2023-01-31T01:06:03-08:00 New Revision: 54b40a1785e9e7602fd69cd274cb46fc5746e029 URL: https://github.com/llvm/llvm-project/commit/54b40a1785e9e7602fd69cd274cb46fc5746e029 DIFF: https://github.com/llvm/llvm-project/commit/54b40a1785e9e7602fd69cd274cb46fc5746e029.diff LOG: [1

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

DavidSpickett updated this revision to Diff 493518. DavidSpickett added a comment. Remove the Armhf comment, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140011/new/ https://reviews.llvm.org/D140011 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141591/new/ https://reviews.llvm.org/D141591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140874/new/ https://reviews.llvm.org/D140874 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

kiranchandramohan added a subscriber: raghavendhra. kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constan

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::Ope

[PATCH] D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2153544865a9: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D140011: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd173cbd7cca: [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux… (authored by DavidSpickett). Repository: rG LLVM Githu

[clang] cd173cb - [clang][compiler-rt] Support LLVM_ENABLE_PER_TARGET_RUNTIME_DIR on Arm Linux and BSD

Author: David Spickett Date: 2023-01-31T09:49:56Z New Revision: cd173cbd7cca69c29df42cd4b42e60433435c29b URL: https://github.com/llvm/llvm-project/commit/cd173cbd7cca69c29df42cd4b42e60433435c29b DIFF: https://github.com/llvm/llvm-project/commit/cd173cbd7cca69c29df42cd4b42e60433435c29b.diff LOG

[PATCH] D142327: [clang][RISCV] Fix ABI handling of empty structs with hard FP calling conventions in C++

asb added a comment. In D142327#4080044 , @asb wrote: > Thanks Luis for the quick review. As an important part of this is trying to > align with gcc/g++ I'd really appreciate a review from @kito-cheng too if you > have the time (thanks in advance!). Fr

[clang] d708a18 - [Clang] Implement Change scope of lambda trailing-return-type

Author: Corentin Jabot Date: 2023-01-31T11:06:14+01:00 New Revision: d708a186b6a9b050d09558163dd353d9f738c82d URL: https://github.com/llvm/llvm-project/commit/d708a186b6a9b050d09558163dd353d9f738c82d DIFF: https://github.com/llvm/llvm-project/commit/d708a186b6a9b050d09558163dd353d9f738c82d.diff

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd708a186b6a9: [Clang] Implement Change scope of lambda trailing-return-type (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @aaron.ballman Thanks for the review! I hope we won't find further issue with the paper this time :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351

[PATCH] D142967: [clangd] Introduce source.organizeImports code action.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This would provide us a way to a

[PATCH] D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

eopXD reopened this revision. eopXD added a comment. This revision is now accepted and ready to land. Previous landing was reverted because of test case `Clang :: Sema/uninit-variables-riscv-vector.c` that was not updated, causing failure. Reopening to land this patch correctly. Repository:

[PATCH] D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

eopXD updated this revision to Diff 493533. eopXD added a comment. Update test case `Sema/uninit-variables-riscv-vector.c`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142644/new/ https://reviews.llvm.org/D142644 Files: clang/lib/Support/RISCV

[PATCH] D142644: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG013c7d1f3a13: [2/3][Clang][RISCV] Add `__riscv_` for non-overloaded intrinsics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES S

[clang] e4bc989 - [Clang] Fix typo in ReleaseNotes.rst

Author: Corentin Jabot Date: 2023-01-31T11:19:44+01:00 New Revision: e4bc9898ddbeb70bc49d713bbf863f050f21e03f URL: https://github.com/llvm/llvm-project/commit/e4bc9898ddbeb70bc49d713bbf863f050f21e03f DIFF: https://github.com/llvm/llvm-project/commit/e4bc9898ddbeb70bc49d713bbf863f050f21e03f.diff

[PATCH] D91000: [clang-tidy] Add bugprone-unsafe-functions checker.

whisperity added a comment. Alright, the tests came back from the CI positively and there were no crashes on like 15 projects (about 50:50 C and C++). There are some nice results: - In LLVM, in `LexPPMacroExpansion.cpp` `ExpandBuiltinMacro()` there is a hit for a call `Result = asctime(TM);`. T

[clang] 5f01a62 - [ConstantFold] Fix inbounds inference on mismatching source element type

Author: Nikita Popov Date: 2023-01-31T11:33:00+01:00 New Revision: 5f01a626dd0615df49773d419c75aeb33666ee83 URL: https://github.com/llvm/llvm-project/commit/5f01a626dd0615df49773d419c75aeb33666ee83 DIFF: https://github.com/llvm/llvm-project/commit/5f01a626dd0615df49773d419c75aeb33666ee83.diff

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

nikic added a comment. @umesh.kalappa0 This issue should be fixed by https://github.com/llvm/llvm-project/commit/5f01a626dd0615df49773d419c75aeb33666ee83. Can you please give it another try? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 __

[PATCH] D142384: [C++20] Fix a crash with modules.

usaxena95 updated this revision to Diff 493538. usaxena95 added a comment. Moved the use of definition where fields are accessed. This now resolves several other C++20/Module related crashes as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

barannikov88 created this revision. Herald added a subscriber: jeroen.dobbelaere. Herald added a project: All. barannikov88 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://rev

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains updated this revision to Diff 493546. iains marked 2 inline comments as done. iains added a comment. rebased, added tests for instantiated variable/function templates. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142704/new/ https://reviews.

[PATCH] D142704: [C++20][Modules] Handle template declarations in header units.

iains added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:15265 FD->getFormalLinkage() == Linkage::ExternalLinkage && - !FD->isInvalidDecl() && BodyKind != FnBodyKind::Delete && + !FD->isInvalidDecl() && !IsFnTemplate && BodyKind != FnBodyKind::Delete

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked 2 inline comments as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLoc

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 493549. TIFitis marked an inline comment as done. TIFitis added a comment. Moved getSizeInBytes to OMPIRBuilder.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142914/new/ https://reviews.llvm.org/D142914 Fi

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

foad added a comment. Looks OK but what's the motivation for it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142968/new/ https://reviews.llvm.org/D142968 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

foad added inline comments. Comment at: clang/docs/tools/clang-formatted-files.txt:7421 llvm/utils/not/not.cpp +llvm/Utils/TableGen/CodeGenInstAlias.cpp +llvm/Utils/TableGen/CodeGenInstAlias.h Should come after CodeBeads in alphabetical order? Repository: rG

[PATCH] D142697: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics

eopXD updated this revision to Diff 493551. eopXD added a comment. Update left-out test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142697/new/ https://reviews.llvm.org/D142697 Files: clang/lib/Support/RISCVVIntrinsicUtils.cpp clang/

[PATCH] D142697: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1ec6c562: [3/3][Clang][RISCV] Add `__riscv_` for overloaded intrinsics (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D142822: [clang] ASTImporter: Fix importing of va_list types and declarations

vabridgers updated this revision to Diff 493553. vabridgers added a subscriber: balazske. vabridgers added a comment. Updates per suggestion from @balazske Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142822/new/ https://reviews.llvm.org/D142822

[PATCH] D142094: [Clang][Doc] Add release note for changes for the RVV intrinsics

eopXD updated this revision to Diff 493555. eopXD added a comment. Address comment from Alex. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142094/new/ https://reviews.llvm.org/D142094 Files: clang/docs/ReleaseNotes.rst Index: clang/docs/Relea

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::Ope

[PATCH] D142637: A slightly more concise AST dump :)

merrymeerkat updated this revision to Diff 493557. merrymeerkat added a comment. Addressing review comments (improve tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142637/new/ https://reviews.llvm.org/D142637 Files: clang/include/clang/AST

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

barannikov88 added a comment. I intent to make make InstAlias with "complex" operands (non-empty MIOperandInfo) more robust (stricter syntax). The change will clobber most of the code here, and I thought it is a good time to move the class to a dedicated file. Another weak point is that this cla

[PATCH] D142637: A slightly more concise AST dump :)

merrymeerkat marked 3 inline comments as done. merrymeerkat added a comment. thank you @sammccall @gribozavr2 for spotting these issues! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142637/new/ https://reviews.llvm.org/D142637 ___

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493564. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Remove all special-casing, skip all variant pages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo added a comment. Thanks for the comments! Comment at: clang/tools/include-mapping/cppreference_parser.py:196 + "std::remove$": "algorithm", + "std::atomic.*": "atomic", + kadircet wrote: > there's no variant of "std::atomic.*" called "atomic",

[PATCH] D142092: [include-mapping] Allow multiple headers for the same symbol. Choose the first header of available ones.

VitaNuo updated this revision to Diff 493565. VitaNuo added a comment. Remove a FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142092/new/ https://reviews.llvm.org/D142092 Files: clang/include/clang/Tooling/Inclusions/CSymbolMap.inc clan

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm updated this revision to Diff 493566. arsenm added a comment. Revert implicitarg.ptr changes since not-HSA has different alignment for no reason. Also with the size differences between amdhsa and different CO versions we're already wrong for emitting 256 unconditionally CHANGES SINCE LA

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

foad added a comment. I think the tablegen functionality should be a separate patch from the amdgpu changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142823/new/ https://reviews.llvm.org/D142823 ___ cfe-commits mailing list cfe-commits@

[PATCH] D142968: [NFC] Extract `CodeGenInstAlias` into its own *.h/*.cpp

foad accepted this revision. foad added a comment. This revision is now accepted and ready to land. Seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142968/new/ https://reviews.llvm.org/D142968 __

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

arsenm added a comment. In D142823#4093357 , @foad wrote: > I think the tablegen functionality should be a separate patch from the amdgpu > changes. Maybe, but then it’s untested in the patch which adds it CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D142823: Intrinsics: Allow tablegen to mark parameters with dereferenceable

foad added a comment. In D142823#4093363 , @arsenm wrote: > In D142823#4093357 , @foad wrote: > >> I think the tablegen functionality should be a separate patch from the >> amdgpu changes. > > Maybe, but then it’

[PATCH] D141472: [clang][Interp] Add function pointers

aaron.ballman added a comment. In D141472#4092745 , @tbaeder wrote: > In D141472#4091662 , @aaron.ballman > wrote: > >> Design question -- do you anticipate this class handling *all* function >> pointers, includ

[PATCH] D142384: [C++20] Fix a crash with modules.

ilya-biryukov added a reviewer: rsmith. ilya-biryukov added a comment. This fix looks very sensible to me and @rsmith confirmed this pattern that we are seeing might happen (seeing members of something that was demoted from declaration to a definition). @rsmith could you confirm the update versi

[PATCH] D140874: [clang][Interp] Support pointer types in compound assignment operations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140874/new/ https://reviews.llvm.org/D140874 ___ cfe-commits mailing list

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLoc

[PATCH] D141591: [clang][Interp] Properly identify not-yet-defined functions

aaron.ballman added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:158-174 +struct F { + constexpr bool ok() const { +return okRecurse(); + } + constexpr bool okRecurse() const { +return true; + } Should we have some similar tests in

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

aaron.ballman added a comment. Test coverage? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon updated this revision to Diff 493576. Fznamznon added a comment. Apply suggestions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/Driver.

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

clementval added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLocStrFromLocation(Location loc, llvm::Ope

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2571 // No driver mode exposes -x and /TC or /TP; we don't support mixing them. assert(!Args.hasArg(options::OPT_x) && "-x and /TC or /TP is not allowed"); } MaskRay wrote: > Fz

[PATCH] D142976: [clang][CGCall] Remove header file not used. [NFCI]

fpetrogalli created this revision. Herald added a project: All. fpetrogalli requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D142976 Files: clang/lib/CodeGen/CGCall.cpp Ind

[PATCH] D142826: [Clang] Add -Wtype-limits to -Wextra for GCC compatibility

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:45-46 +- -Wtype-limits added to -Wextra for GCC compatibility. This fixes + `Issue 58375 `_. + I'd move this into bug fixes as I don

[PATCH] D139926: [clangd] Add semantic token for angle brackets

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:382 + +// For the inner element of a nested template instantiation with no space +// between the '>' characters, TemplateSpecializationLocInfo::RAngleLoc has i a

[PATCH] D142871: [clangd] Semantic highlighting for constrained-parameter

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:720 + // Pick up the name via VisitNamedDecl + Base::VisitTemplateTypeParmDecl(D); +} kadircet wrote: > nridge wrote: > > Am I using the API correctly here? It's a

[PATCH] D142976: [clang][CGCall] Remove header file not used. [NFCI]

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. Self approving a non-controversial trivial change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142976/new/ https://reviews.llvm.org/

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} v1nh1shungry wrote: > kadircet wrote: > > v1nh1shungry wrot

[clang] c3bc61d - [clang-format][NFC] Pull FormatTokenSource into its own header.

Author: Manuel Klimek Date: 2023-01-31T14:32:31Z New Revision: c3bc61d72f8da9a2b45e610ee3c2ccfc5f884f69 URL: https://github.com/llvm/llvm-project/commit/c3bc61d72f8da9a2b45e610ee3c2ccfc5f884f69 DIFF: https://github.com/llvm/llvm-project/commit/c3bc61d72f8da9a2b45e610ee3c2ccfc5f884f69.diff LOG:

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman added a comment. Aside from a nit about comments, I don't have any further concerns. LGTM! Comment at: clang/include/clang/Basic/WebAssemblyReferenceTypes.def:16 +// +// - Name is the name of the builtin type. MangledName is the mangled name. +// ---

[PATCH] D122215: [WebAssembly] Initial support for reference type externref in clang

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Oops, it helps to actually accept it in Phab. :-D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122215/new/ https://reviews.llvm.o

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493594. ckandeler marked an inline comment as done. ckandeler added a comment. Improved implementation as per review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:382 + +// For the inner element of a nested template instantiation with no space +// between the '>' characters, TemplateSpecializationLocInfo::RAngleLoc has ka

[PATCH] D142981: [clangd] Support include paths relative to .clangd config file

freqmod created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. freqmod requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This addresses the use case in https://gith

[clang] ab0116e - [Clang] Improve error message for violations of -fmodules-decluse.

Author: James Y Knight Date: 2023-01-31T09:57:23-05:00 New Revision: ab0116e2f05c6156c4bc3d35986de1e98cc27016 URL: https://github.com/llvm/llvm-project/commit/ab0116e2f05c6156c4bc3d35986de1e98cc27016 DIFF: https://github.com/llvm/llvm-project/commit/ab0116e2f05c6156c4bc3d35986de1e98cc27016.diff

[PATCH] D142925: [Clang] Improve error message for violations of -fmodules-decluse.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGab0116e2f05c: [Clang] Improve error message for violations of -fmodules-decluse. (authored by jyknight). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

hazohelet added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15548 + + SuggestParentheses(Self, Bop->getOperatorLoc(), + Self.PDiag(diag::note_precedence_silence) erichkeane wrote: > I find myself wondering if we could provide a b

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm marked 2 inline comments as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2059-2061 + F.removeFnAttrs(AttrsToRemove); + addDenormalModeAttrs(Merged, MergedF32, FuncAttrs); + F.addFnAttrs(FuncAttrs); tra wrote: > IIUIC, thi

[PATCH] D142800: [Clang][Diagnostic] Add `-Wcomparison-op-parentheses` to warn on chained comparisons

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15548 + + SuggestParentheses(Self, Bop->getOperatorLoc(), + Self.PDiag(diag::note_precedence_silence) hazohelet wrote: > erichkeane wrote: > > I find myself wondering i

[clang] be31f2c - [clang-format][NFC] Move IndexedTokenSource to FormatTokenSource header.

Author: Manuel Klimek Date: 2023-01-31T15:06:20Z New Revision: be31f2c11d47d3eca28d922a06de181d6e23b355 URL: https://github.com/llvm/llvm-project/commit/be31f2c11d47d3eca28d922a06de181d6e23b355 DIFF: https://github.com/llvm/llvm-project/commit/be31f2c11d47d3eca28d922a06de181d6e23b355.diff LOG:

[clang] 20f3ebd - [clang][CGCall] Remove header file not used. [NFCI]

Author: Francesco Petrogalli Date: 2023-01-31T16:12:46+01:00 New Revision: 20f3ebd258851e801cb5c2baf92e895c72695858 URL: https://github.com/llvm/llvm-project/commit/20f3ebd258851e801cb5c2baf92e895c72695858 DIFF: https://github.com/llvm/llvm-project/commit/20f3ebd258851e801cb5c2baf92e895c7269585

[PATCH] D142976: [clang][CGCall] Remove header file not used. [NFCI]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20f3ebd25885: [clang][CGCall] Remove header file not used. [NFCI] (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D141858: [clang][Interp] Fix Pointer::toAPValue() for expressions

tbaeder added a comment. It's a bit involved since without working `MaterializeTemporaryExpr`s, this code is a no-op, but without this code, the MTEs don't properly work, usually. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141858/new/ https://reviews.llvm.org/D141858 __

[PATCH] D139926: [clangd] Add semantic token for angle brackets

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. In D139926#4091990 , @nridge wrote: > but it sounds like you've looked at that well i did now :P --- thanks a lot to you both, let's ship it!

[PATCH] D142934: clang: Use ptrmask for pointer alignment

fhahn added a comment. Using `ptrmask` here looks good to me, but it looks like a couple of tests need still updating; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142934/new/ https://reviews.llvm.org/D142934 ___ cfe-commits mailing list cf

[PATCH] D142907: LangRef: Add "dynamic" option to "denormal-fp-math"

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2059-2061 + F.removeFnAttrs(AttrsToRemove); + addDenormalModeAttrs(Merged, MergedF32, FuncAttrs); + F.addFnAttrs(FuncAttrs); arsenm wrote: > tra wro

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added inline comments. Comment at: clang/docs/ReleaseNotes.rst:60 `Issue 59446 `_. +- Fix confusing warning message when `/clang:-x` is passed in clang-cl driver + mode and emit an error which suggests using `/TC` o

[PATCH] D142757: [clang][driver] Emit an error for `/clang:-x`

Fznamznon added a comment. @MaskRay , thanks for the suggestions. Applied. Please let me know that it is ok now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142757/new/ https://reviews.llvm.org/D142757 __

[PATCH] D139926: [clangd] Add semantic token for angle brackets

ckandeler updated this revision to Diff 493610. ckandeler added a comment. Incorporated review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139926/new/ https://reviews.llvm.org/D139926 Files: clang-tools-extra/clangd/SemanticHighlighti

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 updated this revision to Diff 493612. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/inbounds.c llvm/include/llvm/IR/ConstantFold.h llvm/lib/IR/ConstantFold.cpp Ind

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 added a comment. In D142872#4093093 , @nikic wrote: > @umesh.kalappa0 This issue should be fixed by > https://github.com/llvm/llvm-project/commit/5f01a626dd0615df49773d419c75aeb33666ee83. > Can you please give it another try? Thank you @

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis updated this revision to Diff 493615. TIFitis marked an inline comment as done. TIFitis added a comment. Added new header file mlir/include/mlir/Target/LLVMIR/Dialect/Utils.h, moved two common functions to the new file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D142914: [MLIR][OpenMP] Added OMPIRBuilder support for Target Data directives.

TIFitis marked an inline comment as done. TIFitis added inline comments. Comment at: mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp:1342-1382 +/// Create a constant string location from the MLIR Location information. +static llvm::Constant * +createSourceLoc

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

jhuber6 created this revision. jhuber6 added a reviewer: uabelho. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. There were intemittent errors in the linker wrapper when using the sanitizers in parallel

[PATCH] D142985: [LinkerWrapper] Fix memory issues due to unguarded accesses to global state

jhuber6 added a comment. If this fixes the issues on your side, please open a bug so it can be backported. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142985/new/ https://reviews.llvm.org/D142985 ___

[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain

michaelplatings created this revision. michaelplatings added a reviewer: phosek. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. michaelplatings requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. The defaul

[clang] 40d8c06 - [flang][driver] Add support for -embed-offload-object flag in flang

Author: Jan Sjodin Date: 2023-01-31T10:56:45-05:00 New Revision: 40d8c0666f19599c16e5345abee371d016409c12 URL: https://github.com/llvm/llvm-project/commit/40d8c0666f19599c16e5345abee371d016409c12 DIFF: https://github.com/llvm/llvm-project/commit/40d8c0666f19599c16e5345abee371d016409c12.diff LO

[PATCH] D142244: [flang][driver] Add support for -embed-offload-object flag in flang -fc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG40d8c0666f19: [flang][driver] Add support for -embed-offload-object flag in flang (authored by jsjodin). Herald added projects: clang, Flang. Herald

[PATCH] D142872: Honor the fwrapv option when generating the inbounds GEP .

umesh.kalappa0 updated this revision to Diff 493623. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142872/new/ https://reviews.llvm.org/D142872 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/inbounds.c llvm/include/llvm/IR/ConstantFold.h llvm/lib/IR/ConstantFold.cpp Ind

[clang] 04ed86f - [clang-format][NFC] Bring FormatTokenSource under test.

Author: Manuel Klimek Date: 2023-01-31T16:06:46Z New Revision: 04ed86ff1b7272faf8e62fa32da4acaa2d3c6add URL: https://github.com/llvm/llvm-project/commit/04ed86ff1b7272faf8e62fa32da4acaa2d3c6add DIFF: https://github.com/llvm/llvm-project/commit/04ed86ff1b7272faf8e62fa32da4acaa2d3c6add.diff LOG:

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:994 HI.CalleeArgInfo.emplace(toHoverInfoParam(PVD, PP)); + PassType.PassBy = getPassMode(PVD->getType()); +} kadircet wrote: > v1nh1shungry wrote: > > kadircet wrot

[PATCH] D142014: [clangd] fix wrong CalleeArgInfo in the hover

v1nh1shungry updated this revision to Diff 493626. v1nh1shungry added a comment. - restore code changes - add test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142014/new/ https://reviews.llvm.org/D142014 Files: clang-tools-extra/clangd/H

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

nikic added a comment. FYI this causes a minor compile-time regression (around 0.35% on 7zip at `O0`): http://llvm-compile-time-tracker.com/compare.php?from=cd173cbd7cca69c29df42cd4b42e60433435c29b&to=d708a186b6a9b050d09558163dd353d9f738c82d&stat=instructions%3Au Just wanted to check whether tha

  1   2   3   >