[PATCH] D56878: [mips] Add '-mrelax-pic-calls', '-mno-relax-pic-calls'

sdardis added inline comments. Comment at: cfe/trunk/include/clang/Driver/Options.td:2423 + Group, + HelpText<"Try turning PIC calls (j{al}r{c} $25) into direct calls " + "(MIPS only)">, Flags<[HelpHidden]>; I think this help text could be a little better. Ins

[PATCH] D55878: [Driver] Use --hash-style=gnu instead of both on FreeBSD

sdardis added a comment. > I can't find rationale behind the MIPS discrepancy in the original commit. I > can add the if branch back if you tell me why... From my recollections, the gnu-hash style isn't supported in ld.bfd for MIPS. A patch was posted to the binutils list (https://sourceware.o

[PATCH] D51356: [docs][mips] Clang 7.0 Release notes

sdardis added inline comments. Comment at: ReleaseNotes.rst:121 +- On MIPS FreeBSD default CPUs have been changed to ``mips2`` + for 32-bit targets and ``mips3`` for 32-bit targets. + ``mips3`` for 64 bit targets. D48499. Repository: rC Clang https://revie

[PATCH] D48169: [mips] Add '-mcrc', '-mno-crc' options to enable/disable CRC ASE

sdardis added inline comments. Comment at: include/clang/Driver/Options.td:2214 HelpText<"Disable SVR4-style position-independent code (Mips only)">; +def mno_crc : Flag<["-"], "mno-crc">, Group, + HelpText<"Disallow use of CRC instructions (Mips only)">; ata

[PATCH] D47829: [Driver] Accept the -fno-shrink-wrap option for GCC compatibility

sdardis added a comment. In https://reviews.llvm.org/D47829#1124040, @efriedma wrote: > Is this something which is actually useful to control? From your > description, you want to add the flag to clang not because you actually want > to use it, but just because you can't figure out how to pass

[PATCH] D47829: [Driver] Accept the -fno-shrink-wrap option for GCC compatibility

sdardis updated this revision to Diff 150904. sdardis added a comment. Modify implementation to produce a function attribute. Repository: rC Clang https://reviews.llvm.org/D47829 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunctio

[PATCH] D47829: [Driver] Accept the -fno-shrink-wrap option for GCC compatibility

sdardis created this revision. sdardis added a reviewer: rsmith. Herald added a reviewer: javed.absar. Herald added subscribers: atanasyan, kristof.beyls, arichardson. As reported in GCC bug #86069, LLVM currently provokes a bug in GCC where objects compiled for MIPS with PIC and optimizations whe

[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. Herald added a subscriber: chrib. Sorry for the delay. LGTM. Repository: rUNW libunwind https://reviews.llvm.org/D41968 ___ cfe-commits mai

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM, with a touch up of the error message to match the others we have regarding -mabicalls. Some other minor nits inlined. Comment at: include/clang/Basic/DiagnosticDrive

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

sdardis added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:340 + "ignoring '%0' option as it cannot be used with " + "explicit use of -mabicalls and the N64 ABI">, InGroup; Use the %select{optionA|optionB|..|optionZ}$NUM operator

[PATCH] D44684: [mips] Improve handling of -fno-[pic/PIC] option

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. A quick comment on the error message, inlined. It's about the quality of the diagnostics. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:336-337 +def w

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang https://reviews.llvm.org/D44381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. You should also update the description of the patch. Repository: rC Clang https://reviews.llvm.org/D44381 ___ cfe-commits mailing

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis added a comment. Thanks for the review. Repository: rL LLVM https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

This revision was automatically updated to reflect the committed changes. Closed by commit rL329167: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when… (authored by sdardis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://r

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis added a comment. Ping. Repository: rCXX libc++ https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

This revision was automatically updated to reflect the committed changes. Closed by commit rL329053: [clangd][cmake] Provide libatomic when there is no native support for 64bit… (authored by sdardis, committed by ). Herald added subscribers: llvm-commits, MaskRay. Changed prior to commit: https

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis added a comment. Ping. Repository: rCXX libc++ https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44381: [mips] Prevent PIC to be set to level 2

sdardis added inline comments. Comment at: lib/Driver/ToolChains/CommonArgs.cpp:983 + return std::make_tuple(llvm::Reloc::Static, 0U, false); +// It's never PIC level 2 for mips. +IsPICLevelTwo = false; Can you reformulate this comment to say that MI

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

sdardis added a comment. Thanks, I wasn't sure who to add as a reviewer. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

sdardis added a comment. Ping? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44381: [mips] Change the way how Clang chooses relocation mode

sdardis added a comment. This patch looks mostly ok, but I think there are some small issues with it. Can you separate the new warnings/error relating to -fno-pic / -mabicalls into another patch from the change which alters the behaviour of __PIC__ / __pic__ ? The title of the patch is misleadi

[PATCH] D44248: [clangd][cmake] Provide libatomic when there is no native support for 64bit atomics

sdardis created this revision. Herald added subscribers: ioeric, jkorous-apple, ilya-biryukov, arichardson, mgorny, klimek. This addresses a persistent failure on clang-cmake-mips buildbot. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44248 Files: clangd/CMakeLists.txt I

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis added a comment. Ping. Repository: rCXX libc++ https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis added a comment. Ping. Repository: rCXX libc++ https://reviews.llvm.org/D43509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. Herald added a subscriber: christof. LGTM after https://reviews.llvm.org/D43585 lands. Repository: rUNW libunwind https://reviews.llvm.org/D39074 _

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D43585#1017957, @bsdjhb wrote: > My only question is if this should be named LIBUNWIND_TEST_COMPILER_FLAGS to > match the name used in libc++? I would say yes f

[PATCH] D43585: [libunwind] Permit additional compiler flags to be passed to tests.

sdardis added a subscriber: arichardson. sdardis added a comment. This works as expected with your corresponding libcxx patch. However @arichardson 's https://reviews.llvm.org/D42139 does similar things for libcxx. We should wait for that to land, and ensure that this patch is rebased against t

[PATCH] D43487: [mips] Spectre variant two mitigation for MIPSR2

This revision was automatically updated to reflect the committed changes. Closed by commit rL325651: [mips] Spectre variant two mitigation for MIPSR2 (authored by sdardis, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43487 Files: cfe

[PATCH] D43509: [libcxx][cmake] Remove libatomic temporarily from CMAKE_REQUIRED_LIBRARIES when configuring

sdardis created this revision. sdardis added a reviewer: EricWF. Herald added subscribers: christof, mgorny. When libcxx is built in tree for a host which requires libatomic, LLVM's configuration steps will determine it is required and add it to CMAKE_REQUIRED_LIBRARIES. When libcxx is later confi

[PATCH] D43487: [mips] Spectre variant two mitigation for MIPSR2

sdardis created this revision. sdardis added a reviewer: atanasyan. Herald added a subscriber: arichardson. This patch provides migitation for CVE-2017-5715, Spectre variant two, which affects the https://reviews.llvm.org/P5600 and https://reviews.llvm.org/P6600. It provides the option -mindirect

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. Yes. Something like LIBUNWIND_TEST_CFLAGS mapping to config.test_cflags, which libunwind/test/libunwind/test/config.py then appends when building the tests. Thanks. Repository: rUNW libunwind https://reviews.llvm.org/D39074 ___

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. The only thing this needs now is to get correct testing support. Could you add support for passing down to the configuration script an additional set of cflags like compiler-rt and libomp do (as a separate patch)? If you look at libomp, you'll see LIBOMP_TEST_CFLAGS def

[PATCH] D41968: [libunwind][MIPS] Support MIPS floating-point registers for hard-float ABIs.

sdardis added a reviewer: compnerd. sdardis added a comment. I am not sure what the answer is. There's a slightly different issue in that returning the contents of a floating point register on MIPS and expecting it to be a double is not necessarily correct. For a 64bit FPU, the result of lwc1/m

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. Ok, I've found my issue. inttypes.h in libcxx include_next's , which on my debian linux systems has the include chain , , . "helpfully" provides #defines of the various _ABIXXX macros, which normally the compiler defines depending on the ABI. The include chain for oth

[PATCH] D42416: [Driver] Add support for mips32 and scudo

This revision was automatically updated to reflect the committed changes. Closed by commit rL323412: [Driver] Add support for mips32 and scudo (authored by sdardis, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D42416?vs=131047&id=131

[PATCH] D42416: [Driver] Add support for mips32 and scudo

sdardis marked an inline comment as done. sdardis added a comment. Thanks, will fix the nit on commit. Repository: rC Clang https://reviews.llvm.org/D42416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

[PATCH] D42416: [Driver] Add support for mips32 and scudo

sdardis created this revision. sdardis added reviewers: cryptoad, atanasyan. Herald added a subscriber: arichardson. r317337 missed that scudo is supported on MIPS32, so permit that option for MIPS32. Repository: rC Clang https://reviews.llvm.org/D42416 Files: lib/Driver/ToolChains/Linux.c

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. I just checked both my qemu copy and on my mips64 machine and it seems to be a a copy / paste error. Reposting here directly from my machines: MIPS64: diff --git a/test/libunwind/test/config.py b/test/libunwind/test/config.py index 2a0c828..a8952c3 100644 --- a/t

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. Um, I now appear to be getting different results for running under QEMU doing it the proper way. I was previously rebuilding the failing test by hand and running under qemu. I don't believe I changed anything important, I'll have to take a longer look. If you define an

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. This was libunwind's test suite: Compiled test failed unexpectedly! Testing Time: 0.53s Failing Tests (1): libunwind :: libunwind_02.pass.cpp Expected Passes: 3 Unexpected Failures: 1 The hacky pat

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added a comment. Sorry for the delay in getting back to this, but testing this by building it explicitly for N32 (I built a full N32 compiler + libunwind and modified the test setup py to compile for N322) and I'm getting crashes on the return path in _Unwind_Backtrace. The problem occ

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added inline comments. Comment at: include/__libunwind_config.h:73 +# elif defined(_ABIN32) && defined(__mips_soft_float) +#define _LIBUNWIND_TARGET_MIPS_NEWABI 1 +#define _LIBUNWIND_CONTEXT_SIZE 35 compnerd wrote: > Minor nit: I prefer either `N

[PATCH] D35624: Removal of microMIPS64R6

sdardis added inline comments. Comment at: lib/Basic/Targets/Mips.cpp:209 bool MipsTargetInfo::validateTarget(DiagnosticsEngine &Diags) const { + // microMIPS64R6 backend is removed + if ((getTriple().getArch() == llvm::Triple::mips64 || "was removed." https

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D38110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. @compnerd, ping? https://reviews.llvm.org/D38110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40023: [RISCV] Implement ABI lowering

sdardis added a comment. > Mips is the only other implementer of shouldSignExtUnsignedType but is > unaffected, as unlike classifyArgumentType, classifyReturnType will not > extend i32 values (@sdardis: is this a bug?). I believe this is an oversight that is addressed in the backend. The MIPS64

[PATCH] D39074: [libunwind][MIPS]: Add support for unwinding in N32 processes.

sdardis added inline comments. Comment at: include/__libunwind_config.h:59-68 +# elif defined(__mips__) && defined(_ABIN32) && defined(__mips_soft_float) +# define _LIBUNWIND_TARGET_MIPS_N64 1 +# define _LIBUNWIND_CONTEXT_SIZE 35 +# define _LIBUNWIND_CURSOR_SIZE 46 +# define

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a reviewer: compnerd. sdardis added a subscriber: compnerd. sdardis added a comment. Two last inlined comments and I think that's everything. @compnerd Have I missed anything? Comment at: src/UnwindRegistersSave.S:100 +# +DEFINE_LIBUNWIND_FUNCTION(unw_getcontext)

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. Marking this as changes required to clear up my review queue - no further comments. https://reviews.llvm.org/D38110 ___ cfe-commits

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. I have tested this on one of my machines after removing the checks for soft float (my debian install doesn't have the necessary headers for soft-float). With the patch you've pointed out and my inline comments addressed (bar the HI / LO register comments), it passes the

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis added a comment. Thanks for the pointer to that patch, I'll take a look tomorrow. Comment at: src/UnwindRegistersRestore.S:492 +#elif defined(__mips__) && _MIPS_SIM == _ABIO32 + Needs checking for soft-float. Comment at: src/UnwindR

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

sdardis edited subscribers, added: cfe-commits; removed: llvm-commits. sdardis added a comment. +CC cfe-commits, -CC llvm-commits. Some comments inlined. I've managed to run the test-suite on one of my machines here and I'm seeing 3 failures: libunwind :: libunwind_01.pass.cpp libunwind ::

[PATCH] D38168: [mips] Accept but ignore -m(no-)branch-likely

This revision was automatically updated to reflect the committed changes. Closed by commit rL314213: [mips] Accept but ignore -m(no-)branch-likely (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D38168 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/test/Dri

[PATCH] D38168: [mips] Accept but ignore -m(no-)branch-likely

sdardis created this revision. Herald added a subscriber: arichardson. -mbranch-likely and -mno-branch-likely are used in some build systems for some MIPS targets. Accept these options but ignore them as they are an (de)optimiztion hint, and that branch likely instructions were deprecated but not

[PATCH] D36712: Emit section information for extern variables

sdardis added a comment. > One suggestion inline for the wording inline, the important part is making > explicit The important part is making explicit that section information for a variable can be explicit or inferred. https://reviews.llvm.org/D36712 __

[PATCH] D36712: Emit section information for extern variables

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. I agree with @kparzysz here. If there is a mis-match between the declaration and definition, there are cases where undesirable behaviour (as such) will not occur depending on how the mismatc

[PATCH] D36954: [Sema] Update release notes with details of implicit scalar to vector conversions

sdardis added a comment. Thanks, Simon Repository: rL LLVM https://reviews.llvm.org/D36954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36954: [Sema] Update release notes with details of implicit scalar to vector conversions

This revision was automatically updated to reflect the committed changes. Closed by commit rL311441: [Sema] Update release notes with details of implicit scalar to vector… (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D36954 Files: cfe/branches/release_50/docs/ReleaseN

[PATCH] D36954: [Sema] Update release notes with details of implicit scalar to vector conversions

sdardis created this revision. Add notes on this to the C language section, along with the C++ section. https://reviews.llvm.org/D36954 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === --- docs/ReleaseNotes.rst +++

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM with a test for warnings. See test/Driver/mips-abicalls.c for reference. Repository: rL LLVM https://reviews.llvm.org/D35982 ___ cfe-co

[PATCH] D36824: [mips] Rename getSupportedNanEncoding() to getIEEE754Standard() (NFC)

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM with comment addressed. Comment at: lib/Driver/ToolChains/Arch/Mips.cpp:328 +mips::IEEE754Standard mips::getIEEE754Standard(StringRef &CPU) { + // Strictly speaking,

[PATCH] D36712: Emit section information for extern variables

sdardis requested changes to this revision. sdardis added a reviewer: kparzysz. sdardis added a comment. This revision now requires changes to proceed. +kparzysz as Hexagon also makes use of the small data section. Comment at: docs/LangRef.rst:629 +corresponding to the LLVM mod

[PATCH] D36315: [mips] Support implicit gpopt with N64 when using -fno-pic

sdardis added a comment. Thanks for the review and spotting this bug that lead me to finding the other bug. Repository: rL LLVM https://reviews.llvm.org/D36315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D36315: [mips] Support implicit gpopt with N64 when using -fno-pic

This revision was automatically updated to reflect the committed changes. Closed by commit rL310714: [mips] Support implicit gpopt with N64 when using -fno-pic (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D36315 Files: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/t

[PATCH] D35982: [mips] Introducing option -mabs=[legacy/2008]

sdardis requested changes to this revision. sdardis added a comment. This revision now requires changes to proceed. Follow @atanasyan 's suggestion and post a patch that renames that enum along with other changes. One comment inlined. Comment at: clang/Basic/DiagnosticDriverK

[PATCH] D35624: Removal of microMIPS64R6

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. One nit inlined, you can address it when committing. Comment at: Basic/Targets/Mips.cpp:206 bool MipsTargetInfo::validateTarget(DiagnosticsEngine &Diags) const { + if ((g

[PATCH] D30465: [mips] Set the Int64Type / IntMaxType types correctly for OpenBSD/mips64

sdardis closed this revision. sdardis added a comment. Closing this, https://reviews.llvm.org/rL297098. Repository: rL LLVM https://reviews.llvm.org/D30465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

sdardis added a comment. Nit: my comment on line 297, "non position-independent code and N64 ABI" should be "non position-independent code and the N64 ABI". LGTM otherwise. Repository: rL LLVM https://reviews.llvm.org/D36550 ___ cfe-commits ma

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis accepted this revision. sdardis added a comment. This revision is now accepted and ready to land. LGTM. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis added inline comments. Comment at: test/Driver/mips-longcalls-warning.c:1 +// REQUIRES: mips-registered-target +// RUN: %clang -### -c -target mips-mti-elf -mlong-calls %s 2>&1 | FileCheck -check-prefix=IMPLICIT %s Can you put this in test/Driver/mips-ab

[PATCH] D36550: [mips] Notify user that `-mabicalls` is ignored on non-PIC N64 ABI

sdardis added a comment. Slight tweak to the summary: > The -mabicalls option does not have a sense in case of non position > independent code on N64 ABI. After this change driver starts to show a > warning that -mabicalls is ignored in that case. The -mabicalls option does not make sense in t

[PATCH] D36551: [mips] Show warning in case of mixing -mlong-calls and -mabicalls options

sdardis added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:296-297 +def warn_drv_unsupported_longcalls : Warning< + "ignoring '-mlong-calls' option as it cannot be used with " + "%select{|the implicit usage of }0-mabicalls">, + InGroup; ---

[PATCH] D36315: [mips] Support implicit gpopt with N64 when using -fno-pic

sdardis created this revision. Herald added a subscriber: arichardson. As clang defaults to -mno-abicalls when using -fno-pic for N64, implicitly use -mgpopt in that case. https://reviews.llvm.org/D36315 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/mips-features.c Index: test/Drive

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. https://reviews.llvm.org/rL309978 for the revert. Repository: rL LLVM https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. In https://reviews.llvm.org/D35917#830898, @joerg wrote: > I don't see any reason why zero-initialised constants should be emitted in > BSS. I know that GCC does that and I just fixed bugs in that because created > wrong section flags for it. So yes, I'd prefer to rever

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added inline comments. Comment at: cfe/trunk/lib/CodeGen/TargetInfo.cpp: + GVar->setLinkage(llvm::GlobalValue::ExternalLinkage); + GVar->setSection("rodata"); +} efriedma wrote: > Also, this change is clearly unacceptable; am

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. It's required for feature parity with GCC. -fno-common will place globals into the bss section which uses memory at runtime. The -membedded-data and -muninit-const-in-rodata options are for reducing RAM usage in some embedded environments. Repository: rL LLVM https

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. Thanks for the reviews of all of these options. Repository: rL LLVM https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

This revision was automatically updated to reflect the committed changes. Closed by commit rL309940: [mips] Implement -muninit-const-in-rodata (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D35917 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/include/clan

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1523 + CmdArgs.push_back("-muninit-const-in-rodata"); + A->claim(); +} atanasyan wrote: > What's happened if the `-muninit-const-in-rodata` is used without > `-m

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis updated this revision to Diff 109545. sdardis marked an inline comment as done. sdardis added a comment. Address review comment. https://reviews.llvm.org/D35917 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/TargetInfo.cpp lib/Driver

[PATCH] D35914: [mips] Add support -m(no-)embedded-data option

This revision was automatically updated to reflect the committed changes. Closed by commit rL309935: [mips] Add support -m(no-)embedded-data option (authored by sdardis). Repository: rL LLVM https://reviews.llvm.org/D35914 Files: cfe/trunk/include/clang/Driver/Options.td cfe/trunk/lib/Dri

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis added a comment. Ping. https://reviews.llvm.org/D35917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

sdardis added a comment. @aaron.ballman I missed your first comments when I'd submitted mine. In https://reviews.llvm.org/D36208#828957, @aaron.ballman wrote: > In https://reviews.llvm.org/D36208#828955, @sdardis wrote: > > > I think for the interrupt attribute, it should be an error. Currently

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

sdardis added a comment. I think for the interrupt attribute, it should be an error. Currently it's an implementation detail that it errors out in the backend but in principal it can be supported (I haven't gotten around to addressing it.) For the micromips attribute, I believe it should be an

[PATCH] D36208: [mips] Enable target-specific attributes for MIPS64

sdardis added a comment. Some comments: Currently there is no support in the backend for the interrupt attribute for mips64 / using N32 & N64 abis, it will give a fatal error. Previously the backend lacked support for the static relocation model which is an expected requirement for interrupt h

[PATCH] D35917: [mips] Implement -muninit-const-in-rodata

sdardis created this revision. Herald added a subscriber: arichardson. This option when combined with -mgpopt and -membedded-data places all uninitialized constant variables in the read-only section. https://reviews.llvm.org/D35917 Files: include/clang/Driver/Options.td include/clang/Fronte

[PATCH] D35914: [mips] Add support -m(no-)embedded-data option

sdardis created this revision. Herald added a subscriber: arichardson. Add support for the -membedded-data option which places constant data in the .rodata section, rather than the .sdata section. https://reviews.llvm.org/D35914 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/C

[PATCH] D35624: Removal of microMIPS64R6

sdardis added a reviewer: cfe-commits. sdardis added a comment. Also, this need to be posted to cfe-commits. Repository: rL LLVM https://reviews.llvm.org/D35624 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D35550: [mips] Add support for -m(no-)extern-data.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308879: [mips] Add support for -m(no-)extern-data. (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D35550?vs=107073&id=107897#toc Repository: rL LLVM https://reviews.llvm.or

[PATCH] D35549: [mips] Add support for -m(no-)local-sdata

This revision was automatically updated to reflect the committed changes. Closed by commit rL308683: [mips] Add support for -m(no-)local-sdata (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D35549?vs=107071&id=107592#toc Repository: rL LLVM https://reviews.llvm.org

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

sdardis added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1336 +if code compiled using ``-mlong-calls`` switch, it forces compiler to use +the ``jal`` instruction to call the function. + }]; rjmccall wrote: > sdardis wrote: > > rjmccall wrote: >

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

sdardis added a comment. Some comments on the documentation. Comment at: include/clang/Basic/AttrDocs.td:1336 +if code compiled using ``-mlong-calls`` switch, it forces compiler to use +the ``jal`` instruction to call the function. + }]; rjmccall wrote: > I su

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308431: [mips] Teach the driver to accept -m(no-)gpopt. (authored by sdardis). Changed prior to commit: https://reviews.llvm.org/D35548?vs=107114&id=107275#toc Repository: rL LLVM https://reviews.ll

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

sdardis updated this revision to Diff 107114. sdardis marked an inline comment as done. sdardis added a comment. Addressed review comment, added warning when combining -mabicalls and -mgpopt. https://reviews.llvm.org/D35548 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/B

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

sdardis added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:1490 + GPOpt->claim(); + } + atanasyan wrote: > Could it be rewritten a bit shorter? > > ``` > bool NoAbiCalls = > ABICalls && ABICalls->getOption().matches(options::OPT_mno_abi

[PATCH] D35550: [mips] Add support for -m(no-)extern-data.

sdardis created this revision. Herald added a subscriber: arichardson. Add support for -m(no-)extern-data when using -mgpopt in the driver. It is enabled by default in the backend. https://reviews.llvm.org/D35550 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/

[PATCH] D35549: [mips] Add support for -m(no-)local-sdata

sdardis created this revision. Herald added a subscriber: arichardson. Teach the driver to support -m(no-)local-sdata. The backend already matches GCC's default behaviour. https://reviews.llvm.org/D35549 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/Clang.cpp test/Driver/m

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

sdardis created this revision. Herald added a subscriber: arichardson. This patch teaches the driver to pass -mgpopt by default to the backend when it is supported, i.e. we are using -mno-abicalls. https://reviews.llvm.org/D35548 Files: include/clang/Driver/Options.td lib/Driver/ToolChains/

  1   2   >