[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

wuzish added a comment. Thanks. I will commit for @qiucf Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

wuzish added inline comments. /cfe/trunk/lib/Driver/ToolChains/PPCLinux.cpp:26 @hubert.reinterpretcast Thanks for your advice. I think the name `ppc_wrappers` is accurate to describe its meaning that wrapping the headers under standard library path or standard header search path. (Headers in li

[Diffusion] rL358949: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

wuzish added a comment. > That (controlling within the headers) sounds good to me. When that lands, > then my understanding is that the `PPCLinuxToolChain` code would be adjusted > to include `ppc_wrappers` in the search path in the general case. Please let > me know if that's not the case. Tha

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

wuzish created this revision. wuzish added reviewers: hfinkel, nemanjai, kbarton. Herald added a subscriber: kristina. > unsigned long long __builtin_unpack_vector_int128 (vector __int128_t, int); > vector __int128_t __builtin_pack_vector_int128 (unsigned long long, unsigned > long long); Built

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

wuzish added a comment. Please make this patch commit after https://reviews.llvm.org/D52072 Repository: rC Clang https://reviews.llvm.org/D52074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D52074: [PowerPC] [Clang] Add vector int128 pack/unpack builtins

wuzish added a comment. Herald added a subscriber: jsji. Please help me to commit this patch. Thanks a lot. Repository: rC Clang https://reviews.llvm.org/D52074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson abandoned this revision. Zeson added a comment. I think this revision is out-of-date. I'd like to abandon it. https://reviews.llvm.org/D27251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson created this revision. Zeson added reviewers: nemanjai, sfertile, jtony, hfinkel, syzaara, lei, kbarton. Zeson added a subscriber: cfe-commits. It's mainly about signed and unsigned llvm builtins confusion. When function args are bool vector and signed vector, it should be mapped to signed

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson added a comment. In https://reviews.llvm.org/D27251#609014, @nemanjai wrote: > Thank you for fixing these issues. I certainly see how the shifts really need > to get the signedness right because the right shifts need to fill with the > sign bit (so that vector bool will still have all 0 o

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson updated this revision to Diff 79856. Zeson added a comment. Make vec_xst_be and vec_xl_be test cases put together seperately in `builtins-ppc-vsx.c` Move up macro `__VSX__` to make all vec_xst_be functions included https://reviews.llvm.org/D27251 Files: lib/Headers/altivec.h test/Cod

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson updated this revision to Diff 80021. Zeson marked 3 inline comments as done. Zeson added a comment. Remove some unnecessary cast https://reviews.llvm.org/D27251 Files: lib/Headers/altivec.h test/CodeGen/builtins-ppc-altivec.c test/CodeGen/builtins-ppc-p8vector.c test/CodeGen/built

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson added a comment. In https://reviews.llvm.org/D27251#610629, @kbarton wrote: > Please make explicit the signed for the parameters to the functions you are > changing and remove unnecessary casts. I marked the first few that I found, > but stopped marking them after the first several. I t

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson marked 2 inline comments as done. Zeson added a comment. Hi, All. The revision has been updated, please review it again. Thanks a lot. https://reviews.llvm.org/D27251 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, kito.cheng, rsmith, asb, DavidSpickett, kaz7. Herald added subscribers: krytarowski, mgorny. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added inline comments. Comment at: clang/lib/Basic/Targets/CSKY.cpp:43 + Builder.defineMacro("__CSKYABI__", ABI == "abiv2" ? "2" : "1"); + Builder.defineMacro("__cskyabi__", ABI == "abiv2" ? "2" : "1"); + DavidSpickett wrote: > Any need to handle when

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added inline comments. Comment at: clang/test/Driver/csky-arch.c:26 + +// RUN: %clang -target csky-unknown-elf -march=csky -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=CSKY %s rengolin wrote: > I don't think this is doing what you exp

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu updated this revision to Diff 415006. zixuan-wu added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 Files: clang/lib/Ba

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. I have updated the patch. Any more comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3388842 , @rengolin wrote: > I'm surprised these tests are passing for you. Perhaps you're not building or > running them all. > > To make sure you're running your tests, you need to build both clang and llvm > (`-D

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu created this revision. zixuan-wu added reviewers: simoncook, lenary, asb. Herald added subscribers: sunshaoce, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D54214: [RISCV] Set triple based on -march flag

zixuan-wu added a comment. Herald added subscribers: sunshaoce, pcwang-thead, eopXD, VincentWu, luke957, StephenFan, vkmr, frasercrmck, evandro, luismarques, MaskRay, arichardson. Herald added a project: All. In D54214#1737255 , @simoncook wrote: > Rebase

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3653895 , @jrtc27 wrote: > Does GCC allow this or not? Because this strikes me as a bad idea at first > sight… GCC can deduce from -mcpu but not -mabi. > riscv64-unknown-linux-gnu-gcc a.c -mabi=ilp32 > cc1: error:

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added inline comments. Comment at: clang/lib/Driver/Driver.cpp:660 + +if (RVArch == llvm::Triple::riscv64 && +ArchName.startswith_insensitive("rv32")) eopXD wrote: > Do we need to throw error (or warning) when these two (`RVArch` and > `Arc

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu updated this revision to Diff 445690. zixuan-wu added a comment. Remove unnecessary include header. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 Files: clang/lib/Driver/Driver.cpp clang/test/Driver/riscv-abi.c clang/test/Dri

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3670586 , @reames wrote: > This was very briefly discussed at today's sync up call. We were running > short on time, so we didn't get a chance to talk through it, but there did > seem to be a consensus that discuss

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

zixuan-wu added inline comments. Herald added subscribers: pcwang-thead, luke957, StephenFan, MaskRay, arichardson. Herald added a project: All. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +r

[PATCH] D93138: Add initial support for multilibs in Baremetal toolchain.

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:177 if (!getDriver().SysRoot.empty()) -return getDriver().SysRoot; +return getDriver().SysRoot + SelectedMultilib.osSuffix(); abidh wrote: > zixuan-wu wrote: > > I

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu created this revision. zixuan-wu added reviewers: majnemer, kparzysz, ddunbar. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSKY is always in 4-byte align, no matter it's long long type. F

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to __builtin_alloca_

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added a comment. Could anybody else have a review or nominate a reviewer? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 ___ cfe-commits mailing list

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

zixuan-wu added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:159 + switch (Language) { + case Language::C: +return "c"; It's same name as `Language` variable above, and it cause compile error. @zixuw Maybe the e

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx" #PT

[PATCH] D122089: [CUDA] Add getTargetFeatures for the NVPTX toolchain

zixuan-wu added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:648 +#define CASE_CUDA_VERSION(CUDA_VER, PTX_VER) \ + case CudaVersion::CUDA_##CUDA_VER: \ +PtxFeature = "+ptx" #PT

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu updated this revision to Diff 419076. zixuan-wu added a comment. Herald added subscribers: StephenFan, dexonsmith, MaskRay. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121445/new/ https://reviews.llvm.org/D121445 Files: clang/lib/Basic/CMakeLists.txt c

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3416518 , @rengolin wrote: > There is also a test error: > > TEST 'Clang :: Driver/csky-toolchain.c' FAILED > > ... > /home/rengolin/devel/llvm-project/clang/test/Drive

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97e496054a37: [Clang][CSKY] Add the CSKY target and compiler driver (authored by zixuan-wu). Changed prior to commit: https://reviews.llvm.org/D12

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3431569 , @dyung wrote: > Hi, one of the tests you added. csky-toolchain.c seems to be failing on a > Windows build bot, and from a quick look, it appears to be a path separator > issue. Can you take a look? > > htt

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added inline comments. Comment at: clang/test/Sema/builtin-alloca-with-align.c:32 void test8(void) { +#if defined(__csky__) __builtin_alloca_with_align(sizeof(__INT64_TYPE__), __alignof__(__INT64_TYPE__)); // expected-warning {{second argument to __builtin_alloca_

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu updated this revision to Diff 428585. zixuan-wu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 Files: clang/test/CodeGen/c-strings.c clang/test/Sema/builtin-alloca-with-align.c Index: clang/t

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

zixuan-wu added a comment. Gentle pin.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124977/new/ https://reviews.llvm.org/D124977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D124977: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different

This revision was automatically updated to reflect the committed changes. Closed by commit rGdca37af061fb: [NFC][Clang] Modify expect of fail test or XFAIL because CSKY align is different (authored by zixuan-wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu created this revision. zixuan-wu added reviewers: rengolin, DavidSpickett. Herald added a project: All. zixuan-wu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. According to the CSKY ABIv2 document

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu updated this revision to Diff 432228. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/CSKY/csky-abi.c clang/test/CodeGen/CSKY/csky-hard-abi.c Index: clang/test/CodeGen/C

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. In D126451#3539512 , @DavidSpickett wrote: > Can you reupload with more context? See > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface > > I doubt I'll be able to give any in depth review but i

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. In D126451#3539656 , @rengolin wrote: > This looks good to me, but wait to make sure others see it, too. > > My reasons are: it is largely similar to RISCV implementation, it seems to > follow what I expected of the ABI (which

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:11708 + case llvm::Triple::csky: { +bool IsSoftFloat = !getTarget().hasFeature("hard-float-abi"); +bool hasFP64 = getTarget().hasFeature("fpuv2_df") || DavidSpickett wrote: > I

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu added a comment. BTW, I have run llvm-test-suite, it passed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

zixuan-wu updated this revision to Diff 432820. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews.llvm.org/D126451 Files: clang/lib/CodeGen/TargetInfo.cpp clang/test/CodeGen/CSKY/csky-abi.c clang/test/CodeGen/CSKY/csky-hard-abi.c clang/test/CodeGen/CSKY/cs

[PATCH] D126451: [Clang][CSKY] Add support about CSKYABIInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rG563cc3fda9a2: [Clang][CSKY] Add support about CSKYABIInfo (authored by zixuan-wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126451/new/ https://reviews

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

zixuan-wu accepted this revision. zixuan-wu added a comment. This revision is now accepted and ready to land. LGTM if nobody objects. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wrote: > hubert.re

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wrote: > wuzish wr

[PATCH] D54087: [PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be modulo the number of bits in the element

wuzish created this revision. wuzish added reviewers: hfinkel, nemanjai, kbarton. Herald added a subscriber: jsji. The second parameter of vec_sr function is representing shift bits and it should be modulo the number of bits in the element like what vec_sl does now. Repository: rC Clang http

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish marked an inline comment as done. wuzish added a comment. Gentle ping. Could anyone else have a more review? https://reviews.llvm.org/D53417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish marked an inline comment as done. wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false;

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added a comment. Gentle ping again since it's a critical patch. Could you please have a more review or give it LGTM if it's LGTM to you. Also welcome new comments. https://reviews.llvm.org/D53417 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D54087: [PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be modulo the number of bits in the element

This revision was automatically updated to reflect the committed changes. Closed by commit rC346471: [PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be… (authored by wuzish, committed by ). Changed prior to commit: https://reviews.llvm.org/D54087?vs=172538&id=173262#t

[PATCH] D54087: [PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be modulo the number of bits in the element

This revision was automatically updated to reflect the committed changes. Closed by commit rL346471: [PowerPC] [Clang] [AltiVec] The second parameter of vec_sr function should be… (authored by wuzish, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revi

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added a comment. In https://reviews.llvm.org/D53417#1292404, @rsmith wrote: > I like the direction here, and I'd like to see this applied generally: a > conversion sequence that bitcasts a vector should be ranked worse than one > that does not, regardless of the kind of vector in use.

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish updated this revision to Diff 173276. wuzish added a comment. Extend the scope to all vector type as one comment suggested. > a conversion sequence that bitcasts a vector should be ranked worse than one > that does not, regardless of the kind of vector in use. Which is also made code cle

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish marked 2 inline comments as done. wuzish added a comment. The updated patch now extended the scope and can include the case. https://reviews.llvm.org/D53417 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/test/CodeGen/altivec-generic-overload.c:74 + convert1(gv1); + // CHECK: call void @_Z8convert1Dv16_a(<16 x i8> %{{[0-9]+}}) + convert1(gv2); hubert.reinterpretcast wrote: > Checking that the call is to the expect

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish updated this revision to Diff 173981. wuzish added a comment. Use return type to distinguish which overload candidate is chosen because different candidate has different pointer return type which can not be converted implicitly without reporting error. https://reviews.llvm.org/D53417 F

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish marked an inline comment as done. wuzish added inline comments. Comment at: clang/test/SemaCXX/vector.cpp:26 float &fr1 = f1(ll16); - f1(c16e); // expected-error{{call to 'f1' is ambiguous}} - f1(ll16e); // expected-error{{call to 'f1' is ambiguous}} + f1(c16e); + f

[PATCH] D53417: [Clang][Sema]Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

This revision was automatically updated to reflect the committed changes. wuzish marked an inline comment as done. Closed by commit rC347019: [Clang][Sema]Choose a better candidate in overload function call if there is a… (authored by wuzish, committed by ). Changed prior to commit: https://rev

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate as function call if there is a compatible vector conversion instead of ambious call error

wuzish created this revision. wuzish added reviewers: hfinkel, nemanjai, Douglasgido, hubert.reinterpretcast, fpichet. There are 2 function variations with altivec type parameter. When we call them with argument of generic gcc vector type we would prefer to choose the variation with implicit ar

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambious call error

wuzish added a comment. If anybody knows who are familiar with C/C++ function overload and code related to this issue, please feel free to add them as reviewers and subscribers. Repository: rC Clang https://reviews.llvm.org/D53417 ___ cfe-commit

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/test/Sema/altivec-generic-overload.c:3 + +typedef signed char __v4sc __attribute__((__vector_size__(16))); +typedef unsigned char __v4uc __attribute__((__vector_size__(16))); hubert.reinterpretcast wrote: > `__v4sc`

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish marked 8 inline comments as done. wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3941 + return ImplicitConversionSequence::Better; + } + hubert.reinterpretcast wrote: > This seems to duplicate the bug described here in > h

[PATCH] D53417: [Clang][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish updated this revision to Diff 170871. wuzish marked 2 inline comments as done. wuzish added a comment. Updated the diff. fix some points from comments. https://reviews.llvm.org/D53417 Files: clang/lib/Sema/SemaOverload.cpp clang/test/Sema/altivec-generic-overload.c Index: clang/tes

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wrote: > Consideri

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wrote: > wuzish wr

[PATCH] D53417: [Clang][Sema][PowerPC] Choose a better candidate in overload function call if there is a compatible vector conversion instead of ambiguous call error

wuzish added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:3913 +for (auto Type : Types) { + if (S.Context.getCanonicalType(Type)->getTypeClass() != Type::Vector) +return false; hubert.reinterpretcast wrote: > wuzish wr

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. AFAIK, --target is clang-specific and transparent for compiler user in RV side. -m is also undefined or less used by RV user. It just uses -march to specify 32 or 64 mode and extensions. Is the convention specified in RV Spec? CHANGES SINCE LAST ACTION https://revi

[PATCH] D63329: Allow static linking of libc++ on Linux, just like -static-libstdc++

zixuan-wu added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. Is this going to continue? And also if we use libunwind to handle EH, then it uses dladdr function which need link libdl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3699911 , @kito-cheng wrote: > Just realized the problem is trying to fixed the default value of `-mabi=`, > currently `clang -target riscv32-elf -march=rv64gc > -mabi=lp64d`/`riscv32-elf-clang -march=rv64gc -mabi=

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. In D129824#3706654 , @asb wrote: > @zixuan-wu we discussed this a bit in the last community sync call > . > One aspect that makes this patch a little

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added inline comments. Comment at: clang/test/Driver/riscv-arch.c:410 // RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-TARGET %s +// RUN: %clang --target=riscv32-unknown-elf -mcpu=sifive-s21 -### %s \ +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV64-

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu marked an inline comment as not done. zixuan-wu added a comment. ping... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

zixuan-wu added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:411 // implemented such that the stack will always be 16 byte aligned. unsigned LibCallFrameSize = alignTo((STI.getXLen() / 8) * LibCallRegs, 16); RVFI->setLibCallStackSize(Li

[PATCH] D136239: [testcase] [OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp

zixuan-wu created this revision. zixuan-wu added reviewers: jdoerfert, MaskRay. Herald added subscribers: StephenFan, arphaman, guansong, yaxunl. Herald added a project: All. zixuan-wu requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang.

[PATCH] D136239: [testcase] [OpenMP] Fix the testcase error of check-all when DCLANG_DEFAULT_OPENMP_RUNTIME is not libomp

This revision was automatically updated to reflect the committed changes. Closed by commit rG55c2137939d8: [testcase][OpenMP] Fix the testcase error of check-all when… (authored by zixuan-wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136239/new/

[PATCH] D121445: [Clang][CSKY] Add the CSKY target and compiler driver

zixuan-wu added a comment. In D121445#3824657 , @MaskRay wrote: > mips computed sysroot from GCCInstallation very early in 2013 > rG08450bd55ccdc4aee4f5f73cde97e25b3c4ce5b9 > and > A

[PATCH] D134454: [Driver][Distro] Fix ArchLinux sysroot detection

zixuan-wu added a comment. It's fine for CSKY to use config file. I only have 2 points. 1. I agree sysroot should be separated from GCC because sysroot is not dependent to GCC and there is even not gcc when we use llvm runtime. This rule should also apply to multilib logic. Sysroot can detect m

[PATCH] D70401: [RISCV] Complete RV32E/ilp32e implementation

zixuan-wu added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:106 +for (size_t Reg = RISCV::X16; Reg <= RISCV::X31; Reg++) + markSuperRegs(Reserved, Reg); + I am wondering whether we need construct another new RegisterClass for

[PATCH] D116735: [RISCV] Adjust RISCV data layout by using n32:64 in layout string

zixuan-wu added a comment. In D116735#3429850 , @craig.topper wrote: > I'm seeing a regression on 401.bzip2 and possibly 471.astar. And I'm not > seeing large improvements on 471.omnetpp or 483.xalancbmk. LGTM. But do you still get regression on spec?

[PATCH] D137838: [Support] Move TargetParsers to new component

zixuan-wu added inline comments. Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:10 +/// \file +/// This header is deprecated in favour of `llvm/Support/RISCVISAInfo.h`. +/// I think there is a typo that should be 'in favour of `llvm/TargetParser/RISCVISAIn

[PATCH] D129824: [RISCV] Set triple based on -march flag which can be deduced in more generic way

zixuan-wu added a comment. Ping.. Do we still prefer to specify target triple explicitly to make a check? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129824/new/ https://reviews.llvm.org/D129824 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

zixuan-wu added a comment. Herald added a subscriber: sunshaoce. I am afraid there is also error at clang/test/Driver/as-options.s when default triple is 'riscv32-unknown-elf' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://revi

[PATCH] D153111: [clang][Serialization][RISCV] Increase the number of reserved predefined type IDs

zixuan-wu added a comment. I also caught this issue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153111/new/ https://reviews.llvm.org/D153111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D152570: [clang] Apply -fmacro-prefix-map to anonymous tags in template arguments

zixuan-wu added a comment. Hi, Comment at: clang/test/CodeGenCXX/macro-prefix-map-lambda.cpp:11 + auto *s = lambdatest([](){}); +// CHECK: @"__PRETTY_FUNCTION__._Z10lambdatestIZ4mainE3$_0EDaOT_" = private unnamed_addr constant [{{[0-9]+}} x i8] c"auto lambdatest(f &&) [f = (l

[PATCH] D151397: [3/3][RISCV][POC] Model vxrm in C intrinsics for RVV fixed-point instruction vaadd, vasub

zixuan-wu added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1734 + __RISCV_VXRM_RDN = 2, + __RISCV_VXRM_ROD = 3, +}; I am wondering if we need a dynamic mode enum which representing using current vxrm value? Repository: rG LLVM

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. Hi, there is a compiling error introduced recently as like following when files under clang/lib/Analysis/FlowSensitive/ are being compiled such as TypeErasedDataflowAnalysis.cpp and Transfer.cpp. Does anybody meet also? > from /usr/include/c++/7/functional:60, > f

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. In D153674#4455357 , @sammccall wrote: > Hi, sorry about that - are you able to provide a full log, or link to a > failing bot? > That error message doesn't show where in the LLVM code the error occurs. It can pass with gcc 8.

[PATCH] D70401: [RISCV] CodeGen of RVE and ilp32e/lp64e ABIs

zixuan-wu added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70401/new/ https://reviews.llvm.org/D70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + benshi001 wrote: > This file is pure test, has nothing to do with `llvm.cttz`, just to avoid > another pat

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: llvm/test/CodeGen/CSKY/intrinsic.ll:21 +entry: + %ntz = call i32 @llvm.cttz.i32(i32 %x, i1 1) + ret i32 %ntz I think we can also test the condition that the second argument is zero. CHANGES SINCE LAST ACTION http

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

zixuan-wu added inline comments. Comment at: clang/test/Driver/debug-options.c:245 // // RUN: %clang -### -c -gsplit-dwarf -g -gno-pubnames %s 2>&1 | FileCheck -check-prefix=NOPUB %s // Here should add not or specify the target with x86 because it fails when

[PATCH] D149017: [RISCV] Rewrite all found class-based subroutines to functions

zixuan-wu added a comment. Is it going to commit? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149017/new/ https://reviews.llvm.org/D149017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

zixuan-wu added a comment. In D153674#4461195 , @sammccall wrote: > Sorry about the delay, and thanks for the `.i`. > > It took me a while to work out what was going on, but it looks like it's just > a bug where GCC forgets to automatic-move. > Fixed in

  1   2   >