[PATCH] D140972: [flang] Add -fstack-arrays flag

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf81ba372628: [flang] add -fstack-arrays flag (authored by tblah). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski accepted this revision. awarzynski added a comment. Thanks for the updates, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 ___ cfe-commits mai

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 491267. tblah added a comment. - Rename option macro to make it clear that it doesn't do marshalling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 Files: clang/incl

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Comment at: clang/include/clang/Driver/Options.td:485-486 +// Works like BoolOption except without specifying a KeyPathAndMacro, as these +// would refer to non-existant members of clang data structures +multiclass BoolFlangOnlyOptionhttps://re

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490801. tblah added a comment. Update to ensure that generated code for Options.td does not try to reference clang::CodegenOpts::StackArrays. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://revi

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: flang/test/Transforms/stack-arrays.f90:22-29 +! LLVM-IR: array_value_copy_simple +! LLVM-IR-NOT: malloc +! LLVM-IR-NOT: free +! LLVM-IR: all

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 490100. tblah marked 4 inline comments as done. tblah added a comment. Clarified a comment in stack-arrays.f90 and clarified the choice of FileCheck prefix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:159 inline void createDefaultFIROptimizerPassPipeline( -mlir::PassManager &pm, llvm::OptimizationLevel optLevel = defaultOptLevel) { +mlir::PassManager &pm, bool stackArrays = false, l

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:159 inline void createDefaultFIROptimizerPassPipeline( -mlir::PassManager &pm, llvm::OptimizationLevel optLevel = defaultOptLevel) { +mlir::PassManager &pm, bool stackArrays = false, llvm::

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 489484. tblah marked 6 inline comments as done. tblah added a comment. Update to address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/new/ https://reviews.llvm.org/D140972 Files: clang/

[PATCH] D140972: [flang] Add -fstack-arrays flag

awarzynski added inline comments. Herald added a subscriber: sunshaoce. Comment at: clang/include/clang/Driver/Options.td:5056-5060 +def fstack_arrays : Flag<["-"], "fstack-arrays">, Group, + HelpText<"Attempt to allocate array temporaries on the stack, no matter their size">;

[PATCH] D140972: [flang] Add -fstack-arrays flag

tblah updated this revision to Diff 488686. tblah added a comment. Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Updated to construct StackArrays as a ModuleOp pass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140972/