[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL361889: Add debuginfo-tests that use cdb on Windows (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D54187?vs=201779=201781#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk updated this revision to Diff 201779. rnk added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - rebase, fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 Files:

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk added a comment. Thanks! I don't think this suite is going to get too far out of control. I think for most debug info features, checking the info itself gives enough confidence that things work, but there are these cases where I also want an integration test. I'm picking this up again

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Okay, so it looks like dexter might be a replacement for the lldgb.py wrapper and would support gdb, lldb, and the visual studio debugger. I think it would be nice to migrate the bulk of

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. (Also, dexter has seen 7 commits over its lifetime, so I'm not sure that's something we'd want to depend on.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 ___ cfe-commits

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. In D54187#1460181 , @aprantl wrote: > Did anyone take the time to look at dexter and whether it would fit the bill > here? It would be great to avoid reimplementing its functionality just to > have something that then only works

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. Did anyone take the time to look at dexter and whether it would fit the bill here? It would be great to avoid reimplementing its functionality just to have something that then only works on Windows. My position is that for the kind of very basic end-to-end testing that

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. aprantl: Ping on Hans's question from Dec 18. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

hans added a comment. This seems to be stuck. Is there some way we can get incremental progress on this? I'm not very familiar with debug info, but I think it would be a huge win (and somewhat overdue) just to get some very basic tests like rnk's hello.c automated and running continuously. I

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290432, @rnk wrote: > I hadn't realized that Dexter knew how to drive VS tools. I'll have to go > read more and get back to you all. > > I think it would be more promising than attempting to come up with a new > llgdb.py-like

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

probinson added a comment. In https://reviews.llvm.org/D54187#1290340, @gbedwell wrote: > (Dexter) will step through every line of the program it can, collecting info > about each step until it reaches the program exit. It won't currently > produce a pass/fail, but rather a score. That is,

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk added a comment. I hadn't realized that Dexter knew how to drive VS tools. I'll have to go read more and get back to you all. I think it would be more promising than attempting to come up with a new llgdb.py-like abstraction for cdb. Specifically, abstracting over setting breakpoints and

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

gbedwell added a comment. In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > +gbedwell > > Just to throw the idea out there, why not abandon debuginfo-tests entirely > and try using Dexter for this. Dexter's design center is debug-info quality, > not correctness, but it already

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. In https://reviews.llvm.org/D54187#1290317, @zturner wrote: > In https://reviews.llvm.org/D54187#1290297, @aprantl wrote: > > > In https://reviews.llvm.org/D54187#1290293, @zturner wrote: > > > > > Especially since as far as I can tell, nobody has even run > > >

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290297, @aprantl wrote: > In https://reviews.llvm.org/D54187#1290293, @zturner wrote: > > > Especially since as far as I can tell, nobody has even run debuginfo-tests > > since late August, because it was actually broken by r341135 on

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. In https://reviews.llvm.org/D54187#1290298, @probinson wrote: > In https://reviews.llvm.org/D54187#1290294, @zturner wrote: > > > In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > > > > > +gbedwell > > > > > > Just to throw the idea out there, why not

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. In https://reviews.llvm.org/D54187#1290293, @zturner wrote: > Especially since as far as I can tell, nobody has even run debuginfo-tests > since late August, because it was actually broken by r341135 on August 30 > (fixed in r346060 yesterday) Can you please refrain

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

probinson added a comment. In https://reviews.llvm.org/D54187#1290294, @zturner wrote: > In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > > > +gbedwell > > > > Just to throw the idea out there, why not abandon debuginfo-tests entirely > > and try using Dexter for this. Dexter's

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290282, @probinson wrote: > +gbedwell > > Just to throw the idea out there, why not abandon debuginfo-tests entirely > and try using Dexter for this. Dexter's design center is debug-info quality, > not correctness, but it already

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. In https://reviews.llvm.org/D54187#1290247, @aprantl wrote: > > I think the only way to realistically make this work for all platforms > > would be to separate the source file from the input/output. The source file > > would be the test case, and if you wanted to

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

probinson added subscribers: gbedwell, probinson. probinson added a comment. +gbedwell Just to throw the idea out there, why not abandon debuginfo-tests entirely and try using Dexter for this. Dexter's design center is debug-info quality, not correctness, but it already knows how to drive

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. > I think the only way to realistically make this work for all platforms would > be to separate the source file from the input/output. The source file would > be the test case, and if you wanted to support a different debugger you would > need to supply a different

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

zturner added a comment. I think the only way to realistically make this work for all platforms would be to separate the source file from the input/output. The source file would be the test case, and if you wanted to support a different debugger you would need to supply a different

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk added a comment. In https://reviews.llvm.org/D54187#1289607, @aprantl wrote: > It would be nice if instead of having a set of windows-only tests, we could > wrap cdb similar to llgdb.py wraps LLDB, so these tests run on all platforms. > If the Windows debugger is just too different for

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. It would be nice if instead of having a set of windows-only tests, we could wrap cdb similar to llgdb.py wraps LLDB, so these tests run on all platforms. If the Windows debugger is just too different for this to make sense, let me know.

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk created this revision. rnk added reviewers: aprantl, zturner. Herald added subscribers: JDevlieghere, mgorny. This is an initial prototype of how we can run debugger integration tests on Windows. cdb and windbg share a command language and debugger engine. Visual Studio has its own, but we