This revision was automatically updated to reflect the committed changes.
Closed by commit rL348605: [CTU] Add more lit tests and better error handling
(authored by martong, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D55131?vs=1771
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
LG!
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55131/new/
https://reviews.llvm.org/D55131
___
cfe-commi
martong updated this revision to Diff 177170.
martong marked an inline comment as done.
martong added a comment.
- Rename externalFnMap files
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55131/new/
https://reviews.llvm.org/D55131
Files:
lib/CrossTU/CrossTrans
martong marked 2 inline comments as done.
martong added inline comments.
Comment at: test/Analysis/ctu-main.c:4
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o
%t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c
+// RUN: cp %S/Inputs/externalFnMap2.txt %t/ctudir2/exter
Szelethus added inline comments.
Comment at: test/Analysis/ctu-main.c:4
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o
%t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c
+// RUN: cp %S/Inputs/externalFnMap2.txt %t/ctudir2/externalFnMap.txt
+// RUN: %clang_cc1 -triple
martong marked an inline comment as done.
martong added inline comments.
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:247
llvm::Expected
CrossTranslationUnitContext::importDefinition(const FunctionDecl *FD) {
ASTImporter &Importer = getOrCreateASTImporter(FD->getASTConte
martong added a comment.
> Also, maybe it'd be worth making a CTU directory under test/Analysis for CTU
> related test files.
It is a good point, but I'd do that in the future once we have even more ctu
related test files. Perhaps together with a new check-clang-analysis-ctu build
target.
Re
martong added inline comments.
Comment at: test/Analysis/Inputs/ctu-other.c:6
+ int b;
+} foobar;
+
a_sidorin wrote:
> Please use a consistent naming style across the file. There are names
> starting with capital, having underscores and written like this.
Ok, I
martong updated this revision to Diff 176619.
martong marked 8 inline comments as done.
martong added a comment.
- Break long RUN lines
- Clang format the test files
- Use consistent naming style
- Remove braces
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55131/
a_sidorin added a comment.
Hi Gabor,
Please find my comments inline.
Comment at: lib/CrossTU/CrossTranslationUnit.cpp:251
+ cast_or_null(Importer.Import(const_cast(FD)));
+ if (!ToDecl) {
+return llvm::make_error(index_error_code::failed_import);
Cond
Szelethus added a comment.
Also, maybe it'd be worth making a CTU directory under `test/Analysis` for CTU
related test files.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55131/new/
https://reviews.llvm.org/D55131
Szelethus added inline comments.
Comment at: test/Analysis/ctu-main.c:3-5
+// RUN: %clang_cc1 -triple x86_64-pc-linux-gnu -emit-pch -o
%t/ctudir2/ctu-other.c.ast %S/Inputs/ctu-other.c
+// RUN: cp %S/Inputs/externalFnMap2.txt %t/ctudir2/externalFnMap.txt
+// RUN: %clang_cc1 -trip
martong created this revision.
martong added reviewers: xazax.hun, balazske, a_sidorin.
Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs.
Adding some more CTU list tests. E.g. to check if a construct is unsupported.
We also slightly modify the handling of the return va
13 matches
Mail list logo
