[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 537871. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/test/Headers/mm_malloc.c llvm/lib/Passes/PassBuilderPipelin

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. @nikic could you try running this over the rust tests again? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 ___ cfe-commits mailing l

[PATCH] D148654: Modify BoundsSan to improve debuggability

aeubanks added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3594 +TrapCall->addFnAttr(A); + } + TrapCall->setDoesNotReturn(); oskarwirga wrote: > vitalybuka wrote: > > wouldn't be you issues solved with > > TrapCall->setCannotMerge(

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks updated this revision to Diff 552889. aeubanks edited the summary of this revision. aeubanks added a comment. add warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158223/new/ https://reviews.llvm.org/D158223 Files: clang/include/cl

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

aeubanks added a comment. In D61670#4607313 , @mstorsjo wrote: >> I expected the answer would be "yes", so I said "lgtm" and then phrased my >> question very awkwardly. > > Ah, thanks for the clarification! > > Any opinion on the name, `-fno-autoimport` v

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D159000: Reland "[Profile] Allow online merging with debug info correlation."

aeubanks added a comment. looks fine to me but I'll let ellis lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159000/new/ https://reviews.llvm.org/D159000 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

aeubanks added a comment. I don't have all the context here, but seems fine once the commit description is updated with the new spelling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61670/new/ https://reviews.llvm.org/D61670

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

aeubanks added inline comments. Comment at: clang/test/OpenMP/amdgpu_exceptions.cpp:10 + +// RUN: %clang_cc1 -fopenmp -triple amdgcn-amd-amdhsa -fopenmp-is-target-device -fcxx-exceptions -fexceptions %s -emit-llvm -S -verify=with -Wopenmp-target-exception -analyze +// RUN: %cla

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D157518: Avoid running optimization passes in frontend test

aeubanks added inline comments. Comment at: clang/test/CodeGenCXX/attr-likelihood-if-branch-weights.cpp:147-148 -// CHECK: ![[PROF_LIKELY]] = !{!"branch_weights", i32 [[UNLIKELY]], i32 [[LIKELY]]} -// CHECK: ![[PROF_UNLIKELY]] = !{!"branch_weights", i32 [[LIKELY]], i32 [[UNLI

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

aeubanks added inline comments. Comment at: clang/test/ExtractAPI/bool.c:14 +//--- input.h +#include +bool Foo; clang tests should not be including system headers since that makes the tests non-hermetic (this test fails in our internal builds that provide more

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. please make the title of the commit say what the commit is actually doing rather than only reference a bug number, the bug number should be in the description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138426/new/ htt

[PATCH] D138426: Fix #58958 on github

aeubanks added a comment. In D138426#3946202 , @krsch wrote: > Should I change the title myself or you can change it during commit? If it's > on me, how do I change it? `git commit --amend; arc diff`? phabricator isn't very elegant, locally changing the

[PATCH] D137149: Use PassGate from LLVMContext if any otherwise global one

aeubanks accepted this revision. aeubanks added a comment. This revision is now accepted and ready to land. the precommit bot is still complaining that flang/lib/Frontend/FrontendActions.cpp needs to be updated lgtm if the precommit bot doesn't show anything related to this patch Repository:

[PATCH] D138626: [Vectorize] Remove legacy passes

aeubanks created this revision. Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, ormris, foad, kerbowa, hiraditya, jvesely, arsenm. Herald added a reviewer: ctetreau. Herald added a reviewer: ctetreau. Herald added a project: All. aeubanks requested review of this revision. Herald

[PATCH] D138628: [clang-fuzzer] Use new pass manager for optimizing IR

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, pcwang-thead. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D138628 Files: clang/tools/clang-fuzzer/ha

[PATCH] D138628: [clang-fuzzer] Use new pass manager for optimizing IR

aeubanks updated this revision to Diff 477658. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138628/new/ https://reviews.llvm.org/D138628 Files: clang/tools/clang-fuzzer/handle-llvm/handle_llvm.cpp Index: clang/

[PATCH] D136078: Use-after-return sanitizer binary metadata

aeubanks added inline comments. Comment at: clang/test/Instrumentation/SanitizerBinaryMetadata/common.h:1-3 +#include +#include +#include tests in `clang/test` cannot assume that standard headers are available, the tests should be hermetic. could you revert a

[PATCH] D66490: [NewPM] Enable the New Pass Manager by Default in Clang

aeubanks added a comment. In D66490#1638708 , @hfinkel wrote: > In D66490#1638162 , @rupprecht wrote: > > > We already know that we don't want this enabled for tsan builds due to > > https://bugs.llvm.org/show_bug.

[PATCH] D75643: Don't emit pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks added reviewers: rnk, thakis, Mordante. MSVC also warns on this: $ cat /tmp/a.c int f(void* p) { return (int) p; } $ cl /c /tmp/a.c C:/src/tmp/a.c(1): warning C4311: 'type cast': pointe

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks created this revision. aeubanks added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds warnings to groups recently added in https://reviews.llvm.org/D72231. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D75708 Files: clang

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks updated this revision to Diff 248610. aeubanks added a comment. - Add tests for void * Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75708/new/ https://reviews.llvm.org/D75708 Files: clang/lib/Sema/SemaCast.cpp clang/test/SemaCXX/Micr

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks marked an inline comment as done. aeubanks added a comment. > I can push this for you and even give attribution (hooray, git!), but I think > you have enough uploaded code reviews that you could request push access as > described here: > https://llvm.org/docs/DeveloperPolicy.html#new-c

[PATCH] D75708: Add warnings for casting ptr -> smaller int for C++ in Microsoft mode

aeubanks updated this revision to Diff 248614. aeubanks added a comment. - Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75708/new/ https://reviews.llvm.org/D75708 Files: clang/lib/Sema/SemaCast.cpp clang/test/SemaCXX/MicrosoftExtension

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aeubanks edited the summary of this revision. aeubanks added reviewers: thakis, rnk. aeubanks retitled this revision from "Move warnings added in https://reviews.llvm.org/D75708 under -Wmicrosoft

[PATCH] D75752: [Sema] Move pointer to int cast warnings under -Wmicrosoft-cast

aeubanks added a comment. Specifically regarding ../../base/debug/close_handle_hook_win.cc(155,16): error: cast to smaller integer type 'unsigned long' from 'void *', I sent out a change to fix that: https://chromium-review.googlesource.com/c/chromium/src/+/2091215, and tried compiling with ToT

[PATCH] D75643: [Sema] Don't emit pointer to int cast warnings under -Wmicrosoft-cast

This revision was automatically updated to reflect the committed changes. Closed by commit rG51d7f645448b: Don't emit pointer to int cast warnings under -Wmicrosoft-cast (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D75643?vs=248306&id=249203#toc Repository: rG LL

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses

aeubanks created this revision. aeubanks added a reviewer: yrouban. Herald added subscribers: ormris, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In p

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

aeubanks updated this revision to Diff 505169. aeubanks retitled this revision from "[StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved" to "[StandardInstrumentations] Verify function doesn't change if analyses are preserved". aeubanks edite

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

aeubanks updated this revision to Diff 505532. aeubanks edited the summary of this revision. aeubanks added a comment. rebase after cleanups fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146003/new/ https://reviews.llvm.org/D146003 Files

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

aeubanks added inline comments. Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1127 +if (!PassPA.allAnalysesInSetPreserved>()) return; nikic wrote: > Hm, aren't we going to skip the CFG check below if only CFGAnalyses are > preserved (but

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

aeubanks updated this revision to Diff 505539. aeubanks retitled this revision from "[StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-preserved-analyses" to "[StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation". aeubanks added a comment. re

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

aeubanks updated this revision to Diff 505558. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146069/new/ https://reviews.llvm.org/D146069 Files: clang/test/CodeGen/lto-newpm-pipeline.c llvm/lib/Passes/StandardI

[PATCH] D146069: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis-invalidation

This revision was automatically updated to reflect the committed changes. Closed by commit rG361cba22b201: [StandardInstrumentations] Rename -verify-cfg-preserved -> -verify-analysis… (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D146003: [StandardInstrumentations] Verify function doesn't change if analyses are preserved

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG20a7ea49f40e: [StandardInstrumentations] Verify function doesn't change if analyses are… (authored by aeubanks). Changed prior to commit: https://

[PATCH] D146163: Experimental new python bindings for clang/llvm based on Cython

aeubanks resigned from this revision. aeubanks added a comment. not familiar enough with python, but there should probably be an RFC for this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146163/new/ https://reviews.llvm.org/D146163 __

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks updated this revision to Diff 506813. aeubanks added a comment. Herald added subscribers: cfe-commits, ormris, wenlei, steven_wu. Herald added a project: clang. update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https:/

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks added a comment. In D145403#4175178 , @tejohnson wrote: > In D145403#4172268 , @aeubanks > wrote: > >> still need to update tests and make sure this doesn't regress anything, but >> sending out to make

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks updated this revision to Diff 507052. aeubanks added a comment. assert not full lto postlink Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 Files: clang/test/CodeGen/thinlto-distributed-newpm.

[PATCH] D145265: [WIP][Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 507053. aeubanks added a comment. Herald added subscribers: cfe-commits, ormris, wenlei, steven_wu. Herald added a project: clang. rebase, update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added inline comments. Comment at: llvm/test/Transforms/PhaseOrdering/X86/pr52289.ll:9 ; CHECK-NEXT: if.end: +; CHECK-NEXT:[[TMP0:%.*]] = add i32 [[A:%.*]], 1 +; CHECK-NEXT:[[CONV:%.*]] = and i32 [[TMP0]], 8 aeubanks wrote: > this is an instcom

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks created this revision. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC makes these string literals [1][2]. [1] https://godbolt.org/z/6vnTzbExx [2] https:

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy, I

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks updated this revision to Diff 500987. aeubanks added a comment. move HasHiddenLTOVisibility DLL code to AlwaysHasLTOVisibilityPublic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 Files: clang

[PATCH] D146003: [StandardInstrumentations] Check that the number of instructions doesn't change if analyses are preserved

aeubanks created this revision. Herald added subscribers: ormris, ChuanqiXu, wenlei, steven_wu, hiraditya. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. CoroCleanup was running Simpl

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks created this revision. aeubanks added a reviewer: tejohnson. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. aeubanks requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks updated this revision to Diff 533627. aeubanks marked an inline comment as done. aeubanks added a comment. update test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153468/new/ https://reviews.llvm.org/D153468 Files: clang/include/clang

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

aeubanks added inline comments. Comment at: clang/test/CodeGen/verify-each.c:5 +// RUN: %clang_cc1 -O2 -o /dev/null -triple x86_64-unknown-linux-gnu -emit-llvm-bc %s -fdebug-pass-manager 2>&1 | FileCheck %s --check-prefix=NO +// NO-NOT: Verifying + tejohnson wro

[PATCH] D153468: [clang][LTO] Add flag to run verifier after every pass

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda7f212f4a7a: [clang][LTO] Add flag to run verifier after every pass (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D146987: [Assignment Tracking] Enable by default

aeubanks added a comment. IR that passes the verifier generally shouldn't crash llvm, so an alternative would be to make a verifier check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 _

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 513335. aeubanks added a comment. Herald added a subscriber: martong. use IgnoreParens instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include

[PATCH] D148268: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks created this revision. Herald added a subscriber: martong. Herald added a reviewer: shafik. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. MSVC makes these string literals [1][2]. [1] https:/

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 513337. aeubanks added a comment. add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.h clang/include/clang/AST/Ignor

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:3586-3591 + // MSVC treats all predefined expressions as string literals rather than char + // arrays. + if (LangOpts.MicrosoftExt) +return SL; + return PredefinedExpr::Create(Context, Loc, ResTy, I

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 513728. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: llvm/lib/Passes/PassBuilderPipelines.cpp llvm/test/Feature/optnon

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 513731. aeubanks edited the summary of this revision. aeubanks added a comment. fix clang test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/test/Co

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. In D145265#4225332 , @asbirlea wrote: > Nit: the diffs would be easier to analyze with "-fno-discard-value-names". done, see commit description the IR diffs look pretty good now, I'm not seeing any major regressions Repositor

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

aeubanks added a comment. `not` will set `LLVM_DISABLE_SYMBOLIZATION` if we use `not --crash` are these tests supposed to crash or gracefully fail? if they're supposed to crash then we should use `not --crash` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks added a comment. I was trying to get this landed with https://reviews.llvm.org/D145265 so I could measure the impact of the two together. But also now there are some merge conflicts that I'd rather deal with after submitting D145265 . But that patch is

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

aeubanks updated this revision to Diff 524406. aeubanks added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 Files: llvm/lib/Passes/PassBuilderPipelines.cpp llvm/test/Other/new-pm-p

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

This revision was automatically updated to reflect the committed changes. Closed by commit rG13e3d4aa5a4e: [Pipeline] Don't run EarlyFPM in LTO post link (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://revie

[PATCH] D151479: [clang] Use IgnoreParensSingleStep in more places

aeubanks created this revision. aeubanks added a reviewer: rsmith. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Addresses a post-commit comment on D146764 . Reposi

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. __clang_hip_math.hip is annoying... We'll need to remove the `MandatoryFirst` inliner in `ModuleInlinerWrapperPass`, although not sure if @mtrofin has any issues with that or not This isn't quite what I had initially thought, but this might be better. (I was thinking

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116080 , @aemerson wrote: > In D143624#4115986 , @aeubanks > wrote: > >> __clang_hip_math.hip is annoying... >> >> We'll need to remove the `MandatoryFirst` inliner in >> `M

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116171 , @mtrofin wrote: > In D143624#4115986 , @aeubanks > wrote: > >> __clang_hip_math.hip is annoying... >> >> We'll need to remove the `MandatoryFirst` inliner in >> `Mo

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. In D143624#4116318 , @aemerson wrote: > Sure, the exponential compile time case is actually just a side benefit here. > The motivating reason for this change is actually to improve code size when > building codebases that make

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. Had a chat offline with @mtrofin, wanted to be clear for future purposes that we do need the separate AlwaysInliner pass because it's used in -O0 and constructing a call graph there is non-trivial in terms of compile time. Originally the mandatory mode of the normal in

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1082 + MPM.addPass(AlwaysInlinerPass(/*InsertLifetimeIntrinsics=*/false)); + aeubanks wrote: > I think we want to insert lifetime intrinsics when optimizing this will never be

[PATCH] D143624: Inlining: Run the legacy AlwaysInliner before the regular inliner.

aeubanks added a comment. (my latest comments didn't get addressed in the land) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143624/new/ https://reviews.llvm.org/D143624 ___ cfe-commits mailing list cfe

[PATCH] D144027: [NFC][IR] Make Module::getGlobalList() private

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/unittests/IR/ModuleTest.cpp:49 EXPECT_FALSE(std::is_sorted(M.global_begin(), M.global_end(), compare)); -M.getGlobalList().sort(compare); -

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D142584: [CodeGen] Add a boolean flag to `Address::getPointer` and `Lvalue::getPointer` that indicates whether the pointer is known not to be null

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:67 return; -// Currently the max supported alignment is much less than 1 << 63 and is +// Currently the max supported alignment is much less than 1 << 32 and is // guaranteed to be a power

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

aeubanks created this revision. aeubanks added reviewers: hans, thakis. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. With recent MSVC releases, STL headers will add /INFERASANLIBS to the drec

[PATCH] D144686: [CodeGen] Remove the template specialization of `Address` that stores alignment information into pointers

aeubanks added inline comments. Comment at: clang/lib/CodeGen/Address.h:28 -// We try to save some space by using 6 bits over two PointerIntPairs to store -// the alignment. However, some arches don't support 3 bits in a PointerIntPair -// so we fallback to storing the alignmen

[PATCH] D144684: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc07867dc999: [clang][Driver] Pass /INFERASANLIBS:NO to link.exe under -fsanitize=address (authored by aeubanks). Repository: rG LLVM Github Monor

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

aeubanks added a comment. In D149800#4317275 , @mtrofin wrote: > high level question, why not have it as a pass that runs after profiles (of > whatever kind - instrumented or sample-based) are ingested. The pass would > attribute functions as described.

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks updated this revision to Diff 519613. aeubanks added a comment. only diagnose if we're initializing an array Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 Files: clang/include/clang/AST/Expr.

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. added a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG856f384bf945: [clang] Make predefined expressions string literals under -fms-extensions (authored by aeubanks). Changed prior to commit: https://r

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks reopened this revision. aeubanks added a comment. This revision is now accepted and ready to land. the following crashes with this patch: struct StringRef { StringRef(const char *); }; template StringRef getTypeName() { StringRef s = __func__; } `clang -cc1 -fms-exten

[PATCH] D149800: [WIP][PGO] Add ability to mark cold functions as optsize/minsize/optnone

aeubanks added a comment. In D149800#4330831 , @davidxl wrote: > This patch uses a cleaner method than the previous effort. There is some > differences: > > 1. yamauchi's patch works for both iFDO and autoFDO, while this patch limits > to iFDO > 2. yama

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

This revision was automatically updated to reflect the committed changes. Closed by commit rG878e590503df: Reland [clang] Make predefined expressions string literals under -fms-extensions (authored by aeubanks). Changed prior to commit: https://reviews.llvm.org/D146764?vs=520204&id=521039#toc

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/ThinLTO/X86/public-type-test.ll:31 ; HIDDEN-NOT: call {{.*}}@llvm.public.type.test ; HIDDEN: call {{.*}}@llvm.type.test sho

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 523175. aeubanks added a comment. rebase keep the existing EarlyCSE/InstCombine ordering Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/test/Headers

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks updated this revision to Diff 523182. aeubanks edited the summary of this revision. aeubanks added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145265/new/ https://reviews.llvm.org/D145265 Files: clang/

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added inline comments. Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:476 + FPM.addPass(EarlyCSEPass()); + nikic wrote: > Why the extra EarlyCSE pass in the `O1` pipeline? forgot to update the commit message, see that Comment

[PATCH] D150645: [Driver] Support multi /guard: options

aeubanks added a comment. this causes `./build/rel/bin/clang-cl /c /tmp/a.cc /Fo/tmp/a /guard:cf,nochecks` to go from no warnings to clang-cl: warning: argument unused during compilation: '/guard:cf,nochecks' [-Wunused-command-line-argument] Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D150645: [Driver] Support multi /guard: options

aeubanks added a comment. if you add a test for the repro, relanding lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://reviews.llvm.org/D150645 ___ cfe-commits mailing list cfe-commi

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D145265: [Pipeline] Remove GlobalCleanupPM

aeubanks added a comment. this regresses clang/test/Headers/mm_malloc.c (added here ) because we now don't run instcombine before the inliner, and we lose return value alignment info when inlining. perhaps this is still a tradeoff worth making Repository: r

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

aeubanks created this revision. Herald added a project: All. aeubanks requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Clang was writing paths to the dependency file that don't exist when using a sysroot with symlinks, causing every

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

aeubanks added a comment. Herald added a subscriber: bd1976llvm. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129700/new/ https://reviews.llvm.org/D129700 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D129700: [clang] Don't emit type tests for dllexport/import classes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf34ecb50e2c0: [clang] Don't emit type tests for dllexport/import classes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D146764: [clang] Make predefined expressions string literals under -fms-extensions

aeubanks added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146764/new/ https://reviews.llvm.org/D146764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D149187: [clang] Canonicalize system headers in dependency file when -canonical-prefixes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f0dd4ef3ed2: [clang] Canonicalize system headers in dependency file when -canonical-prefixes (authored by aeubanks). Repository: rG LLVM Github M

<    1   2   3   4   5   6   7   8   >