Re: [chromium-dev] License implications on Chromium's design

2010-01-18 Thread Dan Kegel
On Mon, Jan 18, 2010 at 3:22 PM, Jerome Leclanche adys...@gmail.com wrote: My question bears on a different level: is the UI layout (not code) somewhat restricted in any way? I'm no lawyer, nor do I know much about interface licensing. IANAL, but if you're not copying any images, and are just

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Dan Kegel
On Wed, Jan 13, 2010 at 9:12 AM, Stephen White senorbla...@chromium.org wrote: 2)  Most of the supposed performance advantage of strict aliasing rules is probably taken care of by memory disambiguation in modern (ie., Core2 and later) CPUs. I kind of doubt that. Disallowing aliasing lets the

Re: [chromium-dev] seeking c++ expertise for a tiny tricky bit of code

2010-01-13 Thread Dan Kegel
On Wed, Jan 13, 2010 at 9:42 AM, Evan Martin e...@chromium.org wrote: With that in mind I think we should explicitly use -fno-strict-aliasing until someone is willing to take the time to run buildbots, track down regressions, etc. +1 for -fno-strict-aliasing until someone fixes most/all of the

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

2010-01-05 Thread Dan Kegel
On Tue, Jan 5, 2010 at 9:13 PM, n179911 n179...@gmail.com wrote: For this test case defined in unload_test.cc: TEST_F(UnloadTest, CrossSiteInfiniteBeforeUnloadSync) {...} i have tried:  ./out/Debug/automated_ui_tests --gtest_filter='CrossSiteInfiniteUnloadSync' ./out/Debug/base_unittests

Re: [chromium-dev] How to compile and run TabSwitchingUITest on Linux

2010-01-05 Thread Dan Kegel
On Tue, Jan 5, 2010 at 9:23 PM, n179911 n179...@gmail.com wrote: Thanks. but It still said '0 tests ran' $ out/Debug/tab_switching_test --gtest_filter=UnloadTest.CrossSiteInfiniteBeforeUnloadSync Note: Google Test filter = UnloadTest.CrossSiteInfiniteBeforeUnloadSync [==] Running 0

Re: [chromium-dev] Faster linking for chromium on ubuntu

2009-12-31 Thread Dan Kegel
On Thu, Dec 31, 2009 at 3:14 PM, n179911 n179...@gmail.com wrote: And I have put 'shared' library in my include gypi file $ more ~/.gyp/include.gpyi {'variables': {   'library': 'shared_library', }} How can I make sure that it is building in shared library and using the gold linker? I

Re: [chromium-dev] Trybot to run WebKit's LayoutTests?

2009-12-17 Thread Dan Kegel
I have had problems trying to install both 2005 and 2008, not sure why, probably dueling service packs? On Dec 17, 2009 9:14 AM, Dominic Mazzoni dmazz...@google.com wrote: Is there a WebKit trybot? I'm working on a small WebKit patch (https://bugs.webkit.org/show_bug.cgi?id=32571), but my test

[chromium-dev] buildbot cycle time dashboard?

2009-12-08 Thread Dan Kegel
Hey folks, I seem to recall we have a dashboard somewhere showing the cycle time of each of our build/test bots, but I can't find it. Can somebody point me to it? If it doesn't exist, maybe I'll scrape one together. Thanks... -- Chromium Developers mailing list: chromium-dev@googlegroups.com

Re: [chromium-dev] Chromium arm native compile error on ubuntu.

2009-12-07 Thread Dan Kegel
Do you have flex installed? On Mon, Dec 7, 2009 at 5:59 AM, Richard Zhao linux...@gmail.com wrote: I'm using chromeos build script build_chrome.sh. Error log:  RULE webcore_bindings_sources_binding_39 out/Release/obj/gen/webcore/ bindings/ V8DocumentType.cpp Traceback (most recent call

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-07 Thread Dan Kegel
On Mon, Dec 7, 2009 at 10:29 AM, oshima osh...@chromium.org wrote: I filed bugs and made CL below. Dan, may I send this to you? http://codereview.chromium.org/466047 Sure, I'd be happy to review. Please replace abc with the real bug number ... oddly, there wasn't one, so I just filed 29598 for

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-07 Thread Dan Kegel
It's d...@chromium.org. On Dec 7, 2009 11:21 AM, oshima osh...@chromium.org wrote: On Mon, Dec 7, 2009 at 10:52 AM, Dan Kegel d...@kegel.com wrote: On Mon, Dec 7, 2009 at 10:29 ... Thanks. Is it dke...@google.com, right? Please replace abc with the real bug number ... oddly

Re: [chromium-dev] gcl commit throwing SVN server error

2009-12-03 Thread Dan Kegel
Sounds like you're trying to commit to the read-only repo? On Thu, Dec 3, 2009 at 3:31 PM, Zelidrag Hornung zelid...@chromium.org wrote: When I try to commit my change, I am getting following error there - any ideas what might be causing this? gcl commit my_change Presubmit checks took 1.7s to

Re: [chromium-dev] gcl commit throwing SVN server error

2009-12-03 Thread Dan Kegel
from your working copy:       #data/really_large_component: None,     },     safesync_url: http://chromium-status.appspot.com/lkgr;   }, ] On Thu, Dec 3, 2009 at 3:48 PM, Dan Kegel d...@kegel.com wrote: Sounds like you're trying to commit to the read-only repo? On Thu, Dec 3, 2009 at 3

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-01 Thread Dan Kegel
On Tue, Dec 1, 2009 at 2:30 PM, oshima osh...@chromium.org wrote: Looks like there are more tests that failing in valgrind test. ... This is not good. Is there any issue if we make a valgrind test fail when the test itself fails? If not, I'd suggest that we exclude them in ui_tetsts.gtext.txt

Re: [chromium-dev] Warning message when running chrome in gdb

2009-11-28 Thread Dan Kegel
Might not hurt to build from the latest sources and make sure they haven't fixed it already, too. On Sat, Nov 28, 2009 at 5:57 AM, Craig Schlenter craig.schlen...@gmail.com wrote: You could file a bug with the gdb people ... keeping a copy of the problematic binary/associated libraries may help

Re: [chromium-dev] Re: NameError: name 'ffmpeg_asm_lib' is not defined

2009-11-26 Thread Dan Kegel
2009/11/26 Maciej Bliziński blizin...@google.com: How is src/third_party/WebKit/WebCore/WebCore.gypi supposed to arrive there, is it generated? No, it's in svn. d...@dank-pc /cygdrive/c/users/dank/Documents/chromium/src/third_party/WebKit/WebCore $ svn info Path: . URL:

Re: [chromium-dev] building without svg

2009-11-16 Thread Dan Kegel
On Mon, Nov 16, 2009 at 12:33 AM, Evan Martin e...@chromium.org wrote: My Release Linux build stripped is 39.5mb.  (The size bots show ~44mb, which I think is a Chrome vs Chromium thing.  It is curious how the Windows binary is nearly half the size of the Linux or Mac one.) ... And like I had

Re: [chromium-dev] Warning about missing newline

2009-11-16 Thread Dan Kegel
On Mon, Nov 16, 2009 at 7:22 PM, Peter Kasting pkast...@google.com wrote: Does this warning help anyone, anywhere, for any reason? .h files that are missing newlines cause nasty and confusing errors on some platforms, IIRC. -- Chromium Developers mailing list: chromium-dev@googlegroups.com

Re: [chromium-dev] Warning about missing newline

2009-11-16 Thread Dan Kegel
On Mon, Nov 16, 2009 at 7:31 PM, Peter Kasting pkast...@google.com wrote: Yeah, and are our preprocessors actually going to do what's described in that post?  I'm sure MSVC won't.  I doubt gcc on Mac/Linux will. This was a real issue for me with gcc a few years ago (at Google, IIRC). - Dan --

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-15 Thread Dan Kegel
I think not. On Sun, Nov 15, 2009 at 12:04 PM, PhistucK phist...@gmail.com wrote: I am using Visual Studio 2005 (Express) and I downloaded the Windows SDK 7 websetup - it mentions there Visual C++ Compilers and in the description, it says Installs the Visual C++ 9.0 Compilers. Do I need it?

Re: [chromium-dev] Any interest in command line tools for network stack?

2009-11-13 Thread Dan Kegel
I like the idea. On Fri, Nov 13, 2009 at 11:58 AM, Chris Bentzel cbent...@gmail.com wrote: I'm using them as a learning exercise for the network stack - and I'm guessing that they will help debug behavior in the future as well. I don't intend to add additional functionality over the standard

Re: [chromium-dev] Any interest in command line tools for network stack?

2009-11-13 Thread Dan Kegel
On Fri, Nov 13, 2009 at 12:25 PM, Peter Kasting pkast...@google.com wrote: Should I spend time trying to flesh these out and add to net/tools, or is this something which doesn't belong in the chromium codebase? I'm weakly against the idea, since adding dependencies increases the burden when

[chromium-dev] Any chromium developer have a citibank account?

2009-11-10 Thread Dan Kegel
http://code.google.com/p/chromium/issues/detail?id=15876 is a report of a memory leak that happens if you're timed out while logged in to citicards.com and the tab is not in front. Can someone with an account there try to reproduce? Thanks... -- Chromium Developers mailing list:

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-10 Thread Dan Kegel
On Mon, Nov 9, 2009 at 6:21 PM, Dominic Jodoin dominic.jod...@gmail.com wrote: I just wanted to share with you all that I've succeeded in compiling Chrome using Visual C++ 2008 Express Edition and ATL 7.1 bundled with the Windows Driver Kit (WDK). I've wrote a blog post that gives the details

[chromium-dev] Re: German Translation

2009-11-08 Thread Dan Kegel
On Sun, Nov 8, 2009 at 7:15 PM, Peter Kasting pkast...@google.com wrote: To be clear, the Chromium codebase doesn't use community-contributed translations.  However, our help center exists in many languages, including German ( http://www.google.com/support/chrome/?hl=de ), and

[chromium-dev] Re: Failed to run gclient runhooks --force.

2009-11-08 Thread Dan Kegel
On Sun, Nov 8, 2009 at 6:27 PM, James Su su...@chromium.org wrote:   I tried to run gclient runhooks --force in a new copy of chromium code, but got following error: If nobody gives better advice, I'd suggest just moving the old tree aside and getting a new one overnight :-( That's what I had

[chromium-dev] Re: How much RAM needed to get past linking? (Linux)

2009-11-03 Thread Dan Kegel
On Tue, Nov 3, 2009 at 1:01 AM, 黒鉄章 ak...@yayakoshi.net wrote: This gold sounds good, although if I want to install it on Fedora I note that there isn't package (yet) and the src/build/install-build-deps.sh script is apparently only for Ubuntu 8/9 Patches to fix this would be welcome. so I

[chromium-dev] Can't build chrome; NameError: name '_toolset' is not defined. Can't sync webkit. :-(

2009-11-03 Thread Dan Kegel
I get NameError: name '_toolset' is not defined while loading dependencies of base/base.gyp while loading dependencies of app/app.gyp while loading dependencies of build/all.gyp while trying to load build/all.gyp when building or even just running 'gclient runhooks --force'. Also, when I do

[chromium-dev] Re: Can't build chrome; NameError: name '_toolset' is not defined. Can't sync webkit. :-(

2009-11-03 Thread Dan Kegel
On Tue, Nov 3, 2009 at 9:21 AM, Evan Martin e...@chromium.org wrote: On Tue, Nov 3, 2009 at 8:06 AM, Dan Kegel d...@kegel.com wrote: NameError: name '_toolset' is not defined while loading dependencies when building or even just running 'gclient runhooks --force'. Also, when I do 'gclient

[chromium-dev] Re: Why is Linux Chrome so fast?

2009-10-28 Thread Dan Kegel
On Wed, Oct 28, 2009 at 8:05 AM, Evan Martin e...@chromium.org wrote: 3) Startup time is faster than calculator. I'm not sure if you're kidding.  Do you mean Windows calculator? On my home linux box (Jaunty, reasonably fast), warm startup time of chrome is less than the warm startup time of

[chromium-dev] Re: Is there any plan to support Visual Studio 2010? (Current in Beta 2)

2009-10-27 Thread Dan Kegel
On Tue, Oct 27, 2009 at 9:00 PM, mht mhsien.t...@gmail.com wrote: Some information about Visual Studio 2010. But question first: Is there any plan (long term / short term) to support it? It would probably be a good idea, eventually. If anyone wants to write an msbuild backend for gyp, have at

[chromium-dev] Re: Unkown Error During Building Chromium for Linux

2009-10-06 Thread Dan Kegel
What linker are you using? Have you tried installing and using gold? Which targets fail? Can you at least build base and base_unittests? Also, next time you save a log, be sure to save *both* stdout and stderr, e.g. make foo log 21 --~--~-~--~~~---~--~~

[chromium-dev] Re: Paper about DRAM error rates

2009-10-06 Thread Dan Kegel
On Tue, Oct 6, 2009 at 4:59 PM, John Abd-El-Malek j...@chromium.org wrote: The point I was trying to make is that the 'limit' factor as you put it is proportional to memory usage.  Given our large memory consumption in the browser process, the numbers from the paper imply dozens of corruptions

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Dan Kegel
On Sat, Oct 3, 2009 at 10:19 AM, Peter Kasting pkast...@google.com wrote: I checked in a commit this morning (27949) which caused linking errors for Linux.  I got undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups in a function which had already been using that constant

[chromium-dev] Re: [Linux] How did I just fix the build?

2009-10-03 Thread Dan Kegel
On Sat, Oct 3, 2009 at 11:07 AM, Dan Kegel d...@kegel.com wrote: undefined reference to BlockedPopupContainer::kImpossibleNumberOfPopups Aha. It's a bug in our code. chrome/browser/blocked_popup_container.cc needs to follow through and actually declare storage for that variable

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Dan Kegel
On Fri, Oct 2, 2009 at 3:44 PM, Jacob Mandelson ja...@mandelson.org wrote: There are multiple, concurrent writers to the socket. If you make assumptions about the kernel's behaviour, you might be able to come up with a workable framing protocol, but it's much better to use the correct

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Dan Kegel
On Fri, Oct 2, 2009 at 4:02 PM, Jacob Mandelson ja...@mandelson.org wrote: Which reads like all or nothing to me, though I could imagine a (perverse?) implementation with each writer having a send buffer lower layer pulling data from multiple writers' send buffers in an interleaved manner.  

[chromium-dev] Re: Why SOCK_SEQPACKET?

2009-10-02 Thread Dan Kegel
On Fri, Oct 2, 2009 at 4:25 PM, Steve Vandebogart vand...@chromium.org wrote: (I think PIPE_BUF is 64K on modern Linux, but might be smaller elsewhere.) I seem to recall that pipe buf is a page and /usr/include/linux/limits.h says #define PIPE_BUF        4096 Yeah, I got PIPE_BUF and pipe

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

2009-10-01 Thread Dan Kegel
It's not supposed to be that way... maybe we need to check in a new cygwin. On Thu, Oct 1, 2009 at 4:03 PM, vha14 vuh...@gmail.com wrote: So it looks like I need to install Cygwin separately before I can build Chrome? If so this should be added to the Windows build instruction page. On Oct

[chromium-dev] Re: [Memory] in TCMalloc, more careful handling of VirtualAlloc commit via SystemAlloc

2009-09-30 Thread Dan Kegel
On Wed, Sep 30, 2009 at 11:09 AM, Peter Kasting pkast...@google.com wrote: I would trade away 3% perf on a benchmark for 500 MB less RAM usage without hesitation or any additional testing. +1 thestig is setting up a linux perf bot right now that will be configured with a tiny amount of system

[chromium-dev] Re: Error in using gclient

2009-09-28 Thread Dan Kegel
On Sat, Sep 26, 2009 at 6:23 PM, Marc-Antoine Ruel mar...@chromium.org wrote: Something disable a trick we use to download a zip file containing svn and uncompressing it. You can do it manually since it's one time process. See for the details:

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Dan Kegel
Does our default build really depend on -msse2 anymore? Doesn't seem to on linux... 2009/9/22 Ujjwol (उज्जवल लामिछाने) ujjwollamichh...@gmail.com: This (http://code.google.com/p/chromium/wiki/LinuxPackaging) page says that For silly reasons our default build depends on SSE, but we don't

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Dan Kegel
',                  '-msse2',                  '-mfpmath=sse',                ],              }],            ], http://code.google.com/p/chromium/issues/detail?id=8475 On Wed, Sep 23, 2009 at 11:00 AM, Dan Kegel d...@kegel.com wrote: Does our default build really depend on -msse2 anymore

[chromium-dev] Re: Chromium Without SSe2

2009-09-23 Thread Dan Kegel
It's so our tests pass, I think. On Wed, Sep 23, 2009 at 11:20 AM, Mark Mentovai m...@chromium.org wrote: Is there a reason we gate this on branding?  The comment doesn't speak to that at all. Evan Martin wrote: The code doesn't lie:           'conditions': [              

[chromium-dev] Re: Is it possible to customize CXXFLAGS and CFLAGS when generating make file or invoking make?

2009-09-22 Thread Dan Kegel
On Tue, Sep 22, 2009 at 12:07 AM, James Su su...@chromium.org wrote:   I'd like to compile chromium with some special CFLAGS/CXXFLAGS, how can I do? I'm using make build on 64bit Linux. Yes, e.g. create ~/.gyp/include.gypi { 'variables': { 'release_extra_cflags': '-g',

[chromium-dev] this webpage is not available

2009-09-22 Thread Dan Kegel
After hitting this message about twenty times over the last couple days, and getting pinged by various people about it, I went looking for a corresponding bug report. The closest match seems to be http://crbug.com/22623 so I updated that and marked it high priority.

[chromium-dev] I wish IE8 installed as fast as chrome...

2009-09-19 Thread Dan Kegel
Chrome installs in finite time, whereas (judging by how long my Vista box has been saying installing IE8) IE8 seems to require infinite time to install. I don't know how many people actually sit there and wait for software updates to finish, but lordy, watching ie8 update is like watching paint

[chromium-dev] Re: I wish IE8 installed as fast as chrome...

2009-09-19 Thread Dan Kegel
doesn't.  They know they'll get it on your box under all circumstances.  So they just don't care.  Sad. Think about the man-years (or man-lives) lost waiting for IE8 installs around the world! Mike On Sat, Sep 19, 2009 at 6:48 PM, Dan Kegel d...@kegel.com wrote: Chrome installs in finite time

[chromium-dev] Re: [linux] unmount bug

2009-09-18 Thread Dan Kegel
OK, I asked on that thread. On Fri, Sep 18, 2009 at 8:53 AM, Paweł Hajdan Jr. phajdan...@chromium.org wrote: Can we ask him to submit strace of chrome when it happens? On Fri, Sep 18, 2009 at 08:40, Evan Martin e...@chromium.org wrote: The cause of the problem is Google Chrome for Linux:

[chromium-dev] Chromium core principles and multiplatform development?

2009-09-10 Thread Dan Kegel
An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what windows developers are for.) He said that none of the doc at

[chromium-dev] Re: Chromium core principles and multiplatform development?

2009-09-10 Thread Dan Kegel
:03, Dan Kegel d...@kegel.com wrote: An external contributor was recently surprised that a change tested on linux was reverted because it broke the build on windows. (His mental model was that linux developers don't have to worry about other platforms, that's what windows developers

[chromium-dev] Re: How to extract .sln and .vcproj files from chrome.gyp

2009-09-04 Thread Dan Kegel
On Thu, Sep 3, 2009 at 5:45 AM, 子朝 王wzcpri...@gmail.com wrote: How to extract .sln and .vcproj files from chrome.gyp? I have added depot_tools, python bin, svn to my PATH, but when I create a bat file: gclient runhooks --force pause and run it, I always got nothing You could try

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Dan Kegel
On Wed, Aug 26, 2009 at 12:28 PM, Darin Fisherda...@chromium.org wrote: I've heard people proclaim the principle of being able to copy a profile across systems as being a deciding factor for certain changes (e.g. the history epoch change). However, it doesn't seem to be universally held or

[chromium-dev] Re: Copying of profiles across systems

2009-08-26 Thread Dan Kegel
On Wed, Aug 26, 2009 at 12:59 PM, Jeremy Orlowjor...@chromium.org wrote: I really like the idea of being able to move people between operating systems and just bringing the profile along without having to export and import... (seems to me there are online services that offer that

[chromium-dev] Re: Cross-compiling on ARM

2009-08-21 Thread Dan Kegel
On Fri, Aug 21, 2009 at 1:43 PM, Antoine Labourpi...@google.com wrote: - Gyp uses pkg-config to find includes/lib dependencies, i.e. it's going to look at the host for them. If your target distribution matches your host maybe you're fine, but it may not work at all, so it'd would be good to

[chromium-dev] linux dev channel crashing on first login to gmail today?

2009-08-19 Thread Dan Kegel
Has anyone else experienced chrome crashes on linux today? I'm on the dev channel (3.0.198.1) and both at home and at work it crashed on me when I tried to log in to gmail the first time. Hasn't crashed thereafter. --~--~-~--~~~---~--~~ Chromium Developers

[chromium-dev] Re: Does Chromium use boost library

2009-08-16 Thread Dan Kegel
I think we haven't quite drunk the boost koolaid. We turn off rtti and exceptions, too. On Aug 16, 2009 12:42 AM, n179911 n179...@gmail.com wrote: Hi, Does Chromium use boost library? In the source tree, i see there is a 'boost' directory under 'third-party'. It appears to be an incomplete

[chromium-dev] Re: Tree hygiene

2009-08-14 Thread Dan Kegel
Maybe that should automatically close the tree... On Fri, Aug 14, 2009 at 2:07 PM, Lei Zhangthes...@chromium.org wrote: Do we have a warning for when the difference between the ToT revision number and LKGR pass a certain threshold? On Fri, Aug 14, 2009 at 8:00 AM, Marc-Antoine

[chromium-dev] Re: Allocator Choice

2009-08-12 Thread Dan Kegel
On Tue, Aug 11, 2009 at 8:25 PM, Mike Belshembel...@google.com wrote:  Unlike Obama's plan for healthcare, this CL is about giving you more choice. Political comments are off-topic for this list, I think. --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] v8 update caused test shell tests crash?

2009-08-12 Thread Dan Kegel
Hi plesner, have you seen http://build.chromium.org/buildbot/waterfall/builders/Webkit%20(dbg)(1) in the last hour or so? It looks like LayoutTests/http/tests/security/cross-frame-access-protocol.html is reliably crashing since the v8 update to trunk/1.3.3 in

[chromium-dev] Re: lan manager in cloud

2009-08-11 Thread Dan Kegel
And are you looking to hire somebody to do the work? (That's what I seem to gather from your hourly comment.) On Tue, Aug 11, 2009 at 3:23 PM, Jeremy Orlowjor...@chromium.org wrote: Even with the translation, it's difficult to understand what you're saying and asking.  Chromium has a full

[chromium-dev] Re: Flakiness. Please help.

2009-08-06 Thread Dan Kegel
On Wed, Aug 5, 2009 at 9:44 PM, Peter Kastingpkast...@google.com wrote: * Yes, even purify, valgrind, and reliability bot redness.  If you can't figure out what to do with these, try pinging erikkay for purify issues and huanr for reliability issues.  (Not sure who a good general valgrind

[chromium-dev] Strange periodic popup window on 3.0.196.0 on Linux?

2009-08-06 Thread Dan Kegel
Ever since updating to 3.0.196.0, I've seen a blank window pop up and go away periodically (once an hour or so?). Anyone else seen that? --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or

[chromium-dev] Re: Dev Chrome crashes on subsequent starts after installing a theme

2009-08-06 Thread Dan Kegel
Evan wrote about this earlier: A few people have found their trunk builds crashing on startup. This comes from a bug in theme loading and can bite you if you installed some of the in-development themes. The fix is to rm -rf your Extensions directory out of your profile directory. The next release

[chromium-dev] PluginTest.Refresh is hanging purify every time

2009-08-06 Thread Dan Kegel
Hi Erik, PluginTest.Refresh is hanging purify every time, ever since http://build.chromium.org/buildbot/waterfall/builders/Webkit%20(purify)/builds/9777 two days ago. Want me to file a bug / disable it? --~--~-~--~~~---~--~~ Chromium Developers mailing list:

[chromium-dev] Re: Idea for next valgrind/purify fixit week: just delete the suppressions and watch the tree go red

2009-08-06 Thread Dan Kegel
On Thu, Aug 6, 2009 at 4:38 PM, Peter Kastingpkast...@google.com wrote: i.e. Next time we hold a valgrind fixit, how about we just delete the non-upstream-bugs suppressions files? I think this would be a mistake. There is a lot of accumulated knowledge in the valgrind suppresions file.  

[chromium-dev] Re: Idea for next valgrind/purify fixit week: just delete the suppressions and watch the tree go red

2009-08-06 Thread Dan Kegel
On Thu, Aug 6, 2009 at 4:48 PM, Peter Kastingpkast...@google.com wrote: I told Ben this morning that I'm taking ownership of the flakiness problem, and I meant it.  I will do my best to harass people.  Next on my list is going to every single subteam meeting and making noise at all of them.

[chromium-dev] Re: gyp failing while triggering gclient sync in linux with git

2009-08-06 Thread Dan Kegel
Please check to make sure the python scripts have UNIX line endings, not DOS ones. --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Re: How to debug Aw, Snap! error

2009-08-06 Thread Dan Kegel
On Thu, Aug 6, 2009 at 9:43 PM, n179911n179...@gmail.com wrote: When I load a page on chromium that I run on debugger,I get 'Aw, Snap! What page? My question is how can i debug problem like this? Is there a stack trace or core dump for situation like this? If you installed the dev channel

[chromium-dev] Re: Mystery error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353.

2009-08-05 Thread Dan Kegel
On Tue, Aug 4, 2009 at 5:14 PM, Adam Langleya...@chromium.org wrote: On Tue, Aug 4, 2009 at 5:11 PM, Peter Kastingpkast...@google.com wrote: That is probably coming from the allocator underneath Chrome (presumably the one provided by the OS kernel).  It probably means you have memory

[chromium-dev] Re: [POSIX] Reworking our child process reaping

2009-08-05 Thread Dan Kegel
Sounds good to me. It's nice living in the future and being able to rely on things like signalfd! - Dan p.s. I wrote a man page of sorts for that wy back in the past, before it existed: http://lkml.indiana.edu/hypermail/linux/kernel/0106.3/0404.html On Wed, Aug 5, 2009 at 12:12 PM, Adam

[chromium-dev] Re: Trick question: Who is responsible for repairing a red tree?

2009-08-05 Thread Dan Kegel
On Wed, Aug 5, 2009 at 2:45 PM, Tim Steelet...@chromium.org wrote: you have to keep asking, unless you're always on IRC and can cleverly search the window contents.  A constant place to go looking for this would make it easier, at least in my opinion.  Like right now I don't know what's up

[chromium-dev] Re: Trick question: Who is responsible for repairing a red tree?

2009-08-05 Thread Dan Kegel
On Wed, Aug 5, 2009 at 2:49 PM, Peter Kastingpkast...@google.com wrote:  Like right now I don't know what's up with Chromium Mac (valgrind) or Webkit dbg (12) to name a few; they're red but the tree is open. If you ever see a case like this, go ahead and close the tree yourself until you get

Re: generated files in the tree (was Re: [chromium-dev] Fwd: Make workers functional on OSX and Linux.)

2009-08-04 Thread Dan Kegel
On Tue, Aug 4, 2009 at 10:18 AM, Dirk Prankedpra...@chromium.org wrote: On Tue, Aug 4, 2009 at 10:10 AM, Darin Fisherda...@chromium.org wrote: I think we need to make it possible for the buildbots to run in a mode where there are absolutely no generated files output into the source directory.

[chromium-dev] Mystery error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353.

2009-08-04 Thread Dan Kegel
Twice now (three days ago and today) I got the error Assertion failed: (slab-magic == SLAB_MAGIC), function slab_alloc, file x-alloc.c, line 353. while running the ui tests under valgrind on the mac... and I can't figure out where it's coming from. I've grepped through the chromium and valgrind

[chromium-dev] new hunspell has tons of valgrind warnings... revert?

2009-08-01 Thread Dan Kegel
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/1671/steps/valgrind%20test:%20unit/logs/stdio introduces 26 new unintialized memory references and two leaks. That's a big enough batch that it might be a good idea to revert it and commit something later

[chromium-dev] Re: new hunspell has tons of valgrind warnings... revert?

2009-08-01 Thread Dan Kegel
On Sat, Aug 1, 2009 at 4:10 PM, Mohamed Mansourm0.interact...@gmail.com wrote:  I am trying to learn about valgrind through the documentation, http://dev.chromium.org/developers/how-tos/using-valgrind, and it seems its Linux related, so I booted in Linux and installed all the valgrind tools.

[chromium-dev] Re: PSA: Consider upgrading to VS2008.

2009-08-01 Thread Dan Kegel
Yeah. How about a presubmit check? (only half joking) On Sat, Aug 1, 2009 at 9:41 PM, PhistucKphist...@gmail.com wrote: I am either wrong or just out of context here, but O3D has added another mentioning of ATL in their code -

[chromium-dev] Re: [BUG][PATCH] Small compilation issue on Linux

2009-07-30 Thread Dan Kegel
That's the third such cl I've seen. Conclusion: tiny fixes like that should be committed as tbr to avoid duplication of effort. On Jul 30, 2009 12:44 PM, Wan-Teh Chang w...@google.com wrote: On Thu, Jul 30, 2009 at 12:13 PM, LivioSoareslivi...@gmail.com wrote: Hi,I'm running... Thanks a

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Dan Kegel
On Mon, Jul 27, 2009 at 11:53 AM, Mark Mentovaim...@chromium.org wrote: I think i'll work on studying the current build system to figure out how to implement a CMake one. That's fine.  Let us (including me) know what you come up with. In particular, a CMake backend for gyp might be cool. -

[chromium-dev] Re: CMake for chromium

2009-07-27 Thread Dan Kegel
reported problem, pain on for example xcode or kdevelop users. What is the problem, again? Does the OP want xcode or kdevelop to run gyp when the user starts a build? On Mon, Jul 27, 2009 at 5:24 PM, Steven Knights...@google.com wrote: What's the coolness here? On Mon, Jul 27, 2009 at 11:58 AM, Dan

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 4:56 AM, Mark Mentovaim...@chromium.org wrote: An objdir-ish solution would make sense, except the native build systems we use don't really work in terms of objdirs, so we'd just wind up generating a parallel directory structure with nothing but xcode projects,

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 2:28 PM, Darin Fisherda...@chromium.org wrote: An objdir-ish solution would make sense, except the native build systems we use don't really work in terms of objdirs, so we'd just wind up generating a parallel directory structure with nothing but xcode projects,

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 9:07 AM, Thomas Van Lententhoma...@chromium.org wrote: Here's my christmas wish: I'd like gyp and chrome to support cross-compilation, so that I could (on my Linux box) kick off distcc-accelerated builds for all three platforms, each one going into a separate objdir.

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 9:15 AM, Thomas Van Lententhoma...@chromium.org wrote: The other thing to remember is the buildbot scripts and a bunch of build scripts on all platforms are full of assumptions about the relationships between projects and the tree.  :( Well, yes. I didn't say it would

[chromium-dev] new valgrind mandatory if you use chrome_tests.sh

2009-07-23 Thread Dan Kegel
If you don't run tools/valgrind/chrome_tests.sh, you can ignore this message. tools/valgrind/chrome_tests.sh now uses the --show-possible option to valgrind. This option isn't in standard valgrind, so bad things will happen if you haven't run tools/valgrind/build-valgrind-for-chrome.sh to

[chromium-dev] Re: new valgrind mandatory if you use chrome_tests.sh

2009-07-23 Thread Dan Kegel
On Thu, Jul 23, 2009 at 10:55 PM, Dan Kegeld...@kegel.com wrote: If you don't run tools/valgrind/chrome_tests.sh, you can ignore this message. tools/valgrind/chrome_tests.sh now uses the --show-possible option to valgrind.  This option isn't in standard valgrind, so bad things will happen if

[chromium-dev] valgrind updated

2009-07-22 Thread Dan Kegel
If you don't run valgrind, you can probably ignore this. tools/valgrind/build-valgrind-for-chromium.sh has been updated. Used to be, if you had gold as your system linker, it would generate a valgrind that couldn't even valgrind /bin/true. It's now a bit smarter, and won't build or install a

[chromium-dev] Re: valgrind updated

2009-07-22 Thread Dan Kegel
. -- Evan Stade On Wed, Jul 22, 2009 at 8:53 PM, Paweł Hajdan Jr.phajdan...@chromium.org wrote: Seems like a good news, but why should I use this script instead of regular valgrind? I don't know the difference. On Wed, Jul 22, 2009 at 20:39, Dan Kegel d...@kegel.com wrote: If you don't run

[chromium-dev] Re: avoiding compile failures on buildbot

2009-07-22 Thread Dan Kegel
That's consistent with trybots doing debug builds. Uninitialized var warnings only show up in optimized builds, nothing we can do there but turn on optimizations. On Thu, Jul 23, 2009 at 2:00 AM, Andrew Scherkusscher...@chromium.org wrote: On a related note, Frank (cc'd) ran into an issue where

[chromium-dev] Generating files in source tree considered harmful

2009-07-22 Thread Dan Kegel
Stop me if you've heard this one before. Today, a new directory was added to the source tree, and shortly thereafter was reverted. Should have been no problem, but... because the new directory contained a gyp file, a file was generated in that directory, and svn couldn't delete the directory

[chromium-dev] Re: Generating files in source tree considered harmful

2009-07-22 Thread Dan Kegel
On Thu, Jul 23, 2009 at 4:15 AM, Mark Larson (Google)m...@chromium.org wrote: Should have been no problem, but... because the new directory contained a gyp file, a file was generated in that directory, and svn couldn't delete the directory when the revert landed. This caused a build breakage,

[chromium-dev] Re: Chromium crash

2009-07-20 Thread Dan Kegel
OK, how about a backtrace? On Mon, Jul 20, 2009 at 8:24 PM, Thiago Farinathiago.far...@gmail.com wrote: Yes, I'm compiling the code under debug build option. Everytime I try to type in omnibox this happens. On Jul 20, 4:02 pm, Scott Hess sh...@chromium.org wrote: Looks to me like the code

[chromium-dev] Re: valgrind help office hours

2009-07-20 Thread Dan Kegel
On Tue, Jul 21, 2009 at 2:04 AM, John Abd-El-Malekj...@chromium.org wrote: I have a leak after a check-in.  I tried following the instructions on my Linux box, but couldn't (I hardly develop on Linux). jabdelma...@jabdelmalek:/usr/local/google/chrome/src$ sh tools/valgrind/chrome_tests.sh 

[chromium-dev] Re: hammer base_unittests failed

2009-07-19 Thread Dan Kegel
On Sun, Jul 19, 2009 at 10:15 AM, empriserxueyunl...@gmail.com wrote: /home/chrome/src/skia/ext/bitmap_platform_device_linux.cc: In static member function 'static skia::BitmapPlatformDevice* skia::BitmapPlatformDevice::Create(int, int, bool, uint8_t*)':

[chromium-dev] Please help fix Chromium crash/leak bugs this week

2009-07-18 Thread Dan Kegel
Dear Chromium developers, more and more people are trying Chrome on Mac and Linux... so it behooves us to really focus on stability. We put a bunch of work into getting the Valgrind buildbots green and on the main waterfall lately, so new bugs will be caught quickly... but that involved

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Dan Kegel
TThomas Van Lententhoma...@chromium.org wrote: We're already running at -O1 on Linux, so there isn't much improvement left to be had, I suspect. =A0 It might be worth it, dunno. There is a lot of code cut out by being NDEBUG instead of DEBUG, that's where I think the mac is getting its speed

[chromium-dev] Re: Mac Valgrind Bots

2009-07-17 Thread Dan Kegel
Right, we use -O1 instead of -O2 or -O0 with valgrind; it strikes a good balance between good stack and speed. On Jul 17, 2009 9:46 AM, Erik Kay erik...@chromium.org wrote: On Fri, Jul 17, 2009 at 8:12 AM, Nicolas Sylvain nsylv...@chromium.org wrote: On Fri, Jul ... One other tradeoff to

[chromium-dev] Re: Memory usage in chrome

2009-06-27 Thread Dan Kegel
On Sat, Jun 27, 2009 at 2:50 PM, Linus Upsonli...@google.com wrote: If I recall correctly, the best way we found to measure the total memory usage of a multi-process system like chrome was to measure the total commit charge of windows as you run the test. My favorite test is to plot the

[chromium-dev] Re: What's the real reason of giving up Windows 2000 support?

2009-06-26 Thread Dan Kegel
Is eComstation the OS/2 that dare not speak its name? :-) On Fri, Jun 26, 2009 at 6:50 AM, Itaiida...@chromium.org wrote: Feel free to make an eComstation port though, 2.0 is about to be released, plus its not that different from any other OS ;) - Itai On Jun 23, 12:48 pm, Elliot

  1   2   >