Re: [chromium-dev] PrefsService shared with OffTheRecordProfile

2009-11-30 Thread John Gregg
rtain preferences as origin-specific preferences rather than just overall browser settings? Then the off-the-record PrefsService could filter those out and not persist? -John On Wed, Nov 25, 2009 at 6:35 PM, Peter Kasting wrote: > On Wed, Nov 25, 2009 at 11:38 AM, John Gregg wrote: >

Re: [chromium-dev] PrefsService shared with OffTheRecordProfile

2009-11-25 Thread John Gregg
On Wed, Nov 25, 2009 at 12:26 PM, Peter Kasting wrote: > On Wed, Nov 25, 2009 at 12:14 PM, Adam Barth wrote: > >> On Wed, Nov 25, 2009 at 11:38 AM, John Gregg wrote: >> > if you whitelist an >> > origin for popups while in incognito mode, that origin is whitelis

[chromium-dev] PrefsService shared with OffTheRecordProfile

2009-11-25 Thread John Gregg
Hi, I was investigating how notifications should work in incognito mode, and came across the fact that the PrefsService for the incognito profile is the same one as the real profile. In some ways I guess that makes sense, since it's state about *how* the user uses the browser, not what the user i

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-09 Thread John Gregg
thing like what content > scripts do with ports. > > What are the proposals for this under discussion? > > Thanks for your help. > > Marcos > > On Thu, Nov 5, 2009 at 6:22 PM, Marcos Aruj wrote: > >> Ok, done: http://www.crbug.com/26859 >> >> I attach

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-11-05 Thread John Gregg
y on it now or if we should wait. >> >> Thanks! >> >> Marcos >> >> On Tue, Oct 20, 2009 at 11:04 AM, Darin Fisher wrote: >> >>> OK, that sounds reasonable to me. >>> -Darin >>> >>> >>> On Tue, Oct 20, 2009 at

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-20 Thread John Gregg
;> >> On Mon, Oct 19, 2009 at 11:25 AM, Ian Fette wrote: >> >>> We're trying to come up with a way to display html notifications on these >>> platforms, once we get the windows one checked in. (Likely code that we will >>> have to write.) >>&g

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-19 Thread John Gregg
I've posted the (draft) API spec to http://sites.google.com/a/chromium.org/dev/developers/design-documents/desktop-notifications/api-specification . -John On Mon, Oct 19, 2009 at 11:58 AM, Marcos Aruj wrote: > Hi all, > Thanks for your answer. > > @John Gregg, We would really

[chromium-dev] Re: [chromium-extensions] Re: Desktop Notifications

2009-10-19 Thread John Gregg
The implementation of notifications is nearly complete for Windows chromium with the final pieces being reviewed right now. Hopefully it will be available on the dev channel very soon behind a command-line switch for developers to start using. If you have questions about the specifics of the API,

[chromium-dev] Re: buildbot failure in Chromium on Linux Builder (Views dbg), revision 28054

2009-10-05 Thread John Gregg
Looks like a merge problem with my recent change to render_messages.h regarding WebPreferences. I can submit a fix. -John On Mon, Oct 5, 2009 at 3:03 PM, wrote: > http://build.chromium.org/buildbot/waterfall/ > > Automatically closing tree for "compile" on "Linux Builder (Views dbg)" > > > ht

[chromium-dev] Changed WebKit build flags, may require clobber after sync

2009-10-05 Thread John Gregg
Hi all, I checked in a change yesterday which sets ENABLE_NOTIFICATIONS=1 for the Chromium build of WebKit (in features_override.gypi). If you sync up and are seeing linking errors regarding notifications, this should be fixed by rebuilding WebCore. Some of the build bots seem to be fine, but oth

[chromium-dev] Re: desktop notifications, preliminary code for review

2009-08-05 Thread John Gregg
; > -Ben > > On Wed, Aug 5, 2009 at 4:13 PM, Evan Martin wrote: > > > > On Wed, Aug 5, 2009 at 4:00 PM, Evan Martin wrote: > >> On Wed, Aug 5, 2009 at 3:51 PM, John Gregg wrote: > >>> As I mentioned to some of you offline, I would greatly appreciate a >

[chromium-dev] Re: desktop notifications, preliminary code for review

2009-08-05 Thread John Gregg
7;ll update the doc to discuss the linux plan. -John On Wed, Aug 5, 2009 at 4:13 PM, Evan Martin wrote: > On Wed, Aug 5, 2009 at 4:00 PM, Evan Martin wrote: > > On Wed, Aug 5, 2009 at 3:51 PM, John Gregg wrote: > >> As I mentioned to some of you offline, I would greatly apprec

[chromium-dev] desktop notifications, preliminary code for review

2009-08-05 Thread John Gregg
Hi all, I'm still waiting for my WebKit patch which creates the Desktop Notification API to be reviewed and get checked in, but since it may yet be a while I posted some of the chromium-side code at http://codereview.appspot.com/104044/. As I mentioned to some of you offline, I would greatly appr

[chromium-dev] Re: sandboxing external libraries (like Growl)

2009-06-18 Thread John Gregg
sible, than pass that to the browser to invoke the library. Thanks, -John On Thu, Jun 18, 2009 at 2:24 PM, Adam Langley wrote: > On Thu, Jun 18, 2009 at 1:58 PM, John Gregg wrote: > > B. renderer gets notification(iconURL, text) call => hop to browser to > > download icon =&

[chromium-dev] sandboxing external libraries (like Growl)

2009-06-18 Thread John Gregg
Hi all, I'm working on a desktop notifications javascript API for web apps; on Mac these calls will go out to the Growl notification system if it's installed and user has granted permission to get notifications from that origin. I'm still trying to completely grasp the sandbox architecture, so th

[chromium-dev] Re: RenderViewHost::LoadAlternateHTMLString

2009-05-22 Thread John Gregg
aka the "error" pages. > > Elsewhere in Chrome we just hook up fake network providers and > navigate webkit to magic urls like "chrome://newtab/". You can read > the code for those to see how they work. > > On Fri, May 22, 2009 at 3:17 PM, John Gregg wrote: > >

[chromium-dev] RenderViewHost::LoadAlternateHTMLString

2009-05-22 Thread John Gregg
I'm trying to load a static HTML string into a small render view (for the purpose of desktop notifications), and I came across the method RenderViewHost::LoadAlternateHTMLString, which, based on the name, sounds like what I want. I have things working the way I want if I call rvh->NavigateToURL(ur

[chromium-dev] Run-Time Check Failures

2009-05-16 Thread John Gregg
I'm synced to 16009 (which is the latest good change according to http://build.chromium.org/buildbot/continuous/LATEST/REVISION), and I got everything built, but when I run Chromium under Visual Studio I get an endless stream of: Run-Time Check Failure #2 - Stack around the variable 'bitmap' was