On Wed, Jan 20, 2010 at 22:38, Eric Roman wrote:
> Omaha doesn't support manual authentication for proxies, so if your
> squid proxy is requiring a username/password that could be the
> problem.
Yes, I know about this problem (it's documented in the help message
linked when the installer finishes
I have a local squid proxy and on Windows machines using it the Chrome
installer never finishes (I can download the first, small .exe which
then initializes and tries to download the main installer). When not
using squid it works fine. When using other proxies like tinyproxy, it
also works fine. Bu
On Wed, Jan 13, 2010 at 23:01, Chris Evans wrote:
> On Wed, Jan 13, 2010 at 8:36 AM, Evan Martin wrote:
>> Since the proposed vulnerability is that I have cd'ed into a specially
>> crafted malicious directory then type out "google-chrome
>> some-particular-url", at which point I will end up at a
Michał, Chris: could you comment on security aspects and give some
recommendations?
Ben, could you comment on the "user interaction / usability" aspect?
We have few choices here, I'm not sure which one is preferred.
On Mon, Jan 11, 2010 at 23:23, Benjamin Smedberg wrote:
> For what it's worth, t
Is there any security risks with passing raw ftp listings to the
renderer in case we can't parse them? We already have a check in the
code so that we will only make a data connection to the server we have
the control connection with.
If it's ok to do so, I'd also like to include some message encou
We have http://crbug.com/4436, and the problem is that if you launch
chrome index.html (with index.html in the current directory) it will
try to navigate to http://index.html/ instead. This behavior is useful
for cases like chrome www.google.com, and generally I don't see a good
solution to this is
On Sat, Dec 19, 2009 at 02:25, Drew Wilson wrote:
> Is there another way to do it? Perhaps ui_test should register its own
> NotificationObserver with the AutomationProvider framework? Or is that a
> bogus approach?
I'd really suggest starting with a browser_test instead. It's much
easier to writ
I was thinking about many DirectoryWatcher problems, especially on
Linux, and now noticed http://crbug.com/20832.
User scripts are the only user of DirectoryWatcher. DirectoryWatcher
has many quirks - on Windows it behaves in a weird way on XP so we
can't test it reliably (and hits the disk on UI
Looks like the browser_tests launcher needs to be updated, because its
exit code was 1 (that's why the bot went red).
On Fri, Dec 18, 2009 at 04:33, Lei Zhang wrote:
> Does FLAKY_ work on all tests? The test run [1] for my most recent
> check-in turned a bot red, even though the only test that fa
On Thu, Dec 17, 2009 at 03:22, Drew Wilson wrote:
> The closest thing I found to what I want is the LoginPromptTest ui_tests,
> but these seem only to work on Windows because the automation framework
> doesn't yet support NotificationType::AUTH_NEEDED on anything but windows:
> ERROR:/Volumes/sour
On Mon, Dec 14, 2009 at 21:23, Andrew Scherkus wrote:
> I wrote up this section under our Tree Sheriff page:
> http://dev.chromium.org/developers/tree-sheriffs#TOC-Disabling-tests
Thanks! I expanded the section to also mention the FLAKY_ prefix
(which is very helpful in keeping the tree green and
I am author of that code, so if it's causing flaky failures I'm
obviously not happy.
So here is my explanation: there is a race. One running Chrome process
has the socket open. When the second browser process starts, it also
opens the socket. And in the test we're seeing a situation when both
have
Thanks so much! It's nice to learn some things about webkit. Some ideas for
the next round of talks:
- how sandboxing works on Linux and Mac
- ChromeFrame internals (how it interacts with IE, ExternalTab magic etc)
- performance tests
- Valgrind and ThreadSanitizer
- plugins in the multi-process a
On Tue, Dec 8, 2009 at 00:19, Mark Mentovai wrote:
> Is this thought to be http://crbug.com/29240, or are there other
> problems with the signal handler? The change to fix that is out at
> http://codereview.chromium.org/460094.
I'm not sure. The failures are not deterministic. If I see some ne
On Mon, Dec 7, 2009 at 22:34, Glenn Wilson wrote:
> Evan
>
> Triaging Linux Jank bugs. Probably not many that are actionable right
now, though.
That's not exactly Jank issue, but on a lot of our bots we're getting
leftover processes on Linux. It seems they don't respond properly to
SIGTERM. This
I hit at least few cases when I broke the views and/or chromeos buildbot
with a CL which doesn't touch the views code directly (which would trigger
submitting it to the views trybot). Today another change in a gypi file
triggered a compile failure on views bots, while all other trybots have been
so
Just FYI, I checked in a patch to disable the test isolation for
net_unittests.
The thing is, it exposed further problems with the tests. I will investigate
that offline. Sorry for a day of increased flakiness. I hope it will pay off
in the future with less debugging mysteries with Singletons etc.
On Wed, Dec 2, 2009 at 19:24, Aaron Boodman wrote:
> The first prompt is not shown when you install from the gallery, so
> for 99% of cases users won't see it.
>
Ah, sounds great. By the way, I'm really happy how extensions in Chrome work
in general. Instant installation etc. And one can even se
Just compiled Chromium Linux from trunk and downloaded the sample buildbot
extension. I got two warnings while doing this:
- when downloading, that the file might be dangerous and hurt my computer -
do I want to continue
- and second, whether I want to install the extension
It may be a better use
On Tue, Dec 1, 2009 at 09:09, Darin Fisher wrote:
> It might help the discussion if you could toss out a proposal for what you
> think might work.
>
My initial idea is an object (ResourceQueue? ResourceWaitQueue?) that the
RDH will ask before starting an URLRequest (similar to how it currently a
Currently we don't start the request in ResourceDispatcherHost until the
user script is ready (or not needed). UserScriptListener handles that. We
also wait for SafeBrowsing, Plugins, etc. We're going to wait for
PrivacyBlacklists.
I was thinking about refactoring RDH so that it would be easy to p
Could you document that on some Mac wiki page on code.google.com/p/chromium?
This way if anyone decides to use Xcode editor at any time will see this
handy tip.
On Mon, Nov 30, 2009 at 21:31, Dave MacLachlan wrote:
> If you don't ever use Xcode as an editor, don't ever want to use Xcode as
> an e
Some progress report on that: now BlacklistManager is integrated with
Profile (each Profile has its BlacklistManager).
Things remaining to be done (can be in parallel):
- validating the privacy blacklists on extension install (quite easy)
- pausing the user-initiated requests until the blacklist i
On Wed, Nov 25, 2009 at 22:33, Tim Steele wrote:
> There are only a couple places where WebCore tells the client that the
>> title changed (looks like 3, search FrameLoader for
>> dispatchDidReceiveTitle). There are conditionals wrapping each such call
>> and also, in some cases, wrapping the me
On Wed, Nov 25, 2009 at 20:57, Tim Steele wrote:
> It seems like the test should wait for the title to update, and not the
> navigation to finish.
I'm pretty sure it's not a waiting problem. I followed what the test does
manually, and I could still reproduce the issue. I also checked with
debug
On Wed, Nov 25, 2009 at 00:07, Evan Stade wrote:
> sounds like http://crbug.com/22560
Thanks for finding it. /me votes for removing the Mstone-X label from it,
bumping priority to Pri-2, adding a FlakyTest label and details about
SessionHistoryTest.LocationReplace, and finally closing the Sessi
A little background: SessionHistoryTest.LocationReplace rarely fails on the
buildbot (isn't even on the flakiness dashboard), but seems to be #1 flaky
test on the trybot, where it fails almost every time (or so it seems to me).
It also reproduces very consistently on my Windows VM, so we have a goo
On Fri, Nov 20, 2009 at 23:34, Darin Fisher wrote:
> We could define a function that must be called before you can use code in
> base/. You could add a call to this everywhere that we currently create the
> AtExitManager. Or, maybe we could combine those somehow.
Thanks for the ideas! That in
On Sat, Nov 21, 2009 at 19:52, Chris Bentzel wrote:
> Have there been any thoughts about adding gcl patch and unpatch commands
> which will grab the file diffs as well as duplicate the CL metadata in
> src/.svn/gcl_info?
>
It's not trivial to correctly apply a patch in svn (file moves, property
On Mon, Nov 23, 2009 at 02:22, Marc-Antoine Ruel wrote:
> It's really about the unit tests, not in chromium.
>
> I guess we could probably leak the singleton in the unit tests too on
> each reset. Pawel, what do you think?
>
> Note to all the static local makers: you create an implicit atexit()
>
Do you have some idea how to get rid of the Singletons in base/time_win.cc?
They don't play very well with base::SystemMonitor, MessageLoop, and test
code.
Here's the scenario we're hitting right now (in browser_tests):
1. HighResolutionTimerManager is created to enable high resolution timer
unco
On Fri, Nov 20, 2009 at 21:05, Evan Martin wrote:
> Your analysis is correct. However, a virtual destructor is not needed
> in the case where you never delete through the Base*. It turns out
> for our codebase that is very common (due to lots of "observer"-like
> patterns), so we decided to not
It turns out that WATCHLISTS aren't fully effective because git-cl doesn't
support them. It doesn't look very hard to implement the support for git-cl
because there is already a watchlists.py file, but then there are some
questions:
- should the watchlists.py file (from depot_tools) be copied to t
Not sure if that's related, but bugdroid started to behave strangely. I see
"new" comments for commits from before a week.
On Wed, Nov 18, 2009 at 20:27, Dirk Pranke wrote:
> Hi all,
>
> Just a heads' up ... we've discovered a bug in Issue Tracker that has
> caused a few of our issues (along wit
On Tue, Nov 17, 2009 at 20:43, Peter Kasting wrote:
> On Tue, Nov 17, 2009 at 11:40 AM, Evan Martin wrote:
>
>> Since we're talking about style, I'll note that this pattern is no
>> good (and I've seen it explicitly called out somewhere before).
>>
>> The problem is that your assertions are not
On Thu, Nov 12, 2009 at 21:28, Peter Kasting wrote:
> On Thu, Nov 12, 2009 at 12:13 PM, John Abd-El-Malek wrote:
>
>> per our chat on irc, I think if a new privacy blacklist is added while
>> running, it should be loaded on the file thread, and when it's available the
>> IO thread should be updat
On Thu, Nov 12, 2009 at 20:26, John Abd-El-Malek wrote:
> My question still stands: if this list is needed in order to process the
> first network request, why add extra complexity to RDH to make more things
> asynchronous, when either way any IO is basically blocked on the blacklist?
> You migh
I was just looking at the buildbot cycle stats at
http://build.chromium.org/buildbot/waterfall/stats and realized that on many
bots the most frequently failing tests are browser_tests and ui_tests.
Then I checked how early they are run by each bot (the earlier we know about
the failure, the earlie
On Thu, Nov 12, 2009 at 01:00, John Abd-El-Malek wrote:
> On Wed, Nov 11, 2009 at 1:22 PM, Paweł Hajdan Jr. > wrote:
>
>> To do that, I'd need to listen for BlacklistManager notifications in RDH
>> (on IO thread). Does it seem OK to make RDH a No
Initially I got an advice to use PauseRequest and ResourceHandler to wait
with servicing requests until all privacy blacklists are loaded. However,
there are problems with that.
When you look at ResourceDispatcher code, we need a Blacklist::Match* even
before creating URLRequest.
I thought about
Note however that you can build specific projects. When working on base or
net for example, you can build just base_unittests and net_unittests. When
working on webkity things, you can sometimes compile just the test_shell,
and not chrome.
--
Chromium Developers mailing list: chromium-dev@googleg
On Mon, Nov 9, 2009 at 5:03 PM, Dave MacLachlan wrote:
> > I haven't looked into it, but I'm assuming the reason it's so slow is
> > because of the bad DSYM parsing in Leopard. It should be much faster in
> Snow
> > Leopard, but that probably doesn't help you.
>
That's probably right. I haven't
On Thu, Oct 29, 2009 at 21:50, Paweł Hajdan Jr. wrote:
> - make ExtensionsService a BlacklistPathProvider and write a test which
> loads an extension and verifies that BlacklistManager notices that (I'm
> working on it now)
>
This is done. To clarify: you can't yet lo
Thanks for all answers! I think I'll use CarbonEmacs for editing (it's
great, my entire .emacs finally works) and Xcode for compiling. Aquamacs
just landed in the trash.
It's nice that Xcode supports some Emacs keybindings - I didn't know that.
--~--~-~--~~~---~--~
So, the problem with Extensions has been solved (thanks to Aaron), but
there's stil the original issue that may bite at any time (please see the
first message for context):
Is there a big difference between a Singleton and LazyInstance? I was
> thinking about making NPAPI::PluginList a Singleton i
On Wed, Nov 4, 2009 at 08:56, Aaron Boodman wrote:
> Why don't you pass an Extension instance?
It's in a test. Mocking an Extension is not trivial as well. :( Or maybe...
I didn't read all of the extensions unit tests, maybe it's not that hard.
> It seems like you are violating the contract o
I encountered another problem related to Singletons in unit tests.
PluginService is a Singleton, and it listens to extensions notifications. In
one of my tests when I was using the extensions notifications the
PluginService crashed because I passed NULL as the Extension* - because the
listener I wa
Recently I started working more and more on Mac OS X, and I'm trying to find
an editor that would work the best for me.
On Linux I used GNU Emacs with many customizations. Some of the most handy
ones for working on Chromium were Google Style script and launching the
compilation from the editor. I
On Mon, Nov 2, 2009 at 20:29, Mark Mentovai wrote:
> If you don't have that file, start looking at how things were checked out,
> and maybe try a "gclient sync --force".
Indeed, running client correctly fixed the issue. I was trying to be too
"smart" to save some time, but it didn't work (I cop
On Tue, Nov 3, 2009 at 19:08, Drew Wilson wrote:
> I've also been known to use the built-in GNU emacs from a terminal shell
> (especially when working remotely/SSH-ing). I see no reason why you can't
> have the same experience that you do with your Linux box, although you'd
> have to find a way t
On Tue, Nov 3, 2009 at 16:58, Evan Martin wrote:
> I'm not sure which news you're referring to. :)
To the one that the files are supposed to by svn-copied by git, that there
is a command to check for that, and that you offered to help in case of
problems. :)
--~--~-~--~~--
On Tue, Nov 3, 2009 at 06:50, John Abd-El-Malek wrote:
> *The solution*
> 1+2: Use ChromeThread::PostTask and friends (i.e. PostDelayedTask,
> DeleteSoon, ReleaseSoon) which are safe and efficient: no locks are grabbed
> if the target thread is known to outlive the current thread. The four
> sta
That's a good news. Can that info be put somewhere in the UsingGit wiki
page?
On Mon, Nov 2, 2009 at 23:56, Evan Martin wrote:
>
> On Mon, Nov 2, 2009 at 2:47 PM, Drew Wilson wrote:
> > I'm doing some refactoring in the chromium worker code, and I got the
> > following review feedback:
> > "sma
I'm getting this compile error when compiling on Ubuntu 9.04 (scons):
Compiling
/home/ph/chromium/src/sconsbuild/Debug/obj/libxslt/libxslt/libxslt/xsltutils.o
Generating version information
Creating library /home/ph/chromium/src/sconsbuild/Debug/lib/libxslt.a
Indexing /home/ph/chromium/src/sconsbu
If you have less than 1 GB of RAM, I wouldn't even try to link the biggest
binaries. 2 GB of RAM should be sufficient, although with 4 and more it's
better. And you will notice the change after switching to gold.
On Mon, Nov 2, 2009 at 18:58, Adam Langley wrote:
>
> On Fri, Oct 30, 2009 at 9:10
I think that the right fix is to switch interactive_ui_tests to
browser_tests launcher (jcampan did some great work to make the launcher
more flexible, it may be quite simple to do the switch now - if there are no
UI tests in interactive_ui_tests).
I also suggest bumping the priority of http://crb
st
On Mon, Oct 26, 2009 at 09:05, Paweł Hajdan Jr. wrote:
> Please don't make non-trivial changes to chrome/browser/privacy_blacklists
> if possible. I have a big change which I'll be soon (today) submitting for
> review. It will be needed to integrate
On Wed, Oct 28, 2009 at 16:35, Scott Violet wrote:
> I suspect this happens when the theme resources aren't correctly
> built. Perhaps we should have this check early on in ui tests so that
> we don't run any tests if this check fails.
Yeah, I was even thinking about a build step, right after t
On Wed, Oct 28, 2009 at 00:44, Ian Fette wrote:
> In an effort to provide more transparency into what the team is working on,
> I'm sending out the meeting notes from the green tree task force to
> chromium-dev, below. I will try to send further notes to chromium-dev from
> our meetings.
>
Sound
Please don't make non-trivial changes to chrome/browser/privacy_blacklists
if possible. I have a big change which I'll be soon (today) submitting for
review. It will be needed to integrate privacy blacklists with extensions.
--~--~-~--~~~---~--~~
Chromium Developers
I get this when compiling unit_tests on Mac OS X 10.6 Snow Leopard:
/Users/ph/chromium/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm:689:0
/Users/ph/chromium/src/chrome/browser/cocoa/
bookmark_bar_controller_unittest.mm:689: warning: 'stringWithCString:' is
deprecated (declared at
/
I'm going to use PauseRequest for privacy blacklists. It seems that I should
create a new ResourceHandler, and resource handlers seem to wrap another
resource handlers. Then I'd have to add code to use the new ResourceHandler
in ResourceDispatcherHost.
I'd need to write a ResourceHandler which woul
That fixed it, thanks!
On Fri, Oct 16, 2009 at 22:00, Marc-Antoine Ruel wrote:
> ... more hotfixes for you to install
>
> http://dev.chromium.org/developers/how-tos/build-instructions-windows
>
> On Fri, Oct 16, 2009 at 3:57 PM, Paweł Hajdan Jr.
> wrote:
> > I'm co
I'm consistently getting this error when linking (fails 57 times when
compiling the entire chrome.sln):
2>shell32.lib(shguid.obj) : fatal error LNK1103: debugging information
corrupt; recompile module
I'm using Visual Studio 2005, fresh checkout. Should I just try clobber?
--~--~-~--~
Today I reviewed some old bugs which didn't get any attention and tried to
correctly mark/assign/close them. Feel free to reassign a bug if I assigned
it to you - I was generally looking for people familiar with the area so
that they can decide what to do next (please not that the status of such
bu
You can read these:
http://dev.chromium.org/developers/testing
http://code.google.com/p/chromium/wiki/RunningChromeUITests
http://dev.chromium.org/developers/how-tos/reliability-tests
I also suggest reading code in src/chrome/test.
On Tue, Oct 13, 2009 at 09:21, Landon Xue wrote:
>
> HI,
>
> I
On Mon, Oct 12, 2009 at 20:53, Jeremy Orlow wrote:
> I think the bigger issue is how/when Area-Misc bugs get triaged. Do they
> ever? If not, we should probably change that.
I sometimes review old bugs and close those which no longer reproduce, and
ask for more details in case they're needed
On Fri, Oct 9, 2009 at 11:01, Jickae Davis wrote:
> Well, I agree with PhistucK. I think a progress bar may help though it's
> not so accurate.
>
> By the way, if I want to add such a bar with chromium, how should I start?
> Is there a method that tells the size of the resources to be loaded and
(adding people more familiar with the release process...)
On Wed, Oct 7, 2009 at 20:16, Amit Kishnani wrote:
>
> Hey Elliot,
>
> thanks for quick turnaround.
>
> the trunk (svn) : http://src.chromium.org/svn/trunk/src/chrome/VERSION is
>
> MAJOR=4
> MINOR=0
> BUILD=222
> PATCH=1
>
> but I am loo
On Wed, Oct 7, 2009 at 21:25, Jeremy Orlow wrote:
> I could't imagine many users understanding a feature like this much less
> finding it particularly useful.
>
That's right, an average user would be only confused. Just exposing this
info (cpu-hungriness) to extensions seems interesting.
> Wha
Just a while before one of my tabs (GMail) started using a lot of CPU time
(67% while I was compiling in the background). The browser and the system
were responsive at all times, but processing power was wasted.
We have a warning dialog for hanged renderers offering to kill them. What do
you think
On Wed, Oct 7, 2009 at 02:02, Nicolas Sylvain wrote:
> Once we start tagging the flaky tests, we will monitor the flakiness
> dashboard and make sure
> that a test that is no longer flaky has its FLAKY_ tag removed.
>
It may be a good idea to expand the number of tests listed in the flakiness
re
Confirmed. It is flaky. I'm going to disable it when I have a while. Feel
free to disable it earlier.
On Fri, Sep 25, 2009 at 14:19, Eric Roman wrote:
> Looks like FTPCacheURLCredentials is flaky; none of these changes touched
> that code...
>
>
> On Fri, Sep 25, 2009 at 2:14 PM, wrote:
>
>> ht
On Fri, Sep 25, 2009 at 05:26, Thomas Van Lenten wrote:
> On Thu, Sep 24, 2009 at 6:24 PM, Paweł Hajdan Jr. > wrote:
>
>> On Thu, Sep 24, 2009 at 12:24, Thomas Van Lenten
>> wrote:
>>
>>> Brad landed support for depending on all the python files that go in
On Thu, Sep 24, 2009 at 12:24, Thomas Van Lenten wrote:
> Brad landed support for depending on all the python files that go into
> grit, so that part would have worked. The not always rebuilding for .h
> files is the problem.
>
Does it mean we're missing some deps in the gyp files?
--~--~--
I don't
> think we depend on all the grit .py files. I think these changes are
> rare enough that we can just clobber as needed.
>
> On Thu, Sep 24, 2009 at 12:03 PM, Paweł Hajdan Jr.
> wrote:
> > We still have problems with resources, examples:
> &g
We still have problems with resources, examples:
[FATAL:tab_renderer.cc(132)] Check failed:
waiting_animation_frames->width() % waiting_animation_frames->height()
== 0.
[FATAL:image_operations.cc(373)] Check failed: rgb.width() == alpha.width().
[FATAL:resource_bundle_win.cc(155)] Check failed
On Tue, Sep 22, 2009 at 18:06, Dimitri Glazkov wrote:
> Today wasn't a happy day for p...@. He did a seemingly innocuous roll
> that broke the world: selenium, ui tests, layout tests. I am sure it
> was stressful and probably added unnecessary gray to his hair.
How about running ui and selenium
On Tue, Sep 22, 2009 at 17:40, Nicolas Sylvain wrote:
> 3 PM : two failing ui tests are disabled by the webkit sheriff
>
I was looking at the UI tests and it wasn't immediately obvious that a
webkit update might break them. Can we run all the UI tests on the webkit
canary bot? If that takes too l
What's the best way to attach the debugger to a browser started by a UI
test? How about doing that only in case of a crash?
I'm looking for solution both for Windows and Linux, so if you have good
techniques, it'd be really nice. I can even document them on the wiki, but
currently I'm using LOG sta
Can we ask him to submit strace of chrome when it happens?
On Fri, Sep 18, 2009 at 08:40, Evan Martin wrote:
>
> "The cause of the problem is Google Chrome for Linux: when I launch
> it, all removable devices attached to my pc are unmounted after 10-11
> seconds. Really strange..."
> http://foru
Updated daily, looks at 20 builds from different bots (20 from each bot).
On Thu, Sep 17, 2009 at 12:48, Lei Zhang wrote:
> How often is this updated? How many runs does it look at to calculate
> the test run times?
>
> On Thu, Sep 17, 2009 at 8:52 AM, Paweł Hajdan Jr.
>
The slowness dashboard is ready at
http://build.chromium.org/buildbot/slowness-report/
There are some problems with it (like garbage in test names), and it could
possibly display more data (like median and stddev), but it's generally
usable.
--~--~-~--~~~---~--~~
Ch
On Wed, Sep 16, 2009 at 17:22, Ian Fette wrote:
> Out of curiosity, could this be integrated in our testing framework to have
> less-flaky UI tests (at least for some subset of the functionality currently
> tested with UI tests)?
>
I don't have idea how to use it for that purpose. I can certainl
Looks like a good candidate for LinuxDebugging wiki page.
On Wed, Sep 16, 2009 at 17:04, Evan Martin wrote:
>
> http://chipx86.github.com/gtkparasite/
>
> We had looked into using parasite back in the early days, but I forgot
> about it due to 32/64-bit stuff.
> But now that we've grown up it's
You can mock the HostResolver to make it fail to resolve anything (possibly
except localhost). For examples, see HostResolver's unit tests and possibly
other places where it is used.
You can also make it fail to resolve specific hosts, which should also be
handy.
On Tue, Sep 15, 2009 at 13:54, TJ
Oops. I just noticed that Animation is now in src/app, which means no
NotificationService... do you have any more ideas?
On Fri, Sep 11, 2009 at 17:41, Evan Stade wrote:
> I would say take an approach similar to the View ID stuff. Make each
> animation user (optionally) set an ID on the animatio
> >
> >
> > On Mon, Aug 17, 2009 at 10:38 AM, Darin Fisher
> wrote:
> >> It would be great if the UI test framework printed out a stack trace
> when a
> >> [D]CHECK fails.
> >> -Darin
> >>
> >>
> >> On Mon, Aug 17, 2009 at 9:3
DevToolsSanityTest flips frequently between enabled and disabled. It seems
to be mostly caused by changes in WebKit. I see two nice ways to prevent
that:
- run the tests upstream on webkit.org bots (probably hard)
- run the tests on our webkit canary bot (should be doable)
What do you think?
--~-
I wonder if we could deal with animating parts of the browser (like find
window, bookmark bar, etc) just in one way: wait for a specified number of
animations to finish. The alternative is to add notification for each thing:
find window stopped animating, bookmark bar stopped animating, and so on.
I think it would be simpler to modify git-cl to know which git commit
corresponds to given svn revision.
On Fri, Sep 11, 2009 at 13:38, Yaar Schnitman wrote:
> Its easy to tell what is the last known good SVN revision for chrome:
> http://chromium-status.appspot.com/lkgr
>
> But what I need is t
On Thu, Sep 10, 2009 at 15:54, Chris Evans wrote:
> Sounds like a moderate amount of work. IMHO, it would be acceptable from a
> security standpoint to:
>
> 1) Fix any bugs turned up by fuzzing.
>
Even then, I'd need some way to verify the validity of the fixes. Mozilla
has some test data at
htt
If you want to help make Chromium better, read on. You probably know we're
developing a new FTP stack:
http://blog.chromium.org/2009/09/new-ftp-implementation-goes-live.html
Currently we're using directory listing parsing routines from Mozilla, but
the code is written in a very low-level style, whi
gt;>>>> ;) The rietveld change is at
>>>>> http://code.google.com/p/rietveld/source/detail?r=455, if anyone sends
>>>>> me a patch to make it work with multiple bug ids, I'd be happy to push it.
>>>>>
>>>>>
>>>&g
I like it! Like every feature which allows one to take a look under the
hood.
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
I think you can execute javascript with automation (see
chrome/test/automation/tab_proxy.h). It is possible to submit forms using
javascript.
If you want to add a new automation request, see
chrome/test/automation_messages{,_internal}.h and add a new message there.
Then add a new call to TabProxy t
On Thu, Sep 10, 2009 at 10:16, Dan Kegel wrote:
> In this case, the code may have been submitted by a committer
> without using the trybots (tsk, tsk). We don't currently mention
> the trybots on dev.chromium.org. Is it time to?
Submitting without trybots and breaking the compile? Doesn't lo
For me it was obvious, but if people are surprised by this, then improving
the documentation is probably a good idea.
Just curious... the change has been submitted to trybots before landing,
hasn't it?
On Thu, Sep 10, 2009 at 10:03, Dan Kegel wrote:
>
> An external contributor was recently surp
I just noticed that BUG=1234 lines are autolinked to the correct bug when
viewed in Rietveld (codereview.chromium.org). This is very useful, thanks!
--~--~-~--~~~---~--~~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email op
The bug is about a firewall forbidding the connection. Why the trick won't
work? If I can't connect to the PASV port, I'd try PORT, even on successful
PASV response.
On Wed, Sep 9, 2009 at 12:52, Michal Zalewski wrote:
> >> I can't think of any. It would be nice to have active support. I'm not
1 - 100 of 210 matches
Mail list logo
