problems with this, please let me know.
Keith
ChangeLog
2007-07-19 Keith Seitz [EMAIL PROTECTED]
* classpath/gnu/classpath/jdwp/value/StringValue.java
(StringValue): Tag of StringValue is STRING not OBJECT.
(write): String values are written to the wire as tag byte
Kyle Galloway wrote:
2007-05-11 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/ReferenceTypeCommandSet
(executeMethods): Remove cast to ClassReferenceTypeId.
Questions/Issues?
Good catch. Please commit.
Keith
Kyle Galloway wrote:
ChangeLog
2007-05-08 Kyle Galloway [EMAIL PROTECTED]
* vm/reference/VMFrame.java (init): Add a parameter for the this
pointer of the frame.
Questions/Issues?
Not with your patch! Please commit.
Thank you for digging through this.
Keith
and class), but
Sun's HotSpot VM does not do it this way. It sends a packet for each event.
Largely it is a refactoring of the old code.
Keith
ChangeLog
2007-05-03 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/Jdwp.java (notify): Rewrite to call
new array-based method
Hi,
Despite my original assessment of how all this would unfold,
LocationOnlyFilter.matches *does* need to be properly implemented. This
patch does just that.
Keith
ChangeLog
2007-04-27 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/filters/LocationOnlyFilter.java
debug will set a CLASS_PREPARE event request for each
breakpoint. Go figure.
The attached patch fixes this poor assumption.
Keith
ChangeLog
2007-04-27 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/EventManager.java
(getEventRequest): Rename
Kyle Galloway wrote:
ChangeLog
2007-04-11 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/ReferenceTypeCommandSet.java
(executeSourceFile): Throw an exception if no source file was found.
Questions/comments/concerns?
Hmm. I'm not convinced this is the right way to do
Kyle Galloway wrote:
I'm definitely seeing this come up, but I'm not sure it will get us
around having to implment some things right away. For example I think
we're going to need VirtualMachine.AllClasses since I don't think having
it throw an unimplemented exception is going to go over very
Kyle Galloway wrote:
ChangeLog
2007-04-03 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/value/ArrayValue.java: New file.
Questions/comments/concerns?
Looks good. Please commit.
Keith
Kyle Galloway wrote:
This fix changes two values in gnu.classpath.jdwp.util.VariableTable so
that they are correctly ints instead of longs.
ChangeLog
2007-3-30
* gnu/classpath/jdwp/util/VariableTable.java: Make argCnt and slots
ints.
(write): Replace writeLong with writeInt for above.
Kyle Galloway wrote:
It seem Thunderbird (at least my version) doesn't believe in tabs. When
I hit TAB, it places three spaces. Take solace though, I am aware
of this and I do use tabs in the actual ChangeLogs. This patch has been
committed.
One more thing... Update the copyright
-03-29 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/ThreadStartEvent.java (Event):
Event type is THREAD_START not THERAD_END.
* gnu/classpath/jdwp/transport/SocketTransport.java (ITransport):
Handle configure strings :port and port.
Index: gnu/classpath
Kyle Galloway wrote:
This patch fixes JDWP so when a Resume command is sent to a thread, it
will correctly call VMVirtualMachine.resumeThread instead of calling
VMVirtualMachine.suspendThread again. Currently, it is impossible to
Resume a thread once you have suspended it with JDWP, this
Hi,
The Classpath Hacker's Guide doesn't mention anything about annotations.
Doing a quick grep of the sources, I see that, e.g., the @Override
annotation is being handled in several different ways:
@Override
public void foo();
@Override public void foo();
public @Override void foo();
Do
Tom Tromey wrote:
Mario == Mario Torre [EMAIL PROTECTED] writes:
@Override
public void foo();
Me too. Three votes... maybe the motion passes? :)
So that's several votes for this style already. One last question: what
about comments/javadoc?
1) Before
@Override
/**
* foo
*/
2)
Mario Torre wrote:
Il giorno ven, 09/03/2007 alle 12.05 -0800, Keith Seitz ha scritto:
2) After
/**
* foo
*/
@Override
I presume most people would prefer #1?
Keith
I speak for myself, but I think most of us agree here, doing #1 would
make things to lost easily, for example in case
[my apologies for the delay in getting back to you]
Kyle Galloway wrote:
Keith Seitz wrote:
I see that this method can throw InvalidObjectException if the object
ID is not known by the ID manager. How is JdwpInternalErrorException
thrown?
This gets thrown by JdwpString.readString().
Ah
Kyle Galloway wrote:
Questions/Comments/Concerns?
I like it. Just some minor nits (some cosmetic, even).
Index: gnu/classpath/jdwp/value/Value.java
===
RCS file: gnu/classpath/jdwp/value/Value.java
diff -N
Hi,
I've committed the attached patch which does some simple housekeeping
cleanup to make the code more consistent, and fix some silly error
message cut-n-paste faux pas.
Keith
ChangeLog
2007-02-28 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/MethodCommandSet.java
the processor code, too, and implemented all the
previously optional methods that were waiting for this fix.
Keith
ChangeLog
2007-02-28 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/EventRequestCommandSet.java
(executeSet): Check if VM has capability for field
Kyle Galloway wrote:
ChangeLog
2007-02-27 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/id/NullObjectId.java: New class.
* gnu/classpath/jdwp/util/NullObject.java: New class.
* vm/reference/gnu/classpath/jdwp/VMIdManager.java (getObjectId):
Handle null object.
(get):
Kyle Galloway wrote:
Hi,
This patch changes VMFrame::getValues to take a signature byte as well
as a slot when getting local variables. This is done for use in type
checking when interfacing with the VM.
Questions/comments/concerns?
Yeah, that's logical. Please commit.
Keith
changing it. :-)
Keith
ChangeLog
2007-02-22 Keith Seitz [EMAIL PROTECTED]
* vm/refernece/gnu/classpath/jdwp/VMVirtualMachine.java
(getAllLoadedClassesCount): Remove.
(getAllLoadedClasses): Return a Collection.
* gnu/classpath/jdwp/processor
Kyle Galloway wrote:
2007-02-01 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/StackFrameCommandSet.java
(executeGetValues): Changed getFrame to use a jlong to pass frameID.
(executeSetValues): Ditto.
(executeThisObject): Ditto.
*
the startup
suspend option. Originally I was dealing with this differently, but I
see no reason why this should be necessary.
Keith
ChangeLog
2007-01-17 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/events/filters/StepFilter.java:
Update javadoc.
(matches
Kyle Galloway wrote:
Comments, concerns, or is this ok to commit?
Ok, but please double-check the indentation before you commit. It may
just be my mailer, but the String-based constructor looks mis-indented.
Keith
Kyle Galloway wrote:
Comments, concerns, or is this ok to commit?
Looks okay.
Do you have commit access, or do you need me to check it in for you?
Keith
Kyle Galloway wrote:
Comments, concerns, or is this ok to commit?
Okay
Keith
Kyle Galloway wrote:
Comments, concerns, or is this ok to commit?
Okay
Keith
Hi,
I received this patch from Martin Platter a while ago. Since he has not
submitted it here, I am checking it in myself. All it does is fix
several typos in include/jvmti.h.
Keith
ChangeLog
2006-08-31 Keith Seitz [EMAIL PROTECTED]
From Martin Platter [EMAIL PROTECTED
Hi,
This simple patch simply includes another header file to actually give
the VM a chance to define all those nice macros that are in jvmti.h!
Keith
ChangeLog
2006-08-31 Keith Seitz [EMAIL PROTECTED]
* include/jvmti.h: Include jvmti_md.h.
Index: include/jvmti.h
Tom Tromey wrote:
This is fine. IMO you don't need to ask for approval for future
additions, bug fixes, etc, to jvmti.h.
With any luck, this will be the only patch...
I've committed it.
Thanks,
Keith
Tom Tromey wrote:
Keith == Keith Seitz [EMAIL PROTECTED] writes:
Keith The following patch adds jvmti.h to the classpath repository. It is
Keith very closely modeled on jni.h.
Looks great. Please check it in.
With no further comments, I have committed this patch.
Thank you for taking
Paul Jenner wrote:
Hi Keith.
On Fri, 2006-06-16 at 15:09 -0700, Keith Seitz wrote:
Right now, the build fails if the user does:
$ ../classpath/configure --disable-gtk-peer
For info, this is also Classpath bug #27923 (caught me out too).
Ah, that looks like a better approach than what I
Kyle Galloway wrote:
Small change to ThreadOnlyFilter to avoid a null pointer exception with
null ThreadId. Throws an invalid thread exception instead.
Sure. Thanks.
Keith
Kyle Galloway wrote:
This patch just fixes a repeated javadoc error in several of the JDWP
Events. Not sure if this needs to be approved by the list, but I
figured I'd send it in anyway.
Please commit. For obvious things like this simple javadoc update (in
JDWP, at least), just post your
Hi,
Anyone else notice that there are CVS conflict markers in the ChangeLog?
cvs annotate shows:
1.7849 (tromey 16-Jun-06): 1.7848
1.7841 (rschuste 16-Jun-06): 1.7824
1.7841 (rschuste 16-Jun-06): 1.7799
I've deleted these lines and committed.
Tom and Robert: Would
Tom Tromey wrote:
I'm probably missing something, since it looks like your patch does
use wait/notify.
Oh, sorry. I wasn't clear. I meant wait/notify from the VM into JDWP,
not within JDWP itself. (Calling jdwpThread-wait() would crash gij.)
I'm not overly concerned about the mechanics of
Hi,
I've committed the following patch which changes how the EventManager is
created. This was causing all kinds of nasty problems during startup
with gij.
Keith
2006-06-16 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/EventManager.java (getDefault): Redo
to just issue a warning and disable
the plugin, I don't think that's particularly user friendly, but it
would be easy enough to change.
Keith
ChangeLog
2006-06-16 Keith Seitz [EMAIL PROTECTED]
* configure.ac: Fail if attempting to build gcjwebplugin without
GTK peers.
Index
Kyle Galloway wrote:
Small change to this filter to correct a logical bug that would occur
when the Exception didn't match the filter and both caught and uncaught
exceptions were selected. Requesting approval so I can commit.
Doh! I totally missed that. Yes, please commit.
Keith
comments (for or against).
Keith
ChangeLog
2006-06-15 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/Jdwp.java (_initLock): New field.
(_initCount): New field.
(Jdwp): Don't set isDebugging until fully initialized.
(subcomponentInitialized): New method
Kyle Galloway wrote:
The part that was removed upon commit actually introduced some logic
changes to the constructor to allow it to filter on all exceptions.
Here is another patch to correct the committed file.
2006-06-13 Kyle Galloway [EMAIL PROTECTED]
*
Kyle Galloway wrote:
Ok, fixed that, I think this is probably the better way to do it, I
hadn't though about when the event would get passed from the VM and this
will work both ways.
I've committed this. Thanks.
Keith
Kyle Galloway wrote:
2006-06-13 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java: Allow
null refId.
Grr. I really hate to do this, but I just noticed...
ExceptionOnlyFilter.matches doesn't handle the case where _refId is null.
Since you're
Kyle Galloway wrote:
Small fix for BreakpointEvent for filter compatibility. Requesting
approval and commit.
- Kyle
2006-06-13 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/BreakpointEvent.java : Added
Object _instance for compatibility with filters.
(getParameter):
Kyle Galloway wrote:
Yeah, sorry, should have seen that before, I think when I changed the
logic to compress it I may have destroyed that functionality. Anyways
fixed now.
Committed.
Keith
Kyle Galloway wrote:
I've made changes to fix problems with the patch and the changelog.
This patch contains only the changes related to the change in Event.
Requesting approval and a commit.
Approved and committed.
Keith
Kyle Galloway wrote:
Broke my previous patch into smaller patches(more to come) and fixed
some minor issues. This patch adds one event(ExceptionEvent).
Requesting approval and a commit.
Approved and committed.
Keith
Kyle Galloway wrote:
+ /**
+ * Returns a specific filtering parameter for this event. Valid types are
+ * thread and location
+ *
+ * @param type the type of parameter desired
+ * @returns the desired parameter or null
+ */
+ public Object getParameter(int type)
+ {
+if
Kyle Galloway wrote:
+ /**
+ * Returns a specific filtering parameter for this event. Valid types are
+ * thread and location
+ *
+ * @param type the type of parameter desired
+ * @returns the desired parameter or null
+ */
+ public Object getParameter(int type)
+ {
+if
Kyle Galloway wrote:
+ /**
+ * Returns a specific filtering parameter for this event. Valid types are
+ * thread and location
+ *
+ * @param type the type of parameter desired
+ * @returns the desired parameter or null
+ */
+ public Object getParameter(int type)
+ {
+if
Kyle Galloway wrote:
2006-06-12 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/filters/ExceptionOnlyFilter.java
(forCaught): removed useless accessor method
(forUncaught): removed useless accessor method
(matches): Implemented
This is approved with some slight
Some questions about this...
Kyle Galloway wrote:
+ /**
+ * Constructs a new codeClassUnloadEvent/code
+ *
+ * @param clazz class which was prepared
+ */
+ public ClassUnloadEvent(Class clazz)
+ {
+super(JdwpConstants.EventKind.CLASS_UNLOAD);
+_class = clazz;
+ }
Do you
Kyle Galloway wrote:
This one's fixed as well
And checked-in as well.
Keith
Kyle Galloway wrote:
Fixed that, wow must have been half asleep this morning..
Thanks! I've checked this in.
Keith
Kyle Galloway wrote:
Fixed it here as well.
Excellent. Committed.
Keith
Kyle Galloway wrote:
ChangeLog:
2006-06-09 Kyle Galloway [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/BreakpointEvent.java: Added Object
_instance for filter compatibility
* gnu/classpath/jdwp/event/BreakpointEvent.java(getParameter):
changed from Class type to constants
*
Kyle Galloway wrote:
Here is a patch to complete the functionality of this filter.
So that everyone knows, I've emailed Kyle privately about this patch,
and I think he's going to submit a new patch for this (mainly without
all the whitespace diffs).
Kyle feel free to correct me if I am
Kyle Galloway wrote:
A few nits, mainly typos and other frivolity.
Index: gnu/classpath/jdwp/event/MethodEntryEvent.java
===
RCS file: gnu/classpath/jdwp/event/MethodEntryEvent.java
diff -N
Kyle Galloway wrote:
ChangeLog:
2006-06-08 Kyle Galloway [EMAIL PROTECTED]
*gnu/classpath/jdwp/event/ExceptionEvent.java: New File.
*gnu/classpath/jdwp/event/MethodEntryEvent.java: New File.
*gnu/classpath/jdwp/event/MethodExitEvent.java: New File.
Martin wrote:
Keith Seitz wrote:
No, I do not have write access to the classpath CVS.
I can commit for you.
I have committed your changes. Thanks for the patches!
Keith
Martin wrote:
I have discovered two bugs in EventRequestCommandSet and
ThreadGroupReferenceCommandSet.
In the attachment there is a patch to fix them.
I don't know if my say is needed for approval or whatnot, but FWIW these
patches are correct. If you don't have CVS access, let me know and
these problems.
Keith
2006-03-16 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/Jdwp.java (getJdwpThreadGroup): New method.
* vm/reference/gnu/classpath/jdwp/VMVirtualMachine.java
(suspendAllThreads): Use Jdwp.getJdwpThreadGroup.
Don't suspend the current thread
Hi,
This is the final cleanup for a while (startup synchronization aside).
It simply removes the whole main thread notion from JDWP. Instead, the
VM will handle this when sending VM_INIT. [Aka: I changed my mind!]
Keith
ChangeLog
2006-03-16 Keith Seitz [EMAIL PROTECTED]
* gnu
Hi,
I've committed the following two files which simply add two classes
needed for breakpoints.
Keith
ChangeLog
2006-03-15 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/BreakpointEvent.java: New file.
* gnu/classpath/jdwp/exception/NativeMethodException.java
.
+ *
* @author Keith Seitz ([EMAIL PROTECTED])
*/
public class LocationOnlyFilter
@@ -85,7 +92,7 @@
*/
public boolean matches (Event event)
{
-// FIXME
-throw new RuntimeException (LocationOnlyFilter.matches not implemented);
+// This filter always matches. See comments
Hi,
This patch rewrites the majority of gnu.classpath.jdwp.util.Location to
use VMMethod instead of a tag, classID, methodID, and index.
Keith
ChangeLog
2005-03-15 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/util/Location.java: Rewrite using VMMethod.
(Location
Hi,
Another little random thing to get out of my sandbox. I just didn't like
the redundant information that it required.
Keith
ChangeLog
2006-03-15 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/util/LineTable.java (lines): Remove all occurances
of this redundant
Hello,
This is a follow-up patch to the import trimming where I've eliminated
all the javadoc warnings flagged by eclipse.
Keith
ChangeLog
2006-03-09 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/EventManager.java: Update javadoc.
* gnu/classpath/jdwp/event
Hello,
I've committed the attached patch which updates most of JDWP command
processing to use the new VMMethod class.
There are still one or two miscellaneous places where reflection is
used, but when I get around to testing them, I'll update similarly.
Keith
ChangeLog
2006-03-09 Keith
Tom Tromey wrote:
Keith == Keith Seitz [EMAIL PROTECTED] writes:
Keith If someone could double-check the coding style/standard, I would
Keith appreciate it. I have not yet had any luck with running efj.
Looks fine to me.
Lacking any objections, I've committed this patch.
Thanks for taking
style/standard, I would
appreciate it. I have not yet had any luck with running efj.
Keith
ChangeLog
2006-03-07 Keith Seitz [EMAIL PROTECTED]
* vm/reference/gnu/classpath/jdwp/VMMethod.java: New file.
* vm/reference/gnu/classpath/jdwp/VMVirtualMachine.java
(getClassMethod
Mark Wielaard wrote:
On Thu, 2006-02-16 at 14:21 -0800, Keith Seitz wrote:
Another pretty simple one. VirtualMachineCommandSet.executeIDsizes was
really jumping through hoops because JdwpID.size was abstract. Fooey.
This patch makes size() a static method and includes all the necessary
Hi,
Okay, I am preparing for the next round of patches (mostly for gcj), and
I've got a few small cleanups for Classpath's JDWP implementation, too.
I've committed the following simple patch.
Keith
2006-02-16 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/Jdwp.java
2006-02-16 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/EventRequest.java (getFilters): New
method.
(matches): Use Iterator instead of ListIterator.
Index: gnu/classpath/jdwp/event/EventRequest.java
Hello,
Another pretty simple one. VirtualMachineCommandSet.executeIDsizes was
really jumping through hoops because JdwpID.size was abstract. Fooey.
This patch makes size() a static method and includes all the necessary
changes in other files.
Keith
2006-02-16 Keith Seitz [EMAIL PROTECTED
not manage frames, fields, or methods. JDWP code will use frame,
field, and method wrapper objects to get IDs for these things. [See
follow-up RFA for VMMethod, coming to a patch list near you soon.]
Keith
ChangeLog
2006-02-16 Keith Seitz [EMAIL PROTECTED]
* vm/reference/gnu/classpath/jdwp
if I am assuming too much.
Keith
ChangeLog
2005-12-16 Keith Seitz [EMAIL PROTECTED]
* vm/reference/gnu/classpath/jdwp/VMVirtualMachine.java
(VMVirtualMachine): All methods now throw JdwpException.
Index: vm/reference/gnu/classpath/jdwp/VMVirtualMachine.java
Mark Wielaard wrote:
Please fix.
Indeed! I got a little ahead of myself. I've committed the attached
patch which should fix it. (This time I even waited for the build to
finish. O:-)
Keith
2005-12-16 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/EventManager.java
Anthony Green wrote:
These | operators should have been ||. Ok?
Well, I don't know if you think you need permission from me, but I would
say, How the heck did that escape my attention???
Puzzled (and grateful),
Keith
___
Classpath-patches
Hi,
I've committed the following patch which adds one of the (many) missing
events.
Keith
ChangeLog
2005-09-09 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/VmDeathEvent.java: New file.
Index: gnu/classpath/jdwp/event/VmDeathEvent.java
Hi,
VMIdManager.IdFactory.newObjectId forgot to set the reference for the
various IDs. I've committed the attached patch which corrects this buglet.
Keith
ChangeLog
2005-09-09 Keith Seitz [EMAIL PROTECTED]
* vm/reference/gnu/classpath/jdwp/VMIdManager.java (newObjectId
Hi,
I've committed the following patch which corrects a little buglet in the
VirtualMachine.Version command which was erroneously outputting two
integers as bytes instead of integers.
Keith
ChangeLog
2005-09-08 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor
Hi,
I've committed the attached patch which changes the return value to
*CommandSet.runCommand to abide by the API specified by
CommandSet.runCommand.
Keith
ChangeLog
2005-09-08 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/ArrayReferenceCommandSet.java
Hi,
I've committed the attached patch which updates gnu.classpath.jdwp.* for
the pending VMVirtualMachine check-in to follow.
Keith
ChangeLog
2005-09-02 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/CommandSet.java [vm]: Remove.
VMVirtualMachine is entirely
Hi,
I've committed the attached patch, which adds a shutdown method to
ITransport.java and friends.
Keith
ChangeLog
2005-09-02 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/transport/ITransport.java (shutdown): New
method.
* gnu/classpath/jdwp/transport
all this code.
With this, classpath should now also build with jdwp code. At the
maintainer's discretion, vm/reference/standard.omit and
lib/standard.omit may both be changed to permit the inclusion of this code.
Keith
ChangeLog
2005-09-02 Keith Seitz [EMAIL PROTECTED]
* gnu
Hi,
I've committed some files covering events. It is not complete, but it is
a start. I don't like some of it, but I'll fix whatever I don't like
when I start working on optimization.
Keith
ChangeLog
2005-08-29 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/Event.java
for setting up the appropriate notification conditions.
Nonetheless, this is how JDWP classifies/groups these things, so I've
kept it the same. Any filter can be queried for its conditions.
Keith
ChangeLog
2005-08-26 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/event/filters
. [For example, calling
Jdwp.notify will cause EventManager to evaluate filters on the event.
However calling Jdwp.sendEvent bypasses all of this and sends the event
notification down the wire.
/nitty-gritty-details
Keith
ChangeLog
2005-08-25 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp
Hi,
I've committed the attached patch which updates all the CommandSets in
the processor package with the new VMIdManager and EventManager APIs. It
also removes all the duplicated private variables for these things and
adds them to a base class.
Keith
ChangeLog
2005-08-25 Keith Seitz
Hi,
I've committed the attached patch which just cleans-up a few untidy ends
in EventReqeustCommandSet.java.
Keith
ChangeLog
2005-08-25 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/processor/EventRequestCommandSet.java
(executeSet): Use constants for case values
collection, etc).
Keith
ChangeLog
2005-08-20 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/id/ClassLoaderId.java (getClassLoader): New
method.
* gnu/classpath/jdwp/id/ClassObjectId.java (getClassObject): New
method.
* gnu/classpath/jdwp/id/JdwpId.java
On Tue, 2005-08-09 at 13:23 -0700, Keith Seitz wrote:
I am refactoring my code now and I will post a follow-up shortly.
Well, after quite a bit of refactoring and distraction, I've finally
gotten everything in the next stage of satisfied. I've checked this over
several times, and I think I've
On Tue, 2005-08-09 at 15:30 -0400, Bryce McKinlay wrote:
Keith, this looks reasonable to me, although see comments below. Note
that using an abstract class is a little different to how most of the
VM* classes are implemented in classpath. Typically, classpath provides
a reference
(request for comment/request for approval). But who knows, even a blind
man occasionally hits the target! ;-)
ChangeLog
2005-08-04 Keith Seitz [EMAIL PROTECTED]
* gnu/classpath/jdwp/vm/IdManager.java: New file describing
the interface used by the JDWP back-end for object and type
[pardon top posting]
It's been over a week now, does anyone else have an opinion or does
everyone agree with Bryce's comments?
Keith
On Mon, 2005-06-27 at 17:51 -0700, Keith Seitz wrote:
On Mon, 2005-06-27 at 17:03 -0400, Bryce McKinlay wrote:
Please post ChangeLog entries whenever you
On Tue, 2005-07-05 at 15:32 -0400, Aaron Luchko wrote:
There are a couple interesting points for this patch. The first is that
upon Keith's suggestion any Command which has something to do with
generics (in this case just queries for the generic signature) we just
throw a
On Tue, 2005-07-05 at 16:15 -0400, Bryce McKinlay wrote:
Class preparation is distinct from initialization. Preparation is
effectively linking the class: laying out its fields, initializing class
data structures in the VM, etc. Initialization involves actually running
Java code to
1 - 100 of 130 matches
Mail list logo
