[cp-patches] FYI - Use generics in gjarsigner

2007-01-08 Thread Raif S. Naffah
hello all, the attached patch --already committed-- updates the jarsigner tool to use generics. it also fixes a small bug in the jar verification code. the ChangeLog entry follows: 2007-01-09 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/jarsigner/SFHelper.java

Re: [cp-patches] RFC: fix JarEntry cert lookup

2006-11-27 Thread Raif S. Naffah
On Sunday 26 November 2006 19:58, Casey Marshall wrote: On Nov 25, 2006, at 3:59 PM, Raif S. Naffah wrote: On Tuesday 21 November 2006 08:35, Casey Marshall wrote: ... This patch fixes an issue with JarEntry objects that are created before the entry is verified... ...before your patch

[cp-patches] FYI: Added Jeroen Jeroen Frijters to Authors

2006-11-26 Thread Raif S. Naffah
hello there, after approval from Mark, i added Jeroen to the list of AUTHORS. the ChangeLog entry is: 2006-11-27 Raif S. Naffah [EMAIL PROTECTED] * AUTHORS: Added Jeroen Fritjers. cheers; rsn pgpne65fe7e9h.pgp Description: PGP signature

[cp-patches] FYI, Marco Trudel's javax.crypto fixes

2006-10-22 Thread Raif S. Naffah
hello all, the attached patch was already committed on behalf of Marco Trudel. the ChangeLog entry looks like so: 2006-10-23 Marco Trudel [EMAIL PROTECTED] * gnu/javax/crypto/pad/PKCS7.java (unpad): Removed an unnecessary test. * javax/crypto/CipherOutputStream.java:

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigIntegertake2 (compressed)

2006-10-08 Thread Raif S. Naffah
hello Jeroen, On Sunday 08 October 2006 22:44, Jeroen Frijters wrote: Hi Raif, The synchronization is still not completely right. If a method operates on two different BigIntegers, they both need to be protected from asynchronous finalization. Note also that when you synchronize on two

Re: [cp-patches] RFC: rmic merge

2006-09-22 Thread Raif S. Naffah
hello Tom, On Friday 22 September 2006 14:53, Thomas Fitzsimmons wrote: ... I've reorganized GNU Classpath's RMI tools and merged in cp-tools' rmic. ... - made rmic build conditional on USE_ASM now that both rmic and javah tools use the asm library, should we add it to external? cheers;

Re: [cp-patches] RFC: rmic merge

2006-09-22 Thread Raif S. Naffah
hello Tom, On Saturday 23 September 2006 02:42, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif now that both rmic and javah tools use the asm library, should Raif we add it to external? I thought we discussed this already and the answer was no. I don't have a link

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-05 Thread Raif S. Naffah
On Tuesday 05 September 2006 04:52, Jeroen Frijters wrote: Raif S. Naffah wrote: On Monday 04 September 2006 20:40, Jeroen Frijters wrote: ... ...*All* native method calls that use the native_ptr need to be synchronized. i'm sorry but it is still not obvious to me why this should

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-05 Thread Raif S. Naffah
earlier, i wrote: On Tuesday 05 September 2006 04:52, Jeroen Frijters wrote: Raif S. Naffah wrote: On Monday 04 September 2006 20:40, Jeroen Frijters wrote: ... ...*All* native method calls that use the native_ptr need to be synchronized. i'm sorry but it is still

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-04 Thread Raif S. Naffah
On Sunday 03 September 2006 18:02, Jeroen Frijters wrote: ... Most people do not understand the (security) implications of using native code in combination with handles and most of the code out there is simply wrong (as is the current patch). See [1]. i'll have to read this document

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger (compressed)

2006-09-04 Thread Raif S. Naffah
commenting out the code, the tests' failure pattern is unchanged. as for cacao, here is the tests's output: $ ./bin/cacao -cp ~/. test z = 9.007199254740994E15 d = 0.0 Thanks, Rob. On 9/3/06, Raif S. Naffah [EMAIL PROTECTED] wrote: hello Robert, On Sunday 03 September 2006 15:26

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-04 Thread Raif S. Naffah
On Monday 04 September 2006 20:40, Jeroen Frijters wrote: ... ...*All* native method calls that use the native_ptr need to be synchronized. i'm sorry but it is still not obvious to me why this should be so. every instance of a BigInteger has its own value of native_ptr. what are we

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger (compressed)

2006-09-03 Thread Raif S. Naffah
hello Robert, On Sunday 03 September 2006 15:26, Robert Lougher wrote: Hi, What architecture were you running JamVM on? here is the uname related lines in my jamvm config.log: uname -m = i686 uname -r = 2.6.17-1.2174_FC5smp uname -s = Linux uname -v = #1 SMP Tue Aug 8 16:00:39 EDT 2006

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-03 Thread Raif S. Naffah
hello Jeroen, On Sunday 03 September 2006 18:02, Jeroen Frijters wrote: ... How/why is the native version better? Is it really worthwhile to complicate the code this way? Where are the benchmarks that prove the native code is faster? the attractiveness of the native code is performance. to

Re: [cp-patches] RFC: PR Classpath/28664 - GNU MP based BigInteger(compressed)

2006-09-03 Thread Raif S. Naffah
hello Sven, On Sunday 03 September 2006 19:46, Sven de Marothy wrote: On Sun, 2006-09-03 at 10:02 +0200, Jeroen Frijters wrote: Raif S. Naffah wrote: the attached patch adds support for GNU MP in BigInteger if/when configured. How/why is the native version better? Is it really

[cp-patches] FYI: fix for PR Classpath/23952

2006-08-12 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes the above PR by having the cache of previously resolved resource bundles as an LRU, of CACHE_SIZE elements, organized by access. 2006-08-13 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23952 * java/util

Re: [cp-patches] FYI: JTree keyboard handling fix

2006-08-09 Thread Raif S. Naffah
hello Mark, On Wednesday 09 August 2006 08:29, Mark Wielaard wrote: ... This are most likely last only code changes on the release branch. I am looking at the BigInteger fixes from Raif, but those haven't hit CVS yet. these, and the ResourceBundle one, can wait until the next release. two

[cp-patches] RFC: fix for PR 27372

2006-08-06 Thread Raif S. Naffah
hello all, the attached patch fixes the above PR. 2006-08-06 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/27372 * java/math/BigInteger.java: Updated copyright year. (init): Consume as little bytes as possible. a new Mauve test gnu/testlet/java/math/BigInteger

[cp-patches] RFC: BigInteger fixes

2006-08-05 Thread Raif S. Naffah
hello all, the attached patch fixes some problems in two of the BigInteger constructors highlighted by the new Mauve test gnu.testlet.java.math.BigInteger.ctor. the expected ChangeLog entry will look like so: 2006-08-06 Raif S. Naffah [EMAIL PROTECTED] * java/math/BigInteger.java

[cp-patches] RFC: better handling of default-preferences-peer config option

2006-08-04 Thread Raif S. Naffah
hello all, the attached patch adds better handling of the default-preferences-peer option and checks for obvious wrong values. OK to commit? cheers; rsn Index: configure.ac === RCS file:

[cp-patches] Re: RFC: better handling of default-preferences-peer config option

2006-08-04 Thread Raif S. Naffah
hello Mark, On Saturday 05 August 2006 10:09, Mark Wielaard wrote: On Sat, 2006-08-05 at 08:37 +1000, Raif S. Naffah wrote: the attached patch adds better handling of the default-preferences-peer option and checks for obvious wrong values. OK to commit? Yes, very nice... thanks

[cp-patches] FYI: handle absent or NULL DSA parameters in X.509 certificates

2006-08-04 Thread Raif S. Naffah
hello all, the attached patch --already committed-- caters for x.509 certificates with absent or null parameters in an AlgorithmIdentifier element (of a SubjectPublicKeyInfo). all 100 Mauve tests in gnu.testlet.java.security.cert.pkix.pkits should now pass! 2006-08-05 Raif S. Naffah [EMAIL

[cp-patches] FYI: import-cacerts.sh script added

2006-08-03 Thread Raif S. Naffah
hello all, the attached patch --already committed-- adds a batch import script to facilitate populating a cacerts keystore. 2006-08-03 Raif S. Naffah [EMAIL PROTECTED] * scripts/import-cacerts.sh: Batch CA certificates import script. cheers; rsn Index: import-cacerts.sh

Re: [cp-patches] Re: RFC: add a cacerts file under resource/java/security

2006-08-03 Thread Raif S. Naffah
hello Mark, On Thursday 03 August 2006 22:42, Mark Wielaard wrote: On Thu, 2006-08-03 at 22:32 +1000, Raif S. Naffah wrote: ... the gkeytool knows how to import _one_ certificate from such encoded files with either the -import or the -cacert commands. the latter, coupled with the import

Re: [cp-patches] RFA: Crypto algorithm name case sensitivity

2006-07-30 Thread Raif S. Naffah
hello all, On Monday 31 July 2006 08:14, Mark Wielaard wrote: Hi Matt, On Sun, 2006-07-30 at 16:35 -0400, Matthew Wringe wrote: The attached patch, already committed, fixes this problem. There should be no other tests regressions from this patch. Thanks. Also added to the release and

[cp-patches] RFC: fix for PR 23952

2006-07-30 Thread Raif S. Naffah
hello all, the attached patch addresses the above PR by implementing the lookup of resource bundles using an LRU organised by access. the ChangeLog will appear as follows: 2006-07-31 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/23952 * java/util/ResourceBundle.java

Re: [cp-patches] Patch: RFC: add javah tool

2006-07-28 Thread Raif S. Naffah
hello Tom, On Friday 28 July 2006 08:10, Tom Tromey wrote: ... This adds a 'javah' tool which is also a replacement (not quite drop-in -- I changed some stuff) for gcjh... This tool uses the ASM library. I added a new configure option for this, point --with-asm to the all jar and javah

Re: [cp-patches] Re: Patch: RFC: add javah tool

2006-07-28 Thread Raif S. Naffah
hello Tom, On Saturday 29 July 2006 01:15, Tom Tromey wrote: Tom == Tom Tromey [EMAIL PROTECTED] writes: ... Now that there is a 0.92 branch, I'm checking it in. I've appended the updated patch -- it fixes a buglet in the tool wrapper and it also updates NEWS. while trying to 'make' a

Re: [cp-patches] Re: Patch: RFC: add javah tool

2006-07-28 Thread Raif S. Naffah
On Saturday 29 July 2006 05:10, Raif S. Naffah wrote: ... while trying to 'make' a freshly updated project i get: 61. ERROR in ./gnu/classpath/tools/javah/JniHelper.java (at line 77) assert type.getSort() == Type.OBJECT; ^ Syntax error on token

[cp-patches] FYI: some cleanup of keytool classes

2006-07-28 Thread Raif S. Naffah
hello all, the attached patch --already committed-- removes unused imports, fields and methods from the keytool classes. 2006-07-29 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/keytool/Command.java: Removed unused import. (getCallbackHandler): Fully qualify

Re: [cp-patches] Re: Patch: RFC: add javah tool

2006-07-28 Thread Raif S. Naffah
On Saturday 29 July 2006 05:42, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif 60. WARNING in ./gnu/classpath/tools/javah/JniHelper.java Raif (at line 77) Raif assert type.getSort() == Type.OBJECT; Raif ^^ Raif 'assert' should not be used

[cp-patches] FYI: add source 1.4 compliance to ECJ when used

2006-07-28 Thread Raif S. Naffah
hello all, the attached patch --already committed-- does the following: 2006-07-29 Raif S. Naffah [EMAIL PROTECTED] * tools/Makefile.am: Added source 1.4 compliance option when ECJ is used. cheers; rsn Index: Makefile.am

Re: [cp-patches] Re: Patch: RFC: add javah tool

2006-07-28 Thread Raif S. Naffah
On Saturday 29 July 2006 06:18, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif 57. ERROR in ./gnu/classpath/tools/javah/Main.java Raif (at line 339) Raif r.accept(result, true); Raif ^^ Raif The method accept(ClassVisitor, int) in the type

Re: [cp-patches] Patch: RFC: add javah tool

2006-07-28 Thread Raif S. Naffah
On Saturday 29 July 2006 00:09, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif what safe assumptions can we make for non-Eclipse users; e.g. a Debian Raif packager who requires the sources as well to patch them when addressing Raif security issues (see mail in Raif

[cp-patches] FYI: fix for PR 28100

2006-07-21 Thread Raif S. Naffah
hello all, the attached patch adds support for handling 1 and 2, in addition to the existing 3, DES keys to the triple-DES cipher. the Mauve test TestOfTripleDES (in gnu.testlet.gnu.javax.crypto.cipher) was amended to test the new changes. 2006-07-22 Raif S. Naffah [EMAIL PROTECTED

[cp-patches] FYI: fix for PR 26302

2006-07-19 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes the above PR. 2006-07-19 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/26302 * resource/java/security/classpath.security: Updated copyright year. (auth.login.defaultCallbackHandler): New property; set to our

Re: [cp-patches] GOST cipher patch

2006-07-19 Thread Raif S. Naffah
hello Morgon, On Wednesday 19 July 2006 04:46, Morgon Kanter wrote: Hello, Attached is a patch to add and enable the use of the GOST cipher. in GOST.java: * in the encrypt(), decrypt() and makeKey() methods you should add a test to check if the passed block size matches the cipher's default

[cp-patches] FYI: fix for PR 27205

2006-07-18 Thread Raif S. Naffah
hello all, the attached patch --already committed-- was originally submitted by David Walluck. it fixes the above PR. 2006-07-18 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/27205 * tools/gnu/classpath/tools/jarsigner/SFHelper.java (writeDSA): Check certificate

Re: [cp-patches] FYI: fix for PR Classpath/28391

2006-07-16 Thread Raif S. Naffah
hello Mark, On Sunday 16 July 2006 20:54, Mark Wielaard wrote: On Sun, 2006-07-16 at 16:00 +1000, Raif S. Naffah wrote: the attached patch --already committed-- fixes the above PR. a keystore should now be created if it is not there but only with the -genkey, -import and -identitydb

Re: [cp-patches] FYI: X peers

2006-07-01 Thread Raif S. Naffah
hello Michael, On Saturday 01 July 2006 20:05, Michael Koch wrote: On Sat, Jul 01, 2006 at 10:33:10AM +0200, Roman Kennke wrote: Am Samstag, den 01.07.2006, 09:24 +1000 schrieb Raif S. Naffah: On Friday 30 June 2006 01:27, Roman Kennke wrote: I checked in the Escher-based X peers

Re: [cp-patches] FYI: X peers

2006-06-30 Thread Raif S. Naffah
hello Roman, On Friday 30 June 2006 01:27, Roman Kennke wrote: I checked in the Escher-based X peers and added some configury for enabling it. To build the X peers you need the most recent Escher library, to be found here: http://kennke.org/~roman/escher-0.3.0.jar Configure with:

[cp-patches] FYI: Remove RCS Revision string from some classes

2006-06-26 Thread Raif S. Naffah
hello all, the attahced patch --already committed-- removes the RCS Revision strings from 2 crypto classes. 2006-06-26 Raif S. Naffah [EMAIL PROTECTED] * gnu/java/security/key/rsa/RSAKeyPairRawCodec.java: Remove RCS Revision. * gnu/javax/crypto/assembly

[cp-patches] FYI: NEWS update

2006-06-19 Thread Raif S. Naffah
hello all, the attached patch --already committed-- updates the NEWS file to mention the security tools and the tools document. 2006-06-19 Raif S. Naffah [EMAIL PROTECTED] * NEWS: Updated (delayed) for security tools and tools.texinfo. cheers; rsn Index: NEWS

[cp-patches] FYI: CipherAdapter and PR Classpath/27849 fixes

2006-06-16 Thread Raif S. Naffah
) should now pass. 2006-06-17 Raif S. Naffah [EMAIL PROTECTED] On behalf of Vivek Lakshmanan [EMAIL PROTECTED] * gnu/javax/crypto/jce/cipher/CipherAdapter.java (engineInit(int, Key, SecureRandom)): Seperate common initialization logic into engineInitHandler and reuse

[cp-patches] FYI: ConfigFileParser fix

2006-06-14 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes a typo, and replaces writing to System.out with logging statements conditioned by Configuration.DEBUG. 2006-06-14 Raif S. Naffah [EMAIL PROTECTED] * gnu/javax/security/auth/login/ConfigFileTokenizer.java: Fixed a typo

[cp-patches] FYI: fix PR Classpath/27853

2006-06-11 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes the above. 2006-06-11 Raif S. Naffah [EMAIL PROTECTED] PR Classpath/27853 * gnu/javax/crypto/RSACipherImpl.java (engineDoFinal): Was short by 1 byte. cheers; rsn Index: RSACipherImpl.java

[cp-patches] Re: fix for ConfigFileParser

2006-06-11 Thread Raif S. Naffah
hello Tom, On Monday 12 June 2006 03:17, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: Raif String t = tokens[i]; Raif -if (Character.isJavaIdentifierStart(cn.toCharArray()[0])) Raif - abort(); Raif

[cp-patches] FYI: Updated tools document author

2006-06-11 Thread Raif S. Naffah
hello all, the attached patch --already committed-- updates the author of the tools document to The GNU Classpath Team. 2006-06-12 Raif S. Naffah [EMAIL PROTECTED] * doc/tools.texinfo: Replaced original author with The GNU Classpath Team. cheers; rsn Index: tools.texinfo

[cp-patches] FYI: fix for ConfigFileParser

2006-06-10 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes a bug in the above. the TestOfConfigurationParser Mauve test (in gnu.testlet.javax.security.auth.login) should now pass. 2006-06-11 Raif S. Naffah [EMAIL PROTECTED] * gnu/javax/security/auth/login/ConfigFileParser.java

Re: [cp-patches] Re: RFC: add a cacerts file under resource/java/security

2006-06-09 Thread Raif S. Naffah
hello Tom, On Friday 09 June 2006 09:16, Tom Tromey wrote: Mark == Mark Wielaard [EMAIL PROTECTED] writes: Mark I CCed the devjam list on which a couple of different distribution Mark packagers are subscribed. Devjam people, Raif added support for Mark importing trusted ca-certs to GNU

Re: [cp-patches] Patch for support of the GOST block cipher.

2006-06-09 Thread Raif S. Naffah
hello Morgon, On Thursday 08 June 2006 16:15, Morgon Kanter wrote: The attached patch adds support for the GOST 28147-89 block cipher. It works and is compatable with the canonical English implementation from [1], which I generated the test vectors that appear in the attached GOSTTest.java

[cp-patches] FYI: re-factored BasePad

2006-06-09 Thread Raif S. Naffah
hello all, the attached patch --already committed (in two commits)-- re-factors the self-test code in BasePad to allow more flexible correctness tests by sub-classes. 2006-06-09 Raif S. Naffah [EMAIL PROTECTED] * gnu/javax/crypto/pad/BasePad.java (selfTest): Re-factored to allow more

[cp-patches] FYI: ISO-10126-2 by Matthew Wringe

2006-06-09 Thread Raif S. Naffah
hello all, the attached patch --already committed on behalf of Matthew Wringe-- adds an implementation of the ISO-10126-2 padding scheme. a new Mauve test to exercise block sizes from 2 to 256 was also added as gnu.testlet.gnu.javax.crypto.pad.TestOfISO10126. 2006-06-09 Raif S. Naffah

Re: [cp-patches] GNU Crypto ISO 10126 Padding

2006-06-06 Thread Raif S. Naffah
On Tuesday 06 June 2006 01:25, Matthew Wringe wrote: On Fri, 2006-06-02 at 20:04 +1000, Raif S. Naffah wrote: On Thursday 01 June 2006 09:52, Matthew Wringe wrote: GNU Crypto currently doesn't implement the ISO 10126-2 padding algorithm, this algorithm is used in xml encryption

Re: [cp-patches] GNU Crypto ISO 10126 Padding

2006-06-06 Thread Raif S. Naffah
hello Matthew, On Tuesday 06 June 2006 01:25, Matthew Wringe wrote: On Fri, 2006-06-02 at 20:04 +1000, Raif S. Naffah wrote: On Thursday 01 June 2006 09:52, Matthew Wringe wrote: GNU Crypto currently doesn't implement the ISO 10126-2 padding algorithm, this algorithm is used in xml

[cp-patches] FYI: remove warnings (end)

2006-06-04 Thread Raif S. Naffah
hello all, the attached patch --already committed-- cleans up some classes in gnu.javax.crypto to remove warnings detected by Eclipse. 2006-06-04 Raif S. Naffah [EMAIL PROTECTED] * gnu/javax/crypto/sasl/SaslUtil.java: Remove unused import. * gnu/javax/crypto/sasl/srp

[cp-patches] FYI: remove warnings

2006-06-03 Thread Raif S. Naffah
hello all, the attached patch --already committed-- cleans up some file in gnu.java.security to remove warnings detected by Eclipse. 2006-06-04 Raif S. Naffah [EMAIL PROTECTED] * gnu/java/security/PolicyFile.java: Updated copyright year. (logger): Increased visibility

Re: [cp-patches] GNU Crypto ISO 10126 Padding

2006-06-02 Thread Raif S. Naffah
hello Mathew, On Thursday 01 June 2006 09:52, Matthew Wringe wrote: GNU Crypto currently doesn't implement the ISO 10126-2 padding algorithm, this algorithm is used in xml encryption. The attached patch and java file will add ISO 10126 support to GNU Crypto. Thanks, thanks for your

[cp-patches] FYI: use @VM_BINARY@ with jarsigner and keytool scripts

2006-06-01 Thread Raif S. Naffah
hello all, the attached patch --already committed-- use @VM_BINARY@, instead of $JAVA in jarsigner and keytool launcher scripts. 2006-06-02 Raif S. Naffah [EMAIL PROTECTED] * tools/jarsigner.in: Use @[EMAIL PROTECTED] * tools/keytool.in: Likewise. cheers; rsn Index

Re: [cp-patches] RFC: add a cacerts file under resource/java/security

2006-05-29 Thread Raif S. Naffah
hello Mark, On Monday 29 May 2006 20:02, Mark Wielaard wrote: Hi Raif, On Mon, 2006-05-22 at 21:42 +1000, Raif S. Naffah wrote: my question is: does anybody see any problem, legal or otherwise, in including our version of this cacerts file which i named cacerts.gkr into the GNU Classpath

[cp-patches] FYI: logging patch

2006-05-28 Thread Raif S. Naffah
hello all, i just committed the following patch but i am about to revert it. apologies for any inconvenience which this may cause. cheers; rsn Index: LogManager.java === RCS file:

[cp-patches] FYI: logging patch reverted

2006-05-28 Thread Raif S. Naffah
hello all, 2006-05-28 Raif S. Naffah [EMAIL PROTECTED] * java/util/logging/FileHandler.java: Reverted previous patch. * java/util/logging/LogManager.java: Likewise. -- cheers; rsn Index: FileHandler.java === RCS

[cp-patches] FYI: FileHandler bug fix

2006-05-28 Thread Raif S. Naffah
hello all, the attached patch --already committed-- ensures that the FileHandler's pattern field is set to a non-null value. this fixes a NPE thrown in the rotate() method if pattern is null. 2006-05-29 Raif S. Naffah [EMAIL PROTECTED] * java/util/logging/FileHandler.java

[cp-patches] FYI: bug fix

2006-05-19 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes a small bug in the list command handler; removes commented out code as well trace/debugging statements pertaining to passwords. 2006-05-20 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/keytool/ListCmd.java (rfc

[cp-patches] FYI: gnu/javax/crypto/keyring fixes

2006-05-19 Thread Raif S. Naffah
2006-05-20 Raif S. Naffah [EMAIL PROTECTED] * gnu/javax/crypto/keyring/PrivateKeyEntry.java: Formatting. (toString): New method. * gnu/javax/crypto/keyring/PasswordEncryptedEntry.java (decrypt): Do not trace/log passwords. Set masked to false before

[cp-patches] FYI:

2006-05-19 Thread Raif S. Naffah
hello all, the attached patch --already committed-- ensures that some methods in the GKR KeyStore Adapter class follow the RI's published API. a Mauve test has been added to validate these changes: gnu.testlet.gnu.javax.crypto.jce.keyring.TestOfKeystore 2006-05-20 Raif S. Naffah [EMAIL

[cp-patches] FYI: minor javadoc fixes.

2006-05-19 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes some javadoc problems in three gnu.java.security classes. 2006-05-20 Raif S. Naffah [EMAIL PROTECTED] * gnu/java/security/OID.java: Updated copyright year. (OID): Removed unused Javadoc param tag. * gnu/java

[cp-patches] FYI: a small formatting patch

2006-05-14 Thread Raif S. Naffah
hello all, the attached patch --already committed-- is a small formatting patch. 2006-05-14 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/jarsigner/Main.java (main): Formatting. cheers; rsn Index: Main.java

[cp-patches] FYI: jarsigner now uses getopt parser

2006-05-12 Thread Raif S. Naffah
hello all, the attached patch --already committed-- replaces command line parsing in the jarsigner tool with the newly added getopt classes. 2006-05-13 Raif S. Naffah [EMAIL PROTECTED] * resource/gnu/classpath/tools/jarsigner/MessageBundle.properties: Added help text

Re: [cp-patches] RFC: allow short keys in HMac

2006-05-11 Thread Raif S. Naffah
hello Casey, On Thursday 11 May 2006 09:51, Casey Marshall wrote: This patch allows short keys by default in the HMac class... looks fine. plsease go ahead. cheers; rsn pgpJQE84KQJ6B.pgp Description: PGP signature

Re: [cp-patches] RFC: handling of longOnly options printing in tools

2006-05-10 Thread Raif S. Naffah
On Wednesday 10 May 2006 07:09, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: ... Raif the longOnly print-help method is for commands which options do not have Raif short-form syntax; e.g. jarsigner. those commands signal their Raif intention with the Parser constructor

[cp-patches] RFC: line wrapping. was: handling of longOnly options...

2006-05-10 Thread Raif S. Naffah
hello all, this patch handles wrapping long header, footer and description texts with the tools' getopt Parser and OptionGroup classes. ok to commit? cheers; rsn Index: OptionGroup.java === RCS file:

[cp-patches] FYI: added line-wrapping to printing help in getopt

2006-05-10 Thread Raif S. Naffah
hello all, the attached patch --already committed-- adds line-wrapping to long header, footer and description texts in getopt Parser and OptionGroup classes. 2006-05-11 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/getopt/OptionGroup.java (FILLER): New

[cp-patches] RFC: handling of longOnly options printing in tools

2006-05-09 Thread Raif S. Naffah
hello all, i started integrating the new option parsing code for use with the jarsigner tool. the attached proposed patch adds better handling of longOnly options when printing the tool's help text. ok to commit? cheers; rsn Index: Parser.java

Re: [cp-patches] RFC: handling of longOnly options printing in tools

2006-05-09 Thread Raif S. Naffah
hello Casey, On Wednesday 10 May 2006 06:43, Casey Marshall wrote: On May 9, 2006, at 8:10 AM, Tom Tromey wrote: One concern I have is that wrapping is a pain to get right across Locales, and even in English if there is quoted text. But maybe we can just try it and see. Is this what

Re: [cp-patches] RFC: handling of longOnly options printing in tools

2006-05-09 Thread Raif S. Naffah
hello Tom, On Wednesday 10 May 2006 01:10, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: ... Raif Index: Parser.java Raif + private void printText(PrintStream out, String text) Raif + { Raif +// is there a newline in the substring [start..finish

[cp-patches] FYI: Simple1LineFormatter amendment

2006-05-07 Thread Raif S. Naffah
hello all, the attached patch --already committed-- delays the class initialization of DateFormat and NumberFormat classes; which otherwise may cause bootstrapping problems with some VMs. 2006-05-07 Raif S. Naffah [EMAIL PROTECTED] * gnu/classpath/debug/Simple1LineFormatter.java

[cp-patches] FYI: Keyring fix

2006-05-03 Thread Raif S. Naffah
hello all, the attached patch --already committed-- makes it possible to use the default keystore type and implementation to work with the keytool. 2006-05-03 Raif S. Naffah [EMAIL PROTECTED] * gnu/javax/crypto/jce/keyring/GnuKeyring.java: Re-implemented using a pair of one

Re: [cp-patches] FYI: Keyring fix

2006-05-03 Thread Raif S. Naffah
hello Casey, On Thursday 04 May 2006 07:22, Casey Marshall wrote: On May 3, 2006, at 5:33 AM, Raif S. Naffah wrote: hello all, the attached patch --already committed-- makes it possible to use the default keystore type and implementation to work with the keytool. Is that really

[cp-patches] Re: include security tools in tools.zip and convenience scipts

2006-05-03 Thread Raif S. Naffah
hello Tom, On Thursday 04 May 2006 04:35, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: [...] Raif AC_CONFIG_COMMANDS([gen-classlist],[chmod 755 lib/gen-classlist.sh]) I would add an AC_CONFIG_COMMANDS, like this one, for each of the new tools. That way

[cp-patches] FYI: bug fix to the keytool ExportCmd

2006-05-03 Thread Raif S. Naffah
hello all, the attached patch --already committed-- fixes a bug in the export command of the keytool. 2006-05-04 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/keytool/ExportCmd.java (setup): Use _alias instead of alias. cheers; rsn Index: ExportCmd.java

Re: [cp-patches] FYI: Keyring fix

2006-05-03 Thread Raif S. Naffah
hello Casey, On Thursday 04 May 2006 10:22, Casey Marshall wrote: On May 3, 2006, at 3:09 PM, Raif S. Naffah wrote: On Thursday 04 May 2006 07:22, Casey Marshall wrote: On May 3, 2006, at 5:33 AM, Raif S. Naffah wrote: the attached patch --already committed-- makes it possible to use

Re: [cp-patches] FYI: Keyring fix

2006-05-03 Thread Raif S. Naffah
On Thursday 04 May 2006 12:02, Casey Marshall wrote: ... And better still would be a keyring implementation that had a usage field of GKR_CERTIFICATES | GKR_PRIVATE_KEYS | GKR_PUBLIC_CREDENTIALS, so you really are storing everything in one keyring, not two keyrings glued together. that

[cp-patches] Re: include security tools in tools.zip and convenience scipts

2006-05-02 Thread Raif S. Naffah
hello Tom On Tuesday 02 May 2006 11:58, Tom Tromey wrote: Raif == Raif S Naffah [EMAIL PROTECTED] writes: ... Raif +jarsigner: $(srcdir)/jarsigner.sh Raif + mkdir -p $(bindir) Raif + rm -f $(bindir)/jarsigner Raif + cat $(srcdir)/jarsigner.sh $(bindir)/jarsigner

[cp-patches] FYI: Re-factored HelpPrinter

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- re-factors the above class to expose a method that prints the help text without exiting the VM. 2006-04-29 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/HelpPrinter.java (printHelp): New method

[cp-patches] FYI: Add our Callback provider to the list of default providers

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- add the GNU-CALLBACKS security provider to the list of default providers. 2006-04-29 Raif S. Naffah [EMAIL PROTECTED] * java/security/Security.java clinit: Add our Callback provider. * resource/java/security

[cp-patches] FYI: Bg fixes to RSA key-pair handling + others

2006-05-01 Thread Raif S. Naffah
signature algorithm when using the keytool). 2006-04-29 Raif S. Naffah [EMAIL PROTECTED] * gnu/java/security/provider/Gnu.java (run): Add RSA as an alias to MD5withRSA. * gnu/java/security/key/rsa/RSAKeyPairX509Codec.java (encodePublicKey): Always encode a NULL

[cp-patches] FYI: new tools.common package and util classes

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- creates a new subpackage (common) in the tools hierarchy and adds some utility classes commonly used, so far, by the jarsigner and keytool tool. 2006-05-02 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/common

[cp-patches] FYI: X500DistinguishedName bug fixes

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- fixes a couple of bugs in the above mentioned class. 2006-04-29 Raif S. Naffah [EMAIL PROTECTED] * gnu/java/security/x509/X500DistinguishedName.java: Updated copyright. (putComponent): Handle O and OU components

[cp-patches] FYI: jarsigner licensed under GPL + Exception

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- changes (back) the license of the jarsigner tool to GPL + Exception. 2006-04-29 Raif S. Naffah [EMAIL PROTECTED] * tools/jarsigner.sh.in: Changed license to GPL + Exception. Use -Xbootclasspath/p instead of -cp when

[cp-patches] FYI: jarsigner - Added support for localised messsages

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- adds support for localisable messages in jarsigner. it also refactors some classes to use the newly added common utilities. 2006-05-02 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/jarsigner/jarsigner.txt: Re

[cp-patches] FYI: a new tools document

2006-05-01 Thread Raif S. Naffah
Classpath Tools Guide [EMAIL PROTECTED] Raif S. Naffah + [EMAIL PROTECTED] [EMAIL PROTECTED] 0pt plus 1filll +Copyright @copyright{} 2006 Free Software Foundation, Inc. [EMAIL PROTECTED] 2 +Permission is granted to make and distribute verbatim copies of this document provided the copyright notice

[cp-patches] FYI: updated top configure.ac

2006-05-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- adds keytool.sh to the list of files to be generated by configure. 2006-05-02 Raif S. Naffah [EMAIL PROTECTED] * tools/.cvsignore: Added keytool.sh. * configure.ac: Added tools/keytool.sh to AC_CONFIG_FILES. cheers; rsn

[cp-patches] RFC: include security tools in tools.zip and convenience scipts

2006-05-01 Thread Raif S. Naffah
hello all, the attached patch proposes the addition of the two security tools (jarsigner and keytool) to the tools.zip plus the generation of two convenience scripts to launch them. bar strong objections, i shall commit this during the weekend. cheers; rsn Index: Makefile.am

[cp-patches] FYI: modification to PBEKDF2 inistialisation

2006-04-19 Thread Raif S. Naffah
the user, when passing a password, to specify a charset encoding to use when converting the password chars into bytes --UTF-8 remains the fallback charset encoding. 2006-04-19 Raif S. Naffah [EMAIL PROTECTED] Suggested by Stephen White [EMAIL PROTECTED] * gnu/javax/crypto/prng

[cp-patches] FYI: Implement Whirlpool Version 3

2006-04-07 Thread Raif S. Naffah
hello there, the attached patch --already committed-- implements version 3 of the Whirlpool hash. it also fixes PR27071. 2006-04-08 Raif S. Naffah [EMAIL PROTECTED] PR classpath/27071 * gnu/java/security/hash/Whirlpool.java: Updated documentation. (DIGEST0): Use

Re: [cp-patches] Patch: RFC: merge URLConnection

2006-04-05 Thread Raif S. Naffah
hello Tom, On Wednesday 05 April 2006 11:45, Tom Tromey wrote: ... Also I'm not completely sure about this cache. Suppose we cache a failed lookup and then the user sets a custom factory? It seems like new attempts ought to try again. Perhaps if there is a factory we ought to ignore the

[cp-patches] FYI: jarsigner cleanup

2006-04-03 Thread Raif S. Naffah
hello there, the attached patch --already committed-- mainly cleans up the jarsigner code. 2006-04-03 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/jarsigner/Main.java: Removed unused imports. (provider): Made it protected. (providerInstalled): New field

[cp-patches] FYI: jarsigner is now GPL

2006-04-01 Thread Raif S. Naffah
hello there, following Mark's suggestion, i changed the licence of the jarsigner sources to be GPL. here is the patch --already committed-- and the ChangeLog entry: 2006-04-02 Raif S. Naffah [EMAIL PROTECTED] * tools/gnu/classpath/tools/jarsigner/HashUtils.java: Use GPL

[cp-patches] FYI: Generating jarsigner script

2006-04-01 Thread Raif S. Naffah
hello there, the attached patch --already committed-- generates a jarsigner shell script which attempts to find a java executable before invoking it with the tool's main class. the ChangeLog entry follows: 2006-04-02 Raif S. Naffah [EMAIL PROTECTED] * configure.ac: Added tools

  1   2   >