On Wed, 8 Feb 2023 01:39:04 GMT, Damon Nguyen wrote:
> I created an automated test, but for some L's (such as Nimbus), an enabled
> vs disabled ComboBox differs in more than just the text color. The
> background, border, and button color may change as well
Then can we not compare the comboBox
On Sun, 18 Sep 2022 21:23:12 GMT, SWinxy wrote:
> `JRSUIUtils.java` structurally does things weirdly. The utility class mostly
> passes parameters from functions to other functions. The indirection makes
> things harder to understand the eventual purpose.
>
> Take
On Tue, 7 Feb 2023 23:14:23 GMT, Damon Nguyen wrote:
>> Before the fix, a JComboBox in Nimbus L would have normal black text even
>> when the JComboBox was disabled if SynthComboBoxRenderer was replaced with a
>> DefaultListCellRenderer. This text should be greyed out like in other L's.
>>
On Tue, 7 Feb 2023 17:16:41 GMT, Alexey Ivanov wrote:
> Since a CSR is required, I suggest updating the spec for `isDone` method so
> that it returns `true` only after `doInBackground` exits. Now `isDone`
> returns `true` after `cancel` completes but the `DONE` state isn't reached
> yet.
My
> Issue is observed that after changing the Look & Feel from Metal to Nimbus
> and back to Metal, the Nimbus font continues to be used by a JFileChooser.
> This is because Synth `installDefaults `methods set the font, but its
> inverse methods `uninstallDefaults `do not remove them.
> Fix is
On Mon, 6 Feb 2023 22:01:28 GMT, Sergey Bylokhov wrote:
>> test/jdk/java/awt/image/VolatileImage/ReportRenderingError.java line 91:
>>
>>> 89: Graphics2D g = vi.createGraphics();
>>> 90: g.setColor(Color.RED);
>>> 91: g.drawImage(image, 0, 0, null); // <- can
On Wed, 14 Dec 2022 08:20:31 GMT, Sergey Bylokhov wrote:
> This is the next iteration of fixing the issue of rendering "broken" image.
> The fix for [JDK-7183828](https://bugs.openjdk.org/browse/JDK-7183828)
> changed the possible IllegalArgumentException during rendering to the
>
On Wed, 8 Feb 2023 02:19:52 GMT, Sergey Bylokhov wrote:
> We can initialize it as suggested but then we should somehow exclude the code
> path in it for the old "basic/DefaultMetalTheme" which do not use this
> property(like via MetalLookAndFeel.usingOcean())
I guess you are talking about
On Tue, 7 Feb 2023 20:35:52 GMT, Alexey Ivanov wrote:
>So it looks all Metal themes use MetalMenuBarUI. As such, moving the
>registration of MenuBarUI class id from OceanTheme to MetalLookAndFeel makes
>sense. Especially, taking into account that javadoc for MetalMenuBarUI states,
>it “is
On Tue, 7 Feb 2023 17:02:51 GMT, Damon Nguyen wrote:
> Also, I think it will be better to make the test automated..something like
> draw comboBox content into BufferedImage and pixel compare if it is same for
> disabled/enabled and fail if they are same and iterate for all L as it
> will also
On Wed, 18 Jan 2023 07:41:01 GMT, Manukumar V S wrote:
> Create a automated regression test for JComboBox titled border
> issues([JDK-8300269](https://bugs.openjdk.org/browse/JDK-8300269)).
>
> This test passes in JDK-20-ea+15 and fails in JDK-20-ea+16 and above.
This pull request has been
On Wed, 8 Feb 2023 01:33:18 GMT, Sergey Bylokhov wrote:
> If this test will be merged to another PR please close this PR.
Yes, I will close this
-
PR: https://git.openjdk.org/jdk/pull/12061
On Wed, 18 Jan 2023 07:41:01 GMT, Manukumar V S wrote:
> Create a automated regression test for JComboBox titled border
> issues([JDK-8300269](https://bugs.openjdk.org/browse/JDK-8300269)).
>
> This test passes in JDK-20-ea+15 and fails in JDK-20-ea+16 and above.
If this test will be merged
On Fri, 3 Feb 2023 13:07:41 GMT, Alexey Ivanov wrote:
> The specification isn't clear, and some parts somewhat contradict each other.
> Logically, the state should transition to DONE as soon as doInBackground
> completes. Then both done method and listeners are called when the state is
> DONE
On Fri, 13 Jan 2023 09:48:32 GMT, Prasanta Sadhukhan
wrote:
> getStyle().getFont() returns null as "getFontForState(context)" returns null
> which is because synth state for floating toolbar is invalid which is 0x201
> getStyle().getFont()" and "tabPane.getFont()" in normal valid case returns
On Mon, 6 Feb 2023 08:46:24 GMT, Prasanta Sadhukhan
wrote:
>> Issue is observed that after changing the Look & Feel from Metal to Nimbus
>> and back to Metal, the Nimbus font continues to be used by a JFileChooser.
>> This is because Synth `installDefaults `methods set the font, but its
>>
On Thu, 26 Jan 2023 20:58:45 GMT, Andrey Turbanov wrote:
> No need to fill elements of array with default values if it was just created.
> Java guarantees that all elements of numeric array have default values after
> allocations - 0.
Marked as reviewed by serb (Reviewer).
-
PR:
On Tue, 7 Feb 2023 23:23:24 GMT, Alexander Zuev wrote:
>> Check if the component is associated with the caret before calling methods
>> from it. Added test case that will make sure that will not happen again.
>
> Alexander Zuev has updated the pull request incrementally with one additional
>
On Tue, 7 Feb 2023 23:23:24 GMT, Alexander Zuev wrote:
>> Check if the component is associated with the caret before calling methods
>> from it. Added test case that will make sure that will not happen again.
>
> Alexander Zuev has updated the pull request incrementally with one additional
>
> Check if the component is associated with the caret before calling methods
> from it. Added test case that will make sure that will not happen again.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixe copyright year.
On Tue, 7 Feb 2023 23:07:55 GMT, Phil Race wrote:
>> Check if the component is associated with the caret before calling methods
>> from it. Added test case that will make sure that will not happen again.
>
> src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 1054:
>
>>
> Before the fix, a JComboBox in Nimbus L would have normal black text even
> when the JComboBox was disabled if SynthComboBoxRenderer was replaced with a
> DefaultListCellRenderer. This text should be greyed out like in other L's.
> When looking into the defaults for Nimbus L files for
On Tue, 7 Feb 2023 22:49:55 GMT, Alexander Zuev wrote:
> Check if the component is associated with the caret before calling methods
> from it. Added test case that will make sure that will not happen again.
src/java.desktop/share/classes/javax/swing/text/DefaultCaret.java line 1054:
> 1052:
Check if the component is associated with the caret before calling methods from
it. Added test case that will make sure that will not happen again.
-
Commit messages:
- 8301989: new javax.swing.text.DefaultCaret().setBlinkRate(N) results in NPE
Changes:
> FrameBorder and DialogBorder had border scaling issues similar to
> JInternalFrame. This fix addresses it by creating `AbstractMetalBorder` class
> within MetalBorder, that contains the common steps required for painting
> border for `FrameBorder`, `DialogBorder` and `InternalFrameBorder`.
>
On Fri, 3 Feb 2023 22:10:47 GMT, Harshitha Onkar wrote:
> Since `isResizable` has to be overridden in this case too, retaining the
> original class hierarchy.
Reasonable, thanks.
-
PR: https://git.openjdk.org/jdk/pull/12391
On Fri, 3 Feb 2023 22:43:22 GMT, Harshitha Onkar wrote:
>> FrameBorder and DialogBorder had border scaling issues similar to
>> JInternalFrame. This fix addresses it by creating `AbstractMetalBorder`
>> class within MetalBorder, that contains the common steps required for
>> painting border
On Mon, 6 Feb 2023 09:24:23 GMT, Prasanta Sadhukhan
wrote:
>> Spec for
>> [MetalLookAndFeel](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java#L247)
>> says:
>> "...MetalLookAndFeel registers an entry for each of the classes
On Tue, 20 Sep 2022 18:24:26 GMT, Alisen Chung wrote:
> Fixed test bug where mouse location was being calculated before robot
> mouseMove operation was complete
This pull request has now been integrated.
Changeset: 2a579ab8
Author:Alisen Chung
URL:
On Tue, 7 Feb 2023 17:08:07 GMT, Julian Waters wrote:
> Alright here you go :) https://bugs.openjdk.org/browse/JDK-8301994
Thank you, @TheShermanTanker.
Do you still want to keep the changes?
If it's not too critical, I would rather prefer you revert the changes to
`awt_List.cpp`.
On Tue, 7 Feb 2023 17:20:19 GMT, Alexander Scherbatiy
wrote:
>> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font
>> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE
>> detection by checking SLES os name property in `/etc/os-release` file.
>>
>>
> [JDK-8278549](https://bugs.openjdk.org/browse/JDK-8278549)` UNIX sun/font
> coding misses SUSE distro detection on recent distro SUSE 15` adds SuSE
> detection by checking SLES os name property in `/etc/os-release` file.
>
> `opensuse/leap:15.4` docker defines os name property as `"openSUSE
On Fri, 3 Feb 2023 14:13:34 GMT, Prasanta Sadhukhan
wrote:
>> SwingWorker done() method [spec
>> ](https://github.com/openjdk/jdk/blob/master/src/java.desktop/share/classes/javax/swing/SwingWorker.java#L452)
>> says "Executed on the Event Dispatch Thread after the doInBackground method
>> is
On Tue, 7 Feb 2023 16:11:59 GMT, Alexey Ivanov wrote:
>> Perhaps, but I'll leave that to the discretion of the client libs group. Are
>> the new changes fine with you though?
>
> I'd rather remove the offending commented out code than change its formatting.
>
> Could you submit a bug, please,
On Tue, 7 Feb 2023 08:15:58 GMT, Prasanta Sadhukhan
wrote:
> https://github.com/openjdk/jdk/blob/98433a2f6e7fe97e03ed26673c9925d7b26466bf/src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java#L552-L558
>
> The present code SynthComboBoxRenderer does enable/disable the
On Tue, 7 Feb 2023 15:57:35 GMT, Julian Waters wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_List.cpp line 183:
>>
>>> 181: // SetWindowPos(hList, 0, 0, 0, w, h, flags);
>>> 182: // }
>>> 183: //
>>
>> Maybe it's time to remove this commented out code? It's been commented
On Tue, 7 Feb 2023 15:14:20 GMT, Alexey Ivanov wrote:
>> Julian Waters has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - D3DVertexCacher.cpp
>> - awt_List.cpp
>
> src/java.desktop/windows/native/libawt/windows/awt_List.cpp line 183:
>
On Mon, 6 Feb 2023 03:31:15 GMT, Julian Waters wrote:
>> I don't know. I'm quite sure I was using the full command in `cmd.exe` after
>> calling some `vcvars64.bat`. I added the `` character because it's a little
>> long to be recorded here. I don't really care which separator is used. You
>>
On Tue, 7 Feb 2023 01:17:18 GMT, Julian Waters wrote:
>> Several comments are technically broken in Windows code, this change cleans
>> up the broken comments that managed to slip past reviewers during Integration
>
> Julian Waters has updated the pull request incrementally with two additional
On Tue, 7 Feb 2023 04:08:09 GMT, Phil Race wrote:
> How did you miss this ?
Oversight, my mistake, it happens sometimes
> Bigger question, why is it important ?
Code quality, constructors in C++ should generally have the initializer list in
the same order as their declaration. It helps
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
>
On Mon, 6 Feb 2023 12:35:16 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in harfbuzz files on Windows (CP932: Japanese
> locale)
>
>
> d:\github-forked\jdk\src\java.desktop\share\native\libharfbuzz\hb.hh(1):
>
On Mon, 6 Feb 2023 12:34:36 GMT, Yasumasa Suenaga wrote:
> This is subtask of https://github.com/openjdk/jdk/pull/12427 .
>
> I have seen C4819 warning in libfreetype files on Windows (CP932: Japanese
> locale)
>
>
>
On Tue, 7 Feb 2023 01:12:06 GMT, Phil Race wrote:
> I grep'ed (with `-i`) in `doc` directory with `LANG`, `utf`, `locale`, but I
> could not find out them. I guess locale of build environment is not mentioned
> clearly. Is it correct?
Yes, it is unfortunately not documented. :-( There is an
On Mon, 6 Feb 2023 19:04:07 GMT, Damon Nguyen wrote:
>> Before the fix, a JComboBox in Nimbus L would have normal black text even
>> when the JComboBox was disabled if SynthComboBoxRenderer was replaced with a
>> DefaultListCellRenderer. This text should be greyed out like in other L's.
>>
On Fri, 20 Jan 2023 12:01:06 GMT, Daniel Jeliński wrote:
>> Please review this patch that fixes and re-enables a few warnings in libawt
>> compilation.
>>
>> Verified that debug and release builds finish successfully on Win, Mac and
>> Linux. Also verified that client libs tests still pass.
>
46 matches
Mail list logo
