On Wed, 20 Sep 2023 23:08:26 GMT, Alisen Chung wrote:
>> Opening some swing tests:
>> 1 javax/swing/LayoutComparator/4907772/bug4907772.java
>> 2 javax/swing/LayoutComparator/4979794/bug4979794.java
>> 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java
>> 4 javax/swing/RootPaneC
On Wed, 20 Sep 2023 05:29:30 GMT, Abhishek Kumar wrote:
> Few closed JButton swing manual test converted to automated and open sourced.
This pull request has now been integrated.
Changeset: 9f5d2b94
Author:Abhishek Kumar
URL:
https://git.openjdk.org/jdk/commit/9f5d2b947f7d70babba663
On Wed, 20 Sep 2023 16:55:30 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
> Alexand
On Wed, 20 Sep 2023 16:26:16 GMT, Damon Nguyen wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> test/jdk/javax/swing/JScrollPane/bug4467063.java line 96:
>
>> 94: }
>> 95: });
>> 96:
> Open sourcing these Swing Scroll related tests:
>
> javax/swing/JScrollBar/4495822/bug4495822.java
> javax/swing/JScrollBar/4696826/bug4696826.java
> javax/swing/JScrollBar/4842792/bug4842792.java
> javax/swing/JScrollPane/4247092/bug4247092.java
> javax/swing/JScrollPane/4264640/bug4264640.java
> Moving some tests to open
> 5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java
> 6 javax/swing/SpringLayout/4756178/bug4756178.java
> 7 javax/swing/SpringLayout/4803649/bug4803649.java
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision
On Thu, 21 Sep 2023 00:53:19 GMT, Alisen Chung wrote:
>> Moving some tests to open
>> 5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java
>> 6 javax/swing/SpringLayout/4756178/bug4756178.java
>> 7 javax/swing/SpringLayout/4803649/bug4803649.java
>
> Alisen Chung has updated the pull request in
> Moving some tests to open
> 5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java
> 6 javax/swing/SpringLayout/4756178/bug4756178.java
> 7 javax/swing/SpringLayout/4803649/bug4803649.java
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision
The BeanContext.* package was added (by me) quite early in the lifetime
of java beans (1.2); based loosely on some of the concepts of the
opendoc component framework,
it was intended to provide a "container" for JavaBeans components to
collaborate with each other by exposing both their presence
> Opening some swing tests:
> 1 javax/swing/LayoutComparator/4907772/bug4907772.java
> 2 javax/swing/LayoutComparator/4979794/bug4979794.java
> 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java
> 4 javax/swing/RootPaneChecking/RootPaneChecking.java
Alisen Chung has updated the p
Moving tests from closed to open
8 javax/swing/SwingGraphics/VolatileBackBuffer/MultimonVImage.java
9 javax/swing/SwingUtilities/4859570/bug4859570.java
10 javax/swing/SwingUtilities/4936652/bug4936652.java
11 javax/swing/ToolTipManager/4768127/bug4768127.java
-
Commit messages:
- mo
Moving some tests to open
5 javax/swing/ScrollPaneLayout/4688907/bug4688907.java
6 javax/swing/SpringLayout/4756178/bug4756178.java
7 javax/swing/SpringLayout/4803649/bug4803649.java
-
Commit messages:
- moving tests to open
- named test frames
- finished updating SpringLayoutSetWi
On Wed, 20 Sep 2023 21:12:55 GMT, Damon Nguyen wrote:
> Converted test needs headful tag added to avoid failures.
This pull request has now been integrated.
Changeset: c04c9ea3
Author:Damon Nguyen
URL:
https://git.openjdk.org/jdk/commit/c04c9ea3615aad875ccb7e103e2d885b34cda7f6
Stats
On Wed, 20 Sep 2023 22:04:55 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove viewChanged
>
> test/jdk/javax/swing/JViewport/bug4546474.java line 37:
>
>> 35: public class bug4546474 {
>> 36:
On Wed, 20 Sep 2023 22:03:22 GMT, Damon Nguyen wrote:
>> Converted test needs headful tag added to avoid failures.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove viewChanged
Looks OK now. You can fix the statics if
> Converted test needs headful tag added to avoid failures.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Make static vars local
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15847/files
- new: https://git.ope
Hi,
Samuel, please correct me if I'm wrong. The requirement is for the
per-user (or system-wide) enablement of accessibility. The
per-application setup is a bad user experience, and it would be nice
to have a single point - properties file - that enables it.
Java 8 achieves this by putting the ac
> Converted test needs headful tag added to avoid failures.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove viewChanged
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15847/files
- new: https://git.openjdk
On Wed, 20 Sep 2023 21:56:50 GMT, Phil Race wrote:
>> The adjustmentListener therefore seems irrelevant too.
>
> Seems to me the test reduces to
> import javax.swing.JPanel;
> import javax.swing.JScrollBar;
> import javax.swing.JScrollPane;
>
> public class bug4546474 {
>
> public static v
On Wed, 20 Sep 2023 21:53:09 GMT, Phil Race wrote:
>> test/jdk/javax/swing/JViewport/bug4546474.java line 51:
>>
>>> 49: if (!viewChanged) {
>>> 50: viewChanged = true;
>>> 51: }
>>
>> What purpose does viewChanged have ?
>> Its set but never read.
>
> The adjustment
On Wed, 20 Sep 2023 21:52:37 GMT, Phil Race wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove size
>
> test/jdk/javax/swing/JViewport/bug4546474.java line 51:
>
>> 49: if (!viewChanged) {
>> 50:
On Wed, 20 Sep 2023 21:54:17 GMT, Damon Nguyen wrote:
>> Converted test needs headful tag added to avoid failures.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove size
test/jdk/javax/swing/JViewport/bug4546474.java
> Converted test needs headful tag added to avoid failures.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove size
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15847/files
- new: https://git.openjdk.org/jd
Can you explain your need for this (a lot) better ?
The location and loading is specified to be done by
java.util.ServiceLoader.
Whilst this might be possible by some enhanced syntax, which if present
invokes ServiceLoader specifying a ClassLoader for this jar file, it
would clearly be new API
> Converted test needs headful tag added to avoid failures.
Damon Nguyen has updated the pull request incrementally with one additional
commit since the last revision:
Remove invokeAndWait and sleep entirely
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15847/files
- new
On Wed, 20 Sep 2023 21:12:55 GMT, Damon Nguyen wrote:
> Converted test needs headful tag added to avoid failures.
Since this test doesn't display anything I don't see why it needs sleep at all
Nor does it need invokeAndWait.
Its a simple unit test.
If the test needs real events to fire then it
On Wed, 20 Sep 2023 21:12:55 GMT, Damon Nguyen wrote:
> Converted test needs headful tag added to avoid failures.
No this is not the right fix. Do not push it.
-
PR Comment: https://git.openjdk.org/jdk/pull/15847#issuecomment-1728455652
On Wed, 20 Sep 2023 21:12:55 GMT, Damon Nguyen wrote:
> Converted test needs headful tag added to avoid failures.
Given the CI test failure, this is probably the right fix so that it can be
integrated quickly.
As a follow-onto this, I see that PR #15802 deliberately tried to make this
test he
On Wed, 20 Sep 2023 21:29:21 GMT, Phil Race wrote:
> How did this get through ? Was it not tested before pushing ? And if a test
> needs "Robot" it surely expects a headful envt ? In fact I am going to say
> that the problem here is using Robot at all. You don't need to add headful,
> you just
On Wed, 20 Sep 2023 21:12:55 GMT, Damon Nguyen wrote:
> Converted test needs headful tag added to avoid failures.
How did this get through ? Was it not tested before pushing ?
And if a test needs "Robot" it surely expects a headful envt ?
In fact I am going to say that the problem here is using
On Wed, 20 Sep 2023 21:12:55 GMT, Damon Nguyen wrote:
> Converted test needs headful tag added to avoid failures.
Thumbs up. This is a trivial fix and does not need to wait 24 hours.
-
Marked as reviewed by dcubed (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15847#pullr
Converted test needs headful tag added to avoid failures.
-
Commit messages:
- Add headful tag
Changes: https://git.openjdk.org/jdk/pull/15847/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15847&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8316627
Stats: 1 line
Hi,
Java accessibility.properties (.accessibility.properties) allows
setting the class name of the accessibility provider but not the jar
file containing it.
Was there any consideration that prevents this feature from being
implemented, such as security?
It would be nice to have it implemented t
On Fri, 16 Jun 2023 23:16:53 GMT, Jeremy wrote:
>> # Problem Summary
>>
>> For non-opaque windows, Window#paint calls `gg.fillRect(0, 0, getWidth(),
>> getHeight())` before `super.paint(g)`.
>>
>> This can cause flickering on Mac, and the flickering seems to have gotten
>> much worse in recen
On Thu, 17 Aug 2023 21:37:17 GMT, Phil Race wrote:
>> The private field `mask` is never used in `JFormattedTextField`.
>>
>> I couldn't find any usages of the field, including JNI. Therefore, it is
>> safe to remove.
>
> Marked as reviewed by prr (Reviewer).
> > @prrace could you confirm, plea
On Tue, 19 Sep 2023 17:49:19 GMT, Damon Nguyen wrote:
>> This is to convert and open source test:
>> javax/swing/JToolBar/4203039/bug4203039.java
>>
>> This manual test now uses PassFailJFrame to handle the display for the
>> instructions text as well as the pass/fail buttons.
>
> Damon Nguye
On Tue, 8 Aug 2023 08:44:25 GMT, Sergei Tachenov wrote:
> Hello!
>
> I'm a member of the UI team in JetBrains IntelliJ department, and we have
> this bug with popup menus being shown on the wrong monitor in multi-monitor
> environments:
>
> https://youtrack.jetbrains.com/issue/JBR-5824/Dual-m
On Sun, 20 Aug 2023 17:53:52 GMT, Ichiroh Takiguchi
wrote:
>> "character set of font" (font charset) table was created by "Rich Text
>> Format Specification 1.9.1"
>> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
>> It refers windgi.h
>> https://learn.mi
On Sun, 20 Aug 2023 17:51:06 GMT, Ichiroh Takiguchi
wrote:
>> "character set of font" (font charset) table was created by "Rich Text
>> Format Specification 1.9.1"
>> https://interoperability.blob.core.windows.net/files/Archive_References/[MSFT-RTF].pdf
>> It refers windgi.h
>> https://learn.mi
On Mon, 17 Jul 2023 20:59:05 GMT, Sergey Bylokhov wrote:
> I have found that MTPerLineTransformValidation - one of our slowest stress
> test spends most of the time not in the code related to the colors
> conversion(as it was intended) but in the initialization of the native
> cmm-transforms.
On Wed, 30 Aug 2023 18:23:11 GMT, Damon Nguyen wrote:
>> Previously, a new key combination involving the option key was added to Aqua
>> LAF for JTextAreas. In doing so, some code was removed that created this
>> regression. The regression caused the right option key on Mac OS to
>> incorrectl
On Tue, 12 Sep 2023 15:27:18 GMT, Alexey Ivanov wrote:
>> To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I
>> updated the instructions for the
>> `test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The
>> commands to create the symbolic links are mar
On Tue, 12 Sep 2023 13:43:40 GMT, Alexey Ivanov wrote:
> > Shouldn't we mention here a window added by `testUI` via builder?
>
> I don't think it's necessary: the builder uses `addTestWindow` under the
> hood. It's the builder that requires documentation.
>
> In fact, the entire class requires
On Tue, 12 Sep 2023 14:11:15 GMT, Alexey Ivanov wrote:
>>> Could be… On the other hand, in post XHTML era, the elements are usually in
>>> lower-case. Thus we should stick with it and use lowercase HTML elements
>>> anyway.
>>
>> https://www.w3schools.com/html/html_elements.asp
>>
>>> HTML is
On Wed, 20 Sep 2023 01:46:35 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing several manual applet tests
>>
>>
>> test/jdk/java/awt/Frame/DefaultSizeTest.java
>> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
>> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
>> test/j
> Open sourcing few tests:
>
> java/awt/Frame/FrameRepackTest.java
> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
> java/awt/Frame/WindowMoveTest.java
Alexander Zvegintsev has updated the pull request incrementally with one
additio
On Wed, 20 Sep 2023 16:41:10 GMT, Harshitha Onkar wrote:
>> Sure, converted.
>
> Automated test changes look good.
> `handleEvent` and `keyDown` is marked for deprecation, should it be replaced
> with `processEvent()`?
I'm not sure that in this case we will test the same thing that the test wa
On Wed, 20 Sep 2023 14:27:58 GMT, Aleksey Shipilev wrote:
>> Correct me if I'm wrong, but I think if we ask for null here it may find a
>> PrintService that does not support PRINTABLE flavor so SkippedException will
>> not be thrown because svc.length will be greater than 0 and we may end up
>
On Wed, 20 Sep 2023 11:04:17 GMT, Aleksey Shipilev wrote:
>> For NullClipARGB we are throwing SkippedException only if instance of caught
>> exception is PrinterException. All other exceptions are considered unrelated
>> to printer configuration.
>>
>> For CountPrintServices we want to throw S
On Tue, 19 Sep 2023 14:45:47 GMT, Michal Sobierski wrote:
> For NullClipARGB we are throwing SkippedException only if instance of caught
> exception is PrinterException. All other exceptions are considered unrelated
> to printer configuration.
>
> For CountPrintServices we want to throw Skippe
On Wed, 20 Sep 2023 13:09:55 GMT, Michal Sobierski wrote:
>> test/jdk/java/awt/print/PrinterJob/ImagePrinting/NullClipARGB.java line 43:
>>
>>> 41:
>>> 42: public static void main( String[] args ) {
>>> 43: PrintService[] svc =
>>> PrintServiceLookup.lookupPrintServices(DocFlavor.S
For NullClipARGB we are throwing SkippedException only if instance of caught
exception is PrinterException. All other exceptions are considered unrelated to
printer configuration.
For CountPrintServices we want to throw SkippedException in the case when
lpstat is not installed, where an IOExcep
On Wed, 20 Sep 2023 01:40:54 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java line 50:
>>
>>> 48: If the above is true, then click Pass, else click Fail.
>>> 49: """;
>>> 50:
>>
>> This can be converted to automated test using r
On Wed, 20 Sep 2023 05:41:01 GMT, Abhishek Kumar wrote:
>> Opening some swing tests:
>> 1 javax/swing/LayoutComparator/4907772/bug4907772.java
>> 2 javax/swing/LayoutComparator/4979794/bug4979794.java
>> 3 javax/swing/LegacyGlueFocusTraversalPolicy/4765272/bug4765272.java
>> 4 javax/swing/RootPan
On Wed, 20 Sep 2023 16:08:40 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
> Alexand
On Tue, 19 Sep 2023 21:51:01 GMT, Phil Race wrote:
> Are you saying this test would be better with an enhancement to
> PassFailJFrame ?
@prrace Yes. Or perhaps, with a reduced set implemented as another class.
> But it is OK right, just more clunky than it could be .. ?
Yes, it is OK. Yet I'
On Wed, 20 Sep 2023 09:38:19 GMT, Tejesh R wrote:
> Open sourcing these Swing Scroll related tests:
>
> javax/swing/JScrollBar/4495822/bug4495822.java
> javax/swing/JScrollBar/4696826/bug4696826.java
> javax/swing/JScrollBar/4842792/bug4842792.java
> javax/swing/JScrollPane/4247092/bug4247092.ja
On Mon, 18 Sep 2023 22:10:54 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTree/4696499/bug4696499.java
> javax/swing/JTree/5039542/bug5039542.java
> javax/swing/JViewport/4546474/bug4546474.java
> javax/swing/JViewport/4677611/bug4677611.java
> javax/swing/Key
> These are the tests being converted:
>
> javax/swing/JTree/4696499/bug4696499.java
> javax/swing/JTree/5039542/bug5039542.java
> javax/swing/JViewport/4546474/bug4546474.java
> javax/swing/JViewport/4677611/bug4677611.java
> javax/swing/KeyboardManager/4345798/bug4345798.java
Damon Nguyen has u
On Wed, 20 Sep 2023 03:50:38 GMT, Prasanta Sadhukhan
wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review comments changes
>
> test/jdk/javax/swing/JTree/bug5039542.java line 33:
>
>> 31:
>> 32: public class b
On Wed, 20 Sep 2023 09:47:36 GMT, Abhishek Kumar wrote:
>> Few closed JButton swing manual test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Marked as rev
> Open sourcing few tests:
>
> java/awt/Frame/FrameRepackTest.java
> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
> java/awt/Frame/WindowMoveTest.java
Alexander Zvegintsev has updated the pull request incrementally with two
additio
On Wed, 13 Sep 2023 15:53:30 GMT, Alexander Zuev wrote:
> Clean up and open source five tests:
> javax/swing/DefaultListCellRenderer/4180943/bug4180943.java
> javax/swing/DefaultListModel/4466250/bug4466250.java
> javax/swing/DefaultListSelectionModel/4140619/bug4140619.java
> javax/swing/Default
On Wed, 20 Sep 2023 14:07:17 GMT, Alexey Ivanov wrote:
>> **Root cause**
>>
>> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has
>> zero length.
>>
>> The test fails if the right half of the image with the rendered glyph
>> contains only pixels of background colour. In
> **Root cause**
>
> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has
> zero length.
>
> The test fails if the right half of the image with the rendered glyph
> contains only pixels of background colour. In this case, the left half of the
> image is also blank. It's so
On Thu, 17 Aug 2023 21:37:17 GMT, Phil Race wrote:
>> The private field `mask` is never used in `JFormattedTextField`.
>>
>> I couldn't find any usages of the field, including JNI. Therefore, it is
>> safe to remove.
>
> Marked as reviewed by prr (Reviewer).
> @prrace could you confirm, please
On Fri, 16 Jun 2023 23:16:53 GMT, Jeremy wrote:
>> # Problem Summary
>>
>> For non-opaque windows, Window#paint calls `gg.fillRect(0, 0, getWidth(),
>> getHeight())` before `super.paint(g)`.
>>
>> This can cause flickering on Mac, and the flickering seems to have gotten
>> much worse in recen
On Wed, 20 Sep 2023 07:52:33 GMT, Brice Dutheil wrote:
> I encountered an issue very similar to this problem, is there any chance to
> see progress on the fix ?
@bric3 This is not how it works… Yet feel free to propose a patch that
addresses the problem. It could be based on this PR.
I looks
On Wed, 20 Sep 2023 09:47:36 GMT, Abhishek Kumar wrote:
>> Few closed JButton swing manual test converted to automated and open sourced.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comment update
Marked as rev
On Wed, 20 Sep 2023 06:16:21 GMT, Prasanta Sadhukhan
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed unused robot instance
>
> test/jdk/javax/swing/JButton/bug4234034.java line 64:
>
>> 62:
> Few closed JButton swing manual test converted to automated and open sourced.
Abhishek Kumar has updated the pull request incrementally with one additional
commit since the last revision:
Review comment update
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15835/files
-
Open sourcing these Swing Scroll related tests:
javax/swing/JScrollBar/4495822/bug4495822.java
javax/swing/JScrollBar/4696826/bug4696826.java
javax/swing/JScrollBar/4842792/bug4842792.java
javax/swing/JScrollPane/4247092/bug4247092.java
javax/swing/JScrollPane/4264640/bug4264640.java
javax/swing/J
On Fri, 16 Jun 2023 23:16:53 GMT, Jeremy wrote:
>> # Problem Summary
>>
>> For non-opaque windows, Window#paint calls `gg.fillRect(0, 0, getWidth(),
>> getHeight())` before `super.paint(g)`.
>>
>> This can cause flickering on Mac, and the flickering seems to have gotten
>> much worse in recen
On Fri, 8 Sep 2023 08:26:16 GMT, Matthias Baesken wrote:
> There are some remaining places in 'general' JDK code (= code not related to
> e.g. a specific tool) getting properties like :
>
> osName = System.getProperty(os.name)
>
> https://github.com/openjdk/jdk/blob/master/src/java.management/
On Mon, 18 Sep 2023 06:19:05 GMT, Arno Zeller wrote:
> The test fails on newer SLES versions that have RobotoSlab-Regular.ttf as
> default font. I suggest to try getting a DejaVu font as default on Linux
> because it is known to work without issues.
This pull request has been closed without be
On Tue, 19 Sep 2023 19:57:25 GMT, Phil Race wrote:
> I'd really like to dig into the specifics of what's happening here for the
> advances of the code points here - and see what they are before truncation
> (ie what is the 26.6 value) as well as afterwards. I don't know what we'll
> find but I
76 matches
Mail list logo
