On Tue, 5 Dec 2023 19:35:50 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Tue, 5 Dec 2023 16:48:55 GMT, Anton Bobrov wrote:
> This patch adds re-try logic to libpipewire screencast error handling as
> discussed in PR #16794 and also brings some additional error handling and
> thread safety improvements. Specifically around cleanup order where incorrect
> ordering
On Tue, 5 Dec 2023 20:45:58 GMT, Anton Bobrov wrote:
>> src/java.desktop/unix/classes/sun/awt/screencast/ScreencastHelper.java line
>> 223:
>>
>>> 221: } else if (retVal == ERROR) {
>>> 222: throw new RuntimeException(
>>> 223: "Screen capture has failed due
Larry,
I submitted https://bugs.openjdk.org/browse/JDK-8321428.
I've assigned it to you, on the assumption you are interested.
Obviously no particular urgency around this.
-phil.
On 9/21/23 4:48 PM, Laurence Cable wrote:
Hi Phillip, inline ...
On 9/21/23 4:16 PM, Philip Race wrote:
Hi Larry,
On Tue, 5 Dec 2023 08:30:44 GMT, Sergey Bylokhov wrote:
> The Java_java_awt_MenuComponent_initIDs function is empty on Windows and
> macOS, on linux it has some code but it is unused.
>
> This issue is similar to https://bugs.openjdk.org/browse/JDK-8318091
This pull request has now been integr
On Tue, 5 Dec 2023 20:22:32 GMT, Phil Race wrote:
>> This patch adds re-try logic to libpipewire screencast error handling as
>> discussed in PR #16794 and also brings some additional error handling and
>> thread safety improvements. Specifically around cleanup order where
>> incorrect orderin
On Tue, 5 Dec 2023 20:38:46 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else we
On Tue, 5 Dec 2023 20:32:49 GMT, Phil Race wrote:
>> With JDK 17, I still see the exception:
>>
>>
>> Exception in thread "main" java.awt.print.PrinterException
>> at java.desktop/sun.lwawt.macosx.CPrinterJob.print(CPrinterJob.java:393)
>> at PrinterDevice.main(PrinterDevice.java:68)
On Tue, 5 Dec 2023 20:25:46 GMT, Alexey Ivanov wrote:
>> On JDK 17 and earlier you will reach this line with this test as written
>> And without that exception, the test would pass when it should fail.
>
> With JDK 17, I still see the exception:
>
>
> Exception in thread "main" java.awt.print.P
On Tue, 5 Dec 2023 20:28:28 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320443
>
> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 109:
>
>> 107: GraphicsDevice gd = gConfig
On Tue, 5 Dec 2023 20:13:50 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else we
> For as long as we've had the macOS port, it seems that queries on the
> GraphicsConfiguration associated with
> a printer would give you null for the defaultTransform.
> Clearly this API isn't a popular one to call in such a context else we'd have
> had lots of reports.
> We have a test that wo
On Tue, 5 Dec 2023 20:13:50 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else we
On Tue, 5 Dec 2023 20:07:56 GMT, Phil Race wrote:
>> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 71:
>>
>>> 69: if (failed) {
>>> 70: throw new RuntimeException("Test failed but no exception
>>> propagated.");
>>> 71: }
>>
>> A comment that `pj.print`
On Tue, 5 Dec 2023 16:48:55 GMT, Anton Bobrov wrote:
> This patch adds re-try logic to libpipewire screencast error handling as
> discussed in PR #16794 and also brings some additional error handling and
> thread safety improvements. Specifically around cleanup order where incorrect
> ordering
On Tue, 5 Dec 2023 19:41:54 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320443
>
> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 52:
>
>> 50: public class PrinterDevice implements
On Tue, 5 Dec 2023 20:07:15 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 52:
>>
>>> 50: public class PrinterDevice implements Printable {
>>> 51:
>>> 52: static volatile boolean failed = false;
>>
>> Is it really needed? In all the cases w
On Tue, 5 Dec 2023 19:45:34 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8320443
>
> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 30:
>
>> 28: * @summary Checks that the PrinterGr
> For as long as we've had the macOS port, it seems that queries on the
> GraphicsConfiguration associated with
> a printer would give you null for the defaultTransform.
> Clearly this API isn't a popular one to call in such a context else we'd have
> had lots of reports.
> We have a test that wo
On Tue, 5 Dec 2023 19:35:50 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Mon, 4 Dec 2023 23:31:47 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else we
> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For
> `DIRECTORIES_ONLY `mode, there may not be any directories in home directory
> and due to that test failed. Added the code to create temporary directories
> and files for the test.
> Tested the current change on the
On Tue, 5 Dec 2023 19:21:52 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Tue, 5 Dec 2023 18:36:13 GMT, Abhishek Kumar wrote:
> > Is it intentional? It's the problem in
> > [JDK-6972078](https://bugs.openjdk.org/browse/JDK-6972078)… that
> > directories can't be selected.
>
> Not intentional though. Thought of creating a single folder with the mix of
> files and
On Tue, 28 Nov 2023 23:40:45 GMT, Damon Nguyen wrote:
> The initial issue was a padding issue for JButton when HTML content was set
> as the button's text.
> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
> [JDK-83
On Tue, 5 Dec 2023 19:05:12 GMT, Damon Nguyen wrote:
> > @DamonGuy Reverted changes fixes the issue. Since you are reverting #12520,
> > shouldn't the corresponding test HtmlButtonWithTextAndIcon.java be reverted
> > too? Copyright years need to be updated for some files.
>
> Alexander brought
On Tue, 5 Dec 2023 19:11:48 GMT, Damon Nguyen wrote:
>> The initial issue was a padding issue for JButton when HTML content was set
>> as the button's text.
>> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
>> [JD
> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For
> `DIRECTORIES_ONLY `mode, there may not be any directories in home directory
> and due to that test failed. Added the code to create temporary directories
> and files for the test.
> Tested the current change on the
On Tue, 5 Dec 2023 18:18:53 GMT, Damon Nguyen wrote:
>> The initial issue was a padding issue for JButton when HTML content was set
>> as the button's text.
>> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
>> [JD
> The initial issue was a padding issue for JButton when HTML content was set
> as the button's text.
> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
> [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are
On Tue, 5 Dec 2023 18:34:52 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Mon, 20 Nov 2023 23:58:30 GMT, Phil Race wrote:
> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I
> realised that although the proposed
> changes there may help, the problem would be inconsequential except that if
> anything causes an app to
> call PrintService.get
On Tue, 5 Dec 2023 13:49:44 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java
> line 217:
On Tue, 5 Dec 2023 14:00:33 GMT, Alexey Ivanov wrote:
> So, `FILES_AND_DIRECTORIES` mode is tested with directories only. Is it
> intentional? It's the problem in
> [JDK-6972078](https://bugs.openjdk.org/browse/JDK-6972078)… that directories
> can't be selected.
Yes, it is tested with directo
On Tue, 5 Dec 2023 18:09:39 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix
>
> Is it possible to shorten the subject of the issue? It is too long and wordy,
> yet it doesn'
> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For
> `DIRECTORIES_ONLY `mode, there may not be any directories in home directory
> and due to that test failed. Added the code to create temporary directories
> and files for the test.
> Tested the current change on the
On Mon, 20 Nov 2023 23:58:30 GMT, Phil Race wrote:
> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I
> realised that although the proposed
> changes there may help, the problem would be inconsequential except that if
> anything causes an app to
> call PrintService.get
On Tue, 5 Dec 2023 18:18:53 GMT, Damon Nguyen wrote:
>> The initial issue was a padding issue for JButton when HTML content was set
>> as the button's text.
>> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
>> [JD
On Thu, 30 Nov 2023 03:34:08 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> There was a typo for color conversion instead of dstColorSpace function
> srcColorSpace was used. Please review and let me know your suggestions if
> any.
>
> Renjith.
The fix looks good to me.
I agree w
On Tue, 5 Dec 2023 18:15:40 GMT, Damon Nguyen wrote:
>> The initial issue was a padding issue for JButton when HTML content was set
>> as the button's text.
>> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
>> [JD
> The initial issue was a padding issue for JButton when HTML content was set
> as the button's text.
> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
> [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are
On Tue, 5 Dec 2023 12:17:55 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Tue, 5 Dec 2023 08:30:44 GMT, Sergey Bylokhov wrote:
> The Java_java_awt_MenuComponent_initIDs function is empty on Windows and
> macOS, on linux it has some code but it is unused.
>
> This issue is similar to https://bugs.openjdk.org/browse/JDK-8318091
Marked as reviewed by aivanov (Review
> The initial issue was a padding issue for JButton when HTML content was set
> as the button's text.
> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
> [JDK-8302173](https://bugs.openjdk.org/browse/JDK-8302173) are
On Tue, 28 Nov 2023 22:34:44 GMT, Alisen Chung wrote:
> Added delays to stabilize test, test passes 50 times consecutively
This pull request has now been integrated.
Changeset: db5613af
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/db5613af89a2d4ab5a8998ad1d43384778974
On Tue, 5 Dec 2023 08:30:44 GMT, Sergey Bylokhov wrote:
> The Java_java_awt_MenuComponent_initIDs function is empty on Windows and
> macOS, on linux it has some code but it is unused.
>
> This issue is similar to https://bugs.openjdk.org/browse/JDK-8318091
Marked as reviewed by prr (Reviewer).
On Fri, 17 Nov 2023 20:21:32 GMT, Alexey Ivanov wrote:
> Update `FileChooserSymLinkTest.java` to simplify its implementation by
> replacing `List` with `JFrame` of its `createTestUI` which now uses
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)` instead of
> `PassFailJFrame.Bui
> Update `FileChooserSymLinkTest.java` to simplify its implementation by
> replacing `List` with `JFrame` of its `createTestUI` which now uses
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)` instead of
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowListCreator)`.
>
> The
On Thu, 30 Nov 2023 18:34:18 GMT, Damon Nguyen wrote:
>> The initial issue was a padding issue for JButton when HTML content was set
>> as the button's text.
>> [JDK-8282772](https://bugs.openjdk.org/browse/JDK-8282772),
>> [JDK-8015854](https://bugs.openjdk.org/browse/JDK-8015854), and
>> [J
On Tue, 5 Dec 2023 17:25:54 GMT, Alisen Chung wrote:
>> Added delays to stabilize test, test passes 50 times consecutively
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> updated test delays
Fix looks good and works on old
On Tue, 5 Dec 2023 17:25:54 GMT, Alisen Chung wrote:
>> Added delays to stabilize test, test passes 50 times consecutively
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> updated test delays
Marked as reviewed by azvegint
> Update `FileChooserSymLinkTest.java` to simplify its implementation by
> replacing `List` with `JFrame` of its `createTestUI` which now uses
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)` instead of
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowListCreator)`.
>
> The
On Tue, 5 Dec 2023 01:12:12 GMT, Alexander Zvegintsev
wrote:
>> Updated changes not reflected on the PR.
>
> I don't see the 100 ms changes either, looks like you didn't push the commit.
oops! just pushed
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16867#discussion_r1416
On Tue, 5 Dec 2023 06:26:03 GMT, Alisen Chung wrote:
>> Added delays to stabilize test, test passes 50 times consecutively
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> updated test
@azvegint @honkar-jdk i've updated the
> Added delays to stabilize test, test passes 50 times consecutively
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
updated test delays
-
Changes:
- all: https://git.openjdk.org/jdk/pull/16867/files
- new: https://g
On Fri, 17 Nov 2023 20:01:55 GMT, Alexey Ivanov wrote:
> Enhance `PassFailJFrame` for single-window test UI which is the most common
> case so that there's no need to return `List.of`.
>
> With this change, the lambda or method reference passed to `Builder.testUI`
> will return Window instead
On Tue, 5 Dec 2023 16:48:55 GMT, Anton Bobrov wrote:
> This patch adds re-try logic to libpipewire screencast error handling as
> discussed in PR #16794 and also brings some additional error handling and
> thread safety improvements. Specifically around cleanup order where incorrect
> ordering
This patch adds re-try logic to libpipewire screencast error handling as
discussed in PR #16794 and also brings some additional error handling and
thread safety improvements. Specifically around cleanup order where incorrect
ordering lead to native memory corruption issues, and lock/unlock accou
On Thu, 30 Nov 2023 19:20:50 GMT, Sergey Bylokhov wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Can this patch be covered by the new te
On Tue, 5 Dec 2023 14:24:09 GMT, Prasanta Sadhukhan
wrote:
> But it can be a bug in the code that it never gave a chance second time..I
> think it should get a chance to reload the URL again in case it is invalid
> the 1st time so I guess the change should be the one where if url is invalid,
On Tue, 5 Dec 2023 14:09:42 GMT, Alexey Ivanov wrote:
> > > if the URL is invalid, the image isn't loaded
> >
> >
> > As per your change, if URL is invalid ie url = null, image is not loaded
> > but `loadedImage` is set to true so it will not give another chance to load
> > the URL again via
On Tue, 5 Dec 2023 07:59:19 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
On Tue, 5 Dec 2023 12:17:55 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>> directori
On Tue, 5 Dec 2023 13:02:36 GMT, Alexey Ivanov wrote:
> if the URL is invalid, the image isn't loaded
if (!loadedImage) {
URL url = CSS.getURL(base, svalue);
if (url != null) {
image = new ImageIcon();
On Tue, 5 Dec 2023 07:55:22 GMT, Prasanta Sadhukhan
wrote:
> > > > It is probably easy just drop the usage of loadedImage and use the
> > > > image instead?
> > >
> > >
> > > Ideally. Yet there's a corner case: if `url` is null, there's nothing to
> > > load; and it doesn't make sense to re-
On Tue, 5 Dec 2023 12:12:34 GMT, Abhishek Kumar wrote:
>> To eliminate duplicating code for disposing of the frame, create a helper
>> method and call it from the `finally` block.
>
>> `fileChooser.setFileSelectionMode` that you call below should be called on
>> EDT, I suggest moving it into th
On Mon, 4 Dec 2023 21:00:58 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java
> line 1:
>
>> 1:
On Mon, 4 Dec 2023 20:53:51 GMT, Alexey Ivanov wrote:
>> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirectorySelection.java
>> line 143:
>>
>>> 141: createAndShowUI();
>>> 142: fileChooser.setCurrentDirectory(testDir);
>>> 143: });
>>
> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`. For
> `DIRECTORIES_ONLY `mode, there may not be any directories in home directory
> and due to that test failed. Added the code to create temporary directories
> and files for the test.
> Tested the current change on the
The Java_java_awt_MenuComponent_initIDs function is empty on Windows and macOS,
on linux it has some code but it is unused.
This issue is similar to https://bugs.openjdk.org/browse/JDK-8318091
-
Commit messages:
- date
- cleanup
Changes: https://git.openjdk.org/jdk/pull/16965/fil
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since the
On Mon, 4 Dec 2023 21:51:15 GMT, Sergey Bylokhov wrote:
> > > It is probably easy just drop the usage of loadedImage and use the image
> > > instead?
> >
> >
> > Ideally. Yet there's a corner case: if `url` is null, there's nothing to
> > load; and it doesn't make sense to re-try, the URL won
72 matches
Mail list logo
