On Wed, 14 Feb 2024 05:29:21 GMT, Alexander Zuev wrote:
>> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
>> overflow.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fixing some coding styl
On Tue, 13 Feb 2024 10:43:38 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Fixed compiler error
>
> test/jdk/java/awt/print/PrinterJob/Cancel/PrinterJobCancel.java line 74:
>
>>
> Add null check for the Aqua LnF situation when tab is hidden die to the tabs
> overflow.
Alexander Zuev has updated the pull request incrementally with one additional
commit since the last revision:
Fixing some coding style related issues
-
Changes:
- all: https://git.openjd
On Tue, 13 Feb 2024 21:34:09 GMT, Alisen Chung wrote:
> Root cause of the test failure was fixed with
> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
> other fix also included a test update.
I updated and ran the test changes. The instructions seem unclear. I double
On Mon, 12 Feb 2024 20:55:34 GMT, Alexey Ivanov wrote:
>> When `` tag is used inside ``, the `line-through` style is lost, and
>> the text is rendered with `underline` only. However, if `` is used,
>> the text is rendered with both `underline` and `line-through` styles.
>>
>> Both `` and `` sh
Root cause of the test failure was fixed with
https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the other
fix also included a test update.
-
Commit messages:
- update test to remove applet
Changes: https://git.openjdk.org/jdk/pull/17838/files
Webrev: https://w
While I was investigating a way to improve performance in JOSM (see
https://josm.openstreetmap.de/ticket/23472 ), I saw that
java.awt.geom.Area#intersect was taking a disproportionate amount of CPU
cycles.
I was able to decrease the amount of time spent in `intersect` by doing
bounds intersec
On Tue, 13 Feb 2024 12:06:25 GMT, vtstydev wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has
On Tue, 13 Feb 2024 12:06:25 GMT, vtstydev wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has
On Tue, 13 Feb 2024 15:21:13 GMT, Alexey Ivanov wrote:
> the test fails all the time in windows & linux if PL is removed...
Okay, I see it fails. For me, it fails on Windows because no suitable font is
found; on Ubuntu 22.04 there are fonts available and the test fails because
**[JDK-8001470](
On Tue, 13 Feb 2024 10:37:44 GMT, Prasanta Sadhukhan
wrote:
> > Can you spot a difference?
>
> Yes, I can...The `&& `is modified by JDK-8001470 to `||
> `[https://hg.openjdk.org/jdk9/jdk9/jdk/rev/ff8622450b29] and it was reverted
> back and current code in repo uses &&.. and yes, the test fai
On Tue, 13 Feb 2024 12:06:25 GMT, vtstydev wrote:
>> More correct way to take in consideration nonzero PHYSICALOFFSETX,
>> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
>> platform under certain conditions real device prints shifted image on paper.
>
> vtstydev has
On Tue, 13 Feb 2024 08:47:06 GMT, Renjith Kannath Pariyangad
wrote:
>> Yes, there is a catch wanted to share with you.
>> This test more inclined with 7183516 issue. With respect to 4884389 issue
>> problem mentioned like _but when its
>> printed italic fonts are printed as plain in Win32._ Th
On Wed, 7 Feb 2024 17:16:55 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disposed g2D object and similar test parm into one line
>
> test/jdk/java/awt/print/PrinterJob/Cancel/Pri
On Tue, 13 Feb 2024 08:46:19 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Thu, 8 Feb 2024 15:15:39 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disposed g2D object and similar test parm into one line
>
> test/jdk/java/awt/print/PrinterJob/PageDlgPrn
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
> More correct way to take in consideration nonzero PHYSICALOFFSETX,
> PHYSICALOFFSETY of device for banded-raster printing loop. Only on Windows
> platform under certain conditions real device prints shifted image on paper.
vtstydev has updated the pull request incrementally with one additional
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
On Tue, 13 Feb 2024 09:56:16 GMT, Alexey Ivanov wrote:
> Can you spot a difference?
Yes, I can...The `&& `is modified by JDK-8001470 to `||
`[https://hg.openjdk.org/jdk9/jdk9/jdk/rev/ff8622450b29]
and it was reverted back and current code in repo uses &&..
and yes, the test fails all the time
On Thu, 1 Feb 2024 10:08:27 GMT, Renjith Kannath Pariyangad
wrote:
>> With the present frame size and layout settings, Set Paper" and "Print"
>> options are not visible.
>>
>> 
>
> Yes, Mac have an is
On Tue, 13 Feb 2024 06:50:29 GMT, vtstydev wrote:
>> test/jdk/java/awt/print/PrinterJob/ImagePrinting/AlphaPrintingOffsets.java
>> line 155:
>>
>>> 153: }
>>> 154:
>>> 155: class CustomPrintable implements Printable {
>>
>> I suggest making `CustomPrintable` a static nested class in
>> `Alph
On Fri, 9 Feb 2024 13:35:55 GMT, Magnus Ihse Bursie wrote:
> This is an attempt to finally implement the idea brought forward in
> JDK-8295729: Properties files is essentially source code. It should have the
> same whitespace checks as all other source code, so we don't get spurious
> trailin
On Tue, 13 Feb 2024 04:26:06 GMT, Prasanta Sadhukhan
wrote:
> Actually there is a misunderstanding of this issue. The original issue
> [JDK-8001470](https://bugs.openjdk.org/browse/JDK-8001470) fix caused
> regression [JDK-8130892](https://bugs.openjdk.org/browse/JDK-8130892) which
> caused r
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
On Fri, 9 Feb 2024 11:04:49 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/print/PrinterJob/PrintAllFonts.java line 40:
>>
>>> 38: * @library /test/lib /java/awt/regtesthelpers
>>> 39: * @build PassFailJFrame jtreg.SkippedException
>>> 40: * @summary Font specified with face nam
> Hi Reviewers,
>
> Updated manual printer test cases with 'PassFailJFrame', also removed unused
> variables. Added 'SkippedException' in case of printer missing or not
> configured.
>
> Please review and let me know your suggestions.
>
> Regards,
> Renjith
Renjith Kannath Pariyangad has upda
> Existing regression test is failing because textfield height is not as per
> test's expectation..Seems like the indic character being tried to render is
> not being loaded (probably because of missing glyphs) leading to 0
> preferredSpan from
> [BoxView](https://github.com/openjdk/jdk/blame/5
29 matches
Mail list logo
