On Wed, 26 Jun 2024 23:37:48 GMT, Alisen Chung wrote:
>> This is somewhat a continuation for
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
>> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>>
>> The former removed the `doIt` flag in #18584, but it introduced a
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly performance
On Fri, 21 Jun 2024 14:46:33 GMT, Renjith Kannath Pariyangad
wrote:
> Yes, there is some disconnect. For all OS (MAC with above changes) print
> range is working properly only with following values firstPage =0 and
> lastPage =-1 at **RasterPrinterJob.java** and highly depend on
>
On Wed, 26 Jun 2024 10:40:47 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Sat, 11 May 2024 17:52:28 GMT, Nizar Benalla wrote:
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in
> #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public
On Wed, 26 Jun 2024 09:00:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
> can't be dragged via its divider, But if SplitPane have one touch expandable
> true than user can click those buttons and change the divider position.
> So, if splitpane is disabled, then both dragging in divider and
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Wed, 26 Jun 2024 09:52:38 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
> If you're currently reviewing this PR, thank you!
> Most fixes here are according to the reports by the since checker tool in
> #18934 and are pretty simple.
>
> To make reviewing easier
> - `BasicSliderUI` has the constructor `public BasicSliderUI(JSlider b)` for a
> long time so the default
On Wed, 26 Jun 2024 08:36:45 GMT, Prasanta Sadhukhan
wrote:
>> Alisen's concern is valid.
>>
>> What if `setEnabled(false)` is called when `isOneTouchExpandable` is `false`
>> and then `setOneTouchExpandable(true)` is called which adds the buttons? The
>> buttons are enabled when they should
On Wed, 26 Jun 2024 08:43:40 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
>> line 376:
>>
>>> 374: leftButton.setEnabled(enabled);
>>> 375: }
>>> 376: }
>>
>> Is it possible to override `isEnabled`
On Wed, 26 Jun 2024 09:00:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Wed, 26 Jun 2024 08:40:24 GMT, Abhishek Kumar wrote:
>> Thank you for looking into it. A `MnemonicHandler` class in `sun.swing` or
>> `sun.swing.plaf` package could be a good candidate. The `sun.swing` package
>> contains a lot of support classes for Swing, including `SwingUtilities2` and
On Tue, 18 Jun 2024 12:19:39 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Omit gtk
>
> test/jdk/javax/swing/JSplitPane/TestSplitPaneEnableTest.java line 100:
>
>> 98:
> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
> can't be dragged via its divider, But if SplitPane have one touch expandable
> true than user can click those buttons and change the divider position.
> So, if splitpane is disabled, then both dragging in divider and
On Tue, 18 Jun 2024 12:17:41 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Omit gtk
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSplitPaneDivider.java
> line 376:
>
> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
> can't be dragged via its divider, But if SplitPane have one touch expandable
> true than user can click those buttons and change the divider position.
> So, if splitpane is disabled, then both dragging in divider and
On Tue, 25 Jun 2024 15:11:31 GMT, Alexey Ivanov wrote:
>> I will check and update if it is possible.
>
> Thank you for looking into it. A `MnemonicHandler` class in `sun.swing` or
> `sun.swing.plaf` package could be a good candidate. The `sun.swing` package
> contains a lot of support classes
On Tue, 18 Jun 2024 12:13:49 GMT, Alexey Ivanov wrote:
>> All L including Aqua extends BasicSplitPaneUI so it's ok...The existing
>> test iterates through all L without any issue..
>
>> All L including Aqua extends BasicSplitPaneUI so it's ok...The existing
>> test iterates through all L
21 matches
Mail list logo
