Integrated: 8347826: Introspector shows wrong method list after 8071693

2025-06-02 Thread Roman Marchenko
On Tue, 4 Feb 2025 16:14:44 GMT, Roman Marchenko wrote: > Fixed `com.sun.beans.introspect.MethodInfo` and > `com.sun.beans.introspect.PropertyInfo` to make `Introspector.addMethod()` > working properly when filtering methods out. > > Also, after PR discussion, added the approptiate test cases

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v5]

2025-06-02 Thread Prasanta Sadhukhan
On Mon, 2 Jun 2025 17:26:23 GMT, Jeremy Wood wrote: > > Does the accompanying testcase fails in Synth/Nimbus L&F, it seems not? > > No. I double-checked: A. If I explicitly set the L&F to Nimbus: this test > does fail in this PR, and it does not fail in master. B. The > SynthPasswordFieldUI de

Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v16]

2025-06-02 Thread duke
On Fri, 30 May 2025 11:20:39 GMT, Roman Marchenko wrote: >> Fixed `com.sun.beans.introspect.MethodInfo` and >> `com.sun.beans.introspect.PropertyInfo` to make `Introspector.addMethod()` >> working properly when filtering methods out. >> >> Also, after PR discussion, added the approptiate test

Re: RFR: 8347826: Introspector shows wrong method list after 8071693 [v16]

2025-06-02 Thread Alexander Zvegintsev
On Fri, 30 May 2025 11:20:39 GMT, Roman Marchenko wrote: >> Fixed `com.sun.beans.introspect.MethodInfo` and >> `com.sun.beans.introspect.PropertyInfo` to make `Introspector.addMethod()` >> working properly when filtering methods out. >> >> Also, after PR discussion, added the approptiate test

RFR: 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119)

2025-06-02 Thread Alexander Zvegintsev
After calling `AWT_UNLOCK()`, `GetStringUTFChars` may be called with a pending exception. - Commit messages: - 8358452: JNI exception pending in Java_sun_awt_screencast_ScreencastHelper_remoteDesktopKeyImpl of screencast_pipewire.c:1214 (ID: 51119) Changes: https://git.openjdk.or

Re: RFR: 8357688: Remove unnecessary List.get before remove in PopupFactory

2025-06-02 Thread Alexander Zuev
On Sat, 17 May 2025 07:42:59 GMT, Andrey Turbanov wrote: > Instead of separate List.get+List.remove calls we can use single > `removeFirst`. It's clearer. LGTM - Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/25283#pullrequestreview-289048159

Re: RFR: 8353950: Clipboard interaction on Windows is unstable [v3]

2025-06-02 Thread Damon Nguyen
On Thu, 29 May 2025 17:13:51 GMT, Matthias Bläsing wrote: >> src/java.desktop/windows/classes/sun/awt/windows/WClipboard.java line 189: >> >>> 187: checkChange(formats); >>> 188: } catch (Throwable ex) { >>> 189: >>> System.getLogger(WClipboard.class.getName()).

Integrated: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java

2025-06-02 Thread Harshitha Onkar
On Sat, 17 May 2025 00:03:23 GMT, Harshitha Onkar wrote: > CopyAreaOOB.java was failing intermittently on some platforms on CI but > recently it started to fail more frequently on macos-aarch64 when the entire > test suite runs. > > Test failure is not reproducible when the test is run individ

Re: RFR: 8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance

2025-06-02 Thread Harshitha Onkar
On Fri, 30 May 2025 23:40:22 GMT, Daniel Gredler wrote: > Per discussion in JBS, adds the following chars to the list of ignorable > whitespace chars: U+000B (Vertical Tab), U+000C (Form Feed), U+0085 (Next > Line), U+2028 (Line Separator), U+2029 (Paragraph Separator). > > Adds the necessary

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v7]

2025-06-02 Thread Sergey Bylokhov
On Mon, 2 Jun 2025 19:11:12 GMT, Harshitha Onkar wrote: >>> Added back Toolkit.sync() and canvas capture to paint method. Although I'm >>> not sure if I understood _"each render frame"_ correctly. Can you please >>> explain? >> >> The paint method may be invoked multiple times after the frame

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v7]

2025-06-02 Thread Sergey Bylokhov
On Mon, 2 Jun 2025 20:53:59 GMT, Harshitha Onkar wrote: >> CopyAreaOOB.java was failing intermittently on some platforms on CI but >> recently it started to fail more frequently on macos-aarch64 when the entire >> test suite runs. >> >> Test failure is not reproducible when the test is run ind

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v7]

2025-06-02 Thread Harshitha Onkar
> CopyAreaOOB.java was failing intermittently on some platforms on CI but > recently it started to fail more frequently on macos-aarch64 when the entire > test suite runs. > > Test failure is not reproducible when the test is run individually (multiple > times) on CI. > > Rewritten the test an

Re: RFR: 8358057: Update validation of ICC_Profile header data [v4]

2025-06-02 Thread Harshitha Onkar
On Mon, 2 Jun 2025 19:28:09 GMT, Sergey Bylokhov wrote: >> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several >> new methods to the ICC_Profile class: >> - getProfileClass(byte[]) >> - getColorSpaceType(byte[]) >> - getPCSType(byte[]) >> - checkRenderingIntent(byte[]

Integrated: 8357696: Enhance code consistency: java.desktop/unix

2025-06-02 Thread Sergey Bylokhov
On Mon, 26 May 2025 03:10:07 GMT, Sergey Bylokhov wrote: > This is a request to update the remaining parts of the java.desktop/unix > package. > The sun.awt subpackage under java.desktop/unix was previously addressed by > https://github.com/openjdk/jdk/pull/24941. > > =

Re: RFR: 8356594: JSplitPane loses divider location when reopened via JOptionPane.createDialog() [v5]

2025-06-02 Thread Sergey Bylokhov
On Wed, 28 May 2025 03:21:45 GMT, Prasanta Sadhukhan wrote: >> The issue is when a JSplitPane is embedded inside a lazily-initialized >> panel, and this panel is displayed using a dialog created via >> JOptionPane.createDialog(), the divider location is not preserved when >> reopening the dia

Re: RFR: 8358057: Update validation of ICC_Profile header data [v4]

2025-06-02 Thread Sergey Bylokhov
> The [next PR](https://github.com/openjdk/jdk/pull/23044) introduces several > new methods to the ICC_Profile class: > - getProfileClass(byte[]) > - getColorSpaceType(byte[]) > - getPCSType(byte[]) > - checkRenderingIntent(byte[]) > > These new methods extract data directly from the provided

Re: RFR: 8358057: Update validation of ICC_Profile header data [v3]

2025-06-02 Thread Harshitha Onkar
On Sat, 31 May 2025 04:21:41 GMT, Sergey Bylokhov wrote: >> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update ValidateICCHeaderData.java > > test/jdk/java/awt/color/ICC_Profile/ValidateICCHeaderData/ValidateICCHeader

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v6]

2025-06-02 Thread Harshitha Onkar
> CopyAreaOOB.java was failing intermittently on some platforms on CI but > recently it started to fail more frequently on macos-aarch64 when the entire > test suite runs. > > Test failure is not reproducible when the test is run individually (multiple > times) on CI. > > Rewritten the test an

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v5]

2025-06-02 Thread Harshitha Onkar
On Mon, 2 Jun 2025 18:44:40 GMT, Sergey Bylokhov wrote: >> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> added testRegion back to paint() > > test/jdk/java/awt/Graphics2D/CopyAreaOOB.java line 84: > >> 82:

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v6]

2025-06-02 Thread Harshitha Onkar
On Sat, 31 May 2025 00:59:49 GMT, Sergey Bylokhov wrote: >> @mrserb >> >> Added back Toolkit.sync() and canvas capture to paint method. Although I'm >> not sure if I understood _"each render frame"_ correctly. Can you please >> explain? >> >> >> BufferedImage capture = null; >>

Re: RFR: JDK-8357082 : Stabilize and add debug logs to CopyAreaOOB.java [v5]

2025-06-02 Thread Sergey Bylokhov
On Fri, 30 May 2025 00:40:11 GMT, Harshitha Onkar wrote: >> CopyAreaOOB.java was failing intermittently on some platforms on CI but >> recently it started to fail more frequently on macos-aarch64 when the entire >> test suite runs. >> >> Test failure is not reproducible when the test is run in

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v8]

2025-06-02 Thread Abhishek Kumar
On Mon, 2 Jun 2025 09:33:34 GMT, Khalid Boulanouare wrote: >> Fixes issue in which the test fails when run on multi-screen machine. >> >> Tested on Ubuntu 24.04, MacOS 15 and Windows 11 >> >> JTREG >> >> runner starting test: java/awt/Frame/MultiScreenTest.java >> runner finished test: java/aw

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v6]

2025-06-02 Thread Jeremy Wood
On Mon, 2 Jun 2025 16:57:14 GMT, Jeremy Wood wrote: >> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI and SynthPa

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v5]

2025-06-02 Thread Jeremy Wood
On Mon, 2 Jun 2025 09:52:04 GMT, Prasanta Sadhukhan wrote: > Does the accompanying testcase fails in Synth/Nimbus L&F, it seems not? No. I double-checked: A. If I explicitly set the L&F to Nimbus: this test does fail in this PR, and it does not fail in master. B. The SynthPasswordFieldUI desce

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v6]

2025-06-02 Thread Jeremy Wood
> Make sure AquaTextPasswordFieldUI can't use selectWordAction. > > The core problem here was we could call selectWordAction in the Aqua LAF on a > JPasswordField. This problem was already solved in the BasicPasswordFieldUI, > but the AquaTextPasswordFieldUI (and SynthPasswordFieldUI) do NOT ext

Re: RFR: 8353950: Clipboard interaction on Windows is unstable [v4]

2025-06-02 Thread Alisen Chung
On Thu, 29 May 2025 17:11:12 GMT, Matthias Bläsing wrote: >> - Introduce a lock into WClipboard that protects the code between >> openClipboard/closeClipboard invocations. >> The native side does not allow to open the clipboard multiple >> times or share the opened clipboard between multip

Re: RFR: 8357672: Extreme font sizes can cause font substitution

2025-06-02 Thread Jayathirth D V
On Mon, 2 Jun 2025 15:05:44 GMT, Phil Race wrote: >> test/jdk/java/awt/FontMetrics/ExtremeFontSizeTest.java line 39: >> >>> 37: /* >>> 38: * @test >>> 39: * @bug 8328896 8357672 >> >> I thought Freetype rasterizer is used on all platforms(Linux, Windows & >> macOS) by default. Since Freetype

Re: RFR: 8357696: Enhance code consistency: java.desktop/unix [v3]

2025-06-02 Thread Phil Race
On Sun, 1 Jun 2025 02:27:50 GMT, Sergey Bylokhov wrote: >> This is a request to update the remaining parts of the java.desktop/unix >> package. >> The sun.awt subpackage under java.desktop/unix was previously addressed by >> https://github.com/openjdk/jdk/pull/24941. >> >>

Integrated: 8357672: Extreme font sizes can cause font substitution

2025-06-02 Thread Phil Race
On Wed, 28 May 2025 20:19:42 GMT, Phil Race wrote: > Instrumenting the existing ExtremeFontSizeTest.java, it was noted that the > freetype code, when encountering a null return from getting a scaler context, > would over-interpret this as a bad font. > The test was intended to check this wasn't

Re: RFR: 8357672: Extreme font sizes can cause font substitution

2025-06-02 Thread Phil Race
On Mon, 2 Jun 2025 11:19:48 GMT, Jayathirth D V wrote: >> Instrumenting the existing ExtremeFontSizeTest.java, it was noted that the >> freetype code, when encountering a null return from getting a scaler >> context, would over-interpret this as a bad font. >> The test was intended to check thi

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux

2025-06-02 Thread Khalid Boulanouare
On Tue, 13 May 2025 03:57:45 GMT, Abhishek Kumar wrote: >>> I ran the test (**without your fix**) on Windows, Mac and Linux platform. >>> It failed on Windows and Mac but no issues on Linux. >> >> Why it fails on win/mac? > >> > I ran the test (**without your fix**) on Windows, Mac and Linux pl

Re: RFR: 8357672: Extreme font sizes can cause font substitution

2025-06-02 Thread Jayathirth D V
On Wed, 28 May 2025 20:19:42 GMT, Phil Race wrote: > Instrumenting the existing ExtremeFontSizeTest.java, it was noted that the > freetype code, when encountering a null return from getting a scaler context, > would over-interpret this as a bad font. > The test was intended to check this wasn't

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v7]

2025-06-02 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B

Re: RFR: 8354646: java.awt.TextField allows to identify the spaces in a password when double clicked at the starting and end of the text [v5]

2025-06-02 Thread Prasanta Sadhukhan
On Fri, 30 May 2025 17:13:24 GMT, Jeremy Wood wrote: >> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI, but the A

Re: RFR: 8352149: Test java/awt/Frame/MultiScreenTest.java generates too many frames on Linux [v8]

2025-06-02 Thread Khalid Boulanouare
> Fixes issue in which the test fails when run on multi-screen machine. > > Tested on Ubuntu 24.04, MacOS 15 and Windows 11 > > JTREG > > runner starting test: java/awt/Frame/MultiScreenTest.java > runner finished test: java/awt/Frame/MultiScreenTest.java > Passed. Execution successful Khalid B

Re: RFR: 8251928: [macos] the printer DPI always be 72, cause some content lost when print out

2025-06-02 Thread Prasanta Sadhukhan
On Wed, 28 May 2025 10:29:17 GMT, GennadiyKrivoshein wrote: > The fix for the https://bugs.openjdk.org/browse/JDK-8251928. > > **Description**. > This PR contains changes to be able to print with DPI higher than 72 on > macOS, set default CPrinterJob DPI is 300 like in the PSPrinterJob. > > As

Re: RFR: 8357994: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [client]

2025-06-02 Thread Volkan Yazici
On Fri, 30 May 2025 21:21:56 GMT, Phil Race wrote: >> Passes the `Charset` read from the `stdin.encoding` system property while >> creating `InputStreamReader` or `Scanner` instances for `System.in`. >> >> `stdin.encoding` is a recently added property for Java 25 in >> [JDK-8350703](https://bu

Withdrawn: 8357994: Use "stdin.encoding" for reading System.in with InputStreamReader/Scanner [client]

2025-06-02 Thread Volkan Yazici
On Fri, 30 May 2025 10:59:17 GMT, Volkan Yazici wrote: > Passes the `Charset` read from the `stdin.encoding` system property while > creating `InputStreamReader` or `Scanner` instances for `System.in`. > > `stdin.encoding` is a recently added property for Java 25 in > [JDK-8350703](https://bug