On Fri, 17 May 2024 03:37:21 GMT, Prasanta Sadhukhan
wrote:
> Inadvertent mention of Netscape in Javadoc is removed..
Changes requested by aivanov (Reviewer).
src/java.desktop/share/classes/javax/swing/CellEditor.java line 91:
> 89: * cell should be selected. However, it is useful to
On Thu, 16 May 2024 04:27:25 GMT, Sergey Bylokhov wrote:
>> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
>> verify that the cmm id of the icc profile is properly reported. Before
>> JDK-8321489 we always report 'lcms' as a cmm id.
>
> Sergey Bylokhov has updated
On Tue, 14 May 2024 19:12:25 GMT, Sergey Bylokhov wrote:
>> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
>> verify that the cmm id of the icc profile is properly reported. Before
>> JDK-8321489 we always report 'lcms' as a cmm id.
>
> Sergey Bylokhov has updated
On Mon, 6 May 2024 20:51:55 GMT, Sergey Bylokhov wrote:
> The new test to cover the https://bugs.openjdk.org/browse/JDK-8326661 and
> verify that the cmm id of the icc profile is properly reported. Before
> JDK-8321489 we always report 'lcms' as a cmm id.
Marked as reviewed by aivanov
On Thu, 9 May 2024 13:01:57 GMT, Alexey Ivanov wrote:
> The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
> frequently fails on Windows in CI, which creates noise.
>
> All of the failures on Windows look the same:
>
> Number of snapshots: 20
>
The `javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java` test
frequently fails on Windows in CI, which creates noise.
All of the failures on Windows look the same:
Number of snapshots: 20
Number of snapshots where number of loader threads:
= 1: 19
= 2: 0
> 2: 1
Exception in
On Wed, 1 May 2024 18:01:03 GMT, ScientificWare wrote:
> I won a racing bib for the "Marathon Pour Tous" of Paris 2024 Olympic Games.
Congratulations! Good luck!
> …I have suspended all projects becauseof my training plan until september.
>
> My intent is to deliver the unit test in december.
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov wrote:
> As soon as I integrated
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
> #18957, the test started failing in CI on Linux and macOS. There are six
> failures found so far.
>
> Before st
On Wed, 1 May 2024 16:29:10 GMT, Alexey Ivanov wrote:
> As soon as I integrated
> `test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
> #18957, the test started failing in CI on Linux and macOS. There are six
> failures found so far.
>
> Before st
As soon as I integrated
`test/jdk/javax/swing/plaf/basic/BasicDirectoryModel/LoaderThreadCount.java`
#18957, the test started failing in CI on Linux and macOS. There are six
failures found so far.
Before starting code review and later, I ran the test many times on CI and I
never saw so many
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote:
> This PR provides a regression test for
> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>
> The test is inspired and based on `Concurr
ing
> output on one of Linux systems:
>
>
> Number of snapshots: 15
> Number of snapshots where number of loader threads:
> = 1: 7
> = 2: 2
> > 2: 6
>
>
> The test passes on the builds where JDK-8325179 is present.
Alexey Ivanov has updated the pull r
On Mon, 29 Apr 2024 10:42:26 GMT, Tejesh R wrote:
> Is it necessary to create dummy files here in this test? Can't we just create
> JFileChooser without creating dummy files and proceed with loader test?
> Because I tested without using dummy files and getting exception without
> JDK-8325179
On Mon, 29 Apr 2024 12:44:14 GMT, Joel Uckelman wrote:
> Will this be backported to Java 21 and 22? It would be very helpful if it
> could be.
It is already backported to 22.
I'm working on backporting it to all supported Oracle releases of Java. It is
up to the OpenJDK community to backport
On Thu, 25 Apr 2024 16:37:39 GMT, Alexey Ivanov wrote:
> This PR provides a regression test for
> [JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
> BasicDirectoryModel.validateFileCache_ reviewed in #18111.
>
> The test is inspired and based on `Concurr
This PR provides a regression test for
[JDK-8325179](https://bugs.openjdk.org/browse/JDK-8325179): _Race in
BasicDirectoryModel.validateFileCache_ reviewed in #18111.
The test is inspired and based on `ConcurrentModification` that I wrote for
On Thu, 11 Apr 2024 09:33:09 GMT, Alexey Ivanov wrote:
> This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
>
> `IS_WINVISTA` was not used at all.
>
> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
> assume Java runs on
On Tue, 23 Apr 2024 05:02:53 GMT, Tejesh R wrote:
> > Do you mind if I shorten the subject of the bug? _Printing JTable throws
> > InternalError: HTHEME is null_?
>
> Sure, it's better to shorten it. And since its only for windows L, it can
> be mentioned in subject I guess.
I've updated the
On Tue, 23 Apr 2024 11:02:48 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Tue, 23 Apr 2024 10:30:49 GMT, Tejesh R wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 110:
>>
>>> 108:// See documentation for SetWindowTheme on MSDN.
>>> 109:setWindowTheme(widget.substring(0, i));
>>> 110:theme =
On Tue, 23 Apr 2024 10:23:33 GMT, Tejesh R wrote:
>> I didn't get the need for helper method?
>
> Ok, I got it. And I have updated. But if we want to change `theme` to `long`,
> then I guess we have to do it every calling function I guess. So is it better
> to leave it as `Long` ?
I still
On Tue, 23 Apr 2024 10:31:02 GMT, Alexey Ivanov wrote:
>> Ok, I got it. And I have updated. But if we want to change `theme` to
>> `long`, then I guess we have to do it every calling function I guess. So is
>> it better to leave it as `Long` ?
>
> I still think we shoul
On Tue, 23 Apr 2024 10:19:40 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Mon, 22 Apr 2024 17:38:59 GMT, Jonathan Gibbons wrote:
> The document [How to Write Doc Comments for the Javadoc
> Tool](https://www.oracle.com/uk/technical-resources/articles/java/javadoc-tool.html)
> is depressingly obsolete, as indicated by this text towards the end:
I know. Yet there's
On Mon, 22 Apr 2024 07:03:54 GMT, Tejesh R wrote:
>> Yes, `openTheme()` actually returns 0. Hence I used `null` && `0` checker.
>
> Moved the failure handling to `openThemeImpl()`.
> Yes, `openTheme()` actually returns 0. …
This is why it can't be `null`.
-
PR Review Comment:
On Mon, 22 Apr 2024 07:08:00 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Mon, 22 Apr 2024 07:08:00 GMT, Tejesh R wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Mon, 22 Apr 2024 08:41:13 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 483:
>>
>>> 481: // The same page with different reference
>>> 482: if (reference != null) {
>>> 483: scrollToReference(reference);
>>
On Fri, 19 Apr 2024 19:19:26 GMT, Rajat Mahajan wrote:
>> Getting a theme for particular dpi failed in windows L during print test.
>> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
>> was independent of DPI. After the fix
>>
On Wed, 10 Apr 2024 04:32:53 GMT, Tejesh R wrote:
> Getting a theme for particular dpi failed in windows L during print test.
> Before [JDK-8294427](https://bugs.openjdk.org/browse/JDK-8294427) fix, theme
> was independent of DPI. After the fix
>
On Fri, 19 Apr 2024 19:18:31 GMT, Jonathan Gibbons wrote:
> We do not have an overall style guide. The conventional wisdom for editing
> any existing file is to follow the style in that file, if such a style can be
> discerned.
That's what I do.
I saw either style used in JDK. Yet I didn't
h one
> additional commit since the last revision:
>
> Update
> src/java.base/share/classes/sun/net/www/protocol/file/FileURLConnection.java
>
> Fix grammatical typo
>
> Co-authored-by: Alexey Ivanov
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18846#pullrequestreview-2012219677
On Fri, 19 Apr 2024 14:53:09 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith
On Fri, 19 Apr 2024 12:30:26 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Added pageloader cancel before new page creation along with code
>> restructuring. Moved all page loading calls inside synchronize to make it
>> thread safe.
>>
>> Regards,
>> Renjith.
>
> Renjith
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Thu, 18 Apr 2024 20:44:00 GMT, Jonathan Gibbons wrote:
> Please review a set of updates to clean up use of `/**` comments in the
> vicinity of declarations.
>
> There are various categories of update:
>
> * "Box comments" beginning with `/**`
> * Misplaced doc comments before package or
On Fri, 19 Apr 2024 05:10:46 GMT, Tejesh R wrote:
> I wasn't able to make out the changes with comparison since restructuring is
> also done here. Just like you are explaining here would help in understanding
> the changes for review.
Putting all access to `pageLoader` into a `synchronized`
On Mon, 8 Apr 2024 06:09:16 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Added pageloader cancel before new page creation along with code
> restructuring. Moved all page loading calls inside synchronize to make it
> thread safe.
>
> Regards,
> Renjith.
Changes requested by
On Thu, 18 Apr 2024 05:07:04 GMT, Tejesh R wrote:
> Since the changes/restructuring is more, it would be better to add more
> details in description which would help in review process.
What details are you looking for?
The purpose of the changes hasn't changed: make the code thread-safe in
On Mon, 8 Apr 2024 07:57:11 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> I have updated the test with PassFailJFrame along with printer availability
>> check. Please review and let me know your suggestions.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad has updated the pull
On Tue, 16 Apr 2024 06:58:19 GMT, Sergey Bylokhov wrote:
>> This clean-up PR removes unused Windows version macro from
>> `ShellFolder2.cpp`.
>>
>> `IS_WINVISTA` was not used at all.
>>
>> `IS_WINXP` guarded support for icons with alpha channel. It is now safe to
>> assume Java runs on a
On Fri, 12 Apr 2024 04:59:17 GMT, Tejesh R wrote:
> Can you update JBS title and description regarding "support for icons with
> alpha channel" too. These updates are visible only in PR and not in JBS.
Updated the JBS subject.
Added [a
On Tue, 9 Apr 2024 20:24:06 GMT, Phil Race wrote:
>> Because you didn't add the backticks ` around your sample, it's
>> interpreted as HTML, and I can't really see it.
>>
>> I guess, the code was something line this: ``.
>>
>> If the both tags have the same value for the `text-decoration`
on`. Now
> `ConvertAction` extends `CharacterAction` and overrides a method to provide
> additional handling.
>
> Thus, [JDK-8325620](https://bugs.openjdk.org/browse/JDK-8325620) is also
> resolved by this PR, the action used for ``, ``, `` is
> `CharacterAction` as specified.
Alex
On Tue, 9 Apr 2024 20:59:53 GMT, Harshitha Onkar wrote:
>> I'm pretty sure there are other cases where `text-decoration` isn't resolved
>> correctly. It is not a goal to resolve all of the possible issues.
>>
>> I'll check whether this scenario can be handled easily. I don't think it is.
>>
On Wed, 10 Apr 2024 21:25:06 GMT, Larry Cable wrote:
>> the beancontext package was added (by me) in JDK 1.2 to provide
>> JavaBeans(tm) with a containment and services hierarchy.
>>
>> based upon concepts from OpenDoc, which was a popular component model at the
>> time, the API pre-dated the
This clean-up PR removes unused Windows version macro from `ShellFolder2.cpp`.
`IS_WINVISTA` was not used at all.
`IS_WINXP` guarded support for icons with alpha channel. It is now safe to
assume Java runs on a Windows version later than Windows XP. Java launchers
specify 6.0 as the minimum OS
On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov wrote:
> I'm adding a regression test for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690](https://b
On Tue, 9 Apr 2024 19:10:26 GMT, Harshitha Onkar wrote:
>> The value of the
>> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
>> property is not inherited correctly in Swing. If the `` element is
>> mixed with `` or ``, only the value from the `style` attribute of
On Tue, 9 Apr 2024 18:36:46 GMT, Harshitha Onkar wrote:
>> The value of the
>> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
>> property is not inherited correctly in Swing. If the `` element is
>> mixed with `` or ``, only the value from the `style` attribute of
On Tue, 9 Apr 2024 17:26:06 GMT, Phil Race wrote:
>> The value of the
>> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
>> property is not inherited correctly in Swing. If the `` element is
>> mixed with `` or ``, only the value from the `style` attribute of
>> ``
On Tue, 9 Apr 2024 17:27:57 GMT, Phil Race wrote:
>> The value of the
>> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
>> property is not inherited correctly in Swing. If the `` element is
>> mixed with `` or ``, only the value from the `style` attribute of
>> ``
On Tue, 2 Apr 2024 16:58:19 GMT, Larry Cable wrote:
>> the beancontext package was added (by me) in JDK 1.2 to provide
>> JavaBeans(tm) with a containment and services hierarchy.
>>
>> based upon concepts from OpenDoc, which was a popular component model at the
>> time, the API pre-dated the
On Tue, 5 Mar 2024 17:01:45 GMT, Alexey Ivanov wrote:
> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there
> are cases where
> `a < b & b < c but a == c`
> which *violates its general contract*.
>
> In particular, it happens for the
On Fri, 5 Apr 2024 15:46:06 GMT, Alexey Ivanov wrote:
> Remove unused class `KeyBuilder` and unused field `unusedSets`.
> Update a comment which used javadoc syntax.
> Mark `KeyEnumeration` and `FontKey` classes as *`final`*.
>
> All the client tests are green.
This pull
On Tue, 5 Mar 2024 17:40:01 GMT, Alexey Ivanov wrote:
>> The implementation of `Win32ShellFolder2.compareTo` is inconsistent: there
>> are cases where
>> `a < b & b < c but a == c`
>> which *violates its general contract*.
>>
>> In particular,
On Fri, 29 Mar 2024 15:32:12 GMT, Alexey Ivanov wrote:
> The value of the
> [`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
> property is not inherited correctly in Swing. If the `` element is
> mixed with `` or ``, only the value from the `styl
On Tue, 2 Apr 2024 10:29:45 GMT, Alexey Ivanov wrote:
> Update the problem-list entry for `
> javax/swing/JFileChooser/8194044/FileSystemRootTest.java` to refer to
> [JDK-8327236](https://bugs.openjdk.org/browse/JDK-8327236) under which the
> failure with `"root drive
On Fri, 5 Apr 2024 16:29:56 GMT, Sergey Bylokhov wrote:
> Could you please check the history of that file, is these unused due to some
> functionality was deleted and this was missed, or we planned to implement
> something and forgot?
Both were used in pre-historic days.
The `unusedSets`
Remove unused class `KeyBuilder` and unused field `unusedSets`.
Update a comment which used javadoc syntax.
Mark `KeyEnumeration` and `FontKey` classes as *`final`*.
All the client tests are green.
-
Commit messages:
- 8329761: Remove unused KeyBuilder and unusedSets from
On Tue, 2 Apr 2024 16:55:27 GMT, Daniel Jeliński wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Debug.cpp line 111:
>>
>>> 109: * DTRACE print callback to dump window's update region bounding
>>> rectangle
>>> 110: */
>>> 111: void DumpUpdateRectangle(const char * file, int
On Tue, 2 Apr 2024 17:10:18 GMT, Daniel Jeliński wrote:
>> Please review this PR that removes unused functions, variables, and WM_AWT
>> window messages.
>>
>> The unused code was detected by automated analysis (MSVC compiler and
>> linker, CodeQL analyzer). I manually verified every symbol
On Fri, 29 Mar 2024 17:29:09 GMT, Harshitha Onkar wrote:
>> Following tests are converted to main and open-sourced:
>>
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
>> PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> -
On Fri, 29 Mar 2024 17:25:38 GMT, Harshitha Onkar wrote:
> It is better to re-throw it as RuntimeException. Updated.
Not really…
If saving the image fails, we want to preserve *the original error message*
which wasn't even thrown by this time. So printing stack trace in this
particular is
On Fri, 29 Mar 2024 17:29:09 GMT, Harshitha Onkar wrote:
>> Following tests are converted to main and open-sourced:
>>
>> - /java/awt/Frame/FrameDialogMixedTest.java- Converted to main/manual using
>> PassFailJFrame.
>> - /java/awt/Frame/MaximizeUndecoratedTest.java - Automated
>> -
On Tue, 2 Apr 2024 13:22:27 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeliński wrote:
> Please review this PR that removes unused functions, variables, and WM_AWT
> window messages.
>
> The unused code was detected by automated analysis (MSVC compiler and linker,
> CodeQL analyzer). I manually verified every symbol
On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeliński wrote:
> Please review this PR that removes unused functions, variables, and WM_AWT
> window messages.
>
> The unused code was detected by automated analysis (MSVC compiler and linker,
> CodeQL analyzer). I manually verified every symbol
On Fri, 29 Mar 2024 18:23:27 GMT, Daniel Jeliński wrote:
> Please review this PR that removes unused functions, variables, and WM_AWT
> window messages.
>
> The unused code was detected by automated analysis (MSVC compiler and linker,
> CodeQL analyzer). I manually verified every symbol
On Tue, 2 Apr 2024 11:19:15 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Mon, 1 Apr 2024 06:34:49 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Mon, 1 Apr 2024 05:38:54 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Mon, 1 Apr 2024 05:38:54 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
Update the problem-list entry for `
javax/swing/JFileChooser/8194044/FileSystemRootTest.java` to refer to
[JDK-8327236](https://bugs.openjdk.org/browse/JDK-8327236) under which the
failure with `"root drive reported as false"` is tracked.
-
Commit messages:
- 8329510: Update
On Fri, 29 Mar 2024 12:45:36 GMT, Alexey Ivanov wrote:
> Remove all the leftovers of the _"standard instructions" machinery_ from the
> `NullPaper.java` test.
>
> The test code consists of two lines now: concise and clear.
This pull request has now been integrated.
Chan
On Fri, 29 Mar 2024 02:00:18 GMT, Sergey Bylokhov wrote:
> > However, there are cases where instantiating and testing is safe on main
> > thread.
>
> That is my point, make it less safe - when the component is created on one
> thread:EDT and then for some reason accessed on a different
On Thu, 7 Mar 2024 09:27:10 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Thu, 7 Mar 2024 07:13:02 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 5 Mar 2024 13:15:04 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Updated instruction
>
> test/jdk/java/awt/print/PrinterJob/Dr
On Tue, 19 Mar 2024 09:24:35 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Fri, 29 Mar 2024 17:24:27 GMT, Phil Race wrote:
> Problem list a test which is failing in CI
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18552#pullrequestreview-1969192957
The value of the
[`text-decoration`](https://www.w3.org/TR/REC-CSS1/#text-decoration) CSS
property is not inherited correctly in Swing. If the `` element is mixed
with `` or ``, only the value from the `style` attribute of `` is
applied.
The fix to this issue is not as simple as that for the
On Fri, 29 Mar 2024 07:21:17 GMT, Prasanta Sadhukhan
wrote:
> There is an old obsolete comment in JRootPane that is between the main
> documentation comment for the class and the declaration of the class itself
> which is causing interference with the work to support Markdown in
>
Remove all the leftovers of the _"standard instructions" machinery_ from the
`NullPaper.java` test.
The test code consists of two lines now: concise and clear.
-
Commit messages:
- Remove redudant comment; add blank line
- 8329320: Simplify awt/print/PageFormat/NullPaper.java
On Mon, 18 Mar 2024 09:04:05 GMT, rjolly wrote:
>> @rjolly Thank you for your contribution. Could you provide more details
>> about the issue? The PR needs to be linked to a JBS issue. I'll create one
>> for you after I get a more detailed description of the problem from you.
>>
>> A test
On Thu, 28 Mar 2024 08:33:52 GMT, rjolly wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if the
On Wed, 6 Mar 2024 05:08:08 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Tue, 5 Mar 2024 12:22:56 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Suggesions incorporated
>
> test/jdk/java/awt/print/PrinterJob/PrintA
On Thu, 7 Mar 2024 09:27:10 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know
On Fri, 22 Mar 2024 21:45:36 GMT, Alexey Ivanov wrote:
>>>Instantiating JFileChooser on EDT adds complexity for no benefit. The
>>>JFileChooser is still accessed concurrently from several threads, including
>>>Swing internal thread.
>>
>> But still, th
On Wed, 27 Mar 2024 13:22:41 GMT, rjolly wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if the
On Wed, 27 Mar 2024 10:43:55 GMT, rjolly wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if the
On Wed, 27 Mar 2024 08:48:55 GMT, rjolly wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if the
On Tue, 26 Mar 2024 12:55:53 GMT, rjolly wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if the
On Mon, 25 Mar 2024 23:48:23 GMT, Joel Uckelman wrote:
> I haven't heard back yet. I hope investigating the second bug will not hold
> up the fix for the first bug getting merged.
It's not a show-stopper. These are different bugs. If possible, I'd like to
follow up and find the root cause of
On Tue, 26 Mar 2024 12:04:35 GMT, Tejesh R wrote:
>> src/java.desktop/share/classes/javax/swing/JEditorPane.java line 621:
>>
>>> 619: String charset = (String) getClientProperty("charset");
>>> 620: try(Reader r = (charset != null) ? new InputStreamReader(in,
>>> charset) :
On Tue, 26 Mar 2024 11:40:50 GMT, Tejesh R wrote:
>> ChangedCharSetException is used to amend the charset during read according
>> to html directives. Currently it causes immediate exit of the method which
>> in turn causes failure to load html documents with charset directives (even
>> if
On Tue, 26 Mar 2024 11:25:45 GMT, Alexey Ivanov wrote:
> You should not force-push to a branch that's already on the review. If you
> want to update to latest master, use `git merge` to update the branch and
> then push it.
A sample on how to merge master in another PR:
https://g
On Thu, 25 Jan 2024 11:11:47 GMT, rjolly wrote:
> ChangedCharSetException is used to amend the charset during read according to
> html directives. Currently it causes immediate exit of the method which in
> turn causes failure to load html documents with charset directives (even if
> the
On Thu, 25 Jan 2024 11:11:47 GMT, rjolly wrote:
> ChangedCharSetException is used to amend the charset during read according to
> html directives. Currently it causes immediate exit of the method which in
> turn causes failure to load html documents with charset directives (even if
> the
101 - 200 of 1956 matches
Mail list logo
