On Mon, 31 Jul 2023 10:26:44 GMT, Alexey Ivanov wrote:
> The private field `mask` is never used in `JFormattedTextField`.
>
> I couldn't find any usages of the field, including JNI. Therefore, it is safe
> to remove.
This pull request has now been integrated.
Changeset: b65
On Mon, 25 Sep 2023 16:46:26 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java line 62:
>>
>>> 60: .build();
>>> 61:
>>> 62: SwingUtilities.invokeAndWait(() -> {
>>
>> Suggestion:
>>
>>
On Mon, 25 Sep 2023 17:21:13 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
>
On Mon, 25 Sep 2023 16:48:51 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Frame/FrameRepackTest.java line 134:
>>
>>> 132: north.setLayout(new BorderLayout(2, 2));
>>> 133: north.add("North", new Label(" This panel is always
>>> displayed"));
>>> 134:
On Wed, 20 Sep 2023 20:05:01 GMT, Phil Race wrote:
> Swing isn't serializable across releases, so I see no need for a CSR.
Thank you. That's what I thought.
-
PR Comment: https://git.openjdk.org/jdk/pull/15088#issuecomment-1734125157
On Fri, 22 Sep 2023 15:43:18 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing several manual applet tests
>>
>>
>> test/jdk/java/awt/Frame/DefaultSizeTest.java
>> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
>> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
>>
On Mon, 25 Sep 2023 15:27:15 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
>
On Wed, 20 Sep 2023 16:55:30 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
>
On Mon, 25 Sep 2023 13:29:09 GMT, Christoph Langer wrote:
>> test/jdk/ProblemList.txt line 472:
>>
>>> 470:
>>> 471: java/awt/font/Rotate/RotatedTextTest.java 8219641 linux-all
>>> 472:
>>
>> Looks good to me, except for its placement: shouldn't it be placed close to
>> other font tests?
On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Mon, 18 Sep 2023 19:08:48 GMT, Damon Nguyen wrote:
>> test/jdk/javax/swing/JTabbedPane/bug4703690.java line 54:
>>
>>> 52: static volatile boolean focusButtonTwo = false;
>>> 53: static volatile boolean switchToTabTwo = false;
>>> 54: static volatile boolean focusButtonOne =
On Sun, 24 Sep 2023 06:12:17 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Mon, 25 Sep 2023 06:53:49 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JTableHeader/SerializeJTableHeader.java line 55:
>>
>>> 53: for (UIManager.LookAndFeelInfo laf :
>>> UIManager.getInstalledLookAndFeels()) {
>>> 54: System.out.println("Testing L: " + laf);
On Mon, 25 Sep 2023 07:00:38 GMT, Prasanta Sadhukhan
wrote:
>> After the first time a JTableHeader is serialized, it no longer will
>> uninstall its UI upon subsequent serializations.
>> This happens for classes that use the BasicTableHeaderUI class. Any LAF that
>> extends the
On Fri, 22 Sep 2023 06:20:42 GMT, Christoph Langer wrote:
> Exclude java/awt/font/Rotate/RotatedTextTest.java until
> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The
> error shows in several linux installations.
test/jdk/ProblemList.txt line 472:
> 470:
> 471:
On Sun, 24 Sep 2023 10:13:03 GMT, Andrey Turbanov wrote:
>> PR with non-swing changes extracted from initial #14847
>
> Andrey Turbanov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8316556: Fix typos in java.desktop
Marked as reviewed
On Tue, 19 Sep 2023 13:41:27 GMT, Alexey Ivanov wrote:
> **Root cause**
>
> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has
> zero length.
>
> The test fails if the right half of the image with the rendered glyph
> contains only pixels
On Thu, 21 Sep 2023 22:36:16 GMT, Harshitha Onkar wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Sat, 16 Sep 2023 16:22:40 GMT, Andrey Turbanov wrote:
> PR with non-swing changes extracted from initial #14847
src/java.desktop/unix/classes/sun/awt/X11/XMenuBarPeer.java line 132:
> 130: * need to have somewhat strange behaviour
> 131: * deduced from java.awt.MenuBar.
> 132:
On Fri, 22 Sep 2023 07:12:08 GMT, Prasanta Sadhukhan
wrote:
> I guess in test, resource leak probably wouldn't matter…
No, it wouldn't. Yet someone could later copy the code and use file streams
where closing the streams matters. Always following the pattern is safer.
-
PR
On Fri, 22 Sep 2023 07:18:09 GMT, Prasanta Sadhukhan
wrote:
>> After the first time a JTableHeader is serialized, it no longer will
>> uninstall its UI upon subsequent serializations.
>> This happens for classes that use the BasicTableHeaderUI class. Any LAF that
>> extends the
On Tue, 19 Sep 2023 21:51:01 GMT, Phil Race wrote:
> Are you saying this test would be better with an enhancement to
> PassFailJFrame ?
@prrace Yes. Or perhaps, with a reduced set implemented as another class.
> But it is OK right, just more clunky than it could be .. ?
Yes, it is OK. Yet
On Wed, 20 Sep 2023 14:07:17 GMT, Alexey Ivanov wrote:
>> **Root cause**
>>
>> The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has
>> zero length.
>>
>> The test fails if the right half of the image with the rendered glyph
>>
o contains background-coloured pixels only.
>
> The updated test does not fail with the _Baekmuk Headline_ font. It still
> detects the original problem and fails on builds without the fix for
> [JDK-8312555](https://bugs.openjdk.org/browse/JDK-8312555).
Alexey Ivanov has updated the pull r
On Thu, 17 Aug 2023 21:37:17 GMT, Phil Race wrote:
>> The private field `mask` is never used in `JFormattedTextField`.
>>
>> I couldn't find any usages of the field, including JNI. Therefore, it is
>> safe to remove.
>
> Marked as reviewed by prr (Reviewer).
> @prrace could you confirm,
On Wed, 20 Sep 2023 07:52:33 GMT, Brice Dutheil wrote:
> I encountered an issue very similar to this problem, is there any chance to
> see progress on the fix ?
@bric3 This is not how it works… Yet feel free to propose a patch that
addresses the problem. It could be based on this PR.
I looks
On Tue, 19 Sep 2023 18:35:12 GMT, Phil Race wrote:
>> Refactored timeout handling in PassFailJFrame:
>>
>> 1. Managing the timer and formatting the time left is inside
>> `TimeoutHandler` class.
>> 2. The class handles timer events and updates the label accordingly.
>>
>> This is implemented
On Tue, 19 Sep 2023 17:04:59 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
>
On Tue, 19 Sep 2023 17:02:54 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4.
On Tue, 19 Sep 2023 16:55:02 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java line 36:
>>
>>> 34: public static void main(String[] args) throws Exception {
>>> 35: String html = "Foo";
>>> 36: new JLabel(html);
>>
>> Suggestion:
>>
On Tue, 19 Sep 2023 16:51:31 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
>> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
>> 3.
On Tue, 19 Sep 2023 09:15:41 GMT, Arno Zeller wrote:
> > The bug report has "Angle: 15, width diff: -4" Over the length of the
> > string "The quick brown fox jumps over the lazy dog" that could be the
> > occasional rounding difference and there is a comment in the bug report
> > claiming
On Tue, 19 Sep 2023 16:02:21 GMT, Harshitha Onkar wrote:
> Better to close the stream objects in finally block in case of Exception.
>
> ```
> finally {
> if (oos != null) {
> oos.close();
> }
> if (ois != null) {
> ois.close();
> }
> }
> ```
No,
**Root cause**
The _Baekmuk Headline_ font maps `\u6f22` (漢) to glyph id 16950 which has zero
length.
The test fails if the right half of the image with the rendered glyph contains
only pixels of background colour. In this case, the left half of the image is
also blank. It's somewhat false
On Tue, 19 Sep 2023 00:00:45 GMT, Harshitha Onkar wrote:
> Looks like a valid explanation as to why `x + width` is used.
This is why `cellWidth` is a bad name: it doesn't convey the meaning. Consider
*renaming the variable* or adding a comment to clarify the meaning.
-
PR Review
On Tue, 19 Sep 2023 00:22:35 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4.
On Tue, 19 Sep 2023 00:03:34 GMT, Harshitha Onkar wrote:
>> With volatile, it makes the test slightly slower. Other than that, there's
>> not much harm.
>>
>> In most of these tests, there's no need for the `passed` field at all: you
>> can throw the exception from the code where you set the
On Mon, 18 Sep 2023 23:30:26 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
>
On Mon, 18 Sep 2023 21:53:36 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
>> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
>> 3.
On Mon, 18 Sep 2023 19:30:46 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4368050/bug4368050.java
>> javax/swing/JToolBar/4465534/bug4465534.java
>> javax/swing/JToolBar/4700351/bug4700351.java
>> javax/swing/JToolTip/4107843/bug4107843.java
>>
On Mon, 18 Sep 2023 19:09:41 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTree/4210432/bug4210432.java
>> javax/swing/JTree/4213868/bug4213868.java
>> javax/swing/JTree/4224491/bug4224491.java
>> javax/swing/JTree/4237370/bug4237370.java
>>
On Mon, 18 Sep 2023 19:14:42 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTabbedPane/4703690/bug4703690.java
>> javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
>> javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
>>
On Mon, 18 Sep 2023 18:54:39 GMT, Harshitha Onkar wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
>> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
>> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
>> 4.
On Mon, 18 Sep 2023 18:16:38 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/text/html/CSS/bug4174871.java line 41:
>>
>>> 39: private static JFrame frame;
>>> 40: private static JTextPane pane;
>>> 41: private static volatile boolean passed = false;
>>
>> Explicitly assigning
On Mon, 18 Sep 2023 19:00:48 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTabbedPane/4703690/bug4703690.java
>> javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
>> javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
>>
On Mon, 18 Sep 2023 18:55:37 GMT, Damon Nguyen wrote:
>> These are the tests being converted:
>>
>> javax/swing/JToolBar/4138694/bug4138694.java
>> javax/swing/JToolBar/4140421/bug4140421.java
>> javax/swing/JToolBar/4196662/bug4196662.java
>> javax/swing/JToolBar/4243930/bug4243930.java
>
>
On Mon, 18 Sep 2023 17:56:28 GMT, Harshitha Onkar wrote:
>> test/jdk/javax/swing/text/html/HTMLDocument/bug4209280.java line 41:
>>
>>> 39: JFrame jFrame = new JFrame("Unknown HTML tag Test");
>>> 40: String html = "Foo";
>>> 41: JLabel label = new
On Mon, 18 Sep 2023 14:34:31 GMT, Matthias Baesken wrote:
> The test RotatedTextTest shows a small width difference in the rotation (but
> the test assumes the width difference is 0 and fails). I wonder if the test
> can really assume a width difference 0 , is this really what we can expect
>
On Mon, 18 Sep 2023 06:19:05 GMT, Arno Zeller wrote:
> The test fails on newer SLES versions that have RobotoSlab-Regular.ttf as
> default font. I suggest to try getting a DejaVu font as default on Linux
> because it is known to work without issues.
What is the root cause for the test failing
On Thu, 14 Sep 2023 21:40:55 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTree/4210432/bug4210432.java
> javax/swing/JTree/4213868/bug4213868.java
> javax/swing/JTree/4224491/bug4224491.java
> javax/swing/JTree/4237370/bug4237370.java
>
On Thu, 14 Sep 2023 21:34:56 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JToolBar/4368050/bug4368050.java
> javax/swing/JToolBar/4465534/bug4465534.java
> javax/swing/JToolBar/4700351/bug4700351.java
> javax/swing/JToolTip/4107843/bug4107843.java
>
On Thu, 14 Sep 2023 16:35:44 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTabbedPane/4703690/bug4703690.java
> javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
> javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
>
On Thu, 14 Sep 2023 16:43:29 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JToolBar/4138694/bug4138694.java
> javax/swing/JToolBar/4140421/bug4140421.java
> javax/swing/JToolBar/4196662/bug4196662.java
> javax/swing/JToolBar/4243930/bug4243930.java
On Fri, 15 Sep 2023 22:54:32 GMT, Harshitha Onkar wrote:
>> These are the tests being converted:
>>
>> javax/swing/JTabbedPane/4703690/bug4703690.java
>> javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
>> javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
>>
On Thu, 14 Sep 2023 16:35:44 GMT, Damon Nguyen wrote:
> These are the tests being converted:
>
> javax/swing/JTabbedPane/4703690/bug4703690.java
> javax/swing/JTabbedPane/GetComponentAt/GetComponentAtTest.java
> javax/swing/JTabbedPane/ReplaceCompTab/ReplaceCompTab.java
>
On Thu, 14 Sep 2023 18:45:34 GMT, Harshitha Onkar wrote:
> Following tests are open sourced as part of this PR.
>
> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
> 3.
On Fri, 15 Sep 2023 19:35:15 GMT, Harshitha Onkar wrote:
> Following tests are open sourced as part of this PR.
>
> 1. test/jdk/javax/swing/text/html/CSS/bug4174871.java
> 2. test/jdk/javax/swing/text/html/CSS/bug4174874.java
> 3. test/jdk/javax/swing/text/html/CSS/bug4284162.java
> 4.
On Tue, 1 Aug 2023 04:16:30 GMT, Renjith Kannath Pariyangad
wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Added CoInitialize status check
>
> Did further investigation on JDK-7116070 (name
On Thu, 3 Aug 2023 10:35:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization
On Thu, 3 Aug 2023 04:02:16 GMT, Renjith Kannath Pariyangad
wrote:
>> src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp
>> line 183:
>>
>>> 181: INT32 cacheIndex;
>>> 182:
>>> 183: if (!DS_lockCache() || FAILED(::CoInitialize(NULL))) {
>>
>> I believe this
;
> Also, I marked up references to classes and members with `{@code}`.
>
> Look at the updated version: [`Document.remove` in JDK
> 22](https://cr.openjdk.org/~aivanov/4622866/api/java.desktop/javax/swing/text/Document.html#remove(int,int)).
Alexey Ivanov has updated the pull requ
On Wed, 13 Sep 2023 21:17:46 GMT, Alexander Zvegintsev
wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8294156: Additional layouts for vertically positioned test windows
>
> te
On Tue, 12 Sep 2023 19:59:27 GMT, Andrey Turbanov wrote:
> Do we need a second reviewer or I can integrate?
It's a good question.
Overall, the changes are trivial: only comments are updated, some javadoc for
private classes which are comments, then a couple of method names and variable
names
On Wed, 30 Aug 2023 14:08:21 GMT, Alexey Ivanov wrote:
> I reverted changes in non-Swing parts to reduce amount of files to review.
Did you submit a follow-up bug for those files?
Do you have a PR already?
-
PR Comment: https://git.openjdk.org/jdk/pull/14847#issuecomm
On Tue, 12 Sep 2023 21:33:44 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/java/awt/Choice/ChoiceSelectTest.java line 160:
>>
>>> 158: public static void main(String[] args) throws Exception {
>>> 159: EventQueue.invokeAndWait(() -> new ChoiceSelectTest().test());
>>> 160: }
>>
On Tue, 12 Sep 2023 21:52:33 GMT, Alexander Zvegintsev
wrote:
>> Some closed AWT test are open sourced.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fix path
Looks good.
-
Marked as reviewed by
On Wed, 13 Sep 2023 18:50:54 GMT, Alexey Ivanov wrote:
>> The manual test frame does not provide any layout managers for test windows,
>> the user has to implement one. This demonstrates how to position a several
>> test UI windows.
>>
>> We may include some i
On Tue, 12 Sep 2023 19:51:45 GMT, Alexey Ivanov wrote:
>>> However, to test this case I'll need a (simple) scenario where multiple
>>> windows are created.
>>
>> For example
>> `test/jdk/java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter
the tests: `test/jdk/java/awt/Window/8294156`.
>
> Alternatively, you can checkout directly from my fork:
>
>
> git fetch https://github.com/aivanov-jdk/jdk.git
> demo-manyTestWindows:demo-manyTestWindows
> git checkout demo-manyTestWindows
Alexey Ivanov has updated the pull request
g a manual test.
>
> This change depends on #15665 and
> [JDK-8294156](https://bugs.openjdk.org/browse/JDK-8294156) as well as #15661,
> both of which depend on #15660.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webr
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote:
>> This enhances the `Builder` pattern added in
>> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
>> `testUI` which allows passing a lambda expression or a method reference to
>> cr
The manual test frame does not provide any layout managers for test windows,
the user has to implement one. This demonstrates how to position a several test
UI windows.
We may include some implementations into the manual test framework in the
future.
**This PR is not meant to be integrated.**
stUI(() -> createTestUI())
> .build()
> .awaitAndCheck();
> }
>
> where `createTestUI` returns a test UI window.
Alexey Ivanov has updated the pull request incrementally with one additional
commit since the last revision:
8294156: Allow creating several t
**Problem**
On a standard display with the scale of 100%, the BoxLayout sample has blurred
edges.
It is the result of how SVG is rendered: the strokes fall between the pixel
grid, therefore a 1-pixel wide stroke is blurred between the previous and the
following pixels with 50% of colour on
On Wed, 13 Sep 2023 07:46:50 GMT, Alexey Ivanov wrote:
> The image in the [documentation for
> `Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int))
> looks as if the portion between the offsets 6 and 10 i
The image in the [documentation for
`Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int))
looks as if the portion between the offsets 6 and 10 is removed. However, the
entire region for _‘quick ’_ is highlighted.
I
On Tue, 12 Sep 2023 12:26:38 GMT, Alexander Zvegintsev
wrote:
>> Some closed AWT test are open sourced.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> spacing
Changes requested by aivanov (Reviewer).
On Tue, 12 Sep 2023 18:41:23 GMT, Alexander Zvegintsev
wrote:
>>> Sometimes we may need to create more than one window(e.g. some DnD test
>>> with two windows). Perhaps we should consider that here by adding
>>> `List createTestUI()`.
>>
>> I thought about it. Yet I couldn't find a simple
them stand out. The test instructions for single- and
> multi-selection are emphasised with bold text.
>
> This change depends on #15660 and
> [JDK-8294158](https://bugs.openjdk.org/browse/JDK-8294158).
Alexey Ivanov has updated the pull request incrementally with one additional
com
On Tue, 12 Sep 2023 13:49:41 GMT, Alexander Zvegintsev
wrote:
>>> Probably `trim()` and `toLowerCase()` could be useful here.
>>
>> Could be… On the other hand, in post XHTML era, the elements are usually in
>> lower-case. Thus we should stick with it and use lowercase HTML elements
>>
On Tue, 12 Sep 2023 13:06:02 GMT, Alexander Zvegintsev
wrote:
> Shouldn't we mention here a window added by `testUI` via builder?
I don't think it's necessary: the builder uses `addTestWindow` under the hood.
It's the builder that requires documentation.
In fact, the entire class requires a
On Tue, 12 Sep 2023 13:04:09 GMT, Alexander Zvegintsev
wrote:
> Sometimes we may need to create more than one window(e.g. some DnD test with
> two windows). Perhaps we should consider that here by adding `List
> createTestUI()`.
I thought about it. Yet I couldn't find a simple scenario where
On Tue, 12 Sep 2023 12:44:34 GMT, Alexander Zvegintsev
wrote:
> Probably `trim()` and `toLowerCase()` could be useful here.
Could be… On the other hand, in post XHTML era, the elements are usually in
lower-case. Thus we should stick with it and use lowercase HTML elements anyway.
I think
On Sun, 30 Jul 2023 12:50:58 GMT, Christopher Sahnwaldt
wrote:
> In
> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
> the weak reference was accidentally changed from a field to a local
> variable, which means that the PropertyChangeListener keeps a strong
>
On Tue, 12 Sep 2023 03:37:07 GMT, Prasanta Sadhukhan
wrote:
>> Few awt problem listed tests are placed in swing category which should be
>> amended
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> PL amend
Marked
On Tue, 12 Sep 2023 03:32:04 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/ProblemList.txt line 471:
>>
>>> 469: java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java 8294264 windows-x64
>>> 470:
>>> 471: java/awt/dnd/MissingDragExitEventTest/MissingDragExitEventTest.java
>>> 8288839 windows-x64
>>
On Thu, 31 Aug 2023 08:02:35 GMT, Prasanta Sadhukhan
wrote:
> After the first time a JTableHeader is serialized, it no longer will
> uninstall its UI upon subsequent serializations.
> This happens for classes that use the BasicTableHeaderUI class. Any LAF that
> extends the BasicTableHeaderUI
Refactored timeout handling in PassFailJFrame:
1. Managing the timer and formatting the time left is inside `TimeoutHandler`
class.
2. The class handles timer events and updates the label accordingly.
This is implemented on top of #15665.
-
Depends on:
This update to `FileChooserSymLinkTest.java` demonstrates the usage of the
`testUI` method of the `PassFailJFrame.Builder` class to streamline creating
the UI for manual tests.
The [`main`
This enhances the `Builder` pattern added in
[JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
`testUI` which allows passing a lambda expression or a method reference to
create *the test UI window*.
The `PassFailJFrame` will automatically call the method on the EDT
them stand out. The test instructions for single- and
> multi-selection are emphasised with bold text.
>
> This change depends on #15660 and
> [JDK-8294158](https://bugs.openjdk.org/browse/JDK-8294158).
Alexey Ivanov has updated the pull request with a new target base due to a
merge o
On Mon, 11 Sep 2023 09:42:36 GMT, Prasanta Sadhukhan
wrote:
> Few awt problem listed tests are placed in swing category which should be
> amended
test/jdk/ProblemList.txt line 471:
> 469: java/awt/Mixing/AWT_Mixing/OpaqueOverlapping.java 8294264 windows-x64
> 470:
> 471:
To demonstrate the functionality of HTML formatting in `PassFailJFrame`, I
updated the instructions for the
`test/jdk/javax/swing/JFileChooser/FileChooserSymLinkTest.java` test. The
commands to create the symbolic links are marked up with monospace font, which
makes them stand out. The test
This enhancement provides HTML formatting for instructions in the manual test
framework, `PassFailJFrame`.
Some tests could benefit from rich-formatted instructions, especially when the
instructions are long.
-
Commit messages:
- Wrap createUI call
- Revert changes to
On Fri, 8 Sep 2023 13:02:07 GMT, Alan Bateman wrote:
> So what about FontConfiguration? Is that something using the class directly
> too?
I think this is not needed either. As far as I can see, the instance of
`FontConfiguration` is created from `doPrivileged`, therefore these two system
On Thu, 7 Sep 2023 10:22:07 GMT, Alexey Ivanov wrote:
>> That is wrong suggestion, if the one bug found in one place it is part of
>> the fixing process to check that it does not exists in another one.
>> Especially for typo it is easy to check. We already discussed this
On Tue, 8 Aug 2023 00:42:36 GMT, Sergey Bylokhov wrote:
> That is wrong suggestion, if the one bug found in one place it is part of the
> fixing process to check that it does not exists in another one. Especially
> for typo it is easy to check.
I don't think it is wrong, especially for typos.
On Wed, 6 Sep 2023 15:39:16 GMT, Prasanta Sadhukhan
wrote:
> A security manager swing test is open sourced
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15597#pullrequestreview-1615073797
On Wed, 6 Sep 2023 01:00:17 GMT, lawrence.andrews wrote:
>> Test was failing with "test result: Error. Parse Exception: Arguments to
>> `manual' option not supported: yesno"
>> Following are fixed
>> 1) Removed yesno
>> 2) Used PassFailJFrame manual test framework to show the test instruction
On Wed, 6 Sep 2023 15:41:47 GMT, Prasanta Sadhukhan
wrote:
>> Few more closed swing headless tests are opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Indent
test/jdk/javax/swing/undo/bug4992178.java
901 - 1000 of 1956 matches
Mail list logo
