On Mon, 7 Oct 2024 21:29:55 GMT, Daniel Gredler wrote:
>> There is a bug in `TextLayout.getOutline(AffineTransform)`, where the
>> transformation is applied too early (before the layout path applies its
>> mapping). The most obvious error caused by this bug is that
>> `Graphics2D.drawString(..
icker:
https://github.com/andy-goryachev-oracle/Test/blob/main/screenshots/Screenshot%202024-08-23%20at%2009.02.31.png
and lastly, the implementation should be cognizant of the time zones, to avoid
bugs like this one https://github.com/yui/yui2/pull/15
cheers,
-andy
From: client-libs-dev on b
On Thu, 2 May 2024 21:58:21 GMT, Phil Race wrote:
>> Delete an internal class that has been around for 20 years but never been
>> used.
>> Verified that is true at least as far back as JDK7
>> All platforms build. Tests pass.
>
> Phil Race has updated the pull request incrementally with one addi
On Wed, 28 Feb 2024 12:20:04 GMT, Alexey Ivanov wrote:
> If a test runs in non-English locale, the digits displayed in the timeout
> could be locale-specific, which may be confusing.
>
> For example, in the Arabic locale `-Duser.language=ar`, the timeout is
> displayed like this:
>
> Test tim
On Thu, 15 Feb 2024 17:09:17 GMT, Naoto Sato wrote:
>> All the java/util/Currency tests pass. I also searched the code for "ZZ" but
>> could not find any references in the test.
>
> Please do not replace those tabs with spaces as they are intentional for
> testing the runtime to safely ignore t
As a fellow Swing developer, let me suggest that one should avoid changing the
component hierarchy in the middle of another change. EventQueue.invokeLater()
might be a solution to this problem.
Cheers,
-andy
From: client-libs-dev on behalf of Alan
Snyder
Date: Wednesday, November 8, 2023
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Tue, 10 Oct 2023 06:45:45 GMT, Prasanta Sadhukhan
wrote:
>>> in the mean time, do you know why the checks are consistently failing for
>>> this PR?
>>
>> No, this failure is in hotspot and it's ok to ignore thisnothing to do
>> with the change in this PR
>> ❌ [linux-x64 / test (hs/tier
On Tue, 10 Oct 2023 15:04:51 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1439:
>>
>>> 1437:
>>> 1438: private static Map initColorNames() {
>>> 1439: return Map.ofEntries(
>>
>> would it make more sense to use a switch statement i
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named c
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Fri, 6 Oct 2023 07:25:54 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Wed, 4 Oct 2023 05:48:59 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Wed, 4 Oct 2023 05:48:59 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Wed, 4 Oct 2023 05:48:59 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
On Wed, 4 Oct 2023 05:48:59 GMT, Prasanta Sadhukhan
wrote:
>> SwingNode does not update its internal cache of Swing pref/max/min height
>> and widths when its JComponent content's corresponding size constraints are
>> updated. As such, it isn't resized to honor those size constraints.
>>
>>
dd the listener as soon as the component is added to the
>> JLightweightFrame's content.
>
> Fix is updated to register listener before component is added/removed.
>
> @andy-goryachev-oracle @aghaisas Can you please review this FX fix?
>
> There is some SwingNode r
On Fri, 17 Mar 2023 20:28:13 GMT, Justin Lu wrote:
>> This PR converts Unicode sequences to UTF-8 native in .properties file.
>> (Excluding the Unicode space and tab sequence). The conversion was done
>> using native2ascii.
>>
>> In addition, the build logic is adjusted to support reading in t
On Wed, 25 Jan 2023 18:43:19 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8296661 : Typo Found In
>> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661)
>>
>> This is tracked in JBS as
>> - [JDK-8296661 : Typo Found In
>> CSSPars
On Wed, 28 Dec 2022 00:10:53 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8296661 : Typo Found In
>> CSSParser.java](https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8296661)
>>
>> This is tracked in JBS as
>> - [JDK-8296661 : Typo Found In
>> CSSPars
On Mon, 2 Jan 2023 08:24:44 GMT, Prasanta Sadhukhan
wrote:
> This is a revert of commit
> https://github.com/openjdk/jdk/commit/415bf44191632cd8dbcc158c0ff0992c0b61c3ba
> which was a fix for 8275715: D3D pipeline processes multiple PaintEvent at
> initial drawing
> as it is causing some repai
I second Alan's sentiment. If a helpful utility method is called multiple
times from Swing code, it does make sense to make publicly available - chances
are it is also useful to the application or third party component developers.
Copying code from Swing has a legal aspect - it probably makes t
On Fri, 2 Dec 2022 17:10:17 GMT, Magnus Ihse Bursie wrote:
> and instead I have split up this work in five different bugs
would you consider also adding a unit test to check whether the localized
resources also contain leading/trailing whitespace, and possibly special
characters (like {, }, ,
On Thu, 10 Nov 2022 08:01:38 GMT, Abhishek Kumar wrote:
> It seems there was a typo inside function `installListeners(Component, int)`
> and `removeListeners(Component)` on case EventID.CELLEDITOR.
>
> Changed the string from "getCellEditorMethod" to "getCellEditor" in
> `protected void instal
On Fri, 4 Nov 2022 01:56:05 GMT, ScientificWare wrote:
> I suspect a typo in the documentation comments.
Marked as reviewed by angorya (no project role).
-
PR: https://git.openjdk.org/jdk/pull/10975
On Mon, 24 Oct 2022 19:58:31 GMT, Naoto Sato wrote:
> I think what we can do is check the original English properties values that
> the engineers provided, and if there is no trailing spaces there, we can
> safely remove trailing spaces in localized bundles.
Good idea! I wonder if this should
On Mon, 24 Oct 2022 19:23:04 GMT, Andy Goryachev wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Revert "Remove check for .properties from jcheck"
On Mon, 24 Oct 2022 19:34:56 GMT, Magnus Ihse Bursie wrote:
> For the files which have trailing "whitespace" (now as unicode sequences), I
> will file follow-up bugs on the respective components to verify if this is
> indeed correct, or a bug that should be fixed.
probably not needed - if nobo
On Mon, 24 Oct 2022 19:21:07 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 21 Oct 2022 08:17:46 GMT, Magnus Ihse Bursie wrote:
>> Properties files is essentially source code. It should have the same
>> whitespace checks as all other source code, so we don't get spurious
>> trailing whitespace changes.
>>
>> With the new Skara jcheck, it is possible to increas
On Fri, 21 Oct 2022 16:04:14 GMT, Naoto Sato wrote:
> replace those dangling white spaces with explicit Unicode escapes
this is a *very good* idea.
-
PR: https://git.openjdk.org/jdk/pull/10792
d any white
>> space characters after it are also skipped. All remaining characters on the
>> line become part of the associated element string;
>
> @andy-goryachev-oracle Oh, I did not know that. Is this really how it is
> implemented, or is there a discrepancy between the spec
On Thu, 20 Oct 2022 11:58:58 GMT, Magnus Ihse Bursie wrote:
> Properties files is essentially source code. It should have the same
> whitespace checks as all other source code, so we don't get spurious trailing
> whitespace changes.
>
> With the new Skara jcheck, it is possible to increase the
On Thu, 25 Aug 2022 08:00:38 GMT, Prasanta Sadhukhan
wrote:
>> When comboBox have focus, pressing Alt+Down (or Up) should render the popup
>> which is not happening for Aqua L&F.
>>
>> Fix is to add toggleAction for Alt+Down/Up keys as has been done for
>> [MetalLookAndFeel](https://github.co
On Mon, 1 Aug 2022 16:18:00 GMT, Andy Goryachev wrote:
>> As the returned value has been used in comparison with 1000.0 , so returning
>> a double value from formatToDoubleValue().
>
> Perhaps we should mention in the comments that this code block is only
> relevant for
On Thu, 28 Jul 2022 16:19:50 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/sun/swing/FilePane.java line 1205:
>>
>>> 1203: } else {
>>> 1204: double kbVal = formatToDoubleValue(len);
>>> 1205: len = (long)kbVal;
>>
>> This c
On Thu, 28 Jul 2022 10:08:24 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
I am afraid that this change will instantly break >80% of all deployed
applications. Same for setSize()/resize().
-andy
From: client-libs-dev on behalf of SWinxy
Date: Thursday, 2022/07/28 at 23:25
To: client-libs-dev@openjdk.org
Subject: Migrating show/hide code to setVisible
The show()
On Wed, 27 Jul 2022 17:37:00 GMT, Andy Goryachev wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> space added as per review comment
>
> src/java.desktop/share/classes/sun/swing/FileP
On Wed, 27 Jul 2022 04:31:58 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Wed, 27 Jul 2022 04:31:58 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Thu, 21 Jul 2022 06:44:26 GMT, Abhishek Kumar wrote:
>> JDK does not do unit tests in this way. There is no place to put it.
>> We do functional "system" level regression tests.
>
> I guess extracting this code to a function won't give much advantage as it is
> not called from multiple places
On Wed, 27 Jul 2022 04:31:58 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Wed, 20 Jul 2022 08:17:09 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since
On Mon, 18 Jul 2022 19:50:28 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> properties file reverted back and filesize shown in KB
>
> src/java.desktop/share/classes/sun/swing/FilePane.java line 1
On Thu, 14 Jul 2022 19:50:40 GMT, Naoto Sato wrote:
>> Upon further consideration, and after discussing the state of plural forms
>> support in JDK with @naotoj I realized that we cannot use ChoiceFormat here
>> at all. The numeric choices, and their corresponding resource strings are
>> loca
On Wed, 13 Jul 2022 16:54:48 GMT, Naoto Sato wrote:
>> I would like to emphasize that this issue is complicated. Plural rules vary
>> from language to language, adding plural strings to resource bundles adds
>> costs in terms of translation and testing.
>>
>> If we were to support proper pl
On Wed, 13 Jul 2022 16:54:48 GMT, Naoto Sato wrote:
>> I would like to emphasize that this issue is complicated. Plural rules vary
>> from language to language, adding plural strings to resource bundles adds
>> costs in terms of translation and testing.
>>
>> If we were to support proper pl
On Wed, 13 Jul 2022 07:22:56 GMT, Abhishek Kumar wrote:
>> am not sure if resource file can support {1} byte case...if that is
>> supported, then you can use that...but likelihood of 1 byte file is very
>> rare so I guess we can ignore it, that's my opinion.
>
> ok, should I revert back "B" to
On Fri, 8 Jul 2022 06:24:54 GMT, Abhishek Kumar wrote:
>> Yet JDK isn't localised into Arabic. Some Slavic languages have different
>> plural forms which depend on the last digit in the number (except for 10-19).
>>
>> It is probably the reason why Windows Explorer shows the size in KB. On the
On Thu, 7 Jul 2022 19:41:07 GMT, Alexey Ivanov wrote:
>> It is similar to the file size shown in native tools i.e. "bytes" in ubuntu
>> platform.
>
> Shall we handle "1 byte"?
good point! that's why I suggested "{0} B"
plural rules can be quite complex, see
http://www.unicode.org/cldr/cldr-aux
On Thu, 7 Jul 2022 06:44:47 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/sun/swing/FilePane.java line 532:
>>
>>> 530:
>>> UIManager.getString("FileChooser.detailsViewActionLabelText", l);
>>> 531:
>>> 532: byteString =
>>> UIManager.getStr
On Wed, 6 Jul 2022 11:59:31 GMT, Abhishek Kumar wrote:
>> JFileChooser - empty file size issue fixed.
>> For empty file, now the size 0 bytes.
>> Manual Test Case "ZeroFileSizeCheck.java" created.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since t
On Thu, 30 Jun 2022 16:24:05 GMT, Naoto Sato wrote:
>> In this case, I would suggest to use straight number.
>>
>> If you notice, the lengths are listed as {0} KB, {0} MB, {0} GB (there are
>> no terabytes, I see), and "1023 bytes" would make the string too long and
>> might case ellipses to a
On Thu, 30 Jun 2022 16:09:51 GMT, Naoto Sato wrote:
>>> > Also, will this code work correctly for non-English locales?
>>>
>>> It won't.
>>>
>>> It has to use `MessageFormat` and it has to add a new string to the
>>> resource bundle.
>>
>> Yeah, I will check on this
>
> The code should employ
On Wed, 29 Jun 2022 13:06:21 GMT, Abhishek Kumar wrote:
> JFileChooser - empty file size issue fixed.
> For empty file, now the size 0 bytes.
> Manual Test Case "ZeroFileSizeCheck.java" created.
src/java.desktop/share/classes/sun/swing/FilePane.java line 1198:
> 1196: text
61 matches
Mail list logo
