Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-20 Thread Phil Race
On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R wrote: >> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER >> functionalities to disable navigation within JTable of FilePane in >> DetailsView. This is causing the issue mentioned in the bug where on >> invoking DetailsView the functi

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-20 Thread Tejesh R
On Tue, 18 Jun 2024 06:21:12 GMT, Tejesh R wrote: >> Yes, modifying the shared `ActionMap` is causing this issue though. As far >> as I have seen the copy first solution is mentioned in this bug >> https://bugs.openjdk.org/browse/JDK-8166352 as customer submitted workaround. > > I did thought o

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-18 Thread Alisen Chung
On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R wrote: >> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER >> functionalities to disable navigation within JTable of FilePane in >> DetailsView. This is causing the issue mentioned in the bug where on >> invoking DetailsView the functi

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Tejesh R
On Tue, 18 Jun 2024 05:13:14 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/sun/swing/FilePane.java line 1320: >> >>> 1318: } >>> 1319: >>> 1320: >>> detailsTable.setFocusTraversalKeys(KeyboardFocusManager.FORWARD_TRAVERSAL_KEYS, >> >> If I have this right, JTable gets

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Tejesh R
On Mon, 17 Jun 2024 19:58:37 GMT, Phil Race wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix - remove null initialization for table > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1320: > >>

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Phil Race
On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R wrote: >> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER >> functionalities to disable navigation within JTable of FilePane in >> DetailsView. This is causing the issue mentioned in the bug where on >> invoking DetailsView the functi

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Tejesh R
On Mon, 17 Jun 2024 08:55:45 GMT, Prasanta Sadhukhan wrote: >> Yes, I hope now it is safe to remove these lines. Since TAB/SHIFT navigation >> is rejected with this >> [fix/line](https://github.com/openjdk/jdk/blame/5528ad74902fa4f4ec621d70e7e7d85f4ac1d780/src/java.desktop/share/classes/sun/sw

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Prasanta Sadhukhan
On Mon, 17 Jun 2024 07:24:32 GMT, Tejesh R wrote: >> src/java.desktop/share/classes/sun/swing/FilePane.java line 1321: >> >>> 1319: >>> 1320: // TAB/SHIFT-TAB should transfer focus and ENTER should >>> select an item. >>> 1321: // We don't want them to navigate within the table

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Tejesh R
> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER > functionalities to disable navigation within JTable of FilePane in > DetailsView. This is causing the issue mentioned in the bug where on invoking > DetailsView the functionalities are removed from JTable. I don't see it's > e

Re: RFR: 6967482: TAB-key does not work in JTables after selecting details-view in JFileChooser [v2]

2024-06-17 Thread Tejesh R
On Fri, 14 Jun 2024 20:17:29 GMT, Alisen Chung wrote: >> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review fix - remove null initialization for table > > src/java.desktop/share/classes/sun/swing/FilePane.java line 1321: >