On Wed, 26 Jun 2024 20:30:55 GMT, Alisen Chung wrote:
> > Yes, there is some disconnect. For all OS (MAC with above changes) print
> > range is working properly only with following values firstPage =0 and
> > lastPage =-1 at **RasterPrinterJob.java** and highly depend on
> >
On Fri, 21 Jun 2024 14:46:33 GMT, Renjith Kannath Pariyangad
wrote:
> Yes, there is some disconnect. For all OS (MAC with above changes) print
> range is working properly only with following values firstPage =0 and
> lastPage =-1 at **RasterPrinterJob.java** and highly depend on
>
On Fri, 21 Jun 2024 14:46:33 GMT, Renjith Kannath Pariyangad
wrote:
> I don't think there is any issue with native code, with this change I have
> brought MAC same as other OS.
Hm… It works correctly now. But if a page range is used,
`SunPageSelection.RANGE` is added to attributes. Now it's
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Thu, 20 Jun 2024 18:40:29 GMT, Alexey Ivanov wrote:
> Do you refer to
> [`test/jdk/java/awt/print/PrinterJob/PageRanges.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/print/PrinterJob/PageRanges.java)
> and
>
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Thu, 20 Jun 2024 11:10:59 GMT, Renjith Kannath Pariyangad
wrote:
>> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 225:
>>
>>> 223: if (isRangeSet) {
>>> 224: attributes.add(new PageRanges(from+1, to+1));
>>> 225:
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Tue, 18 Jun 2024 21:48:54 GMT, Alisen Chung wrote:
> why was this attribute added, and why is it being removed now? is the bug in
> SunPageSelection?
I am not sure why this attribute added, but noticed for other OS's this
workflow will be taken care by _RasterPrinterJob_ . With this
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
Hi Reviewers,
This fix will resolve page range not printing proper pages if the rage begin
from 2 or above on Mac machines.
I have verified the manual range related tests like PageRanges.java,
ClippedImages.java and test.java and confirmed its fixing the issue.
Please review and let me know
On Thu, 29 Dec 2022 09:36:32 GMT, Tibor Malanik wrote:
> The problem is noticeable when setPageable on java.awt.print.PrinterJob is
> used
So why is the Test.java in the bugreport not using it ? And yet claiming it
shows the problem >
And can we have a test with this fix, even if it is
On Mon, 21 Nov 2022 14:32:50 GMT, Christian Heilmann wrote:
> 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS
> leads to not print
The problem is noticeable when setPageable on java.awt.print.PrinterJob is
used. In that case the pageIndex 0 will be used in
On Mon, 21 Nov 2022 14:32:50 GMT, Christian Heilmann wrote:
> 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS
> leads to not print
This PR (and bug) could use a better title. I suggest :
"[macos] pages are missing when printing using page ranges"
Of course it
On Mon, 21 Nov 2022 14:32:50 GMT, Christian Heilmann wrote:
> 8297191: [macos] printing page range "page 2 to 2" or "page 2 to 4" on macOS
> leads to not print
So .. this looks and sounds reasonable except that I can't reproduce it.
I see the "0" there at least as far back as JDK 8 (so I guess
15 matches
Mail list logo
