On Tue, 25 Jun 2024 03:41:05 GMT, Prasanta Sadhukhan
wrote:
> 8334580: Deprecate no-arg constructor BasicSliderUI() for removal
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19874#pullrequestreview-2138314011
8334580: Deprecate no-arg constructor BasicSliderUI() for removal
-
Commit messages:
- Backport e527e1c32fcc7b2560cec540bcde930075ac284a
Changes: https://git.openjdk.org/jdk/pull/19874/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19874=00
Issue:
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Mon, 24 Jun 2024 16:28:36 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Mon, 24 Jun 2024 05:50:40 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 18:49:08 GMT, Kevin Rushforth wrote:
>> Or:
>>
>>
>> * @deprecated This constructor will be removed in a future release.
>> * Use {@link #BasicSliderUI(JSlider b)} instead.
>>
>> This is in the gist of the deprecation message for
>>
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since
On Fri, 21 Jun 2024 18:44:58 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 153:
>>
>>> 151: /**
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: * @deprecated This constructor will be removed in future release
On Fri, 21 Jun 2024 18:33:37 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>>
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 18:08:45 GMT, Phil Race wrote:
> But it means that if we deprecated the consructor with args we'd probably
> want to look at those too. It seems like the ripple effect isn't worth it.
It would clean up the code… Yes, we would need to modify all the subclasses too.
> And
On Fri, 21 Jun 2024 15:13:27 GMT, Iris Clark wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 153:
>>
>>> 151: /**
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: * @deprecated This constructor will be removed in future release
>>
On Fri, 21 Jun 2024 15:59:26 GMT, Prasanta Sadhukhan
wrote:
> Now that I looked at the code more thoroughly, the no-arg constructor makes
> more sense actually.
>
>
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 14:51:39 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>>
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
On Fri, 21 Jun 2024 12:21:38 GMT, Prasanta Sadhukhan
wrote:
> Build works ok however I see in some places like
> [this](https://github.com/openjdk/jdk/blob/08ace27da1d9cd215c77471eabf41417ff6282d2/src/java.desktop/share/classes/java/awt/Graphics.java#L1169)
> @SuppressWarnings("removal") is
On Fri, 21 Jun 2024 12:12:22 GMT, Kevin Rushforth wrote:
> This looks good. I presume you've done a test build to ensure that there are
> no "removal" warnings elsewhere in the JDK? (I suspect there aren't, since I
> doubt any test program would be using this mistakenly added constructor)
On Fri, 21 Jun 2024 11:14:52 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 154:
>>
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: */
>>> 154: @Deprecated(since = "23")
>>
>> You need to add `forRemoval =
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since
On Fri, 21 Jun 2024 11:10:56 GMT, Kevin Rushforth wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
>
On Fri, 21 Jun 2024 03:31:50 GMT, Prasanta Sadhukhan
wrote:
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Changes requested by kcr
The no-arg constructor BasicSliderUI() was added under
[JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
constructor should be deprecated for removal in future release
-
Commit messages:
- -8334580: Deprecate no-arg constructor BasicSliderUI() for removal
31 matches
Mail list logo
