Awesome, thanks!
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Wednesday, January 28, 2015 9:32 AM
To: Robert Goulet
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/27/2015 01:31 PM, Brad
On 01/27/2015 01:31 PM, Brad King wrote:
> On 01/27/2015 01:22 PM, Robert Goulet wrote:
>> If the flag would be wrong, compilation would fail.
>
> What if the flag is not added at all because the property is ignored?
> The test needs to be something that would fail without this change.
I revised
On 01/27/2015 01:22 PM, Robert Goulet wrote:
> If the flag would be wrong, compilation would fail.
What if the flag is not added at all because the property is ignored?
The test needs to be something that would fail without this change.
Thanks,
-Brad
--
Powered by www.kitware.com
Please keep
If the flag would be wrong, compilation would fail.
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Tuesday, January 27, 2015 12:59 PM
To: Robert Goulet
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files
On 01/27/2015 12:47 PM, Robert Goulet wrote:
> There you go. Let me know if it's good now.
Thanks. I've committed the patch and merged for testing:
VS: Add source file property to set extra hlsl shader flags
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=6b9bd827
In the test I see:
VS_S
There you go. Let me know if it's good now.
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Monday, January 26, 2015 3:09 PM
To: Robert Goulet
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On
On 01/26/2015 02:28 PM, Robert Goulet wrote:
> Here's a patch for adding additional compile flags to .hlsl
> files in Visual Studio. For this I simply added the new
> VS_SHADER_FLAGS source file property and basically did the
> same as other VS_SHADER_* properties.
Okay. Please use spaces instead
aster.
-Original Message-
From: Brad King [mailto:brad.k...@kitware.com]
Sent: Monday, January 26, 2015 1:23 PM
To: Robert Goulet
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 01:10 PM, Robert Goulet wrote:
> I might jus
On 01/26/2015 01:10 PM, Robert Goulet wrote:
> I might just go and add the COMPILE_FLAGS into the custom logic.
Okay. Look at the OutputSourceSpecificFlags logic as a reference.
-Brad
--
Powered by www.kitware.com
Please keep messages on-topic and check the CMake FAQ at:
http://www.cmake.or
King [mailto:brad.k...@kitware.com]
Sent: Monday, January 26, 2015 1:08 PM
To: Robert Goulet
Cc: cmake-developers@cmake.org
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 01:04 PM, Robert Goulet wrote:
> Do we really need to go down the road of makin
On 01/26/2015 01:04 PM, Robert Goulet wrote:
> Do we really need to go down the road of making hlsl a 'first-class'
> language to add support for additional compile flags?
Right now the Visual Studio generator has custom logic for .hlsl
sources, so the rest of CMake knows nothing about them and tr
rg
Subject: Re: [cmake-developers] Setting additional compile flags to .hlsl files?
On 01/26/2015 12:20 PM, Robert Goulet wrote:
> set_source_files_properties(${SHADER_FILE} PROPERTIES COMPILE_FLAGS
> "/I${CMAKE_SOURCE_DIR}/src") and it didn't get written to the .vcxproj file
&
On 01/26/2015 12:20 PM, Robert Goulet wrote:
> set_source_files_properties(${SHADER_FILE} PROPERTIES COMPILE_FLAGS
> "/I${CMAKE_SOURCE_DIR}/src")
> and it didn't get written to the .vcxproj file at all.
Right now .hlsl files are written by
cmVisualStudio10TargetGenerator::WriteExtraSource
beca
Hi all,
Any reasons why setting additional compile flags on .hlsl files would not work?
I tried this:
set_source_files_properties(${SHADER_FILE} PROPERTIES COMPILE_FLAGS
"/I${CMAKE_SOURCE_DIR}/src")
...and it didn't get written to the .vcxproj file at all. In this specific
case, I want to add
14 matches
Mail list logo
