[GitHub] [airflow] potiuk commented on pull request #29210: Fix bitnami/postgresql subchart upgrade

2023-01-28 Thread via GitHub
potiuk commented on PR #29210: URL: https://github.com/apache/airflow/pull/29210#issuecomment-1407588395 Needs tests fix as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [airflow] potiuk commented on issue #22790: Helm deployment fails when postgresql.nameOverride is used

2023-01-28 Thread via GitHub
potiuk commented on issue #22790: URL: https://github.com/apache/airflow/issues/22790#issuecomment-1407587460 sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [airflow] potiuk commented on a diff in pull request #29203: docs: Add trigger process missing from Airflow docker

2023-01-28 Thread via GitHub
potiuk commented on code in PR #29203: URL: https://github.com/apache/airflow/pull/29203#discussion_r1089881439 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -68,6 +68,7 @@ This file contains several service definitions: task instances once their dependencies

[GitHub] [airflow] potiuk commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
potiuk commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407581892 > * Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. > > I am sorry I wasn't clear. I meant what should I do about the test

[GitHub] [airflow] Taragolis opened a new pull request, #29213: Fix MySQL integrations tests run

2023-01-28 Thread via GitHub
Taragolis opened a new pull request, #29213: URL: https://github.com/apache/airflow/pull/29213 Use MySQL backend instead of Postgres during `Tests / Integration Tests MySQL` run -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [airflow] amoghrajesh commented on issue #22790: Helm deployment fails when postgresql.nameOverride is used

2023-01-28 Thread via GitHub
amoghrajesh commented on issue #22790: URL: https://github.com/apache/airflow/issues/22790#issuecomment-1407560650 @potiuk @evanrosebrook saw that this issue has been idle for sometime. Can I pick it up? -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [airflow] yehoshuadimarsky commented on pull request #27947: refactored Amazon Redshift-data functionality into the hook

2023-01-28 Thread via GitHub
yehoshuadimarsky commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1407547426 Also update the reverse transfer RS -> S3 with option to use the RS data api -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] yehoshuadimarsky commented on pull request #27947: refactored Amazon Redshift-data functionality into the hook

2023-01-28 Thread via GitHub
yehoshuadimarsky commented on PR #27947: URL: https://github.com/apache/airflow/pull/27947#issuecomment-1407542880 Ok, per comments above added the RS data api to the S3 -> RS transfer operator -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] hussein-awala opened a new pull request, #29212: Fix Trigger DAG w/config origin url

2023-01-28 Thread via GitHub
hussein-awala opened a new pull request, #29212: URL: https://github.com/apache/airflow/pull/29212 closes: #29197 --- This PR fixes the origin url for the Trigger DAG w/config web page, where currently, it redirects to the origin endpoint with the param dag_id, but for some

[GitHub] [airflow] hussein-awala commented on issue #29197: Trigger DAG w/config raising error from task detail views

2023-01-28 Thread via GitHub
hussein-awala commented on issue #29197: URL: https://github.com/apache/airflow/issues/29197#issuecomment-1407520436 Thank you for opening this issue, I can reproduce the problem with 2.5.1 and master. Can someone assign it to me? -- This is an automated message from the Apache Git

[GitHub] [airflow] hussein-awala opened a new pull request, #29211: Provide the missing connection id for the parent classes of snowflake operators

2023-01-28 Thread via GitHub
hussein-awala opened a new pull request, #29211: URL: https://github.com/apache/airflow/pull/29211 closes: #29198 --- In the operators `SnowflakeCheckOperator`, `SnowflakeValueCheckOperator` and `SnowflakeIntervalCheckOperator` we are extending some operators from the

[airflow-client-python] 01/01: Use airflow_version in subject

2023-01-28 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch update-release-process in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git commit 7bb66b36f2fe549a758c242bf031c3e8af4f3c66 Author: pierrejeambrun AuthorDate: Sun

[airflow-client-python] branch update-release-process created (now 7bb66b3)

2023-01-28 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch update-release-process in repository https://gitbox.apache.org/repos/asf/airflow-client-python.git at 7bb66b3 Use airflow_version in subject This branch includes the following

[GitHub] [airflow-client-go] pierrejeambrun commented on a diff in pull request #30: Update release process

2023-01-28 Thread via GitHub
pierrejeambrun commented on code in PR #30: URL: https://github.com/apache/airflow-client-go/pull/30#discussion_r1089829149 ## .asf.yaml: ## @@ -37,4 +37,9 @@ github: enabled_merge_buttons: squash: true merge: false -rebase: false +rebase: true Review

[airflow-client-go] branch update-release-process updated (31deca4 -> 9f6490d)

2023-01-28 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch update-release-process in repository https://gitbox.apache.org/repos/asf/airflow-client-go.git discard 31deca4 Update release process doc add 9f6490d Update release process doc

[GitHub] [airflow-client-go] pierrejeambrun commented on a diff in pull request #30: Update release process

2023-01-28 Thread via GitHub
pierrejeambrun commented on code in PR #30: URL: https://github.com/apache/airflow-client-go/pull/30#discussion_r1089829149 ## .asf.yaml: ## @@ -37,4 +37,9 @@ github: enabled_merge_buttons: squash: true merge: false -rebase: false +rebase: true Review

[GitHub] [airflow-client-go] pierrejeambrun opened a new pull request, #30: Update release process

2023-01-28 Thread via GitHub
pierrejeambrun opened a new pull request, #30: URL: https://github.com/apache/airflow-client-go/pull/30 Following: https://github.com/apache/airflow-client-python/pull/59 update in a similar way the release process to include for go client: - vote against sources - uploading artifact

[airflow-client-go] branch update-release-process created (now 31deca4)

2023-01-28 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a change to branch update-release-process in repository https://gitbox.apache.org/repos/asf/airflow-client-go.git at 31deca4 Update release process doc This branch includes the following new

[airflow-client-go] 01/01: Update release process doc

2023-01-28 Thread pierrejeambrun
This is an automated email from the ASF dual-hosted git repository. pierrejeambrun pushed a commit to branch update-release-process in repository https://gitbox.apache.org/repos/asf/airflow-client-go.git commit 31deca497a6c7b6ce4282ce0b1fbdd92d0390d98 Author: pierrejeambrun AuthorDate: Sun Jan

[airflow] branch main updated (264ace5f86 -> a72e28d6e1)

2023-01-28 Thread jedcunningham
This is an automated email from the ASF dual-hosted git repository. jedcunningham pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 264ace5f86 SQLA20: Replace Query(pk).get by `Session.get` (#29205) add a72e28d6e1 Remove misleading

[GitHub] [airflow] jedcunningham merged pull request #29169: Remove misleading docstring on dagrun_timeout

2023-01-28 Thread via GitHub
jedcunningham merged PR #29169: URL: https://github.com/apache/airflow/pull/29169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow-client-python] maciejmochol opened a new issue, #61: Basic authentication stopped working in 2.5.0

2023-01-28 Thread via GitHub
maciejmochol opened a new issue, #61: URL: https://github.com/apache/airflow-client-python/issues/61 Hello, Version 2.5.0 of the client library stopped generating Authorization header when sending HTTP requests to Airflow. I did some debug of the code and I can see that eg. for

[GitHub] [airflow] pierrejeambrun commented on pull request #29098: Explicit a few steps in the release process

2023-01-28 Thread via GitHub
pierrejeambrun commented on PR #29098: URL: https://github.com/apache/airflow/pull/29098#issuecomment-1407494178 Updated the PR and solved merge conflicts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [airflow] Taragolis commented on issue #22689: HDFS provider causes TypeError: __init__() got an unexpected keyword argument 'encoding'

2023-01-28 Thread via GitHub
Taragolis commented on issue #22689: URL: https://github.com/apache/airflow/issues/22689#issuecomment-1407490415 I tried to build Docker image with HDFS provider on 2.5.1, it is installed and Airflow started without any problem. I believe that in some circumstances it is possible that

[GitHub] [airflow] dnskr opened a new pull request, #29210: Fix bitnami/postgresql subchart upgrade

2023-01-28 Thread via GitHub
dnskr opened a new pull request, #29210: URL: https://github.com/apache/airflow/pull/29210 The PR changes default `pgbouncer.auth_type` value to `scram-sha-256`. It fixes the case when installing the chart with enabled `pgbouncer`, i.e. the following deployment: ``` helm install

[airflow] branch constraints-main updated: Updating constraints. Build id:

2023-01-28 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new de7b8a2a50 Updating

[GitHub] [airflow] Taragolis commented on a diff in pull request #29203: docs: Add trigger process missing from Airflow docker

2023-01-28 Thread via GitHub
Taragolis commented on code in PR #29203: URL: https://github.com/apache/airflow/pull/29203#discussion_r1089812051 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -68,6 +68,7 @@ This file contains several service definitions: task instances once their

[GitHub] [airflow] yxiao1996 commented on issue #28847: Graph UI: Add Filter Downstream & Filter DownStream & Upstream

2023-01-28 Thread via GitHub
yxiao1996 commented on issue #28847: URL: https://github.com/apache/airflow/issues/28847#issuecomment-1407485475 Took a look at the code, seems to me this should be a rather small change as we have the capacity to query downstreams of a task in a dag already defined in the dag data model

[GitHub] [airflow] amarlearning commented on a diff in pull request #29203: docs: Add trigger process missing from Airflow docker

2023-01-28 Thread via GitHub
amarlearning commented on code in PR #29203: URL: https://github.com/apache/airflow/pull/29203#discussion_r1089809614 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -68,6 +68,7 @@ This file contains several service definitions: task instances once their

[GitHub] [airflow] Taragolis commented on a diff in pull request #29203: docs: Add trigger process missing from Airflow docker

2023-01-28 Thread via GitHub
Taragolis commented on code in PR #29203: URL: https://github.com/apache/airflow/pull/29203#discussion_r1089806027 ## docs/apache-airflow/howto/docker-compose/index.rst: ## @@ -68,6 +68,7 @@ This file contains several service definitions: task instances once their

[GitHub] [airflow] jvorenkamp opened a new issue, #29209: BigQueryCreateDataTransferOperator will log AWS credentials when transferring from S3

2023-01-28 Thread via GitHub
jvorenkamp opened a new issue, #29209: URL: https://github.com/apache/airflow/issues/29209 ### Apache Airflow Provider(s) google ### Versions of Apache Airflow Providers [apache-airflow-providers-google

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29209: BigQueryCreateDataTransferOperator will log AWS credentials when transferring from S3

2023-01-28 Thread boring-cyborg
boring-cyborg[bot] commented on issue #29209: URL: https://github.com/apache/airflow/issues/29209#issuecomment-1407474399 Thanks for opening your first issue here! Be sure to follow the issue template! -- This is an automated message from the Apache Git Service. To respond to the

[airflow] branch main updated (eff677c418 -> 264ace5f86)

2023-01-28 Thread kaxilnaik
This is an automated email from the ASF dual-hosted git repository. kaxilnaik pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from eff677c418 Snowflake Provider - hide host from UI (#29208) add 264ace5f86 SQLA20: Replace Query(pk).get by

[GitHub] [airflow] kaxil merged pull request #29205: SQLA20: Replace Session.query(...).get by Session.get

2023-01-28 Thread via GitHub
kaxil merged PR #29205: URL: https://github.com/apache/airflow/pull/29205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] kaxil commented on issue #28723: Fix all deprecations for SQLAlchemy 2.0

2023-01-28 Thread via GitHub
kaxil commented on issue #28723: URL: https://github.com/apache/airflow/issues/28723#issuecomment-1407473316 > I think we should support both 1.4 and 2.0 for at least one minor release, preferrably much longer. Dependencies don’t tend to catch up very fast for this kind of migrations, and

[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407462128 * Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. I am sorry I wasn't clear. I meant what should I do about the test that

[GitHub] [airflow] potiuk commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
potiuk commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407459585 > @potiuk what should I do next? Wait until we approve the tests (as you are first time contributor) and somoene reviews it/merges it. I just run the tests. Let's see. If you see

[GitHub] [airflow] potiuk commented on issue #29031: Scheduler pod restarts

2023-01-28 Thread via GitHub
potiuk commented on issue #29031: URL: https://github.com/apache/airflow/issues/29031#issuecomment-1407456368 I think there is no way someone will help if there are no new evidences that we can see. The errors you have, indicate that when creating the POD in K8S remote end closed the

[GitHub] [airflow] loulsb commented on pull request #29116: Add colors in help outputs of Airfow CLI commands #28789

2023-01-28 Thread via GitHub
loulsb commented on PR #29116: URL: https://github.com/apache/airflow/pull/29116#issuecomment-1407445003 @potiuk what should I do next? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [airflow] Taragolis commented on a diff in pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-01-28 Thread via GitHub
Taragolis commented on code in PR #28338: URL: https://github.com/apache/airflow/pull/28338#discussion_r1089778787 ## airflow/providers/amazon/aws/sensors/dynamodb.py: ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] Taragolis commented on a diff in pull request #28338: New AWS sensor — DynamoDBValueSensor

2023-01-28 Thread via GitHub
Taragolis commented on code in PR #28338: URL: https://github.com/apache/airflow/pull/28338#discussion_r1089778787 ## airflow/providers/amazon/aws/sensors/dynamodb.py: ## @@ -0,0 +1,83 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [airflow] Taragolis commented on pull request #29205: SQLA20: Replace Session.query(...).get by Session.get

2023-01-28 Thread via GitHub
Taragolis commented on PR #29205: URL: https://github.com/apache/airflow/pull/29205#issuecomment-1407443549 Ok, lets do a full test. Just in case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[airflow] branch main updated (6c479437b1 -> eff677c418)

2023-01-28 Thread taragolis
This is an automated email from the ASF dual-hosted git repository. taragolis pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 6c479437b1 enhance production guide with a few Argo specific guidelines (#29078) add eff677c418 Snowflake

[GitHub] [airflow] Taragolis merged pull request #29208: Snowflake Provider Package - hide host from UI

2023-01-28 Thread via GitHub
Taragolis merged PR #29208: URL: https://github.com/apache/airflow/pull/29208 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [airflow] potiuk commented on pull request #29171: Added Snowflake provider to the Docker image

2023-01-28 Thread via GitHub
potiuk commented on PR #29171: URL: https://github.com/apache/airflow/pull/29171#issuecomment-1407441679 Also usually when you see a failure (like building docs or static checks) - the error message explain what you should do to replicate it locally (so just follow the advises) -- This

[GitHub] [airflow] potiuk commented on a diff in pull request #29171: Added Snowflake provider to the Docker image

2023-01-28 Thread via GitHub
potiuk commented on code in PR #29171: URL: https://github.com/apache/airflow/pull/29171#discussion_r1088001308 ## docs/docker-stack/changelog.rst: ## @@ -46,6 +46,9 @@ here so that users affected can find the reason for the changes.

[GitHub] [airflow] potiuk commented on pull request #29171: Added Snowflake provider to the Docker image

2023-01-28 Thread via GitHub
potiuk commented on PR #29171: URL: https://github.com/apache/airflow/pull/29171#issuecomment-1407441027 For any substantial changes, making a UI change is not nearly good enough. You need a development environment. However if you want to use GitHub UI you can use codespaces (they

[GitHub] [airflow] dwreeves commented on pull request #29208: Snowflake Provider Package - hide host from UI

2023-01-28 Thread via GitHub
dwreeves commented on PR #29208: URL: https://github.com/apache/airflow/pull/29208#issuecomment-1407439560 Ah, woops, I meant to link to #24572. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [airflow] potiuk commented on pull request #29207: Fix PgBouncer after postgres subchart upgrade

2023-01-28 Thread via GitHub
potiuk commented on PR #29207: URL: https://github.com/apache/airflow/pull/29207#issuecomment-1407428169 > I propose the following solution: Would you like to add a PR for that @dnskr ? I think what @jedcunningham is trying to do is to prepare a new relese of the Helm Chart soon. I

[GitHub] [airflow] Taragolis commented on pull request #27841: fix: add pre-commit to ban urlparse

2023-01-28 Thread via GitHub
Taragolis commented on PR #27841: URL: https://github.com/apache/airflow/pull/27841#issuecomment-1407418388 I restart failed pipeline (on wait/build images). Let's have a look maybe it pass now. You could also join slack, if you not joined yet: https://s.apache.org/airflow-slack.

[GitHub] [airflow] dnskr commented on pull request #29207: Fix PgBouncer after postgres subchart upgrade

2023-01-28 Thread via GitHub
dnskr commented on PR #29207: URL: https://github.com/apache/airflow/pull/29207#issuecomment-1407403522 I recently upgraded Postgres instance, used by Airflow, from 11 to 15 version, so I would like to share my thoughts. 1. `pgbouncer.auth_type` shoud be `scram-sha-256` by default

[GitHub] [airflow] maggesssss commented on pull request #29204: Make the S3-to-SQL system test self-contained

2023-01-28 Thread via GitHub
magges commented on PR #29204: URL: https://github.com/apache/airflow/pull/29204#issuecomment-1407394968 @ferruzzi sure, go for it! I chose sql_default just because I didn't know better -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [airflow] Taragolis commented on pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-01-28 Thread via GitHub
Taragolis commented on PR #29195: URL: https://github.com/apache/airflow/pull/29195#issuecomment-1407383640 > to my knowledge the function lacked tests to begin with and i was wondering how to test this as it requires a backend db with DAG runs Yeah it required db backend, if you

[GitHub] [airflow] mlnsharma commented on a diff in pull request #28981: Implemented log_containers option to read from all containers in KubernetesPodOperator

2023-01-28 Thread via GitHub
mlnsharma commented on code in PR #28981: URL: https://github.com/apache/airflow/pull/28981#discussion_r1089715650 ## airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py: ## @@ -168,6 +168,9 @@ class KubernetesPodOperator(BaseOperator): :param labels: labels to

[GitHub] [airflow] mlnsharma commented on a diff in pull request #28981: Implemented log_containers option to read from all containers in KubernetesPodOperator

2023-01-28 Thread via GitHub
mlnsharma commented on code in PR #28981: URL: https://github.com/apache/airflow/pull/28981#discussion_r1089713913 ## airflow/providers/cncf/kubernetes/utils/pod_manager.py: ## @@ -264,15 +279,69 @@ def consume_logs(*, since_time: DateTime | None = None, follow: bool = True)

[GitHub] [airflow] ashb commented on pull request #29205: SQLA20: Replace Session.query(...).get by Session.get

2023-01-28 Thread via GitHub
ashb commented on PR #29205: URL: https://github.com/apache/airflow/pull/29205#issuecomment-1407369282 Yeah, mostly because we have so many composite PKs, and using `get()` you have to match the column order directly, which is error prone/hard to read. (Plus for whatever reason

[GitHub] [airflow] duke8585 commented on pull request #29195: Fixing Task Duration view in case of manual DAG runs only (#22015)

2023-01-28 Thread via GitHub
duke8585 commented on PR #29195: URL: https://github.com/apache/airflow/pull/29195#issuecomment-1407346904 > @duke8585, thanks for contribution, however we also need tests for this changes, for more details see: > > * [TESTING](https://github.com/apache/airflow/blob/main/TESTING.rst)