Re: [PR] Add multiselect to run state in grid view [airflow]

2023-11-30 Thread via GitHub
pierrejeambrun commented on code in PR #35403: URL: https://github.com/apache/airflow/pull/35403#discussion_r1410282817 ## airflow/www/static/js/api/useGridData.ts: ## @@ -105,6 +105,7 @@ const useGridData = () => { }; const response = await axios.get(gridDataUrl,

Re: [PR] Add multiselect to run state in grid view [airflow]

2023-11-30 Thread via GitHub
pierrejeambrun commented on code in PR #35403: URL: https://github.com/apache/airflow/pull/35403#discussion_r1410283905 ## airflow/www/static/js/api/useGridData.ts: ## @@ -105,6 +105,7 @@ const useGridData = () => { }; const response = await axios.get(gridDataUrl,

Re: [PR] Add multiselect to run state in grid view [airflow]

2023-11-30 Thread via GitHub
pierrejeambrun commented on code in PR #35403: URL: https://github.com/apache/airflow/pull/35403#discussion_r1410283905 ## airflow/www/static/js/api/useGridData.ts: ## @@ -105,6 +105,7 @@ const useGridData = () => { }; const response = await axios.get(gridDataUrl,

Re: [PR] Add multiselect to run state in grid view [airflow]

2023-11-30 Thread via GitHub
pierrejeambrun commented on code in PR #35403: URL: https://github.com/apache/airflow/pull/35403#discussion_r1410283905 ## airflow/www/static/js/api/useGridData.ts: ## @@ -105,6 +105,7 @@ const useGridData = () => { }; const response = await axios.get(gridDataUrl,

Re: [I] celery executer with SQS and predefined_queues [airflow]

2023-11-30 Thread via GitHub
nagaran1 commented on issue #11225: URL: https://github.com/apache/airflow/issues/11225#issuecomment-1833290322 > @sudarshan2906 - can you show the `celery_config_options` line in your `airflow.cfg`? I'm doing something similar, but getting an error on the scheduler saying: > > > air

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
A-Costa commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833368893 any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

Re: [PR] Introduce @task.bash TaskFlow decorator [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #30176: URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833406532 Disabke it by default add ad parameter is_templated? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Pass conn ID to ObjectStoragePath via URI [airflow]

2023-11-30 Thread via GitHub
uranusjr commented on PR #35913: URL: https://github.com/apache/airflow/pull/35913#issuecomment-1833408135 I added a paragraph in the tutorial to explain the usage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

Re: [PR] Introduce @task.bash TaskFlow decorator [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #30176: URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833410060 Disabke it by default add ad parameter is_templated? WHY? I think the reason why we ant it templated is to allow people to convert old operators easily but I think with put

Re: [PR] Introduce @task.bash TaskFlow decorator [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #30176: URL: https://github.com/apache/airflow/pull/30176#issuecomment-1833409643 Disabke it by default add ad parameter is_templated? away? I think the reason why we ant it templated is to allow people to convert old operators easily but I think with pu

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833428875 > any update on this? Well. The PR is waiting for your actions: > Needs fixes though > I think that is all but we will take closer look in 2nd review once everythin

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833431231 Generallly - making PR green is a prerequisite for anyone to take further look - if tests are failing and you were told to fix them and nothing happened, well, then the ball is on your s

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
amoghrajesh commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833434292 Woops. > remove old script in the same PR I made the changes, forgot to push! -- This is an automated message from the Apache Git Service. To respond to the message, plea

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833433722 (plus you have still WIP in name - usualy that is an indication that this is Work In Progress - I usually just skip over such PRs even if they are rebased by author, because they are we

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
potiuk commented on code in PR #35970: URL: https://github.com/apache/airflow/pull/35970#discussion_r1410427756 ## dev/README_RELEASE_PROVIDER_PACKAGES.md: ## @@ -1029,10 +1029,10 @@ do done # Check which old packages will be removed (you need Python 3.8+ and dev/requiremen

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
amoghrajesh commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833435606 @potiuk BTW, i do not see static checks failing in my env or here. Are they failing? -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
amoghrajesh commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833434851 I have also updated the instructions in the required MD files. Should be good now :D -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
potiuk commented on code in PR #35970: URL: https://github.com/apache/airflow/pull/35970#discussion_r1410427997 ## dev/README_RELEASE_PROVIDER_PACKAGES.md: ## @@ -1029,10 +1029,10 @@ do done # Check which old packages will be removed (you need Python 3.8+ and dev/requiremen

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833440251 > @potiuk BTW, i do not see static checks failing in my env or here. Are they failing? Could be intermittent - I see that recent docker has been failing more frequently in CI (lik

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
amoghrajesh commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833448075 > > @potiuk BTW, i do not see static checks failing in my env or here. Are they failing? > > Could be intermittent - I see that recent docker has been failing more frequently

Re: [I] Prevent Platypus attack on CI (Docker 24.0.7) [airflow]

2023-11-30 Thread via GitHub
potiuk closed issue #35971: Prevent Platypus attack on CI (Docker 24.0.7) URL: https://github.com/apache/airflow/issues/35971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Base date for fetching dag grid view must include selected run_id [airflow]

2023-11-30 Thread via GitHub
hterik commented on PR #34887: URL: https://github.com/apache/airflow/pull/34887#issuecomment-1833492307 Rebased now. I see the problem with base date now. The whole base date selector and the filter options stop working if a `dag_run_id` was present in the URL (though `dag_run_id` i

[PR] Use S3 hook instead of AwsGenericHook in AWS S3 FS [airflow]

2023-11-30 Thread via GitHub
hussein-awala opened a new pull request, #35973: URL: https://github.com/apache/airflow/pull/35973 Replace `AwsGenericHook(..., client_type="s3")` with `S3Hook(...)`, which does the same thing implicitly in the AWS S3 FS. -- This is an automated message from the Apache Git Service. To res

Re: [PR] Pass conn ID to ObjectStoragePath via URI [airflow]

2023-11-30 Thread via GitHub
uranusjr commented on PR #35913: URL: https://github.com/apache/airflow/pull/35913#issuecomment-1833500750 Whatever that should go into the URI’s auth section should go into Connection since we don’t want users to put credentials in a DAG in any scenarios. One example is HTTP; while technic

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
A-Costa commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833532496 > [talkiq/gcloud-aio#634](https://github.com/talkiq/gcloud-aio/pull/634) was merged today so this can be fixed and merged. > > Apart from the missing tests, what else needs to be

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833540925 > > > @potiuk BTW, i do not see static checks failing in my env or here. Are they failing? > > > > > > Could be intermittent - I see that recent docker has been failing more f

[I] Documentation on trigger rule for `one_success` misleading [airflow]

2023-11-30 Thread via GitHub
MondeSinxi opened a new issue, #35974: URL: https://github.com/apache/airflow/issues/35974 ### What do you see as an issue? https://airflow.apache.org/docs/apache-airflow/2.7.3/core-concepts/dags.html#trigger-rules The trigger rule for `one_success` states that " At least one u

Re: [I] Documentation on trigger rule for `one_success` misleading [airflow]

2023-11-30 Thread via GitHub
boring-cyborg[bot] commented on issue #35974: URL: https://github.com/apache/airflow/issues/35974#issuecomment-1833550712 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
amoghrajesh commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833553200 > > > > @potiuk BTW, i do not see static checks failing in my env or here. Are they failing? > > > > > > > > > Could be intermittent - I see that recent docker has been fa

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
amoghrajesh commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833554151 Unable to catch it perhaps because I have some versioning issue in my breeze today..working on fixing it :) -- This is an automated message from the Apache Git Service. To res

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
eladkal commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833566157 Happy to review when you mark the PR as ready :) Sometimes we do multiple runs of reviews that is very OK -- This is an automated message from the Apache Git Service. To respond

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833566575 > Here i asked if something else needed fix Well. The CI tells you what needs to be fixed. I think you should take a look at the contributor's guide and understand that fixing and

Re: [PR] New breeze command to clean up previous provider artifacts [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35970: URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833580721 > Unable to catch it perhaps because I have some versioning issue in my breeze today..working on fixing it :) It could also be that you have all `breeze` packages also install

[PR] Refacto CloudwatchTaskHandler set_context method [airflow]

2023-11-30 Thread via GitHub
hussein-awala opened a new pull request, #35975: URL: https://github.com/apache/airflow/pull/35975 Update `set_context` method signature to match superclass one, and stop setting the instance attribute `json_serialize` which doesn't exist. -- This is an automated message from the Apache G

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
A-Costa commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833595976 @potiuk of course no hard feelings on my side either! I appreciate the exchange and I'm sorry if I came up as rude, was never the intention! Now that is more clear what is expect

Re: [PR] WIP Add use_glob to GCSObjectExistenceSensor [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #34137: URL: https://github.com/apache/airflow/pull/34137#issuecomment-1833609121 Apologies if MY comments were also seen as condescent (which I realise they might) - but this is simply coming from the sheer volume of things we have to deal with - it's very difficult

Re: [PR] [WIP] Add type hints for AWS provider [airflow]

2023-11-30 Thread via GitHub
Taragolis commented on code in PR #35966: URL: https://github.com/apache/airflow/pull/35966#discussion_r1410559773 ## setup.py: ## @@ -424,6 +424,8 @@ def write_version(filename: str = str(AIRFLOW_SOURCES_ROOT / "airflow" / "git_ve f"mypy-boto3-redshift-data>={_MIN_BOTO3_V

Re: [PR] PSRP connection type support [airflow]

2023-11-30 Thread via GitHub
malthe commented on PR #34766: URL: https://github.com/apache/airflow/pull/34766#issuecomment-1833617208 @arjunanan6 now, to test this, you would build on the existing suite: ```python class TestPsrpHook: def test_get_conn(self, runspace_pool, *mocks): with

[PR] Fix a bug in method name used in GlacierToGCSOperator [airflow]

2023-11-30 Thread via GitHub
hussein-awala opened a new pull request, #35978: URL: https://github.com/apache/airflow/pull/35978 Detected while working on #35966. https://botocore.amazonaws.com/v1/documentation/api/latest/reference/response.html#botocore.response.StreamingBody.iter_chunks -- This is an automate

Re: [PR] PSRP connection type support [airflow]

2023-11-30 Thread via GitHub
arjunanan6 commented on PR #34766: URL: https://github.com/apache/airflow/pull/34766#issuecomment-1833628673 @malthe Awesome, thanks for that! I'll get on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[I] Airflow DAG not working anymore on Airflow 2.7.3 [airflow]

2023-11-30 Thread via GitHub
gmarendaz opened a new issue, #35979: URL: https://github.com/apache/airflow/issues/35979 ### Apache Airflow version 2.7.3 ### What happened I was in part of the migration of Apache Airflow in a Ubuntu environment from a Windows WSL environment. DAG was working correc

Re: [I] Airflow DAG not working anymore on Airflow 2.7.3 [airflow]

2023-11-30 Thread via GitHub
boring-cyborg[bot] commented on issue #35979: URL: https://github.com/apache/airflow/issues/35979#issuecomment-1833635071 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Move fs scheme definition from Python to YAML [airflow]

2023-11-30 Thread via GitHub
bolkedebruin commented on PR #35972: URL: https://github.com/apache/airflow/pull/35972#issuecomment-1833667682 LGTM, but will require a release of the providers cc @eladkal, preferably before 2.8 I think? And this should then also be in 2.8 in order not to provide backwards compatibility? c

Re: [PR] Use S3 hook instead of AwsGenericHook in AWS S3 FS [airflow]

2023-11-30 Thread via GitHub
bolkedebruin merged PR #35973: URL: https://github.com/apache/airflow/pull/35973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

(airflow) branch main updated: Use S3 hook instead of AwsGenericHook in AWS S3 FS (#35973)

2023-11-30 Thread bolke
This is an automated email from the ASF dual-hosted git repository. bolke pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new df36e7381a Use S3 hook instead of AwsGenericHook in

Re: [PR] Pass conn ID to ObjectStoragePath via URI [airflow]

2023-11-30 Thread via GitHub
bolkedebruin commented on PR #35913: URL: https://github.com/apache/airflow/pull/35913#issuecomment-1833741231 Were you planning on making it clearer to the user when it fails (ie. a username, password probably has been provided)? -- This is an automated message from the Apache Git Servi

(airflow) branch main updated: Mark daskexecutor provider as removed (#35965)

2023-11-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 9c1c9f450e Mark daskexecutor provider as removed (#

Re: [PR] Mark daskexecutor provider as removed [airflow]

2023-11-30 Thread via GitHub
potiuk merged PR #35965: URL: https://github.com/apache/airflow/pull/35965 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [PR] Mark daskexecutor provider as removed [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35965: URL: https://github.com/apache/airflow/pull/35965#issuecomment-1833761410 ok. Now we just need to release the last one with the "remove" warnings in docs and `pypi` and then we can remove the code of it completely. cc: @eladkal -> maybe we can make a se

Re: [PR] Add processor_subdir to import_error table to handle multiple dag processors [airflow]

2023-11-30 Thread via GitHub
potiuk merged PR #35956: URL: https://github.com/apache/airflow/pull/35956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

Re: [I] dag processor deletes import errors of other dag processors thinking the files don't exist [airflow]

2023-11-30 Thread via GitHub
potiuk closed issue #35949: dag processor deletes import errors of other dag processors thinking the files don't exist URL: https://github.com/apache/airflow/issues/35949 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] Added Datascan Profiling [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35696: URL: https://github.com/apache/airflow/pull/35696#issuecomment-1833800465 Yes. the problem in this PR is that you have not run it through `pre-commit` - which means dependencies have not been regenerated and the image fails to be built, so in order to do anyth

[I] OAUTH users not getting the login again screen when the OAUTH PROVIDERS user password reset or token invoked. [airflow]

2023-11-30 Thread via GitHub
thanushcst opened a new issue, #35980: URL: https://github.com/apache/airflow/issues/35980 ### Apache Airflow version 2.8.0b1 ### What happened Go to 'login' Login with Oauth User Reset the password on Oauth user manager Superset keep allowing the user with exist

Re: [I] OAUTH users not getting the login again screen when the OAUTH PROVIDERS user password reset or token invoked. [airflow]

2023-11-30 Thread via GitHub
boring-cyborg[bot] commented on issue #35980: URL: https://github.com/apache/airflow/issues/35980#issuecomment-1833829981 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-11-30 Thread via GitHub
droppoint commented on PR #35800: URL: https://github.com/apache/airflow/pull/35800#issuecomment-1833844894 > Hi @droppoint let us know what you find My team and I ran an experiment that demonstrated that even if the scheduler shuts down abnormally, the TaskInstance still completes no

Re: [PR] Add helper function for CRUD operations on weaviate's schema and class objects [airflow]

2023-11-30 Thread via GitHub
ephraimbuddy commented on code in PR #35919: URL: https://github.com/apache/airflow/pull/35919#discussion_r1410719309 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -112,22 +117,170 @@ def test_connection(self) -> tuple[bool, str]: self.log.error("Error test

(airflow) branch constraints-main updated: Updating constraints. Github run id:7047187092

2023-11-30 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new 49f98bf5a9 Updating con

Re: [PR] Add processor_subdir to import_error table to handle multiple dag processors [airflow]

2023-11-30 Thread via GitHub
tirkarthi commented on PR #35956: URL: https://github.com/apache/airflow/pull/35956#issuecomment-1833881250 The other issue we had on switching from one dag processor to multiple ones using subdir was that old import errors were not deleted as they had different directory. It will be the sa

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
josh-fell commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1410818839 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +def

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1410827434 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +d

Re: [PR] Create FAB provider and move FAB auth manager in it [airflow]

2023-11-30 Thread via GitHub
vincbeck commented on code in PR #35926: URL: https://github.com/apache/airflow/pull/35926#discussion_r1410830201 ## setup.cfg: ## @@ -103,6 +103,7 @@ install_requires = # NOTE! When you change the value here, you also have to update flask-appbuilder[oauth] in setup.py

Re: [PR] Create FAB provider and move FAB auth manager in it [airflow]

2023-11-30 Thread via GitHub
vincbeck commented on code in PR #35926: URL: https://github.com/apache/airflow/pull/35926#discussion_r1410831443 ## .pre-commit-config.yaml: ## @@ -525,6 +524,7 @@ repos: ^airflow/providers/apache/spark/hooks/| ^airflow/providers/apache/spark/operators/|

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1410832301 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +d

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
josh-fell commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1410836947 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +def

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
mpgreg commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1410844224 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +def cre

Re: [PR] Fix a bug in method name used in GlacierToGCSOperator [airflow]

2023-11-30 Thread via GitHub
vincbeck merged PR #35978: URL: https://github.com/apache/airflow/pull/35978 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated: Fix a bug in method name used in `GlacierToGCSOperator` (#35978)

2023-11-30 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 7e1f67b4b8 Fix a bug in method name used in `Glac

Re: [PR] Refacto CloudwatchTaskHandler set_context method [airflow]

2023-11-30 Thread via GitHub
vincbeck merged PR #35975: URL: https://github.com/apache/airflow/pull/35975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

(airflow) branch main updated (7e1f67b4b8 -> ddb4370dc6)

2023-11-30 Thread vincbeck
This is an automated email from the ASF dual-hosted git repository. vincbeck pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 7e1f67b4b8 Fix a bug in method name used in `GlacierToGCSOperator` (#35978) add ddb4370dc6 Update `set_context`

Re: [PR] Upgrade to Flask Application Builder 4.3.9 [airflow]

2023-11-30 Thread via GitHub
hterik commented on code in PR #35085: URL: https://github.com/apache/airflow/pull/35085#discussion_r1410850196 ## airflow/auth/managers/fab/security_manager/override.py: ## @@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp): "last_name": data

Re: [PR] Add multiselect to run state in grid view [airflow]

2023-11-30 Thread via GitHub
vchiapaikeo commented on code in PR #35403: URL: https://github.com/apache/airflow/pull/35403#discussion_r1410869863 ## airflow/www/static/js/api/useGridData.ts: ## @@ -105,6 +105,7 @@ const useGridData = () => { }; const response = await axios.get(gridDataUrl, {

Re: [PR] Mark daskexecutor provider as removed [airflow]

2023-11-30 Thread via GitHub
eladkal commented on PR #35965: URL: https://github.com/apache/airflow/pull/35965#issuecomment-1834052722 > , it can be done in a next wave Next wave is really close as we are bumping min airflow version for providers today/tommorow -- This is an automated message from the Apache

Re: [PR] Fix race condition in KubernetesExecutor with concurrently running schedulers [airflow]

2023-11-30 Thread via GitHub
dstandish commented on PR #35800: URL: https://github.com/apache/airflow/pull/35800#issuecomment-1834060063 Nice findings. Looks promising. Thanks for that. Ok here's another scenario. The task OOMs and therefore cannot report its state by itself. -- This is an automated mes

(airflow) branch main updated: Replace default empty dict value by None in AzureBlobStorageToS3Operator (#35977)

2023-11-30 Thread husseinawala
This is an automated email from the ASF dual-hosted git repository. husseinawala pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 4a9824de8e Replace default empty dict value b

Re: [PR] Replace default empty dict value by None in AzureBlobStorageToS3Operator [airflow]

2023-11-30 Thread via GitHub
hussein-awala merged PR #35977: URL: https://github.com/apache/airflow/pull/35977 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@ai

Re: [PR] Mark daskexecutor provider as removed [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35965: URL: https://github.com/apache/airflow/pull/35965#issuecomment-1834068149 Right Good timing :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[PR] Fix airflow db shell needing an extra keypress to exit [airflow]

2023-11-30 Thread via GitHub
renzepost opened a new pull request, #35982: URL: https://github.com/apache/airflow/pull/35982 Related: #26186 As @blag noted in #26186, pressing Ctrl-D (EOF) to exit the interactive shell requires an additional keypress to actually exit. It seems that `select.select()` wa

Re: [PR] Upgrade to Flask Application Builder 4.3.9 [airflow]

2023-11-30 Thread via GitHub
potiuk commented on code in PR #35085: URL: https://github.com/apache/airflow/pull/35085#discussion_r1410905233 ## airflow/auth/managers/fab/security_manager/override.py: ## @@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp): "last_name": data

Re: [PR] Upgrade to Flask Application Builder 4.3.9 [airflow]

2023-11-30 Thread via GitHub
potiuk commented on code in PR #35085: URL: https://github.com/apache/airflow/pull/35085#discussion_r1410905233 ## airflow/auth/managers/fab/security_manager/override.py: ## @@ -1432,23 +1430,14 @@ def get_oauth_user_info(self, provider, resp): "last_name": data

[PR] Fix gantt chart queued duration when queued_dttm is greater than start_date for deferred tasks. [airflow]

2023-11-30 Thread via GitHub
tirkarthi opened a new pull request, #35984: URL: https://github.com/apache/airflow/pull/35984 closes: #35288 related: #35288 When a task is deferred then the same attempt is used to queue and resume causing the queued_dttm to be greater than start_date for an execution. This cau

Re: [PR] Implement task duration page in react. [airflow]

2023-11-30 Thread via GitHub
tirkarthi commented on PR #35863: URL: https://github.com/apache/airflow/pull/35863#issuecomment-1834210177 Updated screenshot after PR comments to show task duration when task row is clicked. ![task_duration_after_pr](https://github.com/apache/airflow/assets/3972343/825ee72b-cd63-42

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1411124914 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +d

[PR] Fix nits in LOCAL_VIRTUALENV.rst [airflow]

2023-11-30 Thread via GitHub
EricGao888 opened a new pull request, #35985: URL: https://github.com/apache/airflow/pull/35985 * In "https://raw.githubusercontent.com/apache/airflow/constraints-main/constraints-3.8.txt"; we get `docutils==0.20.1`, which conflicts with https://github.com/apache/airflow/b

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1411124914 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +d

Re: [PR] Add object methods in weaviate hook [airflow]

2023-11-30 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1411124914 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -193,3 +195,88 @@ def query_without_vector( .do() ) return results + +d

[PR] Fix handling of single quotes in `RedshiftToS3Operator` [airflow]

2023-11-30 Thread via GitHub
vincbeck opened a new pull request, #35986: URL: https://github.com/apache/airflow/pull/35986 Continue the work started in #32915. Closes: #30287. --- **^ Add meaningful description above** Read the **[Pull Request Guidelines](https://github.com/ap

Re: [I] Triggering DAG from UI Creates 2 DAG runs if the DAG was paused [airflow]

2023-11-30 Thread via GitHub
vaibhavnsingh commented on issue #24534: URL: https://github.com/apache/airflow/issues/24534#issuecomment-1834423211 I do agree to your comment @RNHTTR . So once i resume the immediate interval which has expired would execute, that is what I have the understanding but in my case it is exec

Re: [I] Triggering DAG from UI Creates 2 DAG runs if the DAG was paused [airflow]

2023-11-30 Thread via GitHub
bispaul commented on issue #24534: URL: https://github.com/apache/airflow/issues/24534#issuecomment-1834453438 Hi @RNHTTR , I can start working on it now that it is clear a message needs to be displayed. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Create FAB provider and move FAB auth manager in it [airflow]

2023-11-30 Thread via GitHub
vincbeck closed pull request #35926: Create FAB provider and move FAB auth manager in it URL: https://github.com/apache/airflow/pull/35926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [I] There's no way to pass params to dag.test() [airflow]

2023-11-30 Thread via GitHub
getaaron commented on issue #35930: URL: https://github.com/apache/airflow/issues/35930#issuecomment-1834462654 @RNHTTR Can you help me get any guidance on implementing this? I'm happy to open a PR but could use some general design guidance. -- This is an automated message from the Apache

Re: [PR] Fix nits in LOCAL_VIRTUALENV.rst [airflow]

2023-11-30 Thread via GitHub
potiuk merged PR #35985: URL: https://github.com/apache/airflow/pull/35985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated (4a9824de8e -> 20db3dbfa9)

2023-11-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git from 4a9824de8e Replace default empty dict value by None in AzureBlobStorageToS3Operator (#35977) add 20db3dbfa9 Fix n

Re: [PR] Fix nits in LOCAL_VIRTUALENV.rst [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35985: URL: https://github.com/apache/airflow/pull/35985#issuecomment-1834472906 Re `-e`, yes we have an issu about that https://github.com/apache/airflow/issues/30764 and I am about to turn my attention to get it fixed. -- This is an automated message from the Ap

Re: [I] Native templating modifies types even when no `{{}}` are present [airflow]

2023-11-30 Thread via GitHub
potiuk commented on issue #35987: URL: https://github.com/apache/airflow/issues/35987#issuecomment-1834485788 No. This is the way how https://jinja.palletsprojects.com/en/3.0.x/nativetypes/ works (and this is what we are using). we are not going to change how it works. You might instead mak

Re: [PR] Fix `airflow db shell` needing an extra keypress to exit [airflow]

2023-11-30 Thread via GitHub
potiuk merged PR #35982: URL: https://github.com/apache/airflow/pull/35982 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a

(airflow) branch main updated: Fix airflow db shell needing an extra keypress to exit (#35982)

2023-11-30 Thread potiuk
This is an automated email from the ASF dual-hosted git repository. potiuk pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new cbb9c4f8cc Fix airflow db shell needing an extra ke

Re: [PR] Fix `airflow db shell` needing an extra keypress to exit [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35982: URL: https://github.com/apache/airflow/pull/35982#issuecomment-1834510472 Fantastic! Thanks @renzepost ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Move fs scheme definition from Python to YAML [airflow]

2023-11-30 Thread via GitHub
potiuk commented on PR #35972: URL: https://github.com/apache/airflow/pull/35972#issuecomment-1834528330 Maybe a new item "fsspec" as a key instead of "filesystems"? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [I] Native templating modifies types even when no `{{}}` are present [airflow]

2023-11-30 Thread via GitHub
theis188 commented on issue #35987: URL: https://github.com/apache/airflow/issues/35987#issuecomment-1834538246 I'm not proposing a change to Jinja. I'm proposing a change to the conditions under which a string is templated by Jinja. IE if there is no `{{ }}` then it does not need to be pas

[PR] Fix a bug with accessing hooks in EKS trigger [airflow]

2023-11-30 Thread via GitHub
hussein-awala opened a new pull request, #35989: URL: https://github.com/apache/airflow/pull/35989 The hook is defined as a standard method; converting it to a cached property is a breaking change. The best solution is to call this method to get the hook, -- This is an automated message f

  1   2   >