rawwar commented on PR #37307:
URL: https://github.com/apache/airflow/pull/37307#issuecomment-2054005270
I am not sure why a few tests are failing. But, I'm looking into it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1563936620
##
airflow/providers/pinecone/CHANGELOG.rst:
##
@@ -20,6 +20,29 @@
Changelog
-
+2.0.0
+.
+
+Breaking changes
+
+
+.. note::
+ This re
Taragolis commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1563914685
##
airflow/providers/pinecone/CHANGELOG.rst:
##
@@ -20,6 +20,29 @@
Changelog
-
+2.0.0
+.
+
+Breaking changes
+
+
+.. note::
+ This
github-actions[bot] commented on PR #37307:
URL: https://github.com/apache/airflow/pull/37307#issuecomment-2041247952
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1496742109
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -135,118 +132,98 @@ def upsert(
)
@staticmethod
+def get_pod_spec_obj(environment, replicas,
pankajastro commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1493785686
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -135,118 +132,98 @@ def upsert(
)
@staticmethod
+def get_pod_spec_obj(environment, repl
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488803231
##
airflow/providers/pinecone/provider.yaml:
##
@@ -44,7 +44,7 @@ dependencies:
# Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some
breaking
Taragolis commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488793501
##
airflow/providers/pinecone/provider.yaml:
##
@@ -44,7 +44,7 @@ dependencies:
# Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some
break
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488788371
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field behaviour.""
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488788371
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field behaviour.""
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488788371
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field behaviour.""
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082
##
airflow/providers/pinecone/provider.yaml:
##
@@ -44,7 +44,7 @@ dependencies:
# Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some
breaking
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082
##
airflow/providers/pinecone/provider.yaml:
##
@@ -44,7 +44,7 @@ dependencies:
# Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some
breaking
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082
##
airflow/providers/pinecone/provider.yaml:
##
@@ -44,7 +44,7 @@ dependencies:
# Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some
breaking
rawwar commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1485570953
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field behaviour.""
Taragolis commented on PR #37307:
URL: https://github.com/apache/airflow/pull/37307#issuecomment-1937490597
> Does it backward compatible? Does it break during upgrade?
Difficult to say right now, in general bump dependency version is not a
breaking changes, if all other components re
Taragolis commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1485549912
##
airflow/providers/pinecone/provider.yaml:
##
@@ -44,7 +44,7 @@ dependencies:
# Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some
break
Taragolis commented on code in PR #37307:
URL: https://github.com/apache/airflow/pull/37307#discussion_r1485546051
##
airflow/providers/pinecone/hooks/pinecone.py:
##
@@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
"""Return custom field behaviour
rawwar opened a new pull request, #37307:
URL: https://github.com/apache/airflow/pull/37307
closes: #37158
Adds support for pinecone-client ~= 3.0.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
19 matches
Mail list logo