Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-14 Thread via GitHub
rawwar commented on PR #37307: URL: https://github.com/apache/airflow/pull/37307#issuecomment-2054005270 I am not sure why a few tests are failing. But, I'm looking into it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1563936620 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,29 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. note:: + This re

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-13 Thread via GitHub
Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1563914685 ## airflow/providers/pinecone/CHANGELOG.rst: ## @@ -20,6 +20,29 @@ Changelog - +2.0.0 +. + +Breaking changes + + +.. note:: + This

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-04-06 Thread via GitHub
github-actions[bot] commented on PR #37307: URL: https://github.com/apache/airflow/pull/37307#issuecomment-2041247952 This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for you

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-20 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1496742109 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,118 +132,98 @@ def upsert( ) @staticmethod +def get_pod_spec_obj(environment, replicas,

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-18 Thread via GitHub
pankajastro commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1493785686 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -135,118 +132,98 @@ def upsert( ) @staticmethod +def get_pod_spec_obj(environment, repl

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488803231 ## airflow/providers/pinecone/provider.yaml: ## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some breaking

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488793501 ## airflow/providers/pinecone/provider.yaml: ## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some break

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488788371 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour.""

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488788371 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour.""

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488788371 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour.""

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082 ## airflow/providers/pinecone/provider.yaml: ## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some breaking

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082 ## airflow/providers/pinecone/provider.yaml: ## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some breaking

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-13 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1488772082 ## airflow/providers/pinecone/provider.yaml: ## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some breaking

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-11 Thread via GitHub
rawwar commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1485570953 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour.""

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-11 Thread via GitHub
Taragolis commented on PR #37307: URL: https://github.com/apache/airflow/pull/37307#issuecomment-1937490597 > Does it backward compatible? Does it break during upgrade? Difficult to say right now, in general bump dependency version is not a breaking changes, if all other components re

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-11 Thread via GitHub
Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1485549912 ## airflow/providers/pinecone/provider.yaml: ## @@ -44,7 +44,7 @@ dependencies: # Pinecone Python SDK v3.0.0 was released at 2024-01-16 and introduce some break

Re: [PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-11 Thread via GitHub
Taragolis commented on code in PR #37307: URL: https://github.com/apache/airflow/pull/37307#discussion_r1485546051 ## airflow/providers/pinecone/hooks/pinecone.py: ## @@ -63,43 +64,40 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]: """Return custom field behaviour

[PR] [WIP] Pinecone provider support for `pinecone-client`>=3 [airflow]

2024-02-10 Thread via GitHub
rawwar opened a new pull request, #37307: URL: https://github.com/apache/airflow/pull/37307 closes: #37158 Adds support for pinecone-client ~= 3.0.x -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a