hussein-awala opened a new pull request, #34247:
URL: https://github.com/apache/airflow/pull/34247
closes: #34241
This PR adds [bandit](https://github.com/PyCQA/bandit) to pre-commit hooks
and static checks, to detect common security issues.
I'm opening it as draft to get the r
hussein-awala commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387311570
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387337241
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387342153
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387343224
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387343224
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387345625
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387345625
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387345625
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on code in PR #34247:
URL: https://github.com/apache/airflow/pull/34247#discussion_r1387342153
##
.pre-commit-config.yaml:
##
@@ -1030,3 +1030,12 @@ repos:
files:
^airflow/migrations/versions/.*\.py$|^docs/apache-airflow/migrations-ref\.rst$
a
potiuk commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1803563968
I guess conflicts/rebase needed now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Taragolis commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1804573465
Just wondering, any reason why we can't use `ruff` implementation
https://docs.astral.sh/ruff/rules/#flake8-bandit-s ?
--
This is an automated message from the Apache Git Service.
T
potiuk commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1804659215
> Just wondering, any reason why we can't use `ruff` implementation
https://docs.astral.sh/ruff/rules/#flake8-bandit-s ?
Sounds like good idea :)
--
This is an automated message
hussein-awala commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1804715689
> Just wondering, any reason why we can't use `ruff` implementation
https://docs.astral.sh/ruff/rules/#flake8-bandit-s ?
I checked it when I started working on this PR, and
potiuk commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1806057665
--
This is an automated message from the Apache Git Service.
To respond to the messag
potiuk commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1806057853
looking good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
hussein-awala commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1806060551
Yes, I just restarted some CI jobs that failed because of resources/network
issues, I will mark it ready for review once all CI check are green.
--
This is an automated message
potiuk merged PR #34247:
URL: https://github.com/apache/airflow/pull/34247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
github-actions[bot] commented on PR #34247:
URL: https://github.com/apache/airflow/pull/34247#issuecomment-1778260448
This pull request has been automatically marked as stale because it has not
had recent activity. It will be closed in 5 days if no further activity occurs.
Thank you for you
github-actions[bot] closed pull request #34247: Add bandit to pre-commit to
detect common security issues
URL: https://github.com/apache/airflow/pull/34247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
20 matches
Mail list logo
