Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
uranusjr commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1366723600 ## airflow/utils/log/logging_mixin.py: ## @@ -68,14 +68,43 @@ class LoggingMixin: """Convenience super-class to have a logger configured with the class name.""

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
uranusjr commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1366724383 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state = di

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
uranusjr commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1366727096 ## airflow/utils/log/logging_mixin.py: ## @@ -68,14 +68,43 @@ class LoggingMixin: """Convenience super-class to have a logger configured with the class name.""

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367026145 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state =

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367027165 ## airflow/utils/log/logging_mixin.py: ## @@ -68,14 +68,43 @@ class LoggingMixin: """Convenience super-class to have a logger configured with the class name.

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
potiuk commented on PR #34964: URL: https://github.com/apache/airflow/pull/34964#issuecomment-1772831484 BTW. You will need to rebase to make this one works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367026145 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state =

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367026145 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state =

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-20 Thread via GitHub
potiuk commented on PR #34964: URL: https://github.com/apache/airflow/pull/34964#issuecomment-1773465545 Static check fixed in main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-21 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367719098 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state =

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-21 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367719098 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state =

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-21 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367725602 ## airflow/utils/log/logging_mixin.py: ## @@ -68,14 +68,43 @@ class LoggingMixin: """Convenience super-class to have a logger configured with the class name.

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-21 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367719098 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state =

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-22 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367904293 ## airflow/utils/log/logging_mixin.py: ## @@ -68,14 +68,43 @@ class LoggingMixin: """Convenience super-class to have a logger configured with the class name.

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-22 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1367946473 ## airflow/models/baseoperator.py: ## @@ -651,6 +653,10 @@ class derived from this one results in the creation of a task object, that is visible in Task Inst

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
uranusjr commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1368310596 ## airflow/models/baseoperator.py: ## @@ -1219,14 +1226,10 @@ def __deepcopy__(self, memo): return result def __getstate__(self): -state = di

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
Taragolis commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369320830 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
Taragolis commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369320830 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369325665 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0r

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369325786 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0r

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369327438 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0r

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369327438 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0r

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369328935 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0r

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
uranusjr commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369637078 ## airflow/models/baseoperator.py: ## @@ -1218,15 +1225,17 @@ def __deepcopy__(self, memo): result.__instantiated = self.__instantiated return resu

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
uranusjr commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369637078 ## airflow/models/baseoperator.py: ## @@ -1218,15 +1225,17 @@ def __deepcopy__(self, memo): result.__instantiated = self.__instantiated return resu

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369648913 ## airflow/models/baseoperator.py: ## @@ -1218,15 +1225,17 @@ def __deepcopy__(self, memo): result.__instantiated = self.__instantiated return re

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369648913 ## airflow/models/baseoperator.py: ## @@ -1218,15 +1225,17 @@ def __deepcopy__(self, memo): result.__instantiated = self.__instantiated return re

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-23 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369648913 ## airflow/models/baseoperator.py: ## @@ -1218,15 +1225,17 @@ def __deepcopy__(self, memo): result.__instantiated = self.__instantiated return re

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-24 Thread via GitHub
Taragolis commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1369857493 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/advanced-logging-configuration.rst: ## @@ -89,3 +94,63 @@ See :doc:`../modules_management` f

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-24 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1370774789 ## airflow/models/baseoperator.py: ## @@ -1218,15 +1225,17 @@ def __deepcopy__(self, memo): result.__instantiated = self.__instantiated return re

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-24 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1370789066 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-24 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1370793124 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/advanced-logging-configuration.rst: ## @@ -89,3 +94,63 @@ See :doc:`../modules_management`

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-24 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1370818602 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/advanced-logging-configuration.rst: ## @@ -89,3 +94,63 @@ See :doc:`../modules_management`

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-10-25 Thread via GitHub
Joffreybvn commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1370789066 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-11-02 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1380869870 ## tests/providers/docker/hooks/test_docker.py: ## @@ -36,7 +36,7 @@ TEST_CONN = {"host": "some.docker.registry.com", "login": "some_user", "password": "some_p4$$w0r

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-11-02 Thread via GitHub
potiuk commented on code in PR #34964: URL: https://github.com/apache/airflow/pull/34964#discussion_r1380869972 ## docs/apache-airflow/administration-and-deployment/logging-monitoring/advanced-logging-configuration.rst: ## @@ -89,3 +94,63 @@ See :doc:`../modules_management` for

Re: [PR] Add task parameter to set custom logger name [airflow]

2023-11-03 Thread via GitHub
potiuk merged PR #34964: URL: https://github.com/apache/airflow/pull/34964 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.a