jscheffl opened a new pull request, #36487:
URL: https://github.com/apache/airflow/pull/36487
As I was investigating for bug report #36100 I stumbled over a missing
type-hint in task_instance.py, attempting to fix this, mypy raised more alarms
which I am trying to fix with this PR.
Still
potiuk commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438397310
##
airflow/models/taskinstance.py:
##
@@ -3398,10 +3405,12 @@ def clear_db_references(self, session):
for table in tables:
session.execute(
jscheffl commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438431448
##
airflow/models/taskinstance.py:
##
@@ -3398,10 +3405,12 @@ def clear_db_references(self, session):
for table in tables:
session.execute(
jscheffl commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438901189
##
airflow/models/renderedtifields.py:
##
@@ -49,7 +49,7 @@
from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
-class RenderedTaskIn
jscheffl commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438901189
##
airflow/models/renderedtifields.py:
##
@@ -49,7 +49,7 @@
from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
-class RenderedTaskIn
hussein-awala commented on code in PR #36487:
URL: https://github.com/apache/airflow/pull/36487#discussion_r1438901910
##
airflow/models/renderedtifields.py:
##
@@ -49,7 +49,7 @@
from airflow.models.taskinstance import TaskInstance, TaskInstancePydantic
-class RenderedT
hussein-awala commented on PR #36487:
URL: https://github.com/apache/airflow/pull/36487#issuecomment-1876072252
I will try to apply my suggestions in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
hussein-awala merged PR #36487:
URL: https://github.com/apache/airflow/pull/36487
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@ai
