potiuk merged PR #35970:
URL: https://github.com/apache/airflow/pull/35970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@airflow.a
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837243001
ALMOST :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837229473
@potiuk just pushed a fix adding your comments. Compiles fine 👍🏽
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412854334
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412854219
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412853907
##
dev/breeze/src/airflow_breeze/utils/common_options.py:
##
@@ -557,6 +557,13 @@ def _set_default_from_parent(ctx: click.core.Context,
option: click.core.Option
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837228436
Thank you. I am making the usability improvements now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809587
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references(site
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837164035
Few nits regaring usability/parameters color-coding communication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809497
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references(site
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809252
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1209,52 @@ def add_back_references(
start_generating_back_references(site
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412809042
##
dev/breeze/src/airflow_breeze/utils/common_options.py:
##
@@ -557,6 +557,13 @@ def _set_default_from_parent(ctx: click.core.Context,
option: click.core.Option,
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837160279
> the `subprocess.run` should be replaced with `run_command` from utils
Somehow I forgot to push the commit :/
Pushed the latest changes now. Should be ok
--
This is
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412807489
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only la
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412795261
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last ve
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837126097
> > I am not so sure why this is happening. Any idea?
>
> Becaasue we also need to import in the method where we use it (locally).
Thank you for the hint. Working on it
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837125248
> I am not so sure why this is happening. Any idea?
Becaasue we also need to import in the method where we use it (locally).
--
This is an automated message from the Apache Git S
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412785049
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only la
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412777390
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last ve
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412777390
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1245,10 +1253,7 @@ def clean_old_provider_artifacts(
# Leave only last ve
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1837036365
@potiuk I tried the suggestion and I keep hitting this:
```
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:155:35:
TCH004 Move import `packaging.version
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412719690
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1200,57 @@ def add_back_references(
start_generating_back_references
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412719276
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -1029,10 +1029,10 @@ do
done
# Check which old packages will be removed (you need Python 3.8+ and
dev/requi
amoghrajesh commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1412718995
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1815,3 +1871,26 @@ def update_constraints(
if confirm_modifications(
eladkal commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1411835929
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -1029,10 +1029,10 @@ do
done
# Check which old packages will be removed (you need Python 3.8+ and
dev/requireme
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1836414437
Thank you for your reviews, I will accommodate it soon. Busy with some tasks
at work :/
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
Lee-W commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1411889779
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1195,6 +1200,57 @@ def add_back_references(
start_generating_back_references(site_
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1411847486
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -1029,10 +1029,10 @@ do
done
# Check which old packages will be removed (you need Python 3.8+ and
dev/requiremen
eladkal commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1411835929
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -1029,10 +1029,10 @@ do
done
# Check which old packages will be removed (you need Python 3.8+ and
dev/requireme
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1411830974
##
dev/breeze/src/airflow_breeze/commands/release_management_commands.py:
##
@@ -1815,3 +1871,26 @@ def update_constraints(
if confirm_modifications(const
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833580721
>
Unable to catch it perhaps because I have some versioning issue in my breeze
today..working on fixing it :)
It could also be that you have all `breeze` packages also install
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833554151
Unable to catch it perhaps because I have some versioning issue in my breeze
today..working on fixing it :)
--
This is an automated message from the Apache Git Service.
To res
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833553200
> > > > @potiuk BTW, i do not see static checks failing in my env or here.
Are they failing?
> > >
> > >
> > > Could be intermittent - I see that recent docker has been fa
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833540925
> > > @potiuk BTW, i do not see static checks failing in my env or here. Are
they failing?
> >
> >
> > Could be intermittent - I see that recent docker has been failing more
f
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833448075
> > @potiuk BTW, i do not see static checks failing in my env or here. Are
they failing?
>
> Could be intermittent - I see that recent docker has been failing more
frequently
potiuk commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833440251
> @potiuk BTW, i do not see static checks failing in my env or here. Are
they failing?
Could be intermittent - I see that recent docker has been failing more
frequently in CI (lik
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1410427997
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -1029,10 +1029,10 @@ do
done
# Check which old packages will be removed (you need Python 3.8+ and
dev/requiremen
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833434851
I have also updated the instructions in the required MD files. Should be
good now :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833435606
@potiuk BTW, i do not see static checks failing in my env or here. Are they
failing?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
potiuk commented on code in PR #35970:
URL: https://github.com/apache/airflow/pull/35970#discussion_r1410427756
##
dev/README_RELEASE_PROVIDER_PACKAGES.md:
##
@@ -1029,10 +1029,10 @@ do
done
# Check which old packages will be removed (you need Python 3.8+ and
dev/requiremen
amoghrajesh commented on PR #35970:
URL: https://github.com/apache/airflow/pull/35970#issuecomment-1833434292
Woops.
> remove old script in the same PR
I made the changes, forgot to push!
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
amoghrajesh opened a new pull request, #35970:
URL: https://github.com/apache/airflow/pull/35970
Currently during every release of a provider, cleanup of the older providers
was done using a script. It would much better for the release manager if this
were a breeze command.
42 matches
Mail list logo
