jscheffl commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1873001635
Closing this PR as the attempt is now super-seeded with PRs:
- #36509
- #36514
- #36515
Leaving the cleanup of migration scripts "open for now"
--
This is an
jscheffl closed pull request #35868: Remove MSSQL support from Airflow core
URL: https://github.com/apache/airflow/pull/35868
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
potiuk commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1872248350
> @potiuk Yes, before re-basing another 10 times, I'd like to get this off
the plate and merged. So your advise and prep help might help:
>
> * I assume all feedback consistently
jscheffl commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1872228582
@potiuk Yes, before re-basing another 10 times, I'd like to get this off the
plate and merged. So your advise and prep help might help:
- I assume all feedback consistently
potiuk commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1871997004
Hey @jscheffl -> do you need my help / actions for that one? I am happy to
create the separate repo, if needed and we could already arrange the PR in the
way to be "ready to marge" when
potiuk commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1846225990
> Anyway... so let put this PR on pause and merge it for 2.9.0...
Well. I think we have all the building-blocks in place. Yes it might meen
few people doing some out-of-hours
jscheffl commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1846192314
> I'm not confortable having this in 2.8.0. Let's leave it for 2.9.0 because
the change is big and close to the release time. Also, I prefer we don't remove
the mssql codes but
ephraimbuddy commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1844942742
I'm not confortable having this in 2.8.0. Let's leave it for 2.9.0 because
the change is big and close to the release time.
Also, I prefer we don't remove the mssql codes but
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1413040413
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1413040413
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
eladkal commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1412851278
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1408517163
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
jscheffl commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1408345648
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1408310262
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
jscheffl commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1408255345
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
jscheffl commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1408255345
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1829892711
> I understand (now) that mssql is needed in the docker for the provider
package, which is fail. reverted the last two (functional) commits, leaving the
driver and the install options
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1407674731
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1407674731
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1407674731
##
airflow/migrations/versions/0027_1_10_0_add_time_zone_awareness.py:
##
@@ -139,11 +139,11 @@ def upgrade():
type_=mysql.TIMESTAMP(fsp=6),
)
potiuk commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1829690314
> Thanks @potiuk for the analysis and the hist to history. My main
"mis-understanding" was that I did not know that there are multiple installs
for the driver. Was wondering if this is
jscheffl commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1829147488
Thanks @potiuk for the analysis and the hist to history. My main
"mis-understanding" was that I did not know that there are multiple installs
for the driver. Was wondering if this is
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1406978989
##
Dockerfile:
##
@@ -342,87 +342,6 @@ if [[ ${INSTALL_MYSQL_CLIENT:="true"} == "true" ]]; then
fi
EOF
-# The content below is automatically copied from
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1406971850
##
Dockerfile:
##
@@ -342,87 +342,6 @@ if [[ ${INSTALL_MYSQL_CLIENT:="true"} == "true" ]]; then
fi
EOF
-# The content below is automatically copied from
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1406955218
##
Dockerfile:
##
@@ -342,87 +342,6 @@ if [[ ${INSTALL_MYSQL_CLIENT:="true"} == "true" ]]; then
fi
EOF
-# The content below is automatically copied from
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1406958011
##
Dockerfile:
##
@@ -1259,29 +1176,19 @@ RUN bash /scripts/docker/install_os_dependencies.sh dev
ARG INSTALL_MYSQL_CLIENT="true"
ARG
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1406955218
##
Dockerfile:
##
@@ -342,87 +342,6 @@ if [[ ${INSTALL_MYSQL_CLIENT:="true"} == "true" ]]; then
fi
EOF
-# The content below is automatically copied from
potiuk commented on code in PR #35868:
URL: https://github.com/apache/airflow/pull/35868#discussion_r1406955218
##
Dockerfile:
##
@@ -342,87 +342,6 @@ if [[ ${INSTALL_MYSQL_CLIENT:="true"} == "true" ]]; then
fi
EOF
-# The content below is automatically copied from
potiuk commented on PR #35868:
URL: https://github.com/apache/airflow/pull/35868#issuecomment-1827066914
Should work after rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jscheffl opened a new pull request, #35868:
URL: https://github.com/apache/airflow/pull/35868
DRAFT PR to remove MSSQL support from Airflow
Open items:
- Green build
- Check that breeze works as expected
- Discuss whether the matix action in Github needs a change for
30 matches
Mail list logo
