potiuk commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2040762752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
potiuk merged PR #34457:
URL: https://github.com/apache/airflow/pull/34457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2036583335
All green now :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1549269048
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
potiuk commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1548320952
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1547161284
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1542691829
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1536847700
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
potiuk commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1535863595
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1533445501
##
airflow/jobs/job.py:
##
@@ -131,22 +146,20 @@ def executors(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2011247217
Test is failing in the health api call testcases. let me debug the issue and
fix it by EOD
--
This is an automated message from the Apache Git Service.
To respond to the message,
Bowrna opened a new pull request, #34457:
URL: https://github.com/apache/airflow/pull/34457
related: #31810
closed: #31810
this covers the point C of the issue
---
**^ Add meaningful description above**
Read the **[Pull Request
potiuk commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2009185801
Looks like real issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Bowrna closed pull request #34457: heartbeat recovery message
URL: https://github.com/apache/airflow/pull/34457
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
potiuk commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2008744388
(or so I saw from reviewing the code myself). It's still good to keep it
though in case we have a case we want to override it.
--
This is an automated message from the Apache Git
potiuk commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2008743614
> @potiuk i made the changes regarding the grace_multiplier. If I remember
right, the grace_multiplier was allowed to be set as a param value in config
side and I don't see that part of
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-2008732165
@potiuk i made the changes regarding the grace_multiplier. If I remember
right, the grace_multiplier was allowed to be set as a param value in config
side and I don't see that part of
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-1993761467
@potiuk i will add the changes that you have suggested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
potiuk commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-1986905542
this looks good @Bowrna (except the static check failing) - but I have one
small proposal. It took me a bit of time to see why grace_multiplier is not
passed to to the method in
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1518546357
##
tests/jobs/test_base_job.py:
##
@@ -205,15 +205,17 @@ def test_is_alive_scheduler(self, job_type):
assert job.is_alive() is False, "Completed jobs even
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1481704412
##
tests/jobs/test_base_job.py:
##
@@ -205,15 +205,17 @@ def test_is_alive_scheduler(self, job_type):
assert job.is_alive() is False, "Completed jobs even
potiuk commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1478932569
##
tests/jobs/test_base_job.py:
##
@@ -205,15 +205,17 @@ def test_is_alive_scheduler(self, job_type):
assert job.is_alive() is False, "Completed jobs even
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-1924290629
@amoghrajesh @potiuk do I have any feedback on the test case I have added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1468854809
##
airflow/jobs/job.py:
##
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1464523088
##
airflow/jobs/job.py:
##
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1463353839
##
airflow/jobs/job.py:
##
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1463345865
##
airflow/jobs/job.py:
##
@@ -213,9 +218,12 @@ def heartbeat(
session.merge(self)
self.latest_heartbeat = timezone.utcnow()
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1458792412
##
airflow/jobs/job.py:
##
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1457670440
##
airflow/jobs/job.py:
##
@@ -201,12 +215,15 @@ def heartbeat(
job = Job._update_heartbeat(job=self, session=session)
amoghrajesh commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1456873011
##
airflow/jobs/job.py:
##
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
potiuk commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1438567596
##
airflow/jobs/job.py:
##
@@ -126,7 +127,19 @@ def executor(self):
def heartrate(self) -> float:
return Job._heartrate(self.job_type)
-def
Bowrna commented on PR #34457:
URL: https://github.com/apache/airflow/pull/34457#issuecomment-1870302012
Do you happen to have any updates/suggestions regarding this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Bowrna commented on code in PR #34457:
URL: https://github.com/apache/airflow/pull/34457#discussion_r1379620724
##
airflow/jobs/job.py:
##
@@ -213,9 +218,12 @@ def heartbeat(
session.merge(self)
self.latest_heartbeat = timezone.utcnow()
33 matches
Mail list logo
