[GitHub] [calcite-avatica] libenchao closed pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

libenchao closed pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields URL: https://github.com/apache/calcite-avatica/pull/183 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003932604 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean

[GitHub] [calcite-avatica] F21 opened a new pull request, #187: [CALCITE-5344] Remove Travis CI configuration

F21 opened a new pull request, #187: URL: https://github.com/apache/calcite-avatica/pull/187 The ASF is discontinuing Travis CI for testing, and it will no longer be available after 31 December 2022. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [calcite] F21 opened a new pull request, #2950: [CALCITE-5344] Remove Travis CI configuration

F21 opened a new pull request, #2950: URL: https://github.com/apache/calcite/pull/2950 The ASF is discontinuing Travis CI for testing, and it will no longer be available after 31 December 2022. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003928315 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -3749,26 +3774,26 @@ void checkPeriodPredicate(Checker checker) { + "select

[GitHub] [calcite] libenchao commented on pull request #2948: [CALCITE-5340] Tests should fail when actual and expected XML reference files are not identical

libenchao commented on PR #2948: URL: https://github.com/apache/calcite/pull/2948#issuecomment-1289869013 @asolimando The PR looks great. The only question I got is why `TopDownOptTest` and `RuleMatchVisualizerTest` are not touched in this PR? -- This is an automated message from the

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1003909401 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite-avatica] wnob opened a new pull request, #186: Add proper support for timestamps with timezones

wnob opened a new pull request, #186: URL: https://github.com/apache/calcite-avatica/pull/186 According to the [JDBC 4.2 spec][1], the `TIME_WITH_TIMEZONE` and `TIMESTAMP_WITH_TIMEZONE` types are meant to be accessed as `java.time.OffsetTime` and `java.time.OffsetDateTime` objects

[GitHub] [calcite] HanumathRao commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1289138925 Thank you @zabetak for the review and improvements. Please go ahead and merge the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] asolimando merged pull request #2947: [MINOR] Add default catalog link to test fixtures

asolimando merged PR #2947: URL: https://github.com/apache/calcite/pull/2947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] wojustme commented on pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

wojustme commented on PR #2686: URL: https://github.com/apache/calcite/pull/2686#issuecomment-1288937219 In my opinion, this case only works on in CALCITE's optimizer or validator, which some expresion only change nullable attribute. we couldn't write an sql `cast(c1 as not integer)`,

[GitHub] [calcite] zabetak commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1288891782 I pushed a few small changes to the PR. @HanumathRao let me know if you are OK with those so that I can rebase and merge the PR. -- This is an automated message from the Apache Git

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1003201432 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) + +

[GitHub] [calcite] asolimando commented on pull request #2947: [MINOR] Add default catalog link to test fixtures

asolimando commented on PR #2947: URL: https://github.com/apache/calcite/pull/2947#issuecomment-1288630911 Thanks @JiajunBernoulli, I agree on your reasoning. Can I ask you to squash the commits? Once done, I will merge it in the next 24 hours. -- This is an automated message from the

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1003027206 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect();

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1002851565 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite-avatica] libenchao commented on a diff in pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

libenchao commented on code in PR #183: URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002804111 ## core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java: ## @@ -222,15 +223,22 @@ public static T instantiatePlugin(Class pluginClass,

[GitHub] [calcite-avatica] F21 commented on pull request #184: CALCITE-5327 Make SSL key-store type configurable

F21 commented on PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#issuecomment-1288233986 +1 to @joshelser's comments, otherwise everything else looks great! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

julianhyde commented on code in PR #183: URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002773357 ## core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java: ## @@ -211,6 +211,7 @@ public static T instantiatePlugin(Class pluginClass, String

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

julianhyde commented on code in PR #183: URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002770970 ## core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java: ## @@ -222,15 +223,22 @@ public static T instantiatePlugin(Class pluginClass,

[GitHub] [calcite-avatica] julianhyde commented on a diff in pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

julianhyde commented on code in PR #183: URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002770793 ## core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java: ## @@ -222,15 +223,22 @@ public static T instantiatePlugin(Class pluginClass,

[GitHub] [calcite] julianhyde commented on a diff in pull request #2949: [CALCITE-4455] Calcite SQLParser: Provide support for INSERT OVERWRITE

julianhyde commented on code in PR #2949: URL: https://github.com/apache/calcite/pull/2949#discussion_r1002766746 ## babel/src/main/codegen/config.fmpp: ## @@ -31,12 +31,14 @@ data: { "org.apache.calcite.sql.babel.SqlBabelCreateTable",

[GitHub] [calcite-avatica] zabetak closed pull request #185: [CALCITE-3078] Move public lastDay method from Calcite to Avatica

zabetak closed pull request #185: [CALCITE-3078] Move public lastDay method from Calcite to Avatica URL: https://github.com/apache/calcite-avatica/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [calcite-avatica] zabetak closed pull request #28: [WIP][CALCITE-1806] Add Apache Spark JDBC test to Avatica server

zabetak closed pull request #28: [WIP][CALCITE-1806] Add Apache Spark JDBC test to Avatica server URL: https://github.com/apache/calcite-avatica/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite-avatica] zabetak commented on pull request #28: [WIP][CALCITE-1806] Add Apache Spark JDBC test to Avatica server

zabetak commented on PR #28: URL: https://github.com/apache/calcite-avatica/pull/28#issuecomment-1288156910 This PR has been inactive for quite some time now and it seems there is no interest from the authors to push this forward thus I am closing it down. -- This is an automated message

[GitHub] [calcite-avatica] zabetak closed pull request #98: [CALCITE-3078] Duplicate code lastDay in calcite-avatica and calcite

zabetak closed pull request #98: [CALCITE-3078] Duplicate code lastDay in calcite-avatica and calcite URL: https://github.com/apache/calcite-avatica/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite-avatica] zabetak commented on pull request #98: [CALCITE-3078] Duplicate code lastDay in calcite-avatica and calcite

zabetak commented on PR #98: URL: https://github.com/apache/calcite-avatica/pull/98#issuecomment-1288156204 Closing this in favor of https://github.com/apache/calcite-avatica/pull/185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] JiajunBernoulli commented on pull request #2947: [MINOR] Add default catalog link to test fixtures

JiajunBernoulli commented on PR #2947: URL: https://github.com/apache/calcite/pull/2947#issuecomment-1288039472 Thanks for your review.@asolimando I agree with your suggestion and I use a single description: > Creates a test context with a SQL query. There are two reasons to use

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r1002626396 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean

[GitHub] [calcite] libenchao commented on a diff in pull request #2686: [CALCITE-4982] NonNull field shouldn't be pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

libenchao commented on code in PR #2686: URL: https://github.com/apache/calcite/pull/2686#discussion_r1002623077 ## core/src/main/java/org/apache/calcite/rel/rules/ProjectJoinTransposeRule.java: ## @@ -157,7 +159,24 @@ public ProjectJoinTransposeRule(

[GitHub] [calcite-avatica] libenchao commented on a diff in pull request #183: [CALCITE-5295] Read the values of plugins (such as connect string properties) from ThreadLocal fields

libenchao commented on code in PR #183: URL: https://github.com/apache/calcite-avatica/pull/183#discussion_r1002613948 ## core/src/main/java/org/apache/calcite/avatica/AvaticaUtils.java: ## @@ -222,15 +223,22 @@ public static T instantiatePlugin(Class pluginClass,

[GitHub] [calcite] libenchao commented on pull request #2612: [CALCITE-4888] Unify type inferring logical for Sarg RexLiteral

libenchao commented on PR #2612: URL: https://github.com/apache/calcite/pull/2612#issuecomment-1287800206 I'm closing this PR because https://github.com/apache/calcite/pull/2853 has been merged and fix this issue. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [calcite] libenchao closed pull request #2612: [CALCITE-4888] Unify type inferring logical for Sarg RexLiteral

libenchao closed pull request #2612: [CALCITE-4888] Unify type inferring logical for Sarg RexLiteral URL: https://github.com/apache/calcite/pull/2612 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] libenchao closed pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

libenchao closed pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types URL: https://github.com/apache/calcite/pull/2853 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] asolimando closed pull request #2944: Fixed and improved javadoc instructions to regenerate RelOptRulesTest…

asolimando closed pull request #2944: Fixed and improved javadoc instructions to regenerate RelOptRulesTest… URL: https://github.com/apache/calcite/pull/2944 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] asolimando commented on pull request #2947: [MINOR] Add default catalog link to test fixtures

asolimando commented on PR #2947: URL: https://github.com/apache/calcite/pull/2947#issuecomment-1287672624 I have recently had the same issue, so +1 on the change. I noticed that the comments for the `sql()` method are all different for these three classes, maybe we can try to

[GitHub] [calcite] JiajunBernoulli opened a new pull request, #2947: [MINOR] Add default catalog link to test fixtures

JiajunBernoulli opened a new pull request, #2947: URL: https://github.com/apache/calcite/pull/2947 - When I write a unit test, I often see which tables and columns are available. At present, I have to search the catalog. If there is a link to jump directly, it is very convenient. - For

[GitHub] [calcite] henneberger commented on pull request #2909: Update SqlSelect to add hints to setOperand

henneberger commented on PR #2909: URL: https://github.com/apache/calcite/pull/2909#issuecomment-1287596760 Closing as invalid. This change would cause other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] henneberger closed pull request #2909: Update SqlSelect to add hints to setOperand

henneberger closed pull request #2909: Update SqlSelect to add hints to setOperand URL: https://github.com/apache/calcite/pull/2909 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] HanumathRao commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1287499498 > > I am using the call context to get the RelMetadataQuery, I think this is not fully formed during the matching of the rule > > @HanumathRao can you elaborate a bit what you

[GitHub] [calcite] HanumathRao commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1002223506 ## testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java: ## @@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory

[GitHub] [calcite] HanumathRao commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r1002223406 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) +

[GitHub] [calcite] asolimando merged pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

asolimando merged PR #2901: URL: https://github.com/apache/calcite/pull/2901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite-avatica] joshelser commented on a diff in pull request #184: CALCITE-5327 Make SSL key-store type configurable

joshelser commented on code in PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#discussion_r1001885363 ## server/src/main/java/org/apache/calcite/avatica/server/HttpServer.java: ## @@ -767,6 +771,27 @@ public Builder withTLS(File keystore, String

[GitHub] [calcite] Aitozi commented on pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

Aitozi commented on PR #2901: URL: https://github.com/apache/calcite/pull/2901#issuecomment-1287071569 > @Aitozi, can you squash the commits into a single one having as commit message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost rels`? As soon as this is done I am

[GitHub] [calcite-avatica] rubenada merged pull request #182: [CALCITE-5257] NVARCHAR is treated as "UNKNOWN TYPE" when searching Oracle

rubenada merged PR #182: URL: https://github.com/apache/calcite-avatica/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] asolimando commented on pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

asolimando commented on PR #2901: URL: https://github.com/apache/calcite/pull/2901#issuecomment-1286888938 @Aitozi, can you squash the commits into a single one having as commit message `[CALCITE-5264] HintStrategy rule exclusion does not match innermost rels`? As soon as this is done I am

[GitHub] [calcite-avatica] rubenada merged pull request #163: [CALCITE-4900] NullPointerException when send ExectuteRequest via protobuf with no parameters

rubenada merged PR #163: URL: https://github.com/apache/calcite-avatica/pull/163 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1001563447 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java: ## @@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types, List

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1001561672 ## core/src/main/codegen/templates/Parser.jj: ## @@ -243,6 +243,17 @@ public class ${parser.class} extends SqlAbstractParserImpl return SqlStmtList();

[GitHub] [calcite-avatica] richardantal commented on pull request #184: CALCITE-5327 Make SSL key-store type configurable

richardantal commented on PR #184: URL: https://github.com/apache/calcite-avatica/pull/184#issuecomment-1286639811 I am not able to add reviewers for this PR, but could you please take a look at it? @joshelser @julianhyde @stoty -- This is an automated message from the Apache Git

[GitHub] [calcite] dependabot[bot] closed pull request #2817: Bump nokogiri from 1.13.4 to 1.13.6 in /site

dependabot[bot] closed pull request #2817: Bump nokogiri from 1.13.4 to 1.13.6 in /site URL: https://github.com/apache/calcite/pull/2817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] dependabot[bot] commented on pull request #2817: Bump nokogiri from 1.13.4 to 1.13.6 in /site

dependabot[bot] commented on PR #2817: URL: https://github.com/apache/calcite/pull/2817#issuecomment-1286379401 Superseded by #2945. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] dependabot[bot] opened a new pull request, #2945: Bump nokogiri from 1.13.4 to 1.13.9 in /site

dependabot[bot] opened a new pull request, #2945: URL: https://github.com/apache/calcite/pull/2945 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.4 to 1.13.9. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases;>nokogiri's

[GitHub] [calcite] julianhyde closed pull request #2943: [CALCITE-5339] Use Method#getParameterCount rather than Method#getParameterTypes to get length

julianhyde closed pull request #2943: [CALCITE-5339] Use Method#getParameterCount rather than Method#getParameterTypes to get length URL: https://github.com/apache/calcite/pull/2943 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] julianhyde commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

julianhyde commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1000994647 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java: ## @@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types, List

[GitHub] [calcite] asolimando opened a new pull request, #2944: Fixed and improved javadoc instructions to regenerate RelOptRulesTest…

asolimando opened a new pull request, #2944: URL: https://github.com/apache/calcite/pull/2944 ….xml, updated RelOptRulesTest.xml to match current tests in RelOptRulesTest.java -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] dssysolyatin commented on a diff in pull request #2819: [CALCITE-5159] Postgres dialect should support implicit cast from string literal to array literal

dssysolyatin commented on code in PR #2819: URL: https://github.com/apache/calcite/pull/2819#discussion_r1000675480 ## core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java: ## @@ -721,4 +738,31 @@ boolean canImplicitTypeCast(List types, List

[GitHub] [calcite] asolimando merged pull request #2941: Updated javadoc instructions to regenerate RelOptRulesTest.xml replac…

asolimando merged PR #2941: URL: https://github.com/apache/calcite/pull/2941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite-avatica] ILuffZhe commented on pull request #182: [CALCITE-5257] NVARCHAR is treated as "UNKNOWN TYPE" when searching Oracle

ILuffZhe commented on PR #182: URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1284743905 Thanks for your review, @rubenada I've squashed the commits. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] snuyanzin opened a new pull request, #2943: [CALCITE-5339] Use Method#getParameterCount rather than Method#getParameterTypes to get length

snuyanzin opened a new pull request, #2943: URL: https://github.com/apache/calcite/pull/2943 As stated in jira issue `Method#getParameterTypes` each time creates a new array so it's better to use `Method#getParameterCount` to know length of array -- This is an automated message from the

[GitHub] [calcite] julianhyde closed pull request #2926: [CALCITE-5305] Support string constants with c-style escapes

julianhyde closed pull request #2926: [CALCITE-5305] Support string constants with c-style escapes URL: https://github.com/apache/calcite/pull/2926 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] asolimando opened a new pull request, #2941: Updated javadoc instructions to regenerate RelOptRulesTest.xml replac…

asolimando opened a new pull request, #2941: URL: https://github.com/apache/calcite/pull/2941 …ing Maven path with Gradle path -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite-avatica] rubenada commented on pull request #182: [CALCITE-5257] NVARCHAR is treated as "UNKNOWN TYPE" when searching Oracle

rubenada commented on PR #182: URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1284238772 Thanks @ILuffZhe , lgtm. Could you please squash commits into a single one? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] libenchao commented on pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

libenchao commented on PR #2853: URL: https://github.com/apache/calcite/pull/2853#issuecomment-1283915022 @abhishek-das-gupta I found that `RexBuilder#makeBetween` also may have the same problem, could you help to confirm this, and fix it if it exists? (In this issue, or a follow-up issue,

[GitHub] [calcite] libenchao closed pull request #2936: [CALCITE-5326] fix values from sql merge

libenchao closed pull request #2936: [CALCITE-5326] fix values from sql merge URL: https://github.com/apache/calcite/pull/2936 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r999314056 ## core/src/test/resources/org/apache/calcite/test/RelOptRulesTest.xml: ## @@ -3058,6 +3058,50 @@ LogicalSort(sort0=[$7], dir0=[ASC], fetch=[0]) + +

[GitHub] [calcite] zabetak commented on a diff in pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on code in PR #2935: URL: https://github.com/apache/calcite/pull/2935#discussion_r999312483 ## testkit/src/main/java/org/apache/calcite/test/catalog/MockCatalogReaderSimple.java: ## @@ -261,6 +261,14 @@ protected MockCatalogReaderSimple(RelDataTypeFactory

[GitHub] [calcite] zabetak commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

zabetak commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1283786273 > I am using the call context to get the RelMetadataQuery, I think this is not fully formed during the matching of the rule @HanumathRao can you elaborate a bit what you mean when

[GitHub] [calcite] wojustme commented on pull request #2686: [CALCITE-4982] NonNull field is pushed down into leaf of outer-join in 'ProjectJoinTransposeRule'

wojustme commented on PR #2686: URL: https://github.com/apache/calcite/pull/2686#issuecomment-1283656880 Add default config: PreserveExprCondition Shouldn't push non-null field, which is wrapped by CAST's operator. Hi @libenchao Please review this pr again, thanks a lot. -- This

[GitHub] [calcite] asolimando merged pull request #2940: [CALCITE-5337] UnionPullUpConstantsRule produces an invalid plan when pulling up constants for nullable fields

asolimando merged PR #2940: URL: https://github.com/apache/calcite/pull/2940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] asolimando commented on pull request #2940: [CALCITE-5337] UnionPullUpConstantsRule produces an invalid plan when pulling up constants for nullable fields

asolimando commented on PR #2940: URL: https://github.com/apache/calcite/pull/2940#issuecomment-1283648291 Test failure after squashing is caused by the known flacky test `org.apache.calcite.test.ServerTest`, not related to the PR -- This is an automated message from the Apache Git

[GitHub] [calcite] asolimando commented on pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

asolimando commented on PR #2901: URL: https://github.com/apache/calcite/pull/2901#issuecomment-1282762416 The PR LGTM, I will merge by the end of this week if there will be no objections -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r997862622 ## core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java: ## @@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {

[GitHub] [calcite] wojustme opened a new pull request, #2939: The rule of AGGREGATE_EXPAND_DISTINCT_AGGREGATES_TO_JOIN throws error, when meeting the rollup's query

wojustme opened a new pull request, #2939: URL: https://github.com/apache/calcite/pull/2939 ISSUE: https://issues.apache.org/jira/browse/CALCITE-5328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite-avatica] ILuffZhe commented on pull request #182: [CALCITE-5257] NVARCHAR is treated as "UNKNOWN TYPE" when searching Oracle

ILuffZhe commented on PR #182: URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1281717165 @rubenada Hi, Ruben. I've added unit test for this case, please take a look when you have time. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] libenchao commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

libenchao commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r997163233 ## core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java: ## @@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {

[GitHub] [calcite-avatica] rubenada commented on pull request #182: [CALCITE-5257] NVARCHAR is treated as "UNKNOWN TYPE" when searching Oracle

rubenada commented on PR #182: URL: https://github.com/apache/calcite-avatica/pull/182#issuecomment-1280950195 @ILuffZhe could you please add a unit test for the problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite-avatica] rubenada commented on pull request #163: [CALCITE-4900] NullPointerException when send ExectuteRequest via protobuf with no parameters

rubenada commented on PR #163: URL: https://github.com/apache/calcite-avatica/pull/163#issuecomment-1280946552 Thanks @Logioniz for the PR. @NobiGo the PR seems in a good shape. Do you have any further comments? Otherwise I'll merge it in the coming days. -- This is an automated

[GitHub] [calcite] rubenada commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

rubenada commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1280924430 @zabetak as you already mentioned in Jira, it seems PruneEmptyRule is the only one that lacks a default config, so we should definitely add it and align with the rest (see e.g.

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996677165 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect(); if

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996676210 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996675145 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -2241,6 +2241,34 @@ void checkPeriodPredicate(Checker checker) {

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996611975 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996599562 ## core/src/main/java/org/apache/calcite/sql/SqlCall.java: ## @@ -118,7 +118,7 @@ public int operandCount() { final SqlDialect dialect = writer.getDialect(); if

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996593733 ## core/src/main/java/org/apache/calcite/sql/SqlWith.java: ## @@ -103,8 +103,9 @@ private SqlWithOperator() { } writer.endList(frame1); final

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996593539 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -2241,6 +2241,34 @@ void checkPeriodPredicate(Checker checker) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996592477 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996591355 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean windowDeclListNewline) {

[GitHub] [calcite] l4wei commented on pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei commented on PR #2938: URL: https://github.com/apache/calcite/pull/2938#issuecomment-1280237370 > OH~, thank you very much for your tip, i have already changed the email in my local git config. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [calcite] libenchao commented on a diff in pull request #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

libenchao commented on code in PR #2938: URL: https://github.com/apache/calcite/pull/2938#discussion_r996443682 ## core/src/main/java/org/apache/calcite/sql/pretty/SqlPrettyWriter.java: ## @@ -398,10 +398,14 @@ public void setWindowDeclListNewline(boolean

[GitHub] [calcite] abhishek-das-gupta commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

abhishek-das-gupta commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r996345727 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -1258,6 +1259,26 @@ private static String toSql(RelNode root,

[GitHub] [calcite] HanumathRao commented on pull request #2935: [CALCITE-5314] Prune empty parts of a query by exploiting stats/metadata

HanumathRao commented on PR #2935: URL: https://github.com/apache/calcite/pull/2935#issuecomment-1279557853 Thanks @zabetak for the review. I have addressed all the comments except the following. _It is better to put the row count check in the matches method. When the condition is

[GitHub] [calcite] julianhyde commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

julianhyde commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r996032708 ## core/src/test/java/org/apache/calcite/rex/RexBuilderTest.java: ## @@ -624,6 +624,29 @@ private void checkDate(RexLiteral literal) {

[GitHub] [calcite] julianhyde commented on a diff in pull request #2853: [CALCITE-4632] SARG datatype should be less restictive than any of the input types

julianhyde commented on code in PR #2853: URL: https://github.com/apache/calcite/pull/2853#discussion_r996031793 ## core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java: ## @@ -1258,6 +1259,26 @@ private static String toSql(RelNode root, SqlDialect

[GitHub] [calcite] l4wei opened a new pull request, #2938: [CALCITE-5299] JDBC adapter sometimes adds unnecessary parentheses around SELECT in WITH body

l4wei opened a new pull request, #2938: URL: https://github.com/apache/calcite/pull/2938 Remove unnecessary parentheses around SELECT in WITH body -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] l4wei closed pull request #2923: [CALCITE-5252] Unparsing "WITH ... AS (SELECT ... UNION SELECT ...)" missing parentheses

l4wei closed pull request #2923: [CALCITE-5252] Unparsing "WITH ... AS (SELECT ... UNION SELECT ...)" missing parentheses URL: https://github.com/apache/calcite/pull/2923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] zabetak commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

zabetak commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1278688528 @rubenada I guess there are other rules which miss a `DEFAULT` config instance. The problem though may not be so serious in every case if rules are not declared as 'RelOptRule` but as a

[GitHub] [calcite] rubenada commented on pull request #2937: [CALCITE-5332] Configuring PruneEmptyRules is cumbersome

rubenada commented on PR #2937: URL: https://github.com/apache/calcite/pull/2937#issuecomment-1277715384 @zabetak IMO the change makes sense, lgtm. Have you checked if there are other rules that could benefit from the same refactoring? -- This is an automated message from the Apache

<    2   3   4   5   6   7   8   9   10   11   >