jaystarshot commented on code in PR #2931:
URL: https://github.com/apache/calcite/pull/2931#discussion_r994622813
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -2815,6 +2815,45 @@ private SqlDialect nonOrdinalDialect() {
jaystarshot commented on code in PR #2931:
URL: https://github.com/apache/calcite/pull/2931#discussion_r994622813
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -2815,6 +2815,45 @@ private SqlDialect nonOrdinalDialect() {
xuzifu666 closed pull request #2933: [Minor] Refactor Matcher class with remove
removePartialMatch
URL: https://github.com/apache/calcite/pull/2933
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
JiajunBernoulli commented on code in PR #2931:
URL: https://github.com/apache/calcite/pull/2931#discussion_r994176618
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -2815,6 +2815,45 @@ private SqlDialect nonOrdinalDialect() {
JiajunBernoulli commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1277060199
It is public method, maybe some uses use it. We should not remove it unless
there is a better method for users.
--
This is an automated message from the Apache Git Service.
To
abhishek-das-gupta commented on PR #2853:
URL: https://github.com/apache/calcite/pull/2853#issuecomment-1277047972
@libenchao I agree with your comment. Please let when can resolve this
issue, If nothing more needs to be done.
--
This is an automated message from the Apache Git Service.
Aitozi commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1275969058
Thanks for your guidance :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1275935388
> Hi @asolimando can you help me here:
>
> when I develop on the calcite, I found it's not easy to conform its
checkstyle, especially the indentation. I have tried
>
> *
clesaec opened a new pull request, #2936:
URL: https://github.com/apache/calcite/pull/2936
This PR addresses
[CALCITE-5326](https://issues.apache.org/jira/browse/CALCITE-5326) about
SqlMerge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
Aitozi commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1275443551
Hi @asolimando can you help me here:
when I develop on the calcite, I found it's not easy to conform its
checkstyle, especially the indentation. I have tried
- `./gradlew
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1274946950
> @asolimando Thanks for your comments, I have addressed them. And rebase on
the latest master force pushed.
Thanks @Aitozi for addressing the comments so fast!
However,
Aitozi commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1274922768
@asolimando Thanks for your comments, I have addressed them. And rebase on
the latest master force pushed.
--
This is an automated message from the Apache Git Service.
To respond to
Aitozi commented on code in PR #2901:
URL: https://github.com/apache/calcite/pull/2901#discussion_r992425797
##
core/src/main/java/org/apache/calcite/plan/RelOptRuleCall.java:
##
@@ -201,13 +201,18 @@ public RelOptPlanner getPlanner() {
* @return true iff rule should be
asolimando commented on PR #2901:
URL: https://github.com/apache/calcite/pull/2901#issuecomment-1274816052
Apart from few minor comments, the PR looks good to me. I have checked the
original PR and the discussion there, it makes sense to me too to check all
rels, but since I am not very
asolimando commented on code in PR #2901:
URL: https://github.com/apache/calcite/pull/2901#discussion_r992421642
##
core/src/test/java/org/apache/calcite/test/SqlHintsConverterTest.java:
##
@@ -578,6 +579,21 @@ public final Fixture sql(String sql) {
.check();
}
+
asolimando commented on code in PR #2901:
URL: https://github.com/apache/calcite/pull/2901#discussion_r992382425
##
core/src/main/java/org/apache/calcite/plan/RelOptRuleCall.java:
##
@@ -201,13 +201,18 @@ public RelOptPlanner getPlanner() {
* @return true iff rule should be
asolimando merged PR #2928:
URL: https://github.com/apache/calcite/pull/2928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
zabetak commented on code in PR #2935:
URL: https://github.com/apache/calcite/pull/2935#discussion_r992121760
##
core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java:
##
@@ -540,4 +540,32 @@ public interface JoinRightEmptyRuleConfig extends
rubenada commented on code in PR #2928:
URL: https://github.com/apache/calcite/pull/2928#discussion_r991336171
##
.github/workflows/main.yml:
##
@@ -123,7 +123,7 @@ jobs:
linux-openj9:
Review Comment:
@asolimando IIRC the problem appeared on an Ubutu + WebSphere
asolimando commented on code in PR #2928:
URL: https://github.com/apache/calcite/pull/2928#discussion_r991252878
##
.github/workflows/main.yml:
##
@@ -123,7 +123,7 @@ jobs:
linux-openj9:
Review Comment:
Thanks @rubenada for pointing to the original discussion. Did you
wojustme commented on PR #2686:
URL: https://github.com/apache/calcite/pull/2686#issuecomment-1273044390
@libenchao
This issue/pr was so long that it took me a little time to review it.
Two solutions:
1. Avoid pushing down with the operand of coalesce's operator
2. Keep pushing
HanumathRao opened a new pull request, #2935:
URL: https://github.com/apache/calcite/pull/2935
The following changes are made to implement an optimization for pruning out
the sub trees when a base-table is empty. The detection of a table being empty
is done using MaxRow stat.
I have
abhishek-das-gupta commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r990811601
##
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##
@@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) {
if
libenchao commented on PR #2925:
URL: https://github.com/apache/calcite/pull/2925#issuecomment-1272545448
@wanda1416 Thanks for your contribution, I can review this. However, before
that, I would like to hear @NobiGo 's opinion since he is the original reporter
and assignee of this issue.
wanda1416 commented on PR #2925:
URL: https://github.com/apache/calcite/pull/2925#issuecomment-1272503736
@libenchao Can you review this? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
libenchao closed pull request #2920: [CALCITE-5296] In a query with ROLLUP,
validator wrongly infers that a column is NOT NULL
URL: https://github.com/apache/calcite/pull/2920
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wojustme commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
String sql =
wojustme commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990634393
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
String sql =
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282510
@danny0405 Teacher Chan, the api is not used in Calcite, want to refactor
it throght remove it for other developers not use the api，thanks
--
This is an automated message from the
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282070
> Sorry, I'm not a commiter to Apache Calcite and lack context to form an
opinion on this change.
get
--
This is an automated message from the Apache Git Service.
To respond
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272282002
@danny0405 Hi, teacher danny, the api is not used in Calcite，and want to
remove it to aviod other developers use it.
> Sorry, I'm not a commiter to Apache Calcite and lack
libenchao commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r990619993
##
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##
@@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) {
if (areAssignable(arg,
bchapuis commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272279359
Sorry, I'm not a commiter to Apache Calcite and lack context to form an
opinion on this change.
--
This is an automated message from the Apache Git Service.
To respond to the
xuzifu666 closed pull request #2934: remove unused method in Resources
URL: https://github.com/apache/calcite/pull/2934
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
xuzifu666 commented on PR #2933:
URL: https://github.com/apache/calcite/pull/2933#issuecomment-1272265819
@bchapuis have a review please, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
xuzifu666 opened a new pull request, #2933:
URL: https://github.com/apache/calcite/pull/2933
removePartialMatch is useless in Mather，and avoid be used by other function
remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
abhishek-das-gupta commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r990604610
##
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##
@@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) {
if
libenchao commented on code in PR #2920:
URL: https://github.com/apache/calcite/pull/2920#discussion_r990601217
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4688,4 +4688,5 @@ void checkCorrelatedMapSubQuery(boolean expand) {
String sql =
rubenada commented on code in PR #2928:
URL: https://github.com/apache/calcite/pull/2928#discussion_r990211351
##
.github/workflows/main.yml:
##
@@ -123,7 +123,7 @@ jobs:
linux-openj9:
Review Comment:
Just to provide some info. IIRC correctly, this was added due to
asolimando commented on code in PR #2928:
URL: https://github.com/apache/calcite/pull/2928#discussion_r990091096
##
.github/workflows/main.yml:
##
@@ -123,7 +123,7 @@ jobs:
linux-openj9:
Review Comment:
Thanks @michaelmior, I have missed that!
I am afraid the
michaelmior commented on code in PR #2928:
URL: https://github.com/apache/calcite/pull/2928#discussion_r990082893
##
.github/workflows/main.yml:
##
@@ -123,7 +123,7 @@ jobs:
linux-openj9:
Review Comment:
It seems there is still some inconsistency here. I'm not sure if
abhishek-das-gupta commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r989827399
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -1252,6 +1253,26 @@ private static String toSql(RelNode root,
libenchao commented on code in PR #2853:
URL: https://github.com/apache/calcite/pull/2853#discussion_r989705887
##
core/src/main/java/org/apache/calcite/rex/RexBuilder.java:
##
@@ -1355,10 +1356,14 @@ public RexNode makeIn(RexNode arg, List ranges) {
if (areAssignable(arg,
jaystarshot opened a new pull request, #2931:
URL: https://github.com/apache/calcite/pull/2931
Based on the ticket https://issues.apache.org/jira/browse/CALCITE-5248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
jaystarshot closed pull request #2930: [Calcite-5248] Support Extended Column
Aliasing
URL: https://github.com/apache/calcite/pull/2930
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
jaystarshot opened a new pull request, #2930:
URL: https://github.com/apache/calcite/pull/2930
https://issues.apache.org/jira/browse/CALCITE-5248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
jaystarshot closed pull request #2882: Work In progress: Column Aliasing
URL: https://github.com/apache/calcite/pull/2882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
asfgit closed pull request #2927: [CALCITE-4186] Add ST_CoveredBy function
URL: https://github.com/apache/calcite/pull/2927
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
itiels commented on code in PR #2868:
URL: https://github.com/apache/calcite/pull/2868#discussion_r985604527
##
core/src/main/java/org/apache/calcite/sql/SqlWithinGroupOperator.java:
##
@@ -79,7 +81,56 @@ public SqlWithinGroupOperator() {
SqlValidator validator,
rubenada merged PR #2921:
URL: https://github.com/apache/calcite/pull/2921
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
itiels commented on code in PR #2868:
URL: https://github.com/apache/calcite/pull/2868#discussion_r985491360
##
core/src/main/java/org/apache/calcite/sql/type/ReturnTypes.java:
##
@@ -988,4 +990,15 @@ public static SqlCall stripSeparator(SqlCall call) {
return
zstan commented on code in PR #2889:
URL: https://github.com/apache/calcite/pull/2889#discussion_r985385913
##
core/src/main/java/org/apache/calcite/rel/type/RelCrossType.java:
##
@@ -58,6 +58,15 @@ public RelCrossType(
return false;
}
+ /**
+ * Returns the
julianhyde commented on code in PR #2868:
URL: https://github.com/apache/calcite/pull/2868#discussion_r985305240
##
core/src/main/java/org/apache/calcite/sql/SqlWithinGroupOperator.java:
##
@@ -79,7 +81,56 @@ public SqlWithinGroupOperator() {
SqlValidator validator,
julianhyde closed pull request #2905: [CALCITE-5276] Implicitly convert strings
to geometries
URL: https://github.com/apache/calcite/pull/2905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
julianhyde commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985149979
##
core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
julianhyde commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985147236
##
core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985147077
##
core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985146944
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
bchapuis commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985146944
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
julianhyde commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985146856
##
core/src/test/java/org/apache/calcite/test/SpatialTypeTableFunctionsTest.java:
##
@@ -0,0 +1,106 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
julianhyde commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985146715
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
julianhyde commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985145490
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
julianhyde commented on code in PR #2924:
URL: https://github.com/apache/calcite/pull/2924#discussion_r985144890
##
core/src/main/java/org/apache/calcite/runtime/SpatialTypeTableFunctions.java:
##
@@ -0,0 +1,158 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
julianhyde closed pull request #2902: [CALCITE-5275] Release Calcite 1.32.0
URL: https://github.com/apache/calcite/pull/2902
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
julianhyde commented on PR #2902:
URL: https://github.com/apache/calcite/pull/2902#issuecomment-1264473601
Closing this PR because the release happened. Commit 413eded693.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
julianhyde commented on PR #2902:
URL: https://github.com/apache/calcite/pull/2902#issuecomment-1264473503
@AjinkyaTaranekar Thanks for letting us know. Sorry I didn't respond sooner.
The problem was fixed in e46dfc619c960bcfbfa46b311a34b4ec7f0685a2.
--
This is an automated message from
libenchao commented on code in PR #2889:
URL: https://github.com/apache/calcite/pull/2889#discussion_r984672791
##
core/src/main/java/org/apache/calcite/rel/type/RelCrossType.java:
##
@@ -58,6 +58,15 @@ public RelCrossType(
return false;
}
+ /**
+ * Returns the
asolimando commented on code in PR #2889:
URL: https://github.com/apache/calcite/pull/2889#discussion_r984551995
##
core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java:
##
@@ -6163,7 +6163,7 @@ private ImmutableList
cube(ImmutableBitSet... sets) {
/** Test case
libenchao commented on code in PR #2813:
URL: https://github.com/apache/calcite/pull/2813#discussion_r984656218
##
core/src/main/java/org/apache/calcite/rel/core/Project.java:
##
@@ -137,20 +163,27 @@ protected Project(RelInput input) {
* @param input Input
* @param
zabetak commented on code in PR #2813:
URL: https://github.com/apache/calcite/pull/2813#discussion_r984488709
##
core/src/main/java/org/apache/calcite/rel/core/Project.java:
##
@@ -137,20 +163,27 @@ protected Project(RelInput input) {
* @param input Input
* @param
libenchao commented on code in PR #2813:
URL: https://github.com/apache/calcite/pull/2813#discussion_r984403160
##
core/src/main/java/org/apache/calcite/rel/core/Project.java:
##
@@ -137,20 +163,27 @@ protected Project(RelInput input) {
* @param input Input
* @param
libenchao closed pull request #2911: [CALCITE-5127] Error when executing query
with subquery in select lis…
URL: https://github.com/apache/calcite/pull/2911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
libenchao commented on PR #2911:
URL: https://github.com/apache/calcite/pull/2911#issuecomment-1263086667
closed due to we changed to https://github.com/apache/calcite/pull/2813
again, see more discussions in the JIRA
--
This is an automated message from the Apache Git Service.
To
l4wei opened a new pull request, #2923:
URL: https://github.com/apache/calcite/pull/2923
Fix a bug in SqlCall::unparse to solve missing parentheses around UNION in
WITH item.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
libenchao closed pull request #2910: [CALCITE-5265] Select operator'
parentheses should be same with Union operator
URL: https://github.com/apache/calcite/pull/2910
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
rubenada commented on PR #2921:
URL: https://github.com/apache/calcite/pull/2921#issuecomment-1262262880
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
snuyanzin commented on PR #793:
URL: https://github.com/apache/calcite/pull/793#issuecomment-1262210294
All updates are in comments for corresponding JIRA issue
https://issues.apache.org/jira/browse/CALCITE-1776
--
This is an automated message from the Apache Git Service.
To respond to
lfdversluis commented on PR #793:
URL: https://github.com/apache/calcite/pull/793#issuecomment-1261959040
Any updates on the status of this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
libenchao closed pull request #2912: [CALCITE-5288] '(a > 1 and a < 3) or (a >
2 and a < 4)' can't be simplified
URL: https://github.com/apache/calcite/pull/2912
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
libenchao commented on PR #2912:
URL: https://github.com/apache/calcite/pull/2912#issuecomment-1260390424
I'll merge this PR if there is no objections appear in 24 hours.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
l4wei commented on PR #2910:
URL: https://github.com/apache/calcite/pull/2910#issuecomment-1260323271
>
I have added test that mentioned by Julian' last comment in third commit in
this PR. FYI
--
This is an automated message from the Apache Git Service.
To respond to the message,
l4wei commented on PR #2910:
URL: https://github.com/apache/calcite/pull/2910#issuecomment-1260304022
>
OK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
libenchao commented on PR #2910:
URL: https://github.com/apache/calcite/pull/2910#issuecomment-1260301791
@l4wei I didn't notice Julian has another comment when I commented with
"LGTM", could you add another test which addresses Julian's comment?
--
This is an automated message from the
libenchao closed pull request #2918: [CALCITE-5297] Casting dynamic variable
twice throws exception
URL: https://github.com/apache/calcite/pull/2918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
keatn closed pull request #2922: Change enum values to match design doc
URL: https://github.com/apache/calcite/pull/2922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
keatn opened a new pull request, #2922:
URL: https://github.com/apache/calcite/pull/2922
See
https://bodo.atlassian.net/wiki/spaces/B/pages/1165197313/MERGE+INTO+Calcite+Plan+and+Delta+Table
and
https://bodo.atlassian.net/wiki/spaces/B/pages/1148715009/MERGE+INTO+I+O+Design
--
This
l4wei commented on code in PR #2910:
URL: https://github.com/apache/calcite/pull/2910#discussion_r981264826
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -6352,6 +6352,20 @@ private void checkLiteral2(String expression, String
expected)
l4wei commented on code in PR #2910:
URL: https://github.com/apache/calcite/pull/2910#discussion_r981260935
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -6352,6 +6352,20 @@ private void checkLiteral2(String expression, String
expected)
libenchao commented on code in PR #2910:
URL: https://github.com/apache/calcite/pull/2910#discussion_r981235738
##
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##
@@ -6352,6 +6352,20 @@ private void checkLiteral2(String expression, String
libenchao commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r981219448
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -235,8 +235,11 @@ public class SqlValidatorImpl implements
SqlValidatorWithHints {
JiajunBernoulli opened a new pull request, #2921:
URL: https://github.com/apache/calcite/pull/2921
…ot a literal"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
wojustme opened a new pull request, #2920:
URL: https://github.com/apache/calcite/pull/2920
ISSUE: https://issues.apache.org/jira/browse/CALCITE-5296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dssysolyatin commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r979700546
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4678,4 +4678,14 @@ void checkCorrelatedMapSubQuery(boolean expand) {
dssysolyatin commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r979699119
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4678,4 +4678,14 @@ void checkCorrelatedMapSubQuery(boolean expand) {
clesaec commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r979686806
##
core/src/test/java/org/apache/calcite/test/SqlToRelConverterTest.java:
##
@@ -4678,4 +4678,14 @@ void checkCorrelatedMapSubQuery(boolean expand) {
dssysolyatin commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r979618676
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -235,8 +235,11 @@ public class SqlValidatorImpl implements
dssysolyatin commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r979618676
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -235,8 +235,11 @@ public class SqlValidatorImpl implements
libenchao commented on code in PR #2918:
URL: https://github.com/apache/calcite/pull/2918#discussion_r979405386
##
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##
@@ -235,8 +235,11 @@ public class SqlValidatorImpl implements
SqlValidatorWithHints {
julianhyde closed pull request #2913: [CALCITE-5180] Implement BigQuery
TIME_TRUNC and TIMESTAMP_TRUNC functions
URL: https://github.com/apache/calcite/pull/2913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
julianhyde closed pull request #2914: [CALCITE-5291] Make BigQuery lexical
policy case insensitive
URL: https://github.com/apache/calcite/pull/2914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
701 - 800 of 18124 matches
Mail list logo
