[GitHub] [calcite] julianhyde closed pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

julianhyde closed pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty URL: https://github.com/apache/calcite/pull/2916 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r978970992 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -485,6 +516,54 @@ protected void perform(RelOptRuleCall call, @Nullable

[GitHub] [calcite] twdsilva commented on a diff in pull request #2876: [CALCITE-5240] Enhance MaterializedViewRule so that it applies to rol…

twdsilva commented on code in PR #2876: URL: https://github.com/apache/calcite/pull/2876#discussion_r978970992 ## core/src/main/java/org/apache/calcite/rel/rules/materialize/MaterializedViewRule.java: ## @@ -485,6 +516,54 @@ protected void perform(RelOptRuleCall call, @Nullable

[GitHub] [calcite] dssysolyatin opened a new pull request, #2918: [CALCITE-5297] Casting dynamic variable twice throws exception

dssysolyatin opened a new pull request, #2918: URL: https://github.com/apache/calcite/pull/2918 It was originally intended that dynamic parameter is nullable by default (see SqlValidatorImpl#inferUnknownTypes), but DeriveTypeVisitor made dynamic parameter is nullable. In the end row type

[GitHub] [calcite] zabetak closed pull request #2683: [CALCITE-4972] Qualify names for repeated structs in getFieldOrigins

zabetak closed pull request #2683: [CALCITE-4972] Qualify names for repeated structs in getFieldOrigins URL: https://github.com/apache/calcite/pull/2683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r978374808 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -479,13 +481,24 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r978348511 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -479,13 +481,24 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] asolimando commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

asolimando commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r978338926 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -479,13 +481,24 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] DeaconDesperado commented on pull request #2683: [CALCITE-4972] Qualify names for repeated structs in getFieldOrigins

DeaconDesperado commented on PR #2683: URL: https://github.com/apache/calcite/pull/2683#issuecomment-1255293057 Thank you @zabetak for the review! Checked in with changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977595733 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,15 +554,13 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] asolimando commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

asolimando commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977552984 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,15 +554,13 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] zabetak commented on a diff in pull request #2683: [CALCITE-4972] Qualify names for repeated structs in getFieldOrigins

zabetak commented on code in PR #2683: URL: https://github.com/apache/calcite/pull/2683#discussion_r977435956 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -9210,6 +9210,23 @@ public void _testGroupExpressionEquivalenceParams() { +

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977434703 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] zabetak commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r977414870 ## core/src/main/java/org/apache/calcite/adapter/enumerable/EnumerableProjectRule.java: ## @@ -42,6 +43,14 @@ protected EnumerableProjectRule(Config config) {

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977348821 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977335384 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977326394 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] bchapuis opened a new pull request, #2917: [CALCITE-5280] Add geometry aggregate functions

bchapuis opened a new pull request, #2917: URL: https://github.com/apache/calcite/pull/2917 This PR addresses [CALCITE-5280](https://issues.apache.org/jira/browse/CALCITE-5280). Notice that I had to remove one of the existing ST_UNION function (due to a name clash?). Also, this

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977311883 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977311883 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977304390 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977303067 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -480,9 +486,25 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977290395 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -551,17 +529,15 @@ public interface JoinRightEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977285954 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r977285031 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] zabetak closed pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

zabetak closed pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules URL: https://github.com/apache/calcite/pull/2915 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] julianhyde commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

julianhyde commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976851396 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -480,9 +486,25 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on PR #2916: URL: https://github.com/apache/calcite/pull/2916#issuecomment-1253858830 Should this patch also be mentioned in `history.md` in ` Bug-fixes, API changes and minor enhancements` section ? -- This is an automated message from the Apache Git Service. To

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

kasakrisz commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976643211 ## site/_docs/history.md: ## @@ -44,6 +44,10 @@ z. Breaking Changes {: #breaking-1-33-0} +*

[GitHub] [calcite] asolimando commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

asolimando commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976634022 ## site/_docs/history.md: ## @@ -44,6 +44,10 @@ z. Breaking Changes {: #breaking-1-33-0} +*

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

kasakrisz commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976631083 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -94,7 +94,7 @@ public interface Config extends RelRule.Config { public static final

[GitHub] [calcite] asolimando commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

asolimando commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976611598 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] asolimando commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

asolimando commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976611160 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +513,29 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] zabetak commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

zabetak commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976589860 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -94,7 +94,7 @@ public interface Config extends RelRule.Config { public static final

[GitHub] [calcite] zabetak commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

zabetak commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976589860 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -94,7 +94,7 @@ public interface Config extends RelRule.Config { public static final

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976576543 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +512,30 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

kasakrisz commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976576290 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -480,9 +486,24 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] kasakrisz commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

kasakrisz commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976575571 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -94,7 +94,7 @@ public interface Config extends RelRule.Config { public static final

[GitHub] [calcite] rubenada commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

rubenada commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976517058 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -491,6 +512,30 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] rubenada commented on a diff in pull request #2916: [CALCITE-5294] Improve PruneEmptyRules join instances to remove join if generates null and one branch is empty

rubenada commented on code in PR #2916: URL: https://github.com/apache/calcite/pull/2916#discussion_r976516051 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -480,9 +486,24 @@ public interface JoinLeftEmptyRuleConfig extends

[GitHub] [calcite] zabetak commented on a diff in pull request #2915: [CALCITE-5293] Support general set operators in PruneEmptyRules

zabetak commented on code in PR #2915: URL: https://github.com/apache/calcite/pull/2915#discussion_r976486206 ## core/src/main/java/org/apache/calcite/rel/rules/PruneEmptyRules.java: ## @@ -94,7 +94,7 @@ public interface Config extends RelRule.Config { public static final

[GitHub] [calcite] tjbanghart commented on a diff in pull request #2913: [CALCITE-5180] Implement BigQuery TIME_TRUNC and TIMESTAMP_TRUNC functions

tjbanghart commented on code in PR #2913: URL: https://github.com/apache/calcite/pull/2913#discussion_r975975647 ## core/src/test/java/org/apache/calcite/test/SqlValidatorTest.java: ## @@ -4083,6 +4083,55 @@ void subTestIntervalSecondNegative() { .fails("(?s).*Was

[GitHub] [calcite] julianhyde commented on a diff in pull request #2913: [CALCITE-5180] Implement BigQuery TIME_TRUNC and TIMESTAMP_TRUNC functions

julianhyde commented on code in PR #2913: URL: https://github.com/apache/calcite/pull/2913#discussion_r975915626 ## testkit/src/main/java/org/apache/calcite/sql/parser/SqlParserTest.java: ## @@ -520,7 +520,9 @@ public class SqlParserTest { "TEMPORARY",

[GitHub] [calcite] libenchao commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r975277091 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount =

[GitHub] [calcite] zabetak commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r975066157 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount =

[GitHub] [calcite] zabetak commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r975061171 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount =

[GitHub] [calcite] alex-plekhanov commented on a diff in pull request #2912: [CALCITE-5288] '(a > 1 and a < 3) or (a > 2 and a < 4)' can't be simplified

alex-plekhanov commented on code in PR #2912: URL: https://github.com/apache/calcite/pull/2912#discussion_r974920016 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -1243,6 +1243,13 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] libenchao commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r974896291 ## core/src/main/java/org/apache/calcite/sql2rel/RelFieldTrimmer.java: ## @@ -481,6 +481,18 @@ public TrimResult trimFields( final int fieldCount =

[GitHub] [calcite] tjbanghart commented on a diff in pull request #2913: [CALCITE-5180] Implement BigQuery TIME_TRUNC and TIMESTAMP_TRUNC functions

tjbanghart commented on code in PR #2913: URL: https://github.com/apache/calcite/pull/2913#discussion_r974859878 ## core/src/main/java/org/apache/calcite/prepare/CalciteCatalogReader.java: ## @@ -91,7 +91,10 @@ public class CalciteCatalogReader implements Prepare.CatalogReader

[GitHub] [calcite] chunweilei commented on a diff in pull request #2912: [CALCITE-5288] '(a > 1 and a < 3) or (a > 2 and a < 4)' can't be simplified

chunweilei commented on code in PR #2912: URL: https://github.com/apache/calcite/pull/2912#discussion_r974817088 ## core/src/test/java/org/apache/calcite/rex/RexProgramTest.java: ## @@ -1243,6 +1243,13 @@ private void checkExponentialCnf(int n) {

[GitHub] [calcite] chunweilei commented on a diff in pull request #2891: [CALCITE-5260] Pop the last RelNode added into the bindings list when failing to apply a rule

chunweilei commented on code in PR #2891: URL: https://github.com/apache/calcite/pull/2891#discussion_r974815308 ## core/src/main/java/org/apache/calcite/plan/hep/HepPlanner.java: ## @@ -614,7 +615,7 @@ private List getVertexParents(HepRelVertex vertex) { private static

[GitHub] [calcite] libenchao closed pull request #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…

libenchao closed pull request #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF… URL: https://github.com/apache/calcite/pull/2895 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] zabetak commented on a diff in pull request #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2911: URL: https://github.com/apache/calcite/pull/2911#discussion_r974202268 ## core/src/main/java/org/apache/calcite/rex/RexUtil.java: ## @@ -2232,6 +2232,16 @@ public static boolean containsCorrelation(RexNode condition) { } } +

[GitHub] [calcite] libenchao commented on pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao commented on PR #2813: URL: https://github.com/apache/calcite/pull/2813#issuecomment-1250211634 https://github.com/apache/calcite/pull/2911 has been opened, so I'm closing this now. -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [calcite] libenchao closed pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao closed pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis… URL: https://github.com/apache/calcite/pull/2813 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [calcite] libenchao opened a new pull request, #2911: [CALCITE-5127] Error when executing query with subquery in select lis…

libenchao opened a new pull request, #2911: URL: https://github.com/apache/calcite/pull/2911 …t that uses outer column of array type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [calcite] libenchao closed pull request #2907: [CALCITE-3129] Update site/README.md about how to release the site

libenchao closed pull request #2907: [CALCITE-3129] Update site/README.md about how to release the site URL: https://github.com/apache/calcite/pull/2907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [calcite] l4wei opened a new pull request, #2910: [CALCITE-5265] Select operator' parentheses should be same with Union operator

l4wei opened a new pull request, #2910: URL: https://github.com/apache/calcite/pull/2910 remove necessary parentheses on select clause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] birschick-bq commented on pull request #1766: [CALCITE-3745] UnitCompiler can not find required class information.

birschick-bq commented on PR #1766: URL: https://github.com/apache/calcite/pull/1766#issuecomment-1249583288 @Fanoid Just checking in to see if a newer version resolved your issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [calcite] AjinkyaTaranekar commented on pull request #2902: [CALCITE-5275] Release Calcite 1.32.0

AjinkyaTaranekar commented on PR #2902: URL: https://github.com/apache/calcite/pull/2902#issuecomment-1249207194 Hello @julianhyde, SQL [Docs](https://calcite.apache.org/docs/reference.html) are not available at the moment, it says > Not Found > The requested URL was not found

[GitHub] [calcite] Mahesh-Raut closed pull request #2908: Ravtdbq 117 - support for hashrow with multiple arguments

Mahesh-Raut closed pull request #2908: Ravtdbq 117 - support for hashrow with multiple arguments URL: https://github.com/apache/calcite/pull/2908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] libenchao commented on pull request #2907: [CALCITE-3129] Update site/README.md about how to release the site

libenchao commented on PR #2907: URL: https://github.com/apache/calcite/pull/2907#issuecomment-1248118430 @zabetak Thanks for your comment, I merged these two parts now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] viliam-durina commented on pull request #2906: [CALCITE-5285] Preventing CalcReduceExpressionsRule to transform to self

viliam-durina commented on PR #2906: URL: https://github.com/apache/calcite/pull/2906#issuecomment-1246739292 Shouldn't we also add a check that will fail in case `call.transformTo` is supposed to transform to a deep-equal relnode, if this is not allowed in general? -- This is an

[GitHub] [calcite] krzysztofslusarski opened a new pull request, #2906: [CALCITE-5285] Preventing CalcReduceExpressionsRule to transform to self

krzysztofslusarski opened a new pull request, #2906: URL: https://github.com/apache/calcite/pull/2906 Fixing https://issues.apache.org/jira/browse/CALCITE-5285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] Aitozi commented on pull request #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

Aitozi commented on PR #2901: URL: https://github.com/apache/calcite/pull/2901#issuecomment-1242679549 Hi @danny0405 @julianhyde please help review when you are free, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [calcite] asfgit merged pull request #2903: (do not merge)

asfgit merged PR #2903: URL: https://github.com/apache/calcite/pull/2903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] vvysotskyi closed pull request #2286: [CALCITE-4423] Add method to pass incoming trait in JdbcRules

vvysotskyi closed pull request #2286: [CALCITE-4423] Add method to pass incoming trait in JdbcRules URL: https://github.com/apache/calcite/pull/2286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [calcite] aymeric-dispa opened a new pull request, #2904: [CALCITE-5279] Fix asymmetric keyword not supported by Firebolt

aymeric-dispa opened a new pull request, #2904: URL: https://github.com/apache/calcite/pull/2904 Jira ticket: https://issues.apache.org/jira/browse/CALCITE-5279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] asfgit closed pull request #2893: [CALCITE-5262] Add WKB, EWKB, GeoJSON, and GML support

asfgit closed pull request #2893: [CALCITE-5262] Add WKB, EWKB, GeoJSON, and GML support URL: https://github.com/apache/calcite/pull/2893 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [calcite] asfgit closed pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

asfgit closed pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter URL: https://github.com/apache/calcite/pull/2896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] asfgit closed pull request #2878: [CALCITE-5241] Implement CHAR function

asfgit closed pull request #2878: [CALCITE-5241] Implement CHAR function URL: https://github.com/apache/calcite/pull/2878 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [calcite] rubenada merged pull request #2898: [CALCITE-5274] Improve DocumentBuilderFactory in DiffRepository test class by using secure features

rubenada merged PR #2898: URL: https://github.com/apache/calcite/pull/2898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] rubenada merged pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

rubenada merged PR #2899: URL: https://github.com/apache/calcite/pull/2899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] Aitozi opened a new pull request, #2901: [CALCITE-5264] Apply hint exclusion check for all rels in the RelOptCall

Aitozi opened a new pull request, #2901: URL: https://github.com/apache/calcite/pull/2901 This PR is meant to apply hint exclusion check for all rels in the RelOptCall. This will help to cover the case that the hint exclusion is attatched not on the rel root. -- This is an automated

[GitHub] [calcite] thomasrebele commented on pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

thomasrebele commented on PR #2899: URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240661122 Seems that we have different definitions of simple code ;) I have the impression that an `IdentityHashMap` and an `ArrayList` is a bit easier to understand than a `LinkedHashMap`

[GitHub] [calcite] dgloeckner opened a new pull request, #2900: CALCITE-5227: add a test case for very wide SELECTs

dgloeckner opened a new pull request, #2900: URL: https://github.com/apache/calcite/pull/2900 This is a test case for https://issues.apache.org/jira/browse/CALCITE-5227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] rubenada commented on pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

rubenada commented on PR #2899: URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240569016 @thomasrebele the code is arguably simpler. There is no need to maintain two different data structures (a map plus a list), just a single map fulfills all our needs. IMO this is less

[GitHub] [calcite] thomasrebele commented on pull request #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

thomasrebele commented on PR #2899: URL: https://github.com/apache/calcite/pull/2899#issuecomment-1240487900 Thanks for the PR! What's the advantage of using a `LinkedHashMap` and `Equivalence.Identity` compared to a simple `ArrayList` containing the `ParameterExpression`s in the order

[GitHub] [calcite] rubenada opened a new pull request, #2899: [CALCITE-5277] Make EnumerableRelImplementor stashedParameters order deterministic to increase BINDABLE_CACHE hit rate

rubenada opened a new pull request, #2899: URL: https://github.com/apache/calcite/pull/2899 More info: [CALCITE-5277](https://issues.apache.org/jira/browse/CALCITE-5277) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [calcite] rubenada opened a new pull request, #2898: [CALCITE-5274] Improve DocumentBuilderFactory in DiffRepository test class by using secure features

rubenada opened a new pull request, #2898: URL: https://github.com/apache/calcite/pull/2898 [[CALCITE-5274](https://issues.apache.org/jira/browse/CALCITE-5274)] Improve DocumentBuilderFactory in DiffRepository test class by using secure features -- This is an automated message from the

[GitHub] [calcite] julianhyde merged pull request #2888: [CALCITE-5251] Support SQL hint for Snapshot

julianhyde merged PR #2888: URL: https://github.com/apache/calcite/pull/2888 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] rubenada merged pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

rubenada merged PR #2892: URL: https://github.com/apache/calcite/pull/2892 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r965255752 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable

[GitHub] [calcite] pjfanning commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

pjfanning commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r965221384 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final

[GitHub] [calcite] tjbanghart commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

tjbanghart commented on PR #2896: URL: https://github.com/apache/calcite/pull/2896#issuecomment-1239596312 Thanks for taking a look. I added a simple unit test in `RelToSqlConverterTest`. I think that should be sufficient but please let me know if it needs more. -- This is an automated

[GitHub] [calcite] bchapuis commented on pull request #2893: [CALCITE-5262] Add WKB, EWKB, GeoJSON, and GML support

bchapuis commented on PR #2893: URL: https://github.com/apache/calcite/pull/2893#issuecomment-1239445331 In addition to the support for WKB, EWKB, GeoJSON, and GML, this PR adds support for a lot of the simplest ST_ functions. Most of the test cases have been adapted from examples found in

[GitHub] [calcite-avatica] Privitar closed pull request #180: Dpp 6545 performance

Privitar closed pull request #180: Dpp 6545 performance URL: https://github.com/apache/calcite-avatica/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [calcite] zabetak commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

zabetak commented on PR #2896: URL: https://github.com/apache/calcite/pull/2896#issuecomment-1239232332 @tjbanghart The best place to add tests about the change is `RelToSqlConverterTest`. Please verify that generated queries actually run in `Firebolt`. -- This is an automated message

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r964484381 ## core/src/test/java/org/apache/calcite/test/SqlXmlFunctionsTest.java: ## @@ -36,6 +39,23 @@ */ class SqlXmlFunctionsTest { + private static final String XML =

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r964468020 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable

[GitHub] [calcite] JiajunBernoulli commented on pull request #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

JiajunBernoulli commented on PR #2896: URL: https://github.com/apache/calcite/pull/2896#issuecomment-1238822070 @tjbanghart , would you please add some unit tests? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [calcite] pjfanning commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

pjfanning commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r964299383 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,13 +67,41 @@ public class XmlFunctions { private static final

[GitHub] [calcite] tjbanghart opened a new pull request, #2896: [CALCITE-5270] Make Firebolt dialect return false for supportsAggregateFunctionFilter

tjbanghart opened a new pull request, #2896: URL: https://github.com/apache/calcite/pull/2896 Firebolt does not support filter clauses in aggregate functions. e.g. COUNT(*) FILTER (WHERE a = 2). The [dialect

[GitHub] [calcite] exceptionfactory commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

exceptionfactory commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r964108841 ## core/src/test/java/org/apache/calcite/test/SqlXmlFunctionsTest.java: ## @@ -36,6 +39,23 @@ */ class SqlXmlFunctionsTest { + private static final

[GitHub] [calcite] zhuwenzhuang commented on pull request #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…

zhuwenzhuang commented on PR #2895: URL: https://github.com/apache/calcite/pull/2895#issuecomment-1238273162 > I checked the history. The rule is introduced from Druid[1], in which newCasts is used. It may be better to correct it instead of removing it. > > [1]

[GitHub] [calcite] zabetak commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

zabetak commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r963555806 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,11 +67,24 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable

[GitHub] [calcite] zabetak commented on a diff in pull request #2813: [CALCITE-5127] Error when executing query with subquery in select lis…

zabetak commented on code in PR #2813: URL: https://github.com/apache/calcite/pull/2813#discussion_r963398493 ## core/src/main/java/org/apache/calcite/rel/core/Project.java: ## @@ -137,20 +163,27 @@ protected Project(RelInput input) { * @param input Input * @param

[GitHub] [calcite] zhuwenzhuang opened a new pull request, #2895: [CALCITE-5267] Remove useless variable 'newCasts' in AggregateCaseToF…

zhuwenzhuang opened a new pull request, #2895: URL: https://github.com/apache/calcite/pull/2895 Remove useless variable 'newCasts' in AggregateCaseToFilter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r963054866 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -60,11 +67,24 @@ public class XmlFunctions { private static final ThreadLocal<@Nullable

[GitHub] [calcite] rubenada commented on a diff in pull request #2892: [CALCITE-5263] Improve XmlFunctions by using an XML DocumentBuilder

rubenada commented on code in PR #2892: URL: https://github.com/apache/calcite/pull/2892#discussion_r963051308 ## core/src/main/java/org/apache/calcite/runtime/XmlFunctions.java: ## @@ -215,6 +238,27 @@ private static String convertNodeToString(Node node) throws

<    4   5   6   7   8   9   10   11   12   13   >