absurdfarce merged PR #1916:
URL: https://github.com/apache/cassandra-java-driver/pull/1916
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsu
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2052308036
Squashed to one commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2049909475
Hi, I reverted the revert of the revert and it should be good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
adutra commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2046000161
Yes, I'd also say let's go back to f3b7007bf54a4287eeda132567c7dc52e4325896
for now and revisit the need for weak references later.
--
This is an automated message from t
absurdfarce commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2045980061
Ah, excellent point @adutra ... you're absolutely right. I forgot that we
also made that change to specifically enable weak references but yeah, without
that change th
adutra commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2045772779
@absurdfarce it looks like we reverted not only the commit that made the
suppliers members of the corresponding updaters; but also the commit that made
the gauges contain we
absurdfarce commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2043691203
Added this note to CASSANDRA-19457, mentioning it here as well. I tested a
3x2 matrix of Micrometer, MicroProfile and the default (Dropwizard) case
against stock 4.18.
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2043477828
Thank you @adutra , test added! Pending for review
I thought Dropwizard was not leaking. To my surprise, all three failed this
test before our fix. They all passed
absurdfarce commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2043079384
Big 👍 to @adutra 's suggestion above. I was thinking about this a bit after
we last talked about it @SiyaoIsHiding. We don't need to test the OOM
directly; in this ca
adutra commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2041040707
> Do you have any suggestions on how we should write the unit test for this?
I don't think you need GC for this, it would be enough to check that the
metrics were clea
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2040457259
Hi @adutra, Last time I fixed a memory leak issue, we tried but we didn't
find a good way to write a unit test for it, because garbage collector's
behavior may not be
adutra commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2040229611
Also would you mind modifying the test here:
https://github.com/apache/cassandra-java-driver/blob/16260261d3df50fcf24fac1fc2d37896c4a111bf/integration-tests/src/test/j
adutra commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2040209708
Thanks @SiyaoIsHiding for taking the time to apply my suggestions!
The code changes LGTM.
> 1. I tried hard, but I could not find an example of how to use
Micro
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2030578292
Questions:
1. I tried hard, but I could not find an example of how to use MicroProfile
with our driver, especially how to instantiate a MicroProfile registry. May I
SiyaoIsHiding commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2030236325
I just realized there is already such a method doing the same thing:
https://github.com/apache/cassandra-java-driver/blob/98e25040f5e69db1092ccafb6665d8e92779cc46/m
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532813593
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected vo
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532813593
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected vo
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532801560
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerNodeMetricUpdater.java:
##
@@ -31,13 +31,18 @@
import i
absurdfarce commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532705838
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protect
absurdfarce commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532689998
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerSessionMetricUpdater.java:
##
@@ -30,22 +30,28 @@
absurdfarce commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532687869
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerNodeMetricUpdater.java:
##
@@ -31,13 +31,18 @@
imp
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532412536
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected vo
adutra commented on code in PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#discussion_r1532412536
##
metrics/micrometer/src/main/java/com/datastax/oss/driver/internal/metrics/micrometer/MicrometerMetricUpdater.java:
##
@@ -100,7 +100,10 @@ protected vo
absurdfarce commented on PR #1916:
URL:
https://github.com/apache/cassandra-java-driver/pull/1916#issuecomment-2007673373
@adutra When you have some time would you mind taking a look at this one?
This came up from an internal DataStax investigation but given the nature of
the issue I'm gu
24 matches
Mail list logo
