[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-26 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045933#comment-17045933 ] David Capwell commented on CASSANDRA-15553: --- I like the use of blocking filters, glad we

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-26 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045773#comment-17045773 ] Blake Eggleston commented on CASSANDRA-15553: - +1, and thanks for addressing each point

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-25 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044977#comment-17044977 ] David Capwell commented on CASSANDRA-15553: --- Spoke to Marcus. I am fine with this patch

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-25 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044304#comment-17044304 ] Marcus Eriksson commented on CASSANDRA-15553: - Pushed another

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-24 Thread Marcus Eriksson (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043222#comment-17043222 ] Marcus Eriksson commented on CASSANDRA-15553: - bq. CassandraValidationIterator.java:61 -

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-19 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040575#comment-17040575 ] David Capwell commented on CASSANDRA-15553: --- If compaction only compacted <= "largest

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-19 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040573#comment-17040573 ] David Capwell commented on CASSANDRA-15553: --- That would be fine; min is still smaller than

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-19 Thread Blake Eggleston (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040546#comment-17040546 ] Blake Eggleston commented on CASSANDRA-15553: - {quote}assuming compaction also maintains

[jira] [Commented] (CASSANDRA-15553) Preview repair should include sstables from finalized incremental repair sessions

2020-02-19 Thread David Capwell (Jira)
[ https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040506#comment-17040506 ] David Capwell commented on CASSANDRA-15553: --- Took a look and had to look closer at IR