[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045933#comment-17045933
]
David Capwell commented on CASSANDRA-15553:
---
I like the use of blocking filters, glad we
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17045773#comment-17045773
]
Blake Eggleston commented on CASSANDRA-15553:
-
+1, and thanks for addressing each point
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044977#comment-17044977
]
David Capwell commented on CASSANDRA-15553:
---
Spoke to Marcus. I am fine with this patch
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17044304#comment-17044304
]
Marcus Eriksson commented on CASSANDRA-15553:
-
Pushed another
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17043222#comment-17043222
]
Marcus Eriksson commented on CASSANDRA-15553:
-
bq. CassandraValidationIterator.java:61 -
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040575#comment-17040575
]
David Capwell commented on CASSANDRA-15553:
---
If compaction only compacted <= "largest
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040573#comment-17040573
]
David Capwell commented on CASSANDRA-15553:
---
That would be fine; min is still smaller than
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040546#comment-17040546
]
Blake Eggleston commented on CASSANDRA-15553:
-
{quote}assuming compaction also maintains
[
https://issues.apache.org/jira/browse/CASSANDRA-15553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17040506#comment-17040506
]
David Capwell commented on CASSANDRA-15553:
---
Took a look and had to look closer at IR