[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449204#comment-17449204
]
Andres de la Peña commented on CASSANDRA-17167:
---
No worries :). `View*Test` contains a
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449183#comment-17449183
]
Berenguer Blasi commented on CASSANDRA-17167:
-
Ah sorry I was out for lunch otherwise I
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449157#comment-17449157
]
Andres de la Peña commented on CASSANDRA-17167:
---
Both PRs look good to me. With the
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17449145#comment-17449145
]
Berenguer Blasi commented on CASSANDRA-17167:
-
[~adelapena] latest review comments
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448690#comment-17448690
]
Andres de la Peña commented on CASSANDRA-17167:
---
{quote}I also pushed trunk. The only
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448453#comment-17448453
]
Berenguer Blasi commented on CASSANDRA-17167:
-
Ah that dup code in
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17448002#comment-17448002
]
Andres de la Peña commented on CASSANDRA-17167:
---
> So big refactor vs some minor code
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447969#comment-17447969
]
Berenguer Blasi commented on CASSANDRA-17167:
-
I reached similar conclusions to you.
I
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447958#comment-17447958
]
Andres de la Peña commented on CASSANDRA-17167:
---
+1 to splitting those tests. Not sure
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447603#comment-17447603
]
Andres de la Peña commented on CASSANDRA-17167:
---
Sure, I'll take a look
> ViewTests
[
https://issues.apache.org/jira/browse/CASSANDRA-17167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17447344#comment-17447344
]
Berenguer Blasi commented on CASSANDRA-17167:
-
Note for the reviewer:
[~adelapena]
11 matches
Mail list logo