[GitHub] rhtyd closed pull request #2662: ui: Fixes #2558 use POST for uploadSslCert API request (#2661)

rhtyd closed pull request #2662: ui: Fixes #2558 use POST for uploadSslCert API request (#2661) URL: https://github.com/apache/cloudstack/pull/2662 This is an automated message from the Apache Git Service. To respond to the

[GitHub] rhtyd closed issue #2558: API uploadSslCert does not work

rhtyd closed issue #2558: API uploadSslCert does not work URL: https://github.com/apache/cloudstack/issues/2558 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[cloudstack] 01/01: Merge apache/4.11

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ea373eb1e5d73626427e9cb36248869613ba53e3 Merge: ada1e73 eb23d91 Author: Rohit Yadav AuthorDate: Wed May 23 09:36:03 2

[cloudstack] branch master updated (ada1e73 -> ea373eb)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from ada1e73 Merge branch '4.11' add eb23d91 ui: Fixes #2558 use POST for uploadSslCert API request (#2661)

[GitHub] rhtyd opened a new pull request #2662: ui: Fixes #2558 use POST for uploadSslCert API request (#2661)

rhtyd opened a new pull request #2662: ui: Fixes #2558 use POST for uploadSslCert API request (#2661) URL: https://github.com/apache/cloudstack/pull/2662 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functio

[GitHub] rhtyd closed pull request #2661: Make uploadSslCert a POST request instead of a GET

rhtyd closed pull request #2661: Make uploadSslCert a POST request instead of a GET URL: https://github.com/apache/cloudstack/pull/2661 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[cloudstack] branch 4.11 updated: ui: Fixes #2558 use POST for uploadSslCert API request (#2661)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new eb23d91 ui: Fixes #2558 use POST for uploadSslCe

[GitHub] rhtyd commented on issue #2661: Make uploadSslCert a POST request instead of a GET

rhtyd commented on issue #2661: Make uploadSslCert a POST request instead of a GET URL: https://github.com/apache/cloudstack/pull/2661#issuecomment-391213318 Lgtm, UI fix. Will merge. This is an automated message from the Ap

[GitHub] Jazz9 commented on issue #2650: Ceph RBD Feature flag update

Jazz9 commented on issue #2650: Ceph RBD Feature flag update URL: https://github.com/apache/cloudstack/issues/2650#issuecomment-391182904 I think it might be best to leave the default action as it currently is. Should we have a global setting for ceph.clone.rbdfeaturecode? Sent from

[GitHub] GabrielBrascher commented on issue #2558: API uploadSslCert does not work

GabrielBrascher commented on issue #2558: API uploadSslCert does not work URL: https://github.com/apache/cloudstack/issues/2558#issuecomment-391177759 We are making a GET request, not a POST. I created PR [2661](https://github.com/apache/cloudstack/pull/2661) to fix it. ---

[GitHub] GabrielBrascher opened a new pull request #2661: Make uploadSslCert a POST request instead of a GET

GabrielBrascher opened a new pull request #2661: Make uploadSslCert a POST request instead of a GET URL: https://github.com/apache/cloudstack/pull/2661 If the Request Header Size grows (for instance a cert chain of 8kb) it will fail to upload the SSL Cert. This problem was raised on

[GitHub] PaulAngus commented on issue #2545: dedicatePublicIpRange to domain doesn't work

PaulAngus commented on issue #2545: dedicatePublicIpRange to domain doesn't work URL: https://github.com/apache/cloudstack/issues/2545#issuecomment-391125196 I've confirmed that this behaviour used to work in 4.9.3 (projects would use IP dedicated to the domain that the project was in) and

[GitHub] rafaelweingartner commented on a change in pull request #2660: Macaddresses

rafaelweingartner commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189961784 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAd

[GitHub] khos2ow commented on issue #2649: Catch error in Debian packaging script and fail the build

khos2ow commented on issue #2649: Catch error in Debian packaging script and fail the build URL: https://github.com/apache/cloudstack/pull/2649#issuecomment-391000806 @rhtyd the fact that debian build is failing on BO might actually be a good result, that the proposed enhancement in this P

[GitHub] DaanHoogland commented on a change in pull request #2660: Macaddresses

DaanHoogland commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189909270 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAddress

[GitHub] wido commented on issue #2650: Ceph RBD Feature flag update

wido commented on issue #2650: Ceph RBD Feature flag update URL: https://github.com/apache/cloudstack/issues/2650#issuecomment-390987002 @Jazz9 Creating is handled by libvirt, but the cloning function wasn't implemented before Ubuntu 16.04 was released. I didn't check CentOS 7, but I assum

[GitHub] Jazz9 commented on issue #2650: Ceph RBD Feature flag update

Jazz9 commented on issue #2650: Ceph RBD Feature flag update URL: https://github.com/apache/cloudstack/issues/2650#issuecomment-390973418 O no! How are the new volumes created? They seem to get the correct feature flags. Kind regards, Glen Baars From: Wido den Hollander Sen

[GitHub] sureshanaparti commented on issue #2659: removed unused code in snapshotDao

sureshanaparti commented on issue #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#issuecomment-390970602 @DaanHoogland Not related to dao. I observed that the Event "BackedupToSecondary" in _Snapshot_ class is never used. Please take a look and

[GitHub] wido commented on issue #2650: Ceph RBD Feature flag update

wido commented on issue #2650: Ceph RBD Feature flag update URL: https://github.com/apache/cloudstack/issues/2650#issuecomment-390968920 I just found out, libvirt in Ubuntu 16.04 doesn't support this yet, so it will take a long time (years) before we can put this upstream as we have to sup

[GitHub] wido commented on issue #2657: KVM hosts are being reset by a script

wido commented on issue #2657: KVM hosts are being reset by a script URL: https://github.com/apache/cloudstack/issues/2657#issuecomment-390968718 The main problem is that it is hard to determine if the host isn't responding or that something else is going on. You do not want the VM t

[cloudstack] 01/01: Merge branch '4.11'

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git commit ada1e730c82da2ffd9c565a43c1617aff920ad89 Merge: 9c1eabf 8b09620 Author: Rohit Yadav AuthorDate: Tue May 22 17:03:24 2

[cloudstack] branch 4.11 updated: CLOUDSTACK-10276: listVolumes not working when storage UUID is not a UUID (#2639)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a commit to branch 4.11 in repository https://gitbox.apache.org/repos/asf/cloudstack.git The following commit(s) were added to refs/heads/4.11 by this push: new 8b09620 CLOUDSTACK-10276: listVolumes not workin

[cloudstack] branch master updated (9c1eabf -> ada1e73)

This is an automated email from the ASF dual-hosted git repository. rohit pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/cloudstack.git. from 9c1eabf Merge branch '4.11' add 8b09620 CLOUDSTACK-10276: listVolumes not working when storage UUID is not

[GitHub] blueorangutan commented on issue #2660: Macaddresses

blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390956360 Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2075 This is an automated message from the Apache

[GitHub] DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao

DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189864373 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -214,26 +183,6

[GitHub] DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao

DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189864397 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -253,41 +202,6

[GitHub] DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao

DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189864415 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -253,41 +202,6

[GitHub] DaanHoogland commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID

DaanHoogland commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390955253 @rafaelweingartner I am fine with merging this so far as we don't allow for manually entering a non-u

[GitHub] blueorangutan commented on issue #2659: removed unused code in snapshotDao

blueorangutan commented on issue #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#issuecomment-390950430 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[GitHub] DaanHoogland commented on issue #2659: removed unused code in snapshotDao

DaanHoogland commented on issue #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#issuecomment-390950370 @blueorangutan package This is an automated message from the Apache Git Servi

[GitHub] rafaelweingartner commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid

rafaelweingartner commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189858968 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java ###

[GitHub] rafaelweingartner commented on a change in pull request #2660: Macaddresses

rafaelweingartner commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189857791 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAd

[GitHub] DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao

DaanHoogland commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189857894 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -253,41 +202,6

[GitHub] DaanHoogland commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid

DaanHoogland commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189857586 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java ##

[GitHub] blueorangutan commented on issue #2660: Macaddresses

blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390947798 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390947600 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland commented on a change in pull request #2660: Macaddresses

DaanHoogland commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189856988 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAddress

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390932472 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] rafaelweingartner commented on a change in pull request #2659: removed unused code in snapshotDao

rafaelweingartner commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189846178 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -214,26 +

[GitHub] rafaelweingartner commented on a change in pull request #2659: removed unused code in snapshotDao

rafaelweingartner commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189846308 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -253,41 +

[GitHub] rafaelweingartner commented on a change in pull request #2659: removed unused code in snapshotDao

rafaelweingartner commented on a change in pull request #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#discussion_r189846471 ## File path: engine/schema/src/main/java/com/cloud/storage/dao/SnapshotDaoImpl.java ## @@ -253,41 +

[GitHub] rafaelweingartner commented on a change in pull request #2660: Macaddresses

rafaelweingartner commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189844708 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAd

[GitHub] DaanHoogland commented on a change in pull request #2660: Macaddresses

DaanHoogland commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189841833 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAddress

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390932472 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID

rafaelweingartner commented on issue #2639: [CLOUDSTACK-10276] listVolumes not working when storage UUID is not a UUID URL: https://github.com/apache/cloudstack/pull/2639#issuecomment-390929227 I really do not see any other smaller/simpler solution for this issue. Moreover, it does not aff

[GitHub] rafaelweingartner commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid

rafaelweingartner commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189836738 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java ###

[GitHub] rafaelweingartner commented on a change in pull request #2660: Macaddresses

rafaelweingartner commented on a change in pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#discussion_r189834173 ## File path: utils/src/test/java/com/cloud/utils/net/MacAddressTest.java ## @@ -51,10 +52,11 @@ public final void testMacAd

[GitHub] blueorangutan commented on issue #2660: Macaddresses

blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390918511 Packaging result: ✖centos6 ✖centos7 ✖debian. JID-2074 This is an automated message from the Apache

[GitHub] blueorangutan commented on issue #2659: removed unused code in snapshotDao

blueorangutan commented on issue #2659: removed unused code in snapshotDao URL: https://github.com/apache/cloudstack/pull/2659#issuecomment-390918506 Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2073 This is an automated m

[GitHub] blueorangutan commented on issue #2660: Macaddresses

blueorangutan commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390910591 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. --

[GitHub] DaanHoogland commented on issue #2660: Macaddresses

DaanHoogland commented on issue #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660#issuecomment-390910499 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] DaanHoogland opened a new pull request #2660: Macaddresses

DaanHoogland opened a new pull request #2660: Macaddresses URL: https://github.com/apache/cloudstack/pull/2660 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-

[GitHub] blueorangutan commented on issue #2659: removed unused code

blueorangutan commented on issue #2659: removed unused code URL: https://github.com/apache/cloudstack/pull/2659#issuecomment-390910283 @DaanHoogland a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. ---

[GitHub] DaanHoogland commented on issue #2659: removed unused code

DaanHoogland commented on issue #2659: removed unused code URL: https://github.com/apache/cloudstack/pull/2659#issuecomment-390910097 @blueorangutan package This is an automated message from the Apache Git Service. To respond

[GitHub] DaanHoogland opened a new pull request #2659: removed unused code

DaanHoogland opened a new pull request #2659: removed unused code URL: https://github.com/apache/cloudstack/pull/2659 ## Description ## Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New featur

[GitHub] DaanHoogland commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid

DaanHoogland commented on a change in pull request #2653: Generate MAC address if the MAC in command addNicToVirtualMachine is invalid URL: https://github.com/apache/cloudstack/pull/2653#discussion_r189795031 ## File path: server/src/com/cloud/vm/UserVmManagerImpl.java ##