brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-439022502
> Was @jcesarmobile's feedback on how to merge or not merge this taken into
account?
I think the edit was too late. No
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438847411
Thanks @jcesarmobile for the detailed review!
This is an aut
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438788760
@janpio I was thinking to do a merge commit to keep the cleanup changes
separate from the behavior change. I think it makes i
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438768035
I just added these changes to PR #555 on 7.x for a patch release, hope we
can make it soon!
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438765761
Just removed the comment, my bad.
This is an automated messa
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438732150
> `app/src/main` is used multiple times, might be worth to put it in a
variable
Done. CanI get a final approval to mer
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438714101
I think the primary rule should be to place files based on target-dir
prefix, i.e. `app` vs `src` vs `lib`, and extensions sh
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438665079
> [...] it also has `.h` and `.c` files that are treated as `.java` files.
> They were `src/c/common/mylib/parts` and he up
brodybits commented on issue #550: Fix for old plugins with non-Java sources
(GH-547)
URL: https://github.com/apache/cordova-android/pull/550#issuecomment-438480204
> `app/src/main` is used multiple times, might be worth to put it in a
variable
I can do this, would favor doing the s
