dependabot[bot] opened a new pull request, #1279:
URL: https://github.com/apache/curator/pull/1279
Bumps org.apache.zookeeper:zookeeper from 3.5.7 to 3.8.4.
[ {
}
fapifta commented on PR #1278:
URL: https://github.com/apache/curator/pull/1278#issuecomment-3271534299
@kezhuw Thank you for your review, I added to the JavaDoc of the
Builder#runSafeService method, and changed the approach the close waits for
these executors to be closed.
I hope the te
fapifta commented on code in PR #1278:
URL: https://github.com/apache/curator/pull/1278#discussion_r2334227217
##
curator-framework/src/main/java/org/apache/curator/framework/imps/CuratorFrameworkImpl.java:
##
@@ -383,6 +385,16 @@ public void close() {
}
kezhuw commented on issue #1276:
URL: https://github.com/apache/curator/issues/1276#issuecomment-3264318813
> I think curator(actually internal zookeeper client) will not try to
connect server after it retry 3 times and connectionTimeout，but actually I see
the log file，zk client seems not c
fapifta opened a new pull request, #1278:
URL: https://github.com/apache/curator/pull/1278
CURATOR-495 introduced a new runSafeService field in CuratorFrameworkImpl
class, and this field is either initialized by an external ExecutorService via
the builder, or it is created internally within
fapifta opened a new issue, #1277:
URL: https://github.com/apache/curator/issues/1277
[CURATOR-495](https://github.com/apache/curator/issues/1015) introduced a
new runSafeService field in CuratorFrameworkImpl class, and this field is
either initialized by an external ExecutorService via the
fapifta commented on issue #1277:
URL: https://github.com/apache/curator/issues/1277#issuecomment-3264200740
I have posted a PR that adds tests to demonstrate what I think is the
expected behaviour, please let me know what you think.
--
This is an automated message from the Apache Git Ser
RonaldWakeup opened a new issue, #1276:
URL: https://github.com/apache/curator/issues/1276
Hello, I Use curator as follow:
CuratorFrameworkFactory.Builder builder = CuratorFrameworkFactory.builder()
.connectString("xxx") //this xxx includes 5 invalid IP address.
.sessionTimeoutMs(10_
uhoefel commented on issue #1069:
URL: https://github.com/apache/curator/issues/1069#issuecomment-3254140187
Note that adding an automatic module name can be as easy as adding (on the
example of curator-framework)
```xml
maven-jar-plugin
3.4.2
kezhuw merged PR #1275:
URL: https://github.com/apache/curator/pull/1275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
kezhuw closed issue #1222: [CURATOR-707] Builder for InstanceSpec
URL: https://github.com/apache/curator/issues/1222
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kezhuw opened a new pull request, #1275:
URL: https://github.com/apache/curator/pull/1275
It is hard for us to know what does `new InstanceSpec(null, -1, -1, -1,
true, -1, -1, -1)` means now.
Closes #1222.
--
This is an automated message from the Apache Git Service.
To respond to t
kezhuw commented on PR #1274:
URL: https://github.com/apache/curator/pull/1274#issuecomment-3200670250
> Perhaps we can track these possible break changes that helps in a tracking
issue said for 6.0.
I think we can create labels for this ? We should discuss this in dev mail.
--
Thi
kezhuw closed issue #1178: [CURATOR-663]
ZooKeeperServerEmbeddedAdapter.configure might fail with ClassCastException
URL: https://github.com/apache/curator/issues/1178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
kezhuw merged PR #1274:
URL: https://github.com/apache/curator/pull/1274
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
Copilot commented on code in PR #1274:
URL: https://github.com/apache/curator/pull/1274#discussion_r2284098321
##
curator-test/src/main/java/org/apache/curator/test/InstanceSpec.java:
##
@@ -209,11 +209,21 @@ public InstanceSpec(
this.tickTime = (tickTime > 0 ? tickTime
kezhuw opened a new pull request, #1274:
URL: https://github.com/apache/curator/pull/1274
`InstanceSpec`'s `customProperties` will be fed to `Properties` in
`QuorumConfigBuilder::buildConfigProperties`, so we have to make sure it
contains only string values.
Fixes #1178, CURATOR-663.
kezhuw commented on PR #1273:
URL: https://github.com/apache/curator/pull/1273#issuecomment-3195331490
> It's will eat the exception if can't find the ZooKeeperServerEmbeddedImpl
class in some case
I expect this should be covered by:
https://github.com/apache/curator/blob/mast
Copilot commented on code in PR #1273:
URL: https://github.com/apache/curator/pull/1273#discussion_r2256991102
##
curator-test/src/main/java/org/apache/curator/test/ZooKeeperServerEmbeddedAdapter.java:
##
@@ -98,8 +98,9 @@ private boolean hijackClientPort(int port) {
bigduu opened a new pull request, #1273:
URL: https://github.com/apache/curator/pull/1273
…mbeddedAdapter
Add debug log for some specify situation to help developer identify the
issue location
It's will eat the exception if can't find the `ZooKeeperServerEmbeddedImpl`
class in
zhishengzhang commented on PR #382:
URL: https://github.com/apache/curator/pull/382#issuecomment-3111703110
good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kezhuw merged PR #1272:
URL: https://github.com/apache/curator/pull/1272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
kezhuw merged PR #1271:
URL: https://github.com/apache/curator/pull/1271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
kezhuw commented on PR #1272:
URL: https://github.com/apache/curator/pull/1272#issuecomment-3032684806
See also
https://github.com/apache/curator/pull/1252#pullrequestreview-2934052557.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
kezhuw opened a new pull request, #1272:
URL: https://github.com/apache/curator/pull/1272
ZOOKEEPER-4508 reports `SessionExpired` after exhausting session timeout
in session establishment instead of endless retries. It is easy to get
in this now with small session timeout.
Beside
kezhuw opened a new pull request, #1271:
URL: https://github.com/apache/curator/pull/1271
`testAdd`, `testAddAsync` and `testAddAndRemove` asserts that
`EnsembleProvider::setConnectionString` is updated with new connect
string after ensemble changed. Since the update is asynchronous, so
kezhuw closed issue #1251: Upgrade Zookeeper to 3.9.3+
URL: https://github.com/apache/curator/issues/1251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
kezhuw merged PR #1252:
URL: https://github.com/apache/curator/pull/1252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
tisonkun closed issue #1269: Bump Jetty to 9.4.57.v20241219
URL: https://github.com/apache/curator/issues/1269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
tisonkun merged PR #1265:
URL: https://github.com/apache/curator/pull/1265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.a
tisonkun closed issue #1266: Bump com.fasterxml.jackson.core:jackson-core from
2.13.5 to 2.18.1
URL: https://github.com/apache/curator/issues/1266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
tisonkun merged PR #1270:
URL: https://github.com/apache/curator/pull/1270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.a
eolivelli commented on PR #1252:
URL: https://github.com/apache/curator/pull/1252#issuecomment-2977284039
re-running CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
meszinorbi opened a new pull request, #1270:
URL: https://github.com/apache/curator/pull/1270
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
meszinorbi opened a new pull request, #1268:
URL: https://github.com/apache/curator/pull/1268
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
meszinorbi opened a new issue, #1269:
URL: https://github.com/apache/curator/issues/1269
due to CVE-2024-8184, CVE-2024-13009
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
meszinorbi opened a new issue, #1267:
URL: https://github.com/apache/curator/issues/1267
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
meszinorbi commented on issue #1266:
URL: https://github.com/apache/curator/issues/1266#issuecomment-2825320144
#1265 PR contains the needed change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chevaris commented on issue #1152:
URL: https://github.com/apache/curator/issues/1152#issuecomment-2820342131
[ISSUE 1258](https://github.com/apache/curator/issues/1258) is solving
exactly the problem discussed in this ticket.
If you agree I think this ticket could be closed
--
Thi
kezhuw commented on PR #1264:
URL: https://github.com/apache/curator/pull/1264#issuecomment-2818120880
Merged. @chevaris Thank you for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kezhuw closed issue #1263: PersistentTTLNode Thread leak
URL: https://github.com/apache/curator/issues/1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
kezhuw merged PR #1264:
URL: https://github.com/apache/curator/pull/1264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
chevaris commented on PR #1264:
URL: https://github.com/apache/curator/pull/1264#issuecomment-2817734403
I see that zk38 is failing BUT is not related with the changes.
TesPersistentTtlNode are passing properly. Not sure how to proceed
--
This is an automated message from the Apache Git S
chevaris commented on PR #1264:
URL: https://github.com/apache/curator/pull/1264#issuecomment-2815677623
I will provide a fix. Thanks for the heads up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kezhuw commented on PR #1264:
URL: https://github.com/apache/curator/pull/1264#issuecomment-2814503805
Seems that the test fails due to
[ZOOKEEPER-4466](https://issues.apache.org/jira/browse/ZOOKEEPER-4466) which is
only shipped in 3.9. Both `PersistentNode` and `PersistentWatcher`(from tes
meszinorbi opened a new pull request, #1265:
URL: https://github.com/apache/curator/pull/1265
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2047192585
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -237,4 +241,88 @@ void touch() {
}
kezhuw commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2046406661
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -237,4 +241,88 @@ void touch() {
}
}
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2046278696
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -237,4 +241,88 @@ void touch() {
}
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2046275893
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -237,4 +241,88 @@ void touch() {
}
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2046251680
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -237,4 +241,88 @@ void touch() {
}
kezhuw commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2045865526
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -237,4 +241,88 @@ void touch() {
}
}
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2042797049
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -61,12 +61,15 @@ public class PersistentTtlNode implements Cl
kezhuw closed issue #1259: PersistentWatcher no longer be used with namespaced
CuratorFramework instance
URL: https://github.com/apache/curator/issues/1259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kezhuw closed issue #1259: PersistentWatcher no longer be used with namespaced
CuratorFramework instance
URL: https://github.com/apache/curator/issues/1259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
kezhuw merged PR #1262:
URL: https://github.com/apache/curator/pull/1262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
kezhuw commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2034443515
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -61,12 +61,15 @@ public class PersistentTtlNode implements Clos
kezhuw commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2034733188
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -61,12 +61,15 @@ public class PersistentTtlNode implements Clos
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2034683332
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -61,12 +61,15 @@ public class PersistentTtlNode implements Cl
chevaris commented on code in PR #1264:
URL: https://github.com/apache/curator/pull/1264#discussion_r2034683332
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -61,12 +61,15 @@ public class PersistentTtlNode implements Cl
chevaris commented on issue #1263:
URL: https://github.com/apache/curator/issues/1263#issuecomment-2786747717
https://github.com/apache/curator/pull/1264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
chevaris opened a new pull request, #1264:
URL: https://github.com/apache/curator/pull/1264
https://github.com/apache/curator/issues/1263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
kezhuw closed issue #1258: PersistentTTLNode fails to remove node
URL: https://github.com/apache/curator/issues/1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kezhuw closed issue #1258: PersistentTTLNode fails to remove node
URL: https://github.com/apache/curator/issues/1258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
kezhuw merged PR #1260:
URL: https://github.com/apache/curator/pull/1260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
kezhuw merged PR #1261:
URL: https://github.com/apache/curator/pull/1261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@curator.apa
kezhuw commented on PR #1261:
URL: https://github.com/apache/curator/pull/1261#issuecomment-2785404701
Merged. @ryansun96 Thank you for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kezhuw closed issue #1254: Redundant updateValue call in SharedValue?
URL: https://github.com/apache/curator/issues/1254
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
ryansun96 commented on PR #1261:
URL: https://github.com/apache/curator/pull/1261#issuecomment-2784687494
@kezhuw Thank you for the PR! Looks good to me. Sorry for not having my
commits ready sooner - will definitely try to contribute more in the future :)
--
This is an automated message
kezhuw commented on PR #1262:
URL: https://github.com/apache/curator/pull/1262#issuecomment-2782066536
I think we probably could introduce `Runnable listenEvent(CuratorListener
listener)` in long term to deprecate `Listenable
getCuratorListenable()`. This way we gain more control over imple
kezhuw opened a new pull request, #1262:
URL: https://github.com/apache/curator/pull/1262
`NamespaceFacade` does not support `getCuratorListenable` while #520 use it
to listen for `CuratorEventType.CLOSING` to fix CURATOR-729.
This commit exports `CuratorFrameworkBase::client` to retr
kezhuw commented on PR #1261:
URL: https://github.com/apache/curator/pull/1261#issuecomment-2781998090
> I think it's fair to say setValue makes a strong guarantee that after
success, any call to getValue will get some more updated value, whether that
value is set by the same session or a d
kezhuw opened a new pull request, #1261:
URL: https://github.com/apache/curator/pull/1261
Closes #1254.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-ma
kezhuw commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2030395398
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -159,44 +160,45 @@ public PersistentTtlNode(
this.clie
tisonkun closed issue #525: [CURATOR-4] POST_INITIALIZED_EVENT race conditions
/ optimizations
URL: https://github.com/apache/curator/issues/525
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
tisonkun closed issue #1032: [CURATOR-512] Utilize NIO StandardCharsets
URL: https://github.com/apache/curator/issues/1032
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
chevaris commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2025096416
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -187,4 +187,34 @@ public void childEvent(CuratorFramework
tisonkun closed issue #962: [CURATOR-442] System.currentTimeMillis() is used
for timing - use nanos instead
URL: https://github.com/apache/curator/issues/962
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
aelazhary commented on issue #1238:
URL: https://github.com/apache/curator/issues/1238#issuecomment-2741827278
Any updates here @tisonkun ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
tisonkun closed issue #752: [CURATOR-232] Consolidate test code
URL: https://github.com/apache/curator/issues/752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
chevaris commented on issue #1258:
URL: https://github.com/apache/curator/issues/1258#issuecomment-2768571396
Pull request
https://github.com/apache/curator/pull/1260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
tisonkun commented on issue #525:
URL: https://github.com/apache/curator/issues/525#issuecomment-2742666786
PathChildrenCache is now deprecated in favor of CuratorCache. Please check
if the new recipe works.
--
This is an automated message from the Apache Git Service.
To respond to the me
tisonkun commented on issue #1172:
URL: https://github.com/apache/curator/issues/1172#issuecomment-2734937359
Closed as stale. IIRC this is no longer an issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
kotman12 opened a new issue, #1256:
URL: https://github.com/apache/curator/issues/1256
https://github.com/apache/curator/pull/1250 introduced a bug where
`CachedModeledFramework::list` is no longer returning all ancestors of the
_root_ node of the underlying cache and is instead returning t
tisonkun closed issue #983: [CURATOR-463] Update docs to point at Tech Notes
where appropriate
URL: https://github.com/apache/curator/issues/983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
tisonkun commented on PR #1250:
URL: https://github.com/apache/curator/pull/1250#issuecomment-2742476386
@kotman12 Let's removed the unused method in a follow-up PR.
I'm going to merge this PR after CI gree.
--
This is an automated message from the Apache Git Service.
To respond to
kotman12 commented on PR #1257:
URL: https://github.com/apache/curator/pull/1257#issuecomment-2752607147
@kezhuw thanks! A few observations here:
`CachedModeledFramework::list` indeed ignores data hierarchy and returns all
descendants of the base path but this is consistent with the [
tisonkun closed issue #1246: Asynchronously Initialize Cache Before Reading
URL: https://github.com/apache/curator/issues/1246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
kezhuw commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2027109436
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -68,6 +69,7 @@ public class PersistentTtlNode implements Closea
chevaris commented on issue #1258:
URL: https://github.com/apache/curator/issues/1258#issuecomment-2773200110
I provided a new implementation addressing your comments. Check latest commit
https://github.com/apache/curator/pull/1260/files
--
This is an automated message from the
chevaris commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2025095911
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -187,4 +187,34 @@ public void childEvent(CuratorFramework
chevaris commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2025093273
##
curator-recipes/src/main/java/org/apache/curator/framework/recipes/nodes/PersistentTtlNode.java:
##
@@ -239,8 +241,8 @@ public byte[] getData() {
/**
*
kezhuw commented on PR #1260:
URL: https://github.com/apache/curator/pull/1260#issuecomment-2769330392
Refs: CURATOR-545,
[ZOOKEEPER-3546](https://issues.apache.org/jira/browse/ZOOKEEPER-3546)(apache/zookeeper#1138),
#1258
--
This is an automated message from the Apache Git Service.
To r
kezhuw commented on code in PR #1260:
URL: https://github.com/apache/curator/pull/1260#discussion_r2022798278
##
curator-recipes/src/test/java/org/apache/curator/framework/recipes/nodes/TestPersistentTtlNode.java:
##
@@ -187,4 +187,34 @@ public void childEvent(CuratorFramework c
chevaris opened a new pull request, #1260:
URL: https://github.com/apache/curator/pull/1260
Fix for Issue 1258
Thanks to Kezhu Wang for the suggestion in the solution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
chevaris commented on issue #1258:
URL: https://github.com/apache/curator/issues/1258#issuecomment-2766939156
| Is it sufficient to create the container node using
"CreateMode.PERSISTENT_WITH_TTL" ?
I think it is. It is even simpler solution that the one I provided in the
link of the
kezhuw commented on issue #1258:
URL: https://github.com/apache/curator/issues/1258#issuecomment-2764538666
MAIL: https://lists.apache.org/thread/t1jcn0wj7krfc9qr3sgn3q44fn3pyotd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kezhuw commented on issue #1258:
URL: https://github.com/apache/curator/issues/1258#issuecomment-2764537783
> In my view the recipe should watch the Container Node itself and just when
the node is created, the recipe could trigger TOUCH node creation to minimize
the opportunity window in wh
kezhuw commented on issue #1259:
URL: https://github.com/apache/curator/issues/1259#issuecomment-2760093412
It caused by #520(CURATOR-729 shipped in 5.8.0) which is a fix to
#464(CURATOR-673 shipped in 5.6.0).
--
This is an automated message from the Apache Git Service.
To respond to the
1 - 100 of 720 matches
Mail list logo
